Commit Graph

129 Commits

Author SHA1 Message Date
Jeff Morriss 25df9f2133 From Guillem Hernandez: fix decoding of EOSP bit. From Jaap Keuter: fix description of 'value' in proto_tree_add_boolean() that caused the former bug.
svn path=/trunk/; revision=22293
2007-07-12 22:36:35 +00:00
Gerald Combs 24238df617 Add a missing display filter.
svn path=/trunk/; revision=22285
2007-07-10 23:23:09 +00:00
Gerald Combs 0ed707468e From Dustin Johnson: Fix a typo.
svn path=/trunk/; revision=22280
2007-07-09 17:01:00 +00:00
Gerald Combs 7efcc33a1e In packet-ieee802.11.c, fix a serious preference bug introduced in the
last checkin.  In airpcap.c, appease the toolbar code by returning a
lower-case, non-separated WEP key.

svn path=/trunk/; revision=22152
2007-06-21 20:22:56 +00:00
Gerald Combs 249a747c51 Be less restrictive about WEP key preferences. Use hex_str_to_bytes to
process WEP keys.  Allow the "wep:" prefix for WEP keys even when
HAVE_AIRPDCAP isn't defined.  Add a NULL pointer check to
hex_str_to_bytes().  Fixes bug 1584.

Fixup indentation.

svn path=/trunk/; revision=22151
2007-06-21 17:49:03 +00:00
Gerald Combs 1d567d6e6b The 802.11 dissector calculates the header size, so pass that value to
the WEP/WPA decryption code instead of re-calculating it.  Fixes bug
1639.

Remove fcsPresent, radiotapPresent, and associated code from airpdcap.c
since they were always FALSE.  Glib-ize some data types.  Fixup white
space.

Update the release notes.

svn path=/trunk/; revision=22104
2007-06-14 22:09:14 +00:00
Gerald Combs 64d16f4888 Add a hint for using wlan.fc.type_subtype.
svn path=/trunk/; revision=22102
2007-06-14 16:44:36 +00:00
Gerald Combs f445de2be5 Add an option to ignore vendor-specific HT elements.
svn path=/trunk/; revision=22064
2007-06-07 17:40:23 +00:00
Guy Harris 5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Guy Harris d2ac4f7133 Check for G_GINT64_MODIFIER in Wireshark as we do in Wiretap.
In all the places where a cast to "long long" or "unsigned long long"
was done, use G_GINT64_MODIFIER and get rid of the cast, as

	1) there's no guarantee that "%ll" works

and

	2) there's no guarantee that "long long" works

(the latter definitely does *NOT* work with MSVC++; the former doesn't
work with regular printf in MSVC++, but it might work with the GLib
printf-based functions).

svn path=/trunk/; revision=21978
2007-05-29 06:56:07 +00:00
Sebastien Tandel 76729e5d0f From David Howells :
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an
x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat
4.1.2-8).

The failures fall into two categories:
  (1) Casts between pointers and 32-bit integers without an intermediary cast
via 'long' or 'unsigned long'.  This results in a compiler warning complaining
about casts between a pointer and an integer of a different size.
  (2) Passing values to "%lld" or similar printf-style format options that the
compiler thinks are a different size.  Such values need to be cast to 'long
long' or 'unsigned long long'.

svn path=/trunk/; revision=21975
2007-05-29 02:43:18 +00:00
Gerald Combs a33ebc8d5c Throw an exception instead of trying to add a 4GB fragment.
svn path=/trunk/; revision=21943
2007-05-25 21:32:32 +00:00
Gerald Combs 55d2b928c2 From Dustin Johnson:
- Update the wireless/AirPcap GUI code to support 802.11n as well as
    some related upcoming code changes.
  - Remove airpcap.h from the repository, since it exists in the AirPcap
    devpack (and will be superseded Real Soon Now).
  - Show the individual channel flag bits in radiotap.
  
Fix the 802.11n MCS set display.

This is a partial checkin, so hopefully nothing is broken.

svn path=/trunk/; revision=21831
2007-05-18 21:06:20 +00:00
Gerald Combs b482e10da4 From Dustin Johnson: Fix a couple of spelling errors. Normalize the display
of A-MPDU and A-MSDU trees.

svn path=/trunk/; revision=21771
2007-05-14 18:27:47 +00:00
Gerald Combs 797545d2e5 Fix a bunch of spelling errors.
svn path=/trunk/; revision=21751
2007-05-12 00:01:57 +00:00
Gerald Combs 6c940e0714 implented -> implemented.
svn path=/trunk/; revision=21749
2007-05-11 22:51:48 +00:00
Gerald Combs 790061f5c7 Add separate filters for vendor-specific HT items.
svn path=/trunk/; revision=21748
2007-05-11 15:52:13 +00:00
Gerald Combs e2733321e9 Bug fixes and cleanup from Dustin Johnson and myself:
- Remove unused hf_block_ack_ssc code.
  - Fix +HTC detection and frame length calculation.
  - Fix Channel Width dissection.
  - Fix Primary Channel dissection.
  - Tweak the TID field width.
  - Display the Block Ack Buffer Size as decimal.
  - Display the SSC fragment and sequence numbers as decimal.
  - Fix the spelling of "recommended".

svn path=/trunk/; revision=21721
2007-05-07 21:57:05 +00:00
Gerald Combs bb76982d2c Add a routine to dissect the MCS Set. Add a tree for the MCS Set
Rx Bitmask.  "Steams" -> "Scheme".

svn path=/trunk/; revision=21654
2007-05-02 23:26:33 +00:00
Gerald Combs 8a2810c15a From Dustin Johnson: Normalize indentation.
svn path=/trunk/; revision=21634
2007-05-01 16:55:15 +00:00
Guy Harris 0bbac7a3e2 Parenthesize to squelch a compiler warning (a warning that suggests that
the parentheses are needed - not that I can remember which of && and ||
have higher precedence, anyway, which is why I like parenthesizing
expressions such as this...).

svn path=/trunk/; revision=21631
2007-05-01 01:56:58 +00:00
Gerald Combs 78b475fc0c From Dustin Johnson and myself:
- HT Control fixes and updates
  - Add an is_ht flag to the common dissection and capture routines, along
    with a registered dissector (which is used in code that hasn't been
    checked in yet.)
  - Action Fixed Parameter updates
  - Control Wrapper fixes and updates
  - Beacon Interval fixes and updates
  - Capability Info fixes and updates
  - Block Ack / Block Ack Request fixes
  - Lots of miscellaneous fixes and updates

svn path=/trunk/; revision=21630
2007-04-30 23:50:35 +00:00
Gerald Combs 99c0698b95 From Dustin Johnson:
- A-MSDU updates
  - Secondary Channel Offset tag updates
  - A-MPDU parameter updates
  - Lots of string fixes updates
  
Fixup whitespace.

svn path=/trunk/; revision=21564
2007-04-25 19:38:47 +00:00
Gerald Combs cde0384abc From Stig Bjørlykke:
Fix break placement for control frames in dissect_ieee80211_common()

svn path=/trunk/; revision=21562
2007-04-25 17:39:38 +00:00
Gerald Combs 02926636da Move some data frame back out of the control frame scope, so Wireshark
will stop crashing.

More .11n additions and updates from Dustin:

  - Power Capability tag
  - Supported Channels tag
  - Block Ack/Block Ack Request

Fixup whitespace.

svn path=/trunk/; revision=21484
2007-04-20 22:29:11 +00:00
Gerald Combs 2c9c0f3651 Fix 64-bit integer handling and whitespace.
svn path=/trunk/; revision=21483
2007-04-20 18:09:31 +00:00
Gerald Combs 24b3b66ba8 More .11n-related updates and additions from Dustin Johnson and myself:
- MIMO Control frame support
  - Control Wrapper frame support
  - Measurement Pilot
  - Action No Ack
  - Block Ack Action
  - PCO Phase Control
  - PSMP Parameter Set
  - Antenna Selection
  - Extended Channel Switch Announcement
  - HT Information
  - HT Action
  - MIMO CSI Matrices Report
  - Fill in and update a bunch of hf strings
  
Fixup(?) whitespace.

svn path=/trunk/; revision=21482
2007-04-20 17:40:13 +00:00
Jeff Morriss ab97c31bb2 Fix warnings of the form "long long unsigned int format, guint64 arg": use
the PRI macros instead of %llu, etc.

svn path=/trunk/; revision=21454
2007-04-17 10:11:41 +00:00
Gerald Combs 5285c91f9a More .11k/n updates from Dustin Johnson:
- Measurement Pilot frame support
  - Various Block Ack fields
  - Various Power fields
  - Measurement Pilot field
  - Country String field
  - Channel Width field
  - QoS Information fields

svn path=/trunk/; revision=21452
2007-04-17 00:34:32 +00:00
Gerald Combs d0a793c353 From Tuomas Maattanen:
the current SVN (rev 21448) 802.11 WMM TSPEC dissector seems to have
some bugs.

TS Info field should be three bytes long, not two.  Suspension Interval
field is missing altogether, shifting all other fields by four bytes.
Maximum Burst Size, Minimum PHY Rate, Peak Data Rate and Delay Bound
are in wrong order.


svn path=/trunk/; revision=21450
2007-04-16 18:35:22 +00:00
Stephen Fisher 63692e83f8 Remove unused variable that is causing a warning
svn path=/trunk/; revision=21420
2007-04-13 22:50:47 +00:00
Gerald Combs 1295325704 802.11k/n updates from Dustin Johnson:
- Refactored Frame Control into its own function
  - Refactored the Action field
  - Add Block Ack/Block Ack Request
  - Add a Control Wrapper stub
  - Add the Neigbor Report tag
  - Add the Extended Channel Switch Announcement tag
  - Add the Supported Regulatory Classes tag
  - Add the Secondary Channel Offset tag

svn path=/trunk/; revision=21415
2007-04-13 19:28:03 +00:00
Gerald Combs 94dbb06046 Additional 802.11k/n support from Dustin Johnson and myself:
- Break out and display A-MSDUs
  - HT Control field (currently disabled)
  - Action No Ack
  - HT Information IE
  - HT Capability IE
  - Block Ack Request
  - Secondary Channel Offset Tag
  - Measurement Request Tag
  - Measurement Report Tag

...along with a bunch of other updates, including displaying the
type/subtype as a hex value (first nibble: type, second nibble: subtype).

svn path=/trunk/; revision=21391
2007-04-12 18:42:19 +00:00
Gerald Combs 19ac60d3a7 From Stig Bjørlykke:
This patch adds an option to IEEE 802.11 to ignore the wep bit with IV,
as mentioned in
http://www.wireshark.org/lists/wireshark-dev/200704/msg00021.html

I also fixed a bug where the packet is dissected different in the Packet
List with and without "Colorize Packet List" (actually when dissecting
with and without "tree").  Try toggling "Colorize Packet List" with my
previous posted ieee80211-wep.pcap without this patch to see the bug.

The patch is tested on OSX.

svn path=/trunk/; revision=21384
2007-04-11 15:15:28 +00:00
Gerald Combs f5b1443173 Fix a typo.
svn path=/trunk/; revision=21341
2007-04-05 22:44:18 +00:00
Jeff Morriss 109388d263 Clean up some more warnings: unused variables, unitialized variables, wrong format (%ld instead of %d) in packet-sccp.c
svn path=/trunk/; revision=21167
2007-03-24 13:46:41 +00:00
Ulf Lamping 7994794ad9 fix a lot more warnings
svn path=/trunk/; revision=21142
2007-03-23 01:29:52 +00:00
Jörg Mayer 2202f3fb0c Add a comment about CCX
svn path=/trunk/; revision=21119
2007-03-22 15:12:14 +00:00
Jörg Mayer d987ac4127 Fixes for: warning: function declaration isn't a prototype
svn path=/trunk/; revision=21082
2007-03-21 04:54:20 +00:00
Guy Harris eaf1ae2df2 wep_decrypt() isn't needed if we have AirPDCap.
Use "break" instead of "goto done" when possible, don't goto a label
that follows immediately, and get rid of labels for which there's no
goto.

svn path=/trunk/; revision=20846
2007-02-19 01:18:26 +00:00
Gerald Combs 41c66690fc From Clay Jones:
This patch adds decodes for 802.11n information elements.  Since 802.11n
isn't a formal standard yet they are not using the final packet
structures or ie type numbers.  But there are already 802.11n pre
release devices out there and these decodes do seem to correctly decode
the IEs that they use.

svn path=/trunk/; revision=20725
2007-02-06 01:59:50 +00:00
Gerald Combs f9e2736d7c Add support for "wildcard" WPA keys in the form "wpa:passphrase" (note
the lack of SSID).  Wildcarding combines the passphrase with the last
seen SSID and attempts decryption.  The last-seen stack is only one
element tall, which means it may get clobbered on busy and diverse
networks.  We can expand it if needed.

Make internal functions static in airpdcap.c.  Rearrange the
AIRPDCAP_KEY_ITEM struct so that the passphrase and SSID don't get
clobbered when we set our PSK.

svn path=/trunk/; revision=20572
2007-01-26 21:54:59 +00:00
Gerald Combs 2664012ca6 Fix a key preference crash bug. Improve WPA passphrase and SSID length
handling.  Free a byte array.  Squelch a compiler warning.  Fix a URI
string parsing bug.

svn path=/trunk/; revision=20549
2007-01-25 01:24:14 +00:00
Gerald Combs cd60c73163 Fix Coverity CID 230: Make sure we handle a negative tvb_length_remaining()
value correctly.  Fix up indentation.

svn path=/trunk/; revision=20546
2007-01-24 19:22:13 +00:00
Gerald Combs 983f496f69 Add uri_str_to_bytes(), byte_array_dup(), and byte_array_equal()
functions to strutil.  Use GByteArrays to store SSIDs for decryption,
and let the user specify arbitrary byte strings using percent-encoded
strings.  We should probably add percent encoding for pass phrases as
well, so you can escape the ":" character.

Move the key struct key conversion utilities to airpdcap.c, and remove
duplicate code from packet-ieee80211.c.  Fix a lot of indentation.

svn path=/trunk/; revision=20388
2007-01-11 02:42:34 +00:00
Gerald Combs 9b70567cb1 Don't lower-case our SSID and passphrase, otherwise we'll create an
incorrect PSK hash.

svn path=/trunk/; revision=20318
2007-01-04 23:21:37 +00:00
Gerald Combs f5ff0c214a Fix a typo.
svn path=/trunk/; revision=20294
2007-01-03 18:10:13 +00:00
Stephen Fisher 9face6ceb8 Add a good/bad tree to the FCS item.
svn path=/trunk/; revision=20273
2007-01-02 19:55:55 +00:00
Gerald Combs bd282b4114 Move the contents of airpdcap to epan/crypt. Try to fix the current
distcheck failure.  Move the nmake build targets for airpdcap from 
epan/dissectors to epan.  This will probably break the Windows build.

svn path=/trunk/; revision=20231
2006-12-28 17:22:12 +00:00
Gerald Combs 2437fd2e77 Prepare to move the airpdcap code to epan/crypt (SVN won't let me actually
move the files until these changes are checked in).  Add an AC_DEFINE
for airpdcap (which will be removed once the changes have settled).
Update the airpdcap code to compile on non-Windows systems.  Fix up
comments and whitespace to conform more closely to the rest of the
code base.  Verified to compile under Windows and OS X.

svn path=/trunk/; revision=20227
2006-12-27 23:05:55 +00:00