osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
49,874 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

54 Commits

Author SHA1 Message Date
Pascal Quantin a0c53ffaa1 emem -> wmem conversion: 
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
 2013-09-22 15:50:55 +00:00
Pascal Quantin efe18f199c Convert a few dissectors from emem to wmem API 
svn path=/trunk/; revision=51983
 2013-09-12 20:37:30 +00:00
Michael Mann 9e3f9b449f expert_add_info_format_text -> expert_add_info_format 
svn path=/trunk/; revision=51852
 2013-09-09 00:44:09 +00:00
Michael Mann e597acdc48 Batch of filterable expert info. 
svn path=/trunk/; revision=51625
 2013-09-01 13:05:27 +00:00
Michael Mann 30c5457f71 Convert proto_item_set_expert_flags into something filterable. 
svn path=/trunk/; revision=51135
 2013-08-04 13:08:59 +00:00
Anders Broman 6bde918078 From beroset: 
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48426
 2013-03-19 20:00:52 +00:00
Bill Meier 1823aa007c it's ==> its & its ==> it's as needed. 
svn path=/trunk/; revision=47891
 2013-02-26 01:06:19 +00:00
Evan Huus 0fa191245e Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8337 
Make offset unsigned and add an additional sanity check.

svn path=/trunk/; revision=47681
 2013-02-15 20:58:59 +00:00
Bill Meier c439b805e2 Comment out unused hf[] entries & etc. 
(found by checkhf)

svn path=/trunk/; revision=47389
 2013-01-31 17:55:31 +00:00
Bill Meier 65384d0091 General cleanup: 
- Don't call col...() & expert...() under 'if (tree)';
- Localize some variables; Remove uneeded initializers;
- Remove incorret _U_ from certain function parameters;
- Reformat long-lines; Do whitespace changes;
- Misc.


svn path=/trunk/; revision=46444
 2012-12-07 16:25:56 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Bill Meier c02d156881 The amqp dissector is not a plugin; remove comment indicating that it's a plugin. 
Also: Fix some "4 space tab" indentation (replace with spaces).

svn path=/trunk/; revision=43566
 2012-07-04 13:04:16 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Anders Broman ffb49b9561 From Matt Dainty: 
Add array datatype parsing to AMQP dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6791

svn path=/trunk/; revision=40879
 2012-02-06 17:27:36 +00:00
Anders Broman 62866c78a0 Get rid of Warnings. 
svn path=/trunk/; revision=39957
 2011-11-20 12:43:04 +00:00
Anders Broman 42b44648c8 Get rid of Warnings. 
svn path=/trunk/; revision=39954
 2011-11-20 08:59:19 +00:00
Alexis La Goutte d9623925e8 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=39606
 2011-10-26 18:00:54 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier 126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
 2011-10-15 18:46:26 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Chris Maynard 417e8f7469 Delete duplicate line of code. Fixes Coverity CID 1281 (UNUSED VALUE). 
svn path=/trunk/; revision=39050
 2011-09-19 19:49:06 +00:00
Guy Harris 998cbd5ed3 Close up space between ENC_BIG_ENDIAN) and ;. 
svn path=/trunk/; revision=38992
 2011-09-14 07:16:26 +00:00
Anders Broman f72e423c33 From Aaron Schrab: 
AMQP dissector support for Exchange Bind method.
- From me simplify writing to column.
- remove deprecated check_col
- Use ENC_BIG_ENDIAN.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6327

svn path=/trunk/; revision=38991
 2011-09-14 07:04:45 +00:00
Bill Meier 2bf572bc41 Remove unneeded #includes: proto.h,tvbuff.h,value_string.h,stdlib.h,... 
svn path=/trunk/; revision=38413
 2011-08-08 17:59:32 +00:00
Bill Meier b708c2892b Dissectors don't need to #include <gmodule.h> 
Also: #include <stdlib.h> not req'd in some cases.

svn path=/trunk/; revision=38409
 2011-08-08 15:41:09 +00:00
Bill Meier 12ff22254f Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings 
svn path=/trunk/; revision=37998
 2011-07-13 17:04:55 +00:00
Jeff Morriss cdedb31e94 As suggested by Chris: use val_to_str_const() instead of match_strval() plus a 
NULL-return check.

Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.

Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).  A couple of these
were cases where it could not actually return NULL, but I changed it for
consistency.

Store the return value of match_strval() rather than calling it repeatedly.

svn path=/trunk/; revision=37204
 2011-05-17 18:58:40 +00:00
Stephen Fisher 39699efe92 Fix compilation error: 
packet-amqp.c:5617:5: error: "/*" within comment

Cause:

Previous comment wasn't terminated right


svn path=/trunk/; revision=36454
 2011-04-04 17:42:37 +00:00
Bill Meier 8b0a085250 Don't assign to a proto_item * if the value won't be used: Coverity 827; 
Comment out some currently unused code: Coverity 828.

svn path=/trunk/; revision=36453
 2011-04-04 17:24:17 +00:00
Jeff Morriss 9335685106 Fix the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5550 : 
In dissect_amqp_0_10_array() if the 'type' is unknown, don't loop (for
potentially a very long time) adding the same element over and over again
(since the type is unknown, we don't know how much to increase the offset so
an exception is never thrown).

svn path=/trunk/; revision=35406
 2011-01-06 21:07:58 +00:00
Guy Harris 8d35834342 Fix (legitimate) warning. 
svn path=/trunk/; revision=35382
 2011-01-05 17:38:03 +00:00
Guy Harris 216fed8397 From Steve Huston: add support for AMQP 0-10. 
From me: add 0_9 to names for #defines and routines for 0-9, add expert
info for the "you ran past the end of the field table" error.

svn path=/trunk/; revision=35380
 2011-01-05 17:19:48 +00:00
Guy Harris eaad8c00f2 Put end-of-field-table checks back into dissect_amqp_field_table(). 
svn path=/trunk/; revision=35369
 2011-01-05 06:11:10 +00:00
Guy Harris 57f521fa1a Don't use DISSECTOR_ASSERT() to catch malformed packets. Fixes bug 
4048.

svn path=/trunk/; revision=35357
 2011-01-04 08:04:27 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Jeff Morriss 3edbdc151d Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34229
 2010-09-24 01:34:45 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34227
 2010-09-23 21:46:31 +00:00
Guy Harris 969b98fa35 tvb_get_ntohl() doesn't return a long on any platform (it returns a 
guint32, and on no platform supported by GLib, and thus on no platform
supported by Wireshark, does a guint32 have to be an unsigned long), so
there's no need to cast it to long and print it with %lld.

svn path=/trunk/; revision=31540
 2010-01-16 02:39:25 +00:00
Stig Bjørlykke 0929d61df2 Changed abbrev for amqp_field. 
svn path=/trunk/; revision=31431
 2010-01-03 15:09:26 +00:00
Anders Broman 88bb44a51e From Jakub Zawadzki: 
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

svn path=/trunk/; revision=30691
 2009-10-25 11:43:30 +00:00
Kovarththanan Rajaratnam ac463d2697 Don't guard col_clear with col_check 
svn path=/trunk/; revision=29346
 2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00
Stig Bjørlykke d3c75a218b From Kovarththanan Rajaratnam: 
Move hf/ett into proto_register_amqp() and do some field cleanup
(duplicate name/blurb removal)

svn path=/trunk/; revision=28981
 2009-07-07 11:58:23 +00:00
Guy Harris 6ef43f30a8 Get rid of a bunch of uses of size_t where int suffices. 
svn path=/trunk/; revision=27786
 2009-03-18 20:54:28 +00:00
Bill Meier 70786edd00 Revert the queueing --> queuing spelling change 
svn path=/trunk/; revision=27057
 2008-12-19 04:21:08 +00:00
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings) 
svn path=/trunk/; revision=27050
 2008-12-18 19:08:49 +00:00
Bill Meier 2ac68fb78a remove unnecessary prefs registration since no prefs; minor cleanup 
svn path=/trunk/; revision=26075
 2008-08-25 17:14:20 +00:00
Jörg Mayer 6935e50369 Get rid of a warning in gcc 4.3: An integer overflow will not cause a sign change 
svn path=/trunk/; revision=25020
 2008-04-14 19:30:35 +00:00
Anders Broman 840a048b7f Implement some of the minor possible speed improvment patches. 
svn path=/trunk/; revision=23192
 2007-10-15 20:11:25 +00:00
Ronnie Sahlberg 4fa079b941 From 
Martin Sustrik 


here's a patch to AMQP dissector. The only change is that when there are
seceral AMQP frames in single TCP packet, all of them are referred in
the info column.



svn path=/trunk/; revision=21254
 2007-03-28 22:16:43 +00:00