Commit Graph

2510 Commits

Author SHA1 Message Date
Ulf Lamping c173da9fec fix #201: add format_text before output of the DNS name, in case it contains invalid chars
svn path=/trunk/; revision=14479
2005-05-29 13:02:57 +00:00
Ulf Lamping 2b30b539ee fix #86: use format_text before adding version string to the info column
svn path=/trunk/; revision=14478
2005-05-29 12:27:31 +00:00
Ulf Lamping 7c07e00f1d fix #11: add a [truncated] to the label, if the message to display is too long
svn path=/trunk/; revision=14477
2005-05-29 11:23:42 +00:00
Ronnie Sahlberg acaf8730be add MMC RESERVE TRACK cdb
svn path=/trunk/; revision=14476
2005-05-29 08:45:09 +00:00
Ronnie Sahlberg bbf29dd862 MMC SET STREAMING command
svn path=/trunk/; revision=14475
2005-05-29 08:29:55 +00:00
Jörg Mayer 0fc3001d6a Add minimal 802.11j decoding. There's not fun in doing more unless
someone provides a capture file.


svn path=/trunk/; revision=14474
2005-05-29 08:19:11 +00:00
Ronnie Sahlberg aa7157462c remove offset and len from the signature of dissect_scsi_payload()
svn path=/trunk/; revision=14473
2005-05-29 03:18:53 +00:00
Ronnie Sahlberg e66ff913ff make all callers of dissect_scsi_cdb() first create a new subset tvb
change the signature for dissect_scsi_cdb since we no longer need to pass offset over.



svn path=/trunk/; revision=14472
2005-05-29 02:55:12 +00:00
Ronnie Sahlberg fc9688991f create a subset tvb before calling off to the SCSI dissector
so that the right part of the hexpane is highlighted when one clicks on an nondissected data line

svn path=/trunk/; revision=14471
2005-05-29 02:30:49 +00:00
Ronnie Sahlberg 6eb6d5f9af minor prettification
in the decode pane for the SCSI protocol,
put the name of the CDB on the protocol line


svn path=/trunk/; revision=14470
2005-05-29 01:54:22 +00:00
Ronnie Sahlberg ae9968883e update iscsi so that when we have ImmediateData we also call SCSI to decode the
payload (DATAOUT)  and not just the scsi CDB.



svn path=/trunk/; revision=14469
2005-05-29 01:49:09 +00:00
Ronnie Sahlberg 3007142732 add MMC READ BUFFER CAPACITY command
svn path=/trunk/; revision=14467
2005-05-28 13:29:45 +00:00
Ronnie Sahlberg 5d7e4750d2 add the SynchronizeCache command for MMC
svn path=/trunk/; revision=14466
2005-05-28 13:01:14 +00:00
Ulf Lamping f8b3fe7668 add some tvb_ensure_bytes_exist() calls, fixes #197, #202 and #208
svn path=/trunk/; revision=14465
2005-05-28 12:49:19 +00:00
Ronnie Sahlberg fb65ef09eb updates to mmc, add more dissection of GET_CONFIGURATION and READ_TOC
svn path=/trunk/; revision=14464
2005-05-28 12:45:38 +00:00
Ronnie Sahlberg 5c1e7a37de some more MMC4 updates
svn path=/trunk/; revision=14462
2005-05-28 08:27:44 +00:00
Ronnie Sahlberg 3df89a9d25 more scsi refactoring
starting to implement MMC codeset : CDROM/DVD



svn path=/trunk/; revision=14461
2005-05-28 05:42:39 +00:00
Ronnie Sahlberg fd6d7dd38e refactor scsi dissector toi be table driven so it will be easier to add new
commandsets.



svn path=/trunk/; revision=14460
2005-05-28 03:37:16 +00:00
Olivier Biot 97babfb98d From Gilbert Ramirez - Fix a FT_NONE with a bitmask (shouldn't have one).
svn path=/trunk/; revision=14459
2005-05-28 00:51:56 +00:00
Ronnie Sahlberg 0890269d05 from Gilbert,
make kink compile again on non-kerberos builds.

encapsulate a call to decrypt kerberos to only be compiled in when compiling with kerberos.


svn path=/trunk/; revision=14458
2005-05-27 21:39:38 +00:00
Ronnie Sahlberg 6879e6da67 from didier fix for the regression for bug 62
svn path=/trunk/; revision=14457
2005-05-27 21:33:27 +00:00
Anders Broman d328993c0d From Martin Mathieson
packet-rdt.c:
- register a configurable UDP port (off by default, but needed where setup traffic isn't captured)
- dissect extra 'buffer info' fields
- move bit fields into 'flags' subtrees
- misc. minor fixes and improvements (mainly formatting)
Missed eralier...

svn path=/trunk/; revision=14456
2005-05-27 18:35:19 +00:00
Luis Ontanon 4cd25ccc5e don't use a static buffer for preference values, allocate it, and, if necessary reallocate so that
the string always fits.


svn path=/trunk/; revision=14455
2005-05-27 18:33:09 +00:00
Gilbert Ramirez c2454f0260 Add a "-G fields3" report which prints the bitmask of the field, and avoids
printing the blurb twice, like fields2 does.
Add a script, fsanity.py, to check sanity of FT definitions. Right now the
only check is for bitmasks for integer-like fields.

svn path=/trunk/; revision=14454
2005-05-27 15:13:09 +00:00
Ronnie Sahlberg 94d8512749 From T.Nakashima
updates to KINK


svn path=/trunk/; revision=14453
2005-05-27 08:53:07 +00:00
Ronnie Sahlberg 864245ef6e cket wsp is creating string items and later appending to them and their value at runtime which breaks when the TRY_TO_FAKE_THIS_ITEM() is used.
Add a comment to proto_item_append_string() explaining the "danger" and what needs to be done if one decides to use proto_item_append_string()

Add a small change to WSP so that it will disable this speed optimization so not to trigger a DISSECTOR_BUG in proto_item_append_string()




svn path=/trunk/; revision=14452
2005-05-27 06:00:08 +00:00
Guy Harris cb3bc515e2 The DESIRE_ and OS_ values are bit indices, not numerical values that
appear by themselves; get rid of the value_string tables for them.

svn path=/trunk/; revision=14450
2005-05-27 02:30:10 +00:00
Anders Broman 7f936ea1c4 These 2 patches make RDT support pretty complete now:
From Martin Mathieson:

packet-rdt.c:
- register a configurable UDP port (off by default, but needed where setup traffic isn't captured)
- dissect extra 'buffer info' fields
- move bit fields into 'flags' subtrees
- misc. minor fixes and improvements (mainly formatting)

packet-rtsp.c:
- improve detection of RDT as the transport
- allow interleaved frame data to be dissected as RDT packets

svn path=/trunk/; revision=14443
2005-05-26 20:11:35 +00:00
Gerald Combs 4a5deae575 In some places we call proto_tree_add_item() with hfindex and length
values that may not be valid (e.g. dissect_ber_octet_string()
in packet-ber.c).  If the length is invalid, get_uint_value() or
get_int_value() will abort.  Change them to throw an exception instead.
This keeps us from having to do a lot of extra work in the dissector.

Fixes bug 182.


svn path=/trunk/; revision=14437
2005-05-26 14:53:39 +00:00
Guy Harris 4a1414164f Add some more reassembly routines.
svn path=/trunk/; revision=14430
2005-05-25 08:25:14 +00:00
Ulf Lamping d35789c6c7 fix IRemUnknown2 UUID
svn path=/trunk/; revision=14429
2005-05-24 20:01:08 +00:00
Ulf Lamping 5fd2ecb1d5 add values for STDOBJREF flags
svn path=/trunk/; revision=14428
2005-05-24 20:00:14 +00:00
Ulf Lamping c911c15371 dissect ORPC this/that of RemoteCreateInstance
svn path=/trunk/; revision=14427
2005-05-24 19:59:20 +00:00
Ulf Lamping 5812f26b65 dissect ServerAlive response
svn path=/trunk/; revision=14426
2005-05-24 19:57:37 +00:00
Gerald Combs 1c650087ac Add extra TLV length checks and signedness fixes. Fixes the infinite loop in
bug 196.

svn path=/trunk/; revision=14425
2005-05-24 16:46:18 +00:00
Gerald Combs 1a5605dc21 Throw an exception instead of calling g_assert_not_reached(). Fixes bug 175.
svn path=/trunk/; revision=14424
2005-05-24 13:50:20 +00:00
Jörg Mayer 19e90d9a5c Warning fix:
packet-bacapp.c:1264: warning: ISO C does not allow extra ';' outside of
a function


svn path=/trunk/; revision=14420
2005-05-23 12:32:37 +00:00
Jörg Mayer 4a6049d3b1 Warning fix:
packet-camel.h:49: warning: 'dissect_camel_DestinationAddress' declared 'static' but never defined


svn path=/trunk/; revision=14419
2005-05-23 12:19:00 +00:00
Jörg Mayer 83f9a803ac Warning fix:
packet-bacapp.c:1266:1: warning: C++ style comments are not allowed in ISO C90
packet-bacapp.c:1266:1: warning: (this will be reported only once per input file)


svn path=/trunk/; revision=14418
2005-05-23 12:18:10 +00:00
Anders Broman 33aa290b25 From Steve Karg:
* added additional value string enumerations from BACnet-2004
* removed vendor specific value string enumerations
* corrected some value strings enumerations that were incorrect
* refactored some common strings as strings + format
* refactored some value strings to use a reserved range and a 
proprietary range by using val_to_split_str function which now correctly 
shows the split range when a value is not matched.
* corrected some spelling errors
* converted some item text values to dissector registration
* added protocol tree for the BACnet tag headers
* added value strings tree display for some bit string BACnet properties
* added value strings tree display for some enumerated BACnet properties
* changed the conversion of signed, unsigned, and enumerated BACnet 
values to use ntohx functions.
* added proper handling for large values of signed, unsigned, and 
enumerated BACnet values.
* refactored BACnet Null and Boolean Tag tree
* refactored BACnet Real and Double Tag tree
* changed comments into functions for special tags
* changed some white space to match existing file style
* refactored tvb_reported_length to tvb_length_remaining to simplify
* corrected octet-string tree when length is zero
* refactored octet-string tree to use tvb_bytes_to_str
* corrected application tagged productions that were context tagged
* corrected context tagged productions that were application tagged
* corrected offset for BACnet character strings
* refactored some identical service request tree handling
* changed confirmed APDU to highlight the correct portion of the APDU
* changed some dissector registration values to display as decimal
* changed cast in call to iconv() to fix compiler warning
* corrected bit-wise AND in AtomicFile tree handling

packet-bvlc.c
* added error text in tree when encoded length doesn't match actual length

svn path=/trunk/; revision=14417
2005-05-23 05:52:28 +00:00
Anders Broman c40a7d2ad9 From Javier Acuna:
filter packets by their Billing ID

svn path=/trunk/; revision=14409
2005-05-21 09:13:28 +00:00
Ulf Lamping d2233711d9 add get_manuf_name_if_known (returns NULL if unknown) in addition to get_manuf_name
svn path=/trunk/; revision=14405
2005-05-20 21:44:17 +00:00
Luis Ontanon 98d824e05b dup the filter string so that it can be freed without problems.
fixes bug 195


svn path=/trunk/; revision=14402
2005-05-20 19:40:10 +00:00
Luis Ontanon bc1292ff1d some cosmetic fixes
svn path=/trunk/; revision=14401
2005-05-20 19:38:24 +00:00
Anders Broman 416c350db1 Use value_string for codec values/strings.
svn path=/trunk/; revision=14400
2005-05-19 20:35:30 +00:00
Anders Broman b8cd3ff407 Display version number and product number as strings.
svn path=/trunk/; revision=14399
2005-05-19 20:34:35 +00:00
Anders Broman 59516e5f4f Add Sony and Nokia VendorID:s
svn path=/trunk/; revision=14398
2005-05-19 20:33:59 +00:00
Guy Harris d444801e4a Clean up indentation.
Add some comments with questions.

Mark an unused argument as such, and get rid of an unused variable.

svn path=/trunk/; revision=14396
2005-05-19 09:26:15 +00:00
Luis Ontanon 3f36640526 - add an isup stats_tree with statistics regarding message types and the directions in which they flow.
svn path=/trunk/; revision=14393
2005-05-18 13:51:49 +00:00
Anders Broman 443d4bf1c1 Add a dissector for h221 nonstandard data which can easily be expanded with publically avalable data or
replaced by a propriatary one.

svn path=/trunk/; revision=14392
2005-05-18 05:44:12 +00:00