Commit Graph

72 Commits

Author SHA1 Message Date
Anders Broman 44c8909f04 From Reinhard Speyerer:
Fixes the incorrect decoding of the CC-SETUP CLIR suppression and invoke info elements (which seem to have been copied from the location update accept PDU).

and added some info from a later spec.

svn path=/trunk/; revision=19675
2006-10-24 22:06:34 +00:00
Anders Broman 989fcb7656 Dissect 'User Location Information' IE and MS Time Zone' IE.
svn path=/trunk/; revision=19016
2006-08-24 17:27:45 +00:00
Anders Broman ba6eb01246 From Florent Drouin:
This patch provide a correction for the element "Channel Needed" in the Paging message. and some improvements for the display of AUTH,SRES,RAND etc..

With some further changes to APDU and LSA Identifier dissection.

svn path=/trunk/; revision=18985
2006-08-21 21:24:42 +00:00
Anders Broman 3094096ae4 Decode RANAP in LongSignalInfo and RadioResourceInformation.
svn path=/trunk/; revision=18718
2006-07-11 19:46:52 +00:00
Anders Broman 2a5e5f26a1 From Nils Ljungberg:
activate_secondary_pdp_contex_acc - radio priority missing, QoS wrongly dekoded.
Fault in i detach_req: should be ELEM_OPT_TLV
identiy half-octeten ignored.
 "Cause" written as "LLC SAPI"
Decoding of TFT.

svn path=/trunk/; revision=18640
2006-07-03 21:10:14 +00:00
Anders Broman 5f09b2fcce From Neil Piercy:
The patch avoids the crash for unknown messages, adds the Common Id 
message dissection which caused it, and also add dissector name 
registration for the 2 other protocols which this file can provide.

svn path=/trunk/; revision=18586
2006-06-27 19:15:43 +00:00
Anders Broman c19f6b2d97 gsm_a: Dissect LLC
Q.931: Add Bit 8 first in Bearer Cap IE

svn path=/trunk/; revision=18477
2006-06-15 21:14:26 +00:00
Anders Broman 996d4db495 Ethereal->Wireshark
svn path=/trunk/; revision=18234
2006-05-28 19:49:07 +00:00
Anders Broman 859e520bdf From Markus Meier:
Better dissection of chanel descriptions.

svn path=/trunk/; revision=18227
2006-05-27 18:26:04 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman 2002225c79 Fix BUGs:
955 UMA: Handover Command message not decoded.
956 UMA: multirate-configuration not decoded correctly .
957 UMA: Received Signal Level List not decoded.

svn path=/trunk/; revision=18179
2006-05-17 18:09:14 +00:00
Anders Broman 7d61c89d91 Calculate Timezone correctly fixes http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=876
svn path=/trunk/; revision=17878
2006-04-16 22:48:47 +00:00
Anders Broman 1d1cf3790a bssgp - handle LLC PDU of 0 length.
Gsm_a - radio pri included in Modify PDP context request.

svn path=/trunk/; revision=17875
2006-04-16 19:14:21 +00:00
Guy Harris 31e5e71b90 Close a comment to squelch a compiler warning.
svn path=/trunk/; revision=17761
2006-03-29 22:03:21 +00:00
Anders Broman 2f9f463ede Fix Bugs
820     gsm-map checkIMEI decoding error  
821     gsm-map sendIMSI decoding error  

svn path=/trunk/; revision=17703
2006-03-23 16:58:50 +00:00
Anders Broman 06d6295287 From Florent.Drouin@alcatel.fr
Add the same workaround used in packet-ftam.c for the bad handling of the asn "IMPLICIT SEQUENCE", in the packet-gsm_map-template.c. This patch concerns Map V3 messages, not correctly decoded with the previous workaround "offset=offset+2".

Change a parameter for Provide Roaming Number decoding.

Add a decoding fonction for "Channel needed" parameter to avoid a decoding error for Paging messages
with a change to actually dissct channel needed.

svn path=/trunk/; revision=17350
2006-02-18 23:29:51 +00:00
Lars Roland 3aebb783ff fuzz testing revealed that an infinite loop in the uma dissector was only partly fixed in revision 17119.
This will fix the infinite loop and bug 738.

svn path=/trunk/; revision=17273
2006-02-12 14:29:41 +00:00
Anders Broman b3adb51d07 Dissect channel needed.
svn path=/trunk/; revision=17194
2006-02-07 04:57:30 +00:00
Anders Broman e77ec7864f gsm_a: Export needed functions
bssap: Dissect most of the IE:s

svn path=/trunk/; revision=17143
2006-02-02 15:16:51 +00:00
Anders Broman cb191e08d2 packet-gsma_a.ch Use valuestrings for Number type etc and export the value_strings
packet-bssap.c Add BSSAP+ dissection. 

svn path=/trunk/; revision=17141
2006-02-01 17:39:20 +00:00
Guy Harris 9958e6b581 Fix indentation, add a /* FALLTHRU */ comment.
svn path=/trunk/; revision=17121
2006-01-29 21:41:44 +00:00
Lars Roland eb4a79cc7a As suggested by Ilja Maslov, display values of
gsm_a.cell_lac and gsm_a.cell_ci in hex
and decimal.


svn path=/trunk/; revision=17120
2006-01-29 21:00:00 +00:00
Lars Roland de4522f70d Fix an infinite loop in gsm_a dissector and a wrong offset in uma dissector.
This fixes bug 716.

svn path=/trunk/; revision=17119
2006-01-29 15:54:10 +00:00
Guy Harris 5186e33416 Fix missing closing */ in comment.
svn path=/trunk/; revision=17113
2006-01-28 22:49:53 +00:00
Anders Broman 33b9a9c90d - Add new IE:s
- White space and comment changes.
- IE type fixes.
- Print timezone data.

svn path=/trunk/; revision=17098
2006-01-25 17:56:27 +00:00
Anders Broman 1c5874e2e3 Dissect CellGlobalIdOrServiceAreaIdOrLAI and RAIdentity
svn path=/trunk/; revision=17075
2006-01-22 21:16:33 +00:00
Anders Broman fded8deafc RANAP - Dissect ProtocolExtensionField IE:s
GSM A - Service Request; Mobile identity element is LV type

svn path=/trunk/; revision=17069
2006-01-21 19:12:52 +00:00
Anders Broman 9d6de675a4 ext_qos_subscribed was not correctly decoded in Camel and GSM MAP
Change to use proto_add_item in packet-gsm_a.c for some octets and export value strings.

svn path=/trunk/; revision=17055
2006-01-19 18:20:14 +00:00
Anders Broman 4ecd261cfb Change some OPCODE decodes from respons to Invoke (bug fix), let gsm_a decode som IE:s.
svn path=/trunk/; revision=17050
2006-01-17 21:52:30 +00:00
Jaap Keuter 343b357b0e From Patrik Olsson
Attached is a patch that fixes several decoding problem is the gsm_a
dissector. The bugs are also submitted to bugzilla id #684 and #687.

svn path=/trunk/; revision=17027
2006-01-13 15:17:50 +00:00
Jörg Mayer f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Anders Broman 857077708b Fix a typo and change TLLI representation to HEX.
svn path=/trunk/; revision=16389
2005-11-03 19:14:52 +00:00
Ronnie Sahlberg 21ec37f287 strcpy() removal
svn path=/trunk/; revision=16163
2005-10-08 11:15:15 +00:00
Ulf Lamping 031d7beea0 prevent output of NULL strings
svn path=/trunk/; revision=15950
2005-09-22 01:16:25 +00:00
Guy Harris 25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
Ronnie Sahlberg e88b3ccb32 remove sprintf from gsm_a
svn path=/trunk/; revision=15492
2005-08-21 01:52:09 +00:00
Anders Broman 913b6b22ec Decode some more of MultiRate configuration.
svn path=/trunk/; revision=15406
2005-08-18 11:09:50 +00:00
Anders Broman 5030bf580c Get rid of an unused variable, don't include tcap.h and remove some redundant code.
svn path=/trunk/; revision=15338
2005-08-13 10:17:20 +00:00
Anders Broman 1f31e083d2 From Peter Johansson:
mnc>>4; Should  be replaced with mnc = mnc>>4;

svn path=/trunk/; revision=15337
2005-08-13 10:11:23 +00:00
Anders Broman 0c69d44dba From Rene Pilz:
The MCC/MNC in de_gmm_rai is not correct decoded

svn path=/trunk/; revision=15296
2005-08-11 20:47:09 +00:00
Ronnie Sahlberg ec3ab9ec3e rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer
svn path=/trunk/; revision=15270
2005-08-10 13:41:13 +00:00
Ronnie Sahlberg 3c0f522818 updates from Anders B
Regenerate gsm ss and gsm map



svn path=/trunk/; revision=15259
2005-08-08 08:53:05 +00:00
Anders Broman 6ced262fdf From THORNTON, MATT
Some changes that I made to flesh out GPRS message parsing.  More information is displayed about the various frame formats.  I have also added some code to parse XID parameters in the U frame.  I have also fixed a couple of display bugs in the GSM and GPRS LLC parser.

svn path=/trunk/; revision=15224
2005-08-05 19:16:29 +00:00
Jörg Mayer 5602f5bb83 Make some funtions static. More char -> const char warning fixes
svn path=/trunk/; revision=15146
2005-07-30 01:01:02 +00:00
Ronnie Sahlberg 7035a45c8f ememify some more tvb_get_string() calls
one memleak in vnc related to tvb_get_string() closed.


svn path=/trunk/; revision=15130
2005-07-28 09:35:27 +00:00
Gerald Combs 0de3a392be In packet-gsm_a.c:
- Make sure every function that has an "add_string" argument, make sure
    it isn't NULL before we write to it.
    a null "add_string".
  - Use "_U_" instead of "add_string = add_string" to squelch compiler
    warnings.
  - Fix other compiler warnings.

In packet-uma.c, pass NULL instead of "" for the add_string argument to
de_mid().  Fixes bug 287.

svn path=/trunk/; revision=14971
2005-07-20 20:57:04 +00:00
Anders Broman c0de9d912b Remove some unused variables.
svn path=/trunk/; revision=14940
2005-07-16 19:59:21 +00:00
Anders Broman a5e89b2793 Packet-gtp.c - Fix up decoding of the rest of the IE:s use routines from packet-gsm_a.c
Packet-uma.c Let packet-gsm_a handle som IE dissection.
Packet-gsm.a add some IE dissection and export some routines.

svn path=/trunk/; revision=14918
2005-07-14 21:05:38 +00:00
Anders Broman 43e9a11b11 Dissect some more fields
svn path=/trunk/; revision=14897
2005-07-11 19:25:25 +00:00
Anders Broman c50d7e229e Add some missing IMPLICIT tags, and use FN_PARS directive.
Add disection of some RR elements and command Handover.

svn path=/trunk/; revision=14878
2005-07-08 20:01:11 +00:00