protocols (where there's a virtual circuit ID of some sort in packets)
what conversations are for protocols ultimately running atop
connectionless network layers. Have circuit type and ID values in the
"packet_info" structure.
Have the Frame Relay dissector set the circuit type and ID values, and
have the Wellfleet compression protocol set up circuit information and
store compression information with the circuit.
svn path=/trunk/; revision=6471
protocols (where there's a virtual circuit ID of some sort in packets)
what conversations are for protocols ultimately running atop
connectionless network layers. Have circuit type and ID values in the
"packet_info" structure.
Have the Frame Relay dissector set the circuit type and ID values, and
have the Wellfleet compression protocol set up circuit information and
store compression information with the circuit.
svn path=/trunk/; revision=6469
fact, they cause an extra blank to appear).
Turn "get_string()" into a routine that fetches the length of a string,
fetches the string, puts the string into the tree with the offset of the
length as the starting offset, and returns the new offset.
Make routines that return offsets return an "int", as packet offset
variables are "int"s.
Fix up a bunch of "proto_tree_add_uint()" calls, including presumably
properly updating the offset after the call.
Clean up the handling of qualified names, integer-or-OID types, and even
objects a bit.
Put octet strings into the protocol tree with the offset of the length
as the starting offset.
Fix up the record length variable to be decimal, and just use
"proto_tree_add_uint()" to put it into the tree.
In at least one capture I've seen, there are only two bytes after the
NDPS tree field in a Bind PA request, not 4, even if the NDPS tree name
isn't an empty string.
FT_BYTES and FT_BOOLEAN don't have a base for display, so use BASE_NONE.
Fix the field for address bytes to have the right name (it's not just
the length, it's the length *and* the bytes).
svn path=/trunk/; revision=6467
Various NDS dissector enhancements including NDS verb 0x07, and
proper ping flags for NDS ping version 10 request.
Updated error codes for several NCP reply packets.
NDPS enhancements.
svn path=/trunk/; revision=6463
A small cosmetic change to make it highlight the proper bytes in
the hex pane.
From Ronnie and me:
use the length from the PPPoE header to set the length of the
tvbuff we hand to the PPP dissector.
svn path=/trunk/; revision=6462
constant, as that won't work with "get_string()" (it'll try to overwrite
the constant, and either crash, trash memory, or both).
svn path=/trunk/; revision=6460
"unsigned long" is an unsigned *64-bit* integer on many platforms.
While we're at it, use "guint8" rather than "unsigned char" for
"unsigned 8-bit integer", and use "guint16" rather than "unsigned short"
for "unsigned 16-bit integer".
Make the seconds field of a libpcap time stamp signed, as it's supposed
to be.
svn path=/trunk/; revision=6445
its starting sequence number, as the "fragment ID" when reassembling,
and include the source and destination port numbers in a
"tcp_segment_key" structure and use that as part of the key in the hash
table for segments, so that we don't get spoofed by segments in two
directions in the same conversation, or by segments in two separate
conversations between the same hosts, having the same starting sequence
number (which is not unlikely to happen if relative sequence numbers are
being used).
svn path=/trunk/; revision=6443
Clean up the stuff to handle MVTYPE_PROC_ENTRY_SPECIFIERS a bit, and put
in comments explaining what's going on for that and MVTYPE_ATTR_REQUEST.
svn path=/trunk/; revision=6439
the same name (abbreviation). Thus, if multiple protocols or fields
are registered with the same name, you can still filter on the name
and have the filtering work as expected.
svn path=/trunk/; revision=6434
dissection if found, with a table of headers that indicate NTLMSSP
authentication.
Add some more headers to that table.
Constify the code a bit.
svn path=/trunk/; revision=6432
just wrap the entire dissection in an "if", as was done before.
(Actually, we can just skip the "if" entirely, I guess....)
svn path=/trunk/; revision=6429
Guy Harris