Commit Graph

2827 Commits

Author SHA1 Message Date
Luis Ontanon c63b0a6bc6 From Peter Johansson:
I have provided a patch for a crash that occurs in uat_gui.c if from the
"Edit preferences..." button when you choose Protocols -> DLT_USER ->
the "Edit..." button -> the "New" button -> the "Cancel" button.
The crash happens because dd gets freed prior to traversing its internal
structure, hence I moved the call to g_free for dd beneath the traversal
of the dd internals.



svn path=/trunk/; revision=20813
2007-02-14 19:21:37 +00:00
Stephen Fisher 0ebc01dc03 From Sebastien Tandel:
Create two new files (ws_strsplit.[ch]) that use GTK2 code to override
the buggy g_strsplit() function when compiling for GTK1.  Include this
work-around function (ws_strsplit) in libwireshark.def.  Add notes on usage
to README.developer.  Include epan/ws_strsplit.h in all files that use
g_strsplit().


svn path=/trunk/; revision=20804
2007-02-13 20:57:22 +00:00
Ronnie Sahlberg d059526285 use g_string_append() instead of g_string_append_printf()
we dont have g_string_append_printf() in gtk 1 

svn path=/trunk/; revision=20798
2007-02-12 20:11:42 +00:00
Luis Ontanon b26c1c4ca2 Add a description of UAT fields, and have it as a tooltip in the New/Edit Dialog.
svn path=/trunk/; revision=20797
2007-02-12 19:57:41 +00:00
Luis Ontanon ee4cf097ad From Albert Chin:
Gnutls can be located in a different place than the other libs.


svn path=/trunk/; revision=20796
2007-02-12 19:55:54 +00:00
Ulf Lamping 64f5bec543 delimit each CSV output with "
(this should be combined into a generic function as this CSV encapsulation functionality is implemented several times)

svn path=/trunk/; revision=20791
2007-02-12 05:10:52 +00:00
Ulf Lamping ca590fafbe ooops, and here comes the actual context menu code change from Douglas Pratley ... already mentioned in SVN 20787
svn path=/trunk/; revision=20790
2007-02-12 05:08:33 +00:00
Luis Ontanon 5db2005993 Have Aply, Cancel and OK buttons instead of the save and ok button.
Have these buttons reloading the capture file if needed.
Some rearrangement of the window (the editor is still missing "ornaments" and tooltips)


svn path=/trunk/; revision=20788
2007-02-11 16:09:21 +00:00
Michael Tüxen 7e8098c520 A fix from Irene Ruengeler to keep assocs selected when
setting/applying filters.
Remove some warnings.


svn path=/trunk/; revision=20759
2007-02-09 21:05:43 +00:00
Martin Mathieson 2a6c2284c4 Fix build (at least for me) by removing macros_dlg.h
svn path=/trunk/; revision=20754
2007-02-09 11:24:59 +00:00
Luis Ontanon 7c57c05ed5 * Add a Submenu (/Views/User Tables) where UATs can be accessed.
* Remove macros_dlg, the DFMacros UAT goes in the menu with all the rest
* in packet-user_encap.c WTAP_ENCAP=XXX has become useless information for the user leave just the DLT#



svn path=/trunk/; revision=20753
2007-02-09 03:11:14 +00:00
Ulf Lamping a70a78e0ec some further work on the "welcome page", still far from being complete
svn path=/trunk/; revision=20741
2007-02-08 01:05:43 +00:00
Luis Ontanon 5ec87e6eef no gtk_window_set_resizable in GTK1
svn path=/trunk/; revision=20735
2007-02-07 13:55:34 +00:00
Luis Ontanon bc2ca61083 Add ENUM and HEXBYTES modes
svn path=/trunk/; revision=20733
2007-02-07 03:39:40 +00:00
Ulf Lamping bc09ad6f17 don't free ofn before the last place used
svn path=/trunk/; revision=20732
2007-02-07 02:50:33 +00:00
Ulf Lamping c7936a1c37 fix a comment typo
svn path=/trunk/; revision=20731
2007-02-07 02:45:53 +00:00
Jeff Morriss 0c17bfd3a8 From Eric Hall to fix bug 1289:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1289

Rename 'svnversion' to 'wireshark_svnversion' to resolve a symbol conflict with
GTK 2.10.6 (hmm, shouldn't GTK not be exporting that symbol or at least naming
it so as to prevent such collisions? Well, so should we, so...)

From Andreas Fink: change #ifdef for size_t in airdcap_interop.h to fix
compile on MacOS X.


svn path=/trunk/; revision=20726
2007-02-06 02:27:59 +00:00
Luis Ontanon 2b22bcb1a3 * Add a help facility for UATs
* export help_topic_html()


svn path=/trunk/; revision=20717
2007-02-05 05:06:21 +00:00
Luis Ontanon b7a16926d7 Add a confirm dialog when the user closes the window with unsaved data.
svn path=/trunk/; revision=20716
2007-02-05 04:22:06 +00:00
Graeme Lunt 3bdc71b56b Augment get_gui_runtime_info() with additional information about the U3 device Wireshark is being run from.
svn path=/trunk/; revision=20711
2007-02-04 12:39:07 +00:00
Luis Ontanon fbc8912b87 Move (Up/Down) & Save buttons
svn path=/trunk/; revision=20708
2007-02-04 05:19:02 +00:00
Luis Ontanon d70a58f881 second iteration:
* fields of an uat table now are passed using an array of uat_filed_t
* field callbacks take two more userdata arguments
* add some macros to define uat field callbacks.
* uats can be registered as preferences for a specific protocol
   - the preference widget is a button that opens the uat's window
* dfilter-macro => reflect changes to API


svn path=/trunk/; revision=20695
2007-02-03 14:25:02 +00:00
Stephen Fisher 19883c003a Assign the cancel button (so you can hit the escape key) on the capture/display
filter dialog box


svn path=/trunk/; revision=20681
2007-02-02 01:09:41 +00:00
Ronnie Sahlberg 7d8687e8ae dont ifdef out main_window_exit() if we dont have PCAP since this symbol is required even without pcap
svn path=/trunk/; revision=20661
2007-02-01 08:36:35 +00:00
Ulf Lamping b1cdc9bcb9 backup of some design work of the Wireshark "Welcome" page - the one shown when no trace file is loaded - this page is still disabled.
This is only a "personal backup" of some design ideas / experiments for this page - and needs a lot more work / cleanup. I'm checking this in just to prevent data loss.

svn path=/trunk/; revision=20640
2007-01-31 03:08:39 +00:00
Ulf Lamping e9dd661b18 use window_present() as discussed
svn path=/trunk/; revision=20639
2007-01-31 03:05:03 +00:00
Jeff Morriss b0bca8ff3b #include stdlib.h so uat.h can find size_t (at least on Solaris). Add newline to end of macros_dlg.h (just to prevent a compiler warning)
svn path=/trunk/; revision=20638
2007-01-31 02:55:14 +00:00
Stephen Fisher 580092477d Show the channel frequencies in the wireless (AirPcap) toolbar next to the channel number in the drop-down list.
svn path=/trunk/; revision=20619
2007-01-30 01:57:34 +00:00
Ulf Lamping 99209b76ce call gtk_window_present() only on GTK >= 2.x, should fix current compilation problems.
I don't have tested this on a GTK 1.x system...

svn path=/trunk/; revision=20615
2007-01-29 23:29:11 +00:00
Anders Broman 1f99d6fc2d Fix a typo (double ;;).
svn path=/trunk/; revision=20610
2007-01-29 21:26:08 +00:00
Michael Tüxen ed692e1c8a Improve the handling of INIT/ABORT mesage pairs.
svn path=/trunk/; revision=20608
2007-01-29 20:44:59 +00:00
Luis Ontanon 3e924d9def Finish (?) UAT's GUI
svn path=/trunk/; revision=20605
2007-01-29 14:14:01 +00:00
Luis Ontanon 8f48cb6364 Actually this is the UAT GUI...
svn path=/trunk/; revision=20599
2007-01-29 10:25:54 +00:00
Luis Ontanon 6a4a51ffec The UAT gui starts to work
set the macros_dlg to use it

add a dummy dfilter_macros file to supress a warning at startup


svn path=/trunk/; revision=20598
2007-01-29 10:23:38 +00:00
Ulf Lamping c01304b04d remove unused "cant_get_if_list_errstr" warning
svn path=/trunk/; revision=20594
2007-01-28 23:48:53 +00:00
Stephen Fisher b4a656ec1f From Douglas Pratley:
This is a patch adding items to the context menus for the packet list
and packet details panes for copying packet data to the clipboard.

New menu item on packet list pane:
Copy (sub menu) ->
        Summary (Text)          Copies fields displayed in the packet
list, tab separated
        Summary (CSV)           Copies fields displayed in the packet
list, comma separated
        Hex and Text            Copies data for the selected frame in
hex-editor style (similar to Copy\All Information in packet bytes pane)
        Text Only               Copies data for the selected frame,
dropping non-printable characters other than line breaks (similar to
Copy\Text Only in packet bytes pane)
        Hex Columns             As Hex and Text but without text
        Hex Stream              Copies data for the selected frame as an
unpunctuated list of hex values
        Binary Stream           Copies raw packet bytes to the clipboard
as MIME type application/octet-stream


svn path=/trunk/; revision=20581
2007-01-28 02:49:50 +00:00
Michael Tüxen bb773be0ef Fix handling when both endpoints use the same port number.
svn path=/trunk/; revision=20570
2007-01-26 17:27:32 +00:00
Gerald Combs 065e9f88e5 Spelling fixes.
svn path=/trunk/; revision=20561
2007-01-26 06:45:12 +00:00
Gerald Combs 0dad9f1bb2 Massive indentation fixes.
svn path=/trunk/; revision=20560
2007-01-26 06:34:05 +00:00
Gerald Combs 94cf826452 Fix Coverity CIDs 217 and 218, and fix filter dialog autoselection in
the process.  This change assumes that you can make a copy of a
GtkTreeIter and use it later (which may not be valid), and hasn't been
tested using GTK 1.

svn path=/trunk/; revision=20550
2007-01-25 02:54:14 +00:00
Gerald Combs 744d6644b8 Instead of checking for WinPcap 4.x versions, assume that if the version
is greater than 3 we can get detailed interface information.  This should
limit the amount of work we have to do when new WinPcap releases come out.

svn path=/trunk/; revision=20542
2007-01-24 01:16:45 +00:00
Gerald Combs ed12aa0cb1 Propagate the recent interface list changes (r20521) to the AirPcap code.
Fix a mismatched declaration found by Gisle Vanem.

svn path=/trunk/; revision=20535
2007-01-23 20:12:09 +00:00
Luis Ontanon 1776daa374 Have build succeed even if portaudio is located somewhere else than any other libraries in use.
svn path=/trunk/; revision=20533
2007-01-23 19:46:55 +00:00
Ulf Lamping 18cf691f7d as Bill Meier noted:
"The Help ! Contents and the Help ! User's Guide  both display the User's 
Guide."

Remove the duplicate Help!/User's Guide item

svn path=/trunk/; revision=20523
2007-01-22 04:03:17 +00:00
Stephen Fisher 2267c19248 Fix various compiler warnings
svn path=/trunk/; revision=20522
2007-01-22 00:20:33 +00:00
Guy Harris cc22748169 Have the routines to get interface lists take a pointer to a "gchar *"
as an argument, and, on an error, if they have an error message, have
them set that "gchar *" to point to a g_malloc()ed string containing the
error message, rather than taking a pointer to a buffer for that message
as an argument.  That's more like what's done in Wiretap, and doesn't
impose an upper limit on the lengths of those error messages.  If that
pointer is null, don't allocate the message string and return it.

Have that error message already have the "cant_get" processing applied
to it, so nobody other than those routines need to call the "cant_get"
routines to process the error messages.

Have get_airpcap_interface_list() explicitly set "*err" to the
appropriate error code.

Clean up indentation.

svn path=/trunk/; revision=20521
2007-01-21 23:45:36 +00:00
Stephen Fisher ed71765bbb Fix a bug where the size of each column was being computed with the GTK+
default font of Sans 10 instead of the setting in Wireshark (such as
Monospace 10).  On some systems this bug was causing the contents of columns
such as the command line specified (CLS) time to be cut off. 


svn path=/trunk/; revision=20512
2007-01-20 23:23:50 +00:00
Ulf Lamping 1587983aff from Stephen Fisher:
A user asked what file format the flow graph is saved as, which isn't 
apparent by looking at the dialog.  I had to try saving a file and check 
its type -- plain text file.  Could someone please apply the attached 
patch or similar change to graph_analysis.c.  My patch updates the title 
of the dialog box from "Wireshark: Save graph to file" to "Wireshark: 
Save graph to text file".

However, I used the term "plain text file" instead ;-)

svn path=/trunk/; revision=20510
2007-01-20 17:52:39 +00:00
Jaap Keuter c01c996999 Trying to get buildbot Windows-XP-x86 to build again.
Reverting GTK2 to GTK1.2 functionname

svn path=/trunk/; revision=20508
2007-01-20 14:08:05 +00:00
Gerald Combs 1e6ce19f79 Recent versions of GTK+ have added a "gtk-label-select-on-focus"
property, which selects the entire contents of a label when it comes
into focus.  This property annoyingly defaults to TRUE, which meant that
the labels in simple dialogs and the about box would unexpectedly show
up selected.

Work around this by setting the focus on the "OK" button in the about
dialog and the first button specified in simple dialogs.

svn path=/trunk/; revision=20507
2007-01-20 02:05:49 +00:00