osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
45,987 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

244 Commits

Author SHA1 Message Date
Pascal Quantin a37c044203 Update the ASN.1 based dissectors following the changes done in r48812 
svn path=/trunk/; revision=48820
 2013-04-11 18:14:53 +00:00
Evan Huus 37600a157b Rename value string (and similar) functions to use a consistent pattern. This 
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
 2013-03-29 00:26:23 +00:00
Anders Broman dafdc19d9e -Wmissing-prototypes 
svn path=/trunk/; revision=48609
 2013-03-28 07:34:13 +00:00
Chris Maynard 186d0c2006 Fix another incorrectly duplicated display filter, this time for hf_gsm_map_etsi_pdp_type_number. 
#BACKPORT(1.6,1.8)

svn path=/trunk/; revision=48601
 2013-03-27 21:41:56 +00:00
Chris Maynard da30b9eb92 Fix the incorrectly duplicated display filter for hf_gsm_map_dlci. 
#BACKPORT(1.6, 1.8)

svn path=/trunk/; revision=48597
 2013-03-27 20:44:47 +00:00
Pascal Quantin 88c0e8e873 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8517 : 
Do not tap an unknown Opration Code

svn path=/trunk/; revision=48539
 2013-03-24 21:53:53 +00:00
Anders Broman 1b788d4061 Update to V11.5.0 (2012-12). 
svn path=/trunk/; revision=48195
 2013-03-08 17:55:53 +00:00
Pascal Quantin 7fdbff4822 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8378 : 
A detailed diagnostic information contains either a SMS-SUBMIT-REPORT or a SMS-DELIVERY-REPORT. Set P2P direction accordingly.

svn path=/trunk/; revision=47927
 2013-02-27 23:08:17 +00:00
Anders Broman e5556e29ce Export TBCD-STRING. 
svn path=/trunk/; revision=47496
 2013-02-05 15:12:13 +00:00
Anders Broman 4a8f124c43 Add an OID translation. 
svn path=/trunk/; revision=47386
 2013-01-31 16:59:39 +00:00
Jaap Keuter f177deead0 Fix for CID 280252. 
We can be sure we've at least 0 bytes remaining in the TVB.

svn path=/trunk/; revision=47162
 2013-01-19 13:06:26 +00:00
Anders Broman 5c1bc94608 "Fill" a couple of value_string(ext) 
svn path=/trunk/; revision=46518
 2012-12-12 12:48:12 +00:00
Jeff Morriss 0266cceef3 Make all enum_val_t's const. 
svn path=/trunk/; revision=46292
 2012-11-29 20:15:37 +00:00
Anders Broman 8d178187e3 AddressString can have a size of 1, fixes Bug 7882 -GSM_MAP show malformed Packets when two IMSI https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7882 
svn path=/trunk/; revision=45687
 2012-10-21 15:01:23 +00:00
Jakub Zawadzki 7a9d27c33f Regenerate asn.1 dissectors. 
svn path=/trunk/; revision=45110
 2012-09-24 19:38:46 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Jakub Zawadzki 9d6e413be7 Regenerate all asn.1 dissectors. 
svn path=/trunk/; revision=44861
 2012-09-10 21:42:36 +00:00
Pascal Quantin f2fbb79c49 Add dissection of locationInformation IE in Ericsson proprietary extension 
svn path=/trunk/; revision=44605
 2012-08-21 15:14:50 +00:00
Pascal Quantin 9f3c1253f7 Fix filter names for Ericsson proprietary extensions 
svn path=/trunk/; revision=44604
 2012-08-21 10:40:04 +00:00
Pascal Quantin 91a531739f Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7648 : 
Add support for Ericsson proprietary extensions to GSM MAP dissector

svn path=/trunk/; revision=44603
 2012-08-21 09:32:04 +00:00
Pascal Quantin dfc983d9ce Remove unused hf_gsm_map_imsi_digits entry and fix filter name for hf_gsm_map_TBCD_digits (which is also used for IMEI, ASCI call reference, MS Group ID and MS Long Group ID on top of IMSI) 
svn path=/trunk/; revision=44596
 2012-08-20 12:47:47 +00:00
Pascal Quantin 45a25dbf9e Avoid defining 2 entries with incompatible types (FT_BYTES vs FT_NONE) and same filter 
svn path=/trunk/; revision=44595
 2012-08-20 09:28:01 +00:00
Pascal Quantin 025200992d Follow-up of r44162: gsm_a_gm dissector is used for both GPRS Mobility Management and Session Management protocols. Update filter names accordingly. 
svn path=/trunk/; revision=44183
 2012-08-01 09:44:57 +00:00
Anders Broman 8ecd85f1ad Introduce a preference setting for application context version. 
svn path=/trunk/; revision=43641
 2012-07-10 11:39:06 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Pascal Quantin f275aeadd9 Fix 'lvalue required as left operand of assignment' error when compiling with gcc 4.3.2 
svn path=/trunk/; revision=43059
 2012-06-04 10:02:08 +00:00
Anders Broman 10fe76d8a0 Get rid of a couple of warnings. 
svn path=/trunk/; revision=43057
 2012-06-04 08:56:48 +00:00
pascal acc2a3706b Fix RVALS() macro usage 
svn path=/trunk/; revision=42720
 2012-05-19 19:05:36 +00:00
Guy Harris dedf907787 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42485
 2012-05-07 21:04:05 +00:00
pascal 7ded30acc1 Set direction according to destination address field also (and not only originating address). 
svn path=/trunk/; revision=42065
 2012-04-14 11:59:14 +00:00
Anders Broman 95a7a04557 Location Number not decoded as per Q.763 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6781 
svn path=/trunk/; revision=41393
 2012-03-07 12:06:16 +00:00
Anders Broman 6b3c0cd4f8 Remove now unused variables. 
svn path=/trunk/; revision=41319
 2012-03-02 11:25:17 +00:00
Alexis La Goutte c1ff84a632 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=41296
 2012-03-02 10:57:48 +00:00
Anders Broman e1d434ee6a From Mike Morrin: 
Add dissectors for GSM and UMTS Cell Broadcast protocols.
( - the patch for gsmtap )

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6770

svn path=/trunk/; revision=40735
 2012-01-26 19:51:48 +00:00
Anders Broman 512e379901 Wireshark crashes in gsm_map dissector 
For now use Jeff's fix:
"The REAL problem is that the GSM_MAP dissector is using this value_string_ext
in the hf without BASE_EXT_STRING:

    { &hf_gsm_old_localValue,
      { "localValue", "gsm_old.localValue",
        FT_INT32, BASE_DEC, &gsm_old_GSMMAPOperationLocalvalue_vals_ext, 0,
        "OperationLocalvalue", HFILL }},

This, in turn, appears to be caused because OperationLocalValue is an alias
for/of GSMMAPOperationLocalValue and only the latter is defined with
.USE_VALS_EXT.

I can fix it by doing:

Index: asn1/gsm_map/gsm_map.cnf
===================================================================
--- asn1/gsm_map/gsm_map.cnf    (revision 39628)
+++ asn1/gsm_map/gsm_map.cnf    (working copy)
@@ -54,6 +54,7 @@

 #.USE_VALS_EXT
 GSMMAPOperationLocalvalue
+OperationLocalvalue

 #.EXPORTS
 AddressString


But it seems to be that asn2wrs should arguably be figuring this out on its
own."

svn path=/trunk/; revision=40033
 2011-11-29 07:03:31 +00:00
Anders Broman 7669c6affd Export NAEA-CIC to be used by Camel. 
svn path=/trunk/; revision=39711
 2011-11-02 06:38:46 +00:00
Bill Meier 24cf0aad06 Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss; 
The only change in each file is in a comment showing the asn2wrs cmd used to build that file.

svn path=/trunk/; revision=39427
 2011-10-15 19:27:27 +00:00
Anders Broman 59a363da40 Update the Camel and MAP ASN.1 files. 
svn path=/trunk/; revision=39386
 2011-10-12 16:41:42 +00:00
Bill Meier 6142dd287b Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1/*: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

 Also: For type FT_IPv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39332
 2011-10-10 01:38:20 +00:00
Anders Broman 83b98f5e2c Add exports 
svn path=/trunk/; revision=39296
 2011-10-06 18:46:47 +00:00
Bill Meier e2996ceabe Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1 dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39294
 2011-10-06 16:50:13 +00:00
Anders Broman 0007775464 Make it possible to dissect proprietarry Opcodes. 
svn path=/trunk/; revision=39183
 2011-09-29 15:23:23 +00:00
Anders Broman a5839116d3 Pretyfy APN display and make it filterable as a string. 
svn path=/trunk/; revision=37731
 2011-06-20 10:29:46 +00:00
Jeff Morriss 7ad71a2d78 Treat TVBs as opaque: use the accessor functions instead of accessing the fields 
directly.

svn path=/trunk/; revision=37420
 2011-05-27 01:57:33 +00:00
Stig Bjørlykke a7c5d642d5 Regenerate ASN.1 dissectors to update the #line directive. 
svn path=/trunk/; revision=37118
 2011-05-13 08:12:27 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman 129f07a949 Added FALLTHRU comment to avoid a "missing break" warning. 
svn path=/trunk/; revision=36365
 2011-03-27 14:02:42 +00:00
Anders Broman f9a0795e3a Export dissect_gsm_map_ISDN_AddressString_PDU(); 
svn path=/trunk/; revision=36079
 2011-02-27 14:54:26 +00:00
Anders Broman 527942b05a Add exports. 
svn path=/trunk/; revision=36049
 2011-02-24 15:06:16 +00:00
Anders Broman 553cf70a68 Dissect V1 version , found in trace from: 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5637

svn path=/trunk/; revision=35843
 2011-02-07 17:44:34 +00:00