Commit graph

46 commits

Author SHA1 Message Date
Ronnie Sahlberg
ff04f85940 Coverity 512
Check if we ran out of bytes in the tvb and return NULL
instead of trying to pass it to the decryption routines.



svn path=/trunk/; revision=36241
2011-03-22 09:35:26 +00:00
Bill Meier
03b57df5a0 Fix various typos and spelling errors.
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
Jeff Morriss
cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34230
2010-09-24 02:51:40 +00:00
Jeff Morriss
0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Jeff Morriss
381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 :
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
2010-09-21 03:14:49 +00:00
Anders Broman
936eb850a1 From Frank Schorr:
NetrLogonControl2 - Control_data_information "name" not being decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5071

svn path=/trunk/; revision=33768
2010-08-11 12:07:25 +00:00
Stig Bjørlykke
1ce4466261 Initialize confounder to ensure it has a known value.
svn path=/trunk/; revision=33709
2010-08-04 13:34:05 +00:00
Gerald Combs
a629fe9c3f Initialize some variables.
svn path=/trunk/; revision=33389
2010-06-30 23:40:05 +00:00
Bill Meier
e1420c0799 Fix a few usages of "" in the hfp] array 'blurb' field.
svn path=/trunk/; revision=32811
2010-05-14 18:56:28 +00:00
Bill Meier
0fc9115705 Use consistent indentation; Whitesapce & formatting cleanup.
svn path=/trunk/; revision=32755
2010-05-11 16:54:55 +00:00
Guy Harris
d6aaf3369b Squelch some compiler warnings.
Use "#if 0"/#endif rather than commenting out some code; that also means
we don't have to use "/ *" and "* /" in the #if'ed-out code, so don't.

Clean up indentation.

svn path=/trunk/; revision=32239
2010-03-19 01:33:12 +00:00
Ronnie Sahlberg
cbd20099ef Add nice dissection of the names of the sign/seal algorithms
in the schannel verifier


svn path=/trunk/; revision=31652
2010-01-25 05:58:26 +00:00
Ronnie Sahlberg
acc4d6bd0a Add proper dissection of NL_AUTH_MESSAGE for schannel as described in
MS-NRPC 2.2.1.3.1


svn path=/trunk/; revision=31651
2010-01-25 05:43:12 +00:00
Sake Blok
cc1afbef75 Make compiler happy when kerberos is not enabled...
svn path=/trunk/; revision=31629
2010-01-22 23:26:53 +00:00
Ronnie Sahlberg
10ee49cdb1 From Matthieu Patou <mat+Informatique.Samba@matws.net>
Enhancements to NETLOGON and ability to decrypt SCHANNEL



svn path=/trunk/; revision=31625
2010-01-22 22:34:24 +00:00
Stig Bjørlykke
46e6206ecd Fixed abbrev for Padding and Flags.
Fixed some indent.

svn path=/trunk/; revision=31425
2010-01-03 15:01:32 +00:00
Guy Harris
8e236e55de For fields of type FT_ABSOLUTE_TIME, have the "display" value be one of
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display
the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL ==
(int)BASE_NONE, so there's no source or binary compatiblity issue,
although we might want to eliminate BASE_NONE at some point and have the
BASE_ values used with integral types start at 0, so that you can't
specify BASE_NONE for an integral field.

svn path=/trunk/; revision=31319
2009-12-19 03:17:44 +00:00
Anders Broman
88bb44a51e From Jakub Zawadzki:
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

svn path=/trunk/; revision=30691
2009-10-25 11:43:30 +00:00
Jeff Morriss
4b6e25c627 s/#if HAVE_KERBEROS/#ifdef HAVE_KERBEROS/
svn path=/trunk/; revision=30649
2009-10-20 20:26:51 +00:00
Jeff Morriss
f687349c04 Another, more sensible, attempt to fix the Win64 build.
svn path=/trunk/; revision=30641
2009-10-20 16:40:00 +00:00
Jeff Morriss
d4d62e3e0d Try to get it compiling on Win64
svn path=/trunk/; revision=30636
2009-10-20 14:12:41 +00:00
Stig Bjørlykke
d43aab714c From Jakub Zawadzki:
Make it compile without kerberos.

svn path=/trunk/; revision=30634
2009-10-20 10:20:14 +00:00
Ronnie Sahlberg
3bb1c2cbd4 From Matthieu Patou
schannel decryption


svn path=/trunk/; revision=30631
2009-10-20 08:44:26 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jaap Keuter
905ae0ffd5 From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28210
2009-05-01 07:06:52 +00:00
Bill Meier
a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Stig Bjørlykke
d0e33bc3c5 Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26646
2008-10-31 14:07:23 +00:00
Ronnie Sahlberg
3e15613ed6 add the new autogenerated lsa dissector
this changes some call signatures requiring changes to the netlogon 
dissector as well


svn path=/trunk/; revision=26320
2008-10-01 00:48:27 +00:00
Ronnie Sahlberg
a8699793aa logoncontrol2 response is a Win32 error code not an nt status code
svn path=/trunk/; revision=20666
2007-02-01 10:10:15 +00:00
Ronnie Sahlberg
68bdadcb50 add decode of trust attribute flags as documented in samba4 netlogon idl
svn path=/trunk/; revision=18905
2006-08-15 02:21:08 +00:00
Ronnie Sahlberg
9149665c5c decode the field of type 11
(it could theoretically also be a union with arm:1 selected instead of a conformant array)


svn path=/trunk/; revision=18858
2006-08-09 08:25:01 +00:00
Ronnie Sahlberg
d72e2d6f6c some functions return dos error codes and not nt status codes
svn path=/trunk/; revision=18331
2006-06-03 02:03:52 +00:00
Ronnie Sahlberg
feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Guy Harris
b13f6dcbd3 Use the new "proto_tree_add_*_format_value" routines.
svn path=/trunk/; revision=17316
2006-02-16 11:43:38 +00:00
Jörg Mayer
735ba01eb1 Bill Meier: More spelling fixes
svn path=/trunk/; revision=16965
2006-01-06 03:26:45 +00:00
Jörg Mayer
f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Ronnie Sahlberg
f5c51aa470 From Kaul
One of the "unknown" fields are actually a digest.


svn path=/trunk/; revision=15983
2005-09-23 21:26:09 +00:00
Jörg Mayer
34493e8f9e char -> const char warning fixes
svn path=/trunk/; revision=15126
2005-07-28 07:53:38 +00:00
Guy Harris
17e0d15df3 Move "dissect_nt_GUID()" into "packet-dcerpc-nt.c", as it's used by the
LSA dissector as well, and declare it in "packet-dcerpc-nt.h".

svn path=/trunk/; revision=13223
2005-02-01 05:21:08 +00:00
Ronnie Sahlberg
bb7160249d rename lsa_dissect_LSA_SECURITY_DESCRIPTOR to lsa_dissect_sec_desc_buf
change its signature to match the autogenerated signatures.

add a small wrapper function so tha tthe handwritten lsa can still call the
function through dissect_ndr_pointer()

no changes in functionality,  essentially just a rename of a function and signature change


svn path=/trunk/; revision=13207
2005-01-30 13:00:35 +00:00
Ronnie Sahlberg
ae9fe25e4f rename lsa_dissect_POLICY_DNS_DOMAIN_INFO to lsa_dissect_DnsDomainInfo and change the signature slightly.
the signature change is to make it compatilbe with the signatures the idl compiler generates.


svn path=/trunk/; revision=13205
2005-01-30 12:21:17 +00:00
Ronnie Sahlberg
0431c0c49f change dissect_ndr_counted_byte_array to be more consistent with dissect_ndr_counted_string
svn path=/trunk/; revision=13202
2005-01-30 02:52:25 +00:00
Ronnie Sahlberg
610da77693 older MS DCE/RPC interfaces often use a construct that is to be treated as a 64 bit integer but in reality is a struct containing 2 32bit integers.
this construct is aligned on 4 byte boundaries in ndr and NOT
8 bytes as a real uint64 (== hyper) would be.


rename the existing dissect_ndr_uint64  ro  dissect_ndr_duint32  (double uint32) to make it reflect better the alignment of the type.



svn path=/trunk/; revision=13184
2005-01-28 09:29:49 +00:00
Guy Harris
13bb12c4f1 Move a bunch of stuff that's more Windows-related than SMB-related to
"packet-windows-common.[ch]".

svn path=/trunk/; revision=11592
2004-08-03 02:28:49 +00:00
Guy Harris
1ef3caa637 Move the NTLMv2 blob stuff back into packet-ntlmssp.c - it's more
NTLMSSP-related than SMB-related, and documents about NTLMSSP talk about
it, so it's a little more convenient to keep all that stuff together -
and export it through a packet-ntlmssp.h header.

svn path=/trunk/; revision=11585
2004-08-02 23:14:32 +00:00
Gilbert Ramirez
669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00
Renamed from packet-dcerpc-netlogon.c (Browse further)