Commit Graph

73 Commits

Author SHA1 Message Date
Jörg Mayer ab7331c393 If a packet is fragmented, show the packet id in the info column.
svn path=/trunk/; revision=27021
2008-12-16 12:28:49 +00:00
Guy Harris 198e48fe85 Don't set the tvbuff actual length based on the IP total length until
after we've checked whether the total length is less than the header
length, so that we don't believe an obviously bogus total length.  (This
doesn't catch all cases of bogus total lengths, but it catches, for
example, a total length of 0.)

svn path=/trunk/; revision=26901
2008-12-02 09:42:57 +00:00
Bill Meier aa30dcd129 Minor proto_reg_handoff cleanup: use find_dissector when appropriate.
svn path=/trunk/; revision=26308
2008-09-30 14:49:44 +00:00
Stig Bjørlykke 2aee2b22f6 Do not flag a low TTL if sending to a multicast address (224.0.0.0/4).
svn path=/trunk/; revision=26195
2008-09-15 12:50:35 +00:00
Bill Meier 38eb4d6ce3 Use const with value_string array definitions
svn path=/trunk/; revision=26028
2008-08-14 23:51:52 +00:00
Guy Harris 83fc9d5e09 Constify a bunch of stuff, to squelch -Wwrite-strings warnings.
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not
ready to enable that warning by default yet.

Throw in some casts to handle GLib routines that take arbitrary
non-const pointers (they can later return the pointers, and some
callers might want to modify or free up those pointers in cases where
they're known to be writable or allocated).

Use ep_tvb_memdup() rather than a combination of ep_alloc() and
tvb_memcpy().

Clean up some indentation.

svn path=/trunk/; revision=25601
2008-06-25 09:12:35 +00:00
Bill Meier 44af6ef887 Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25290
2008-05-14 01:47:41 +00:00
Stig Bjørlykke b091b8d26c Rewrote to use g_strlcpy and g_strlcat.
svn path=/trunk/; revision=24525
2008-03-01 17:23:39 +00:00
Stig Bjørlykke 28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Anders Broman 5935bf73a4 Didier Gautheron:
icmp dissector must call subdissectors even if tree is NULL

svn path=/trunk/; revision=23653
2007-11-28 21:44:40 +00:00
Anders Broman 9da07f5246 Apply yet another set of the optimization patches:
Only call get_hostname once.

svn path=/trunk/; revision=23410
2007-11-09 05:56:42 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Ronnie Sahlberg 30b586ad61 queue the ip/eth headers for tapping before calling any subdissectors
so that they can be tapped even if the subdissectors cause an exception


this fixes bug 1527

svn path=/trunk/; revision=23004
2007-09-28 05:50:19 +00:00
Jaap Keuter 26e21c2f43 From Jonathan:
Capture files generated on TCP segmentation offload (TSO) hardware have an 
all-zero IP-length field in outbound packets.
Wireshark errors out on the small length and refuses to parse the packet further.

svn path=/trunk/; revision=22931
2007-09-24 06:46:59 +00:00
Guy Harris 0e09d21936 Fix indentation.
svn path=/trunk/; revision=22768
2007-09-02 20:37:39 +00:00
Martin Mathieson 7f6d5c04a8 Don't show fragment offset as a bit field, but note number of bits used in long text.
svn path=/trunk/; revision=22727
2007-08-29 15:35:27 +00:00
Bill Meier ac04f94a3d From Todd Martin: "Flag IP TTL more intelligently".
Also: Change default "Low TTL" color filter to match.

svn path=/trunk/; revision=22715
2007-08-28 20:58:50 +00:00
Martin Mathieson 914e885354 Show which bits 'fragment offset' comes from (I had to look it up :( )
svn path=/trunk/; revision=22586
2007-08-22 14:43:26 +00:00
Ulf Lamping cc8f5e8f60 add an expert info, if ip.ttl < 5
svn path=/trunk/; revision=22521
2007-08-16 04:25:54 +00:00
Jeff Morriss 5bf0217530 As requested by Mike Rogovin: register the ICMP dissector by name. For completeness, also register ICMPv6 by name.
svn path=/trunk/; revision=22422
2007-07-30 17:21:40 +00:00
Michael Tüxen cc8ed4a3c4 From Michael Scharf: Add support for TCP Quickstart.
svn path=/trunk/; revision=22041
2007-06-04 23:27:12 +00:00
Sebastien Tandel 028a7cf638 From Ville Nuorvala :
adds support for the following RFCs (and RFC-to-be):
  - RFC 3519 Mobile IP Traversal of Network Address Translation (NAT) Devices
  - RFC 3543 Registration Revocation in Mobile IPv4
  - RFC 4433 Mobile IPv4 Dynamic Home Agent (HA) Assignment (including the not
      yet published errata about the message extension using the short message
      extension format)
  - draft-ietf-mip4-message-string-ext Mobile IPv4 Message String Extension


svn path=/trunk/; revision=21948
2007-05-26 01:01:27 +00:00
Sebastien Tandel 213056bdd2 revert changes of r21879 which fix gcc bugs. These changes was from mipv4
improvements patch.

svn path=/trunk/; revision=21886
2007-05-22 13:47:45 +00:00
Sebastien Tandel 3082359cab fix gcc 4.2 warnings (qualifier type)
svn path=/trunk/; revision=21879
2007-05-22 03:30:28 +00:00
Jaap Keuter 4fef1c31c1 Fix for bug 1497.
Set DSCP_VALUE column info without tree to support export operations.

svn path=/trunk/; revision=21738
2007-05-09 22:27:39 +00:00
Jörg Mayer 379a3e53ec The beginnings of a TAPA dissector (Trapeze Access Point Access Protocol).
Admittedly not much, so if you have any ideas what the rest means or where
I'm wrong please provide feedback.

As tapa uses udp 5000 and ip protocol 4, I needed to add a hack for the
ip part to properly dispatch betweeen ipip and tapa-tunnel (actually I
was unable to turn the ipip dissector into a heuristic dissector :-)

svn path=/trunk/; revision=20971
2007-03-04 11:48:07 +00:00
Jaap Keuter 15648712d9 From Paul Moore:
This patch adds support for the IPv4 Commercial IP Security Option (CIPSO) as
defined in the IETF draft, draft-ietf-cipso-ipsecurity-01.txt.  While this
draft has long since expired, it has become a de-facto standard for labeled
networking with support from several commercial Multi-Level Security (MLS)
operating systems such as HP-UX CMW and Trusted Solaris; in addition, Linux
Kernels 2.6.19 and later provide support for CIPSO in conjunction with
SELinux.

Copies of the expired CIPSO draft can be found at the NetLabel project page:
 * http://netlabel.sf.net

svn path=/trunk/; revision=20506
2007-01-19 23:56:42 +00:00
Luis Ontanon 631ae12e4a taking a look at it the name_str var is unnecessary
svn path=/trunk/; revision=20428
2007-01-14 20:19:00 +00:00
Luis Ontanon c2ea79024a As pointed out by Sebastien Tandel a buffer is allocated unconditionally when it might not be necessary.
svn path=/trunk/; revision=20427
2007-01-14 20:17:13 +00:00
Stephen Fisher 5ed8492c42 Display icmp echo/echo reply sequence numbers in decimal in addition to hex,
so that it is easier to match it with the output of a ping program. 


svn path=/trunk/; revision=20142
2006-12-17 05:44:32 +00:00
Stephen Fisher f4e0b64fe7 From Thomas Sillaber:
Create two new columns: IP DSCP and L2 COS (802.1p)


svn path=/trunk/; revision=20118
2006-12-11 20:24:51 +00:00
Anders Broman d327d37e82 Fix Ethereal bug 994 in Wireshark:
MIP Advertisement reverse tunneling flag not dissected

svn path=/trunk/; revision=18520
2006-06-19 15:54:13 +00:00
Ronnie Sahlberg 067de606f2 from Stephen Fisher
make icmp timestamps more readable



svn path=/trunk/; revision=18406
2006-06-09 20:44:16 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman a784b12150 If version is v6 let the IPv6 dissetor handle it.
svn path=/trunk/; revision=17649
2006-03-16 20:14:47 +00:00
Jaap Keuter d5649bc2de Add UDP-Lite packets to the UDP statistics
svn path=/trunk/; revision=16983
2006-01-09 23:00:20 +00:00
Jörg Mayer 74dc6c2d5f Jon Oberheide:
Ethereal does not take into account the protocol field of the IP header
when reassembling fragmented packets as specified in RFC791.  This can
lead to incorrect reassembly of packets with an identical src address,
dst address, and identification number, but with differing protocols.

The attached patch includes the protocol in the generation of the id
used to index into the reassembly table.


svn path=/trunk/; revision=16937
2006-01-03 23:23:46 +00:00
Ronnie Sahlberg f84e9e9bde from Jaap K
fix for bug 306


svn path=/trunk/; revision=16812
2005-12-15 23:17:01 +00:00
Ronnie Sahlberg 5312127584 get rid of some strcpy()
svn path=/trunk/; revision=16211
2005-10-13 03:22:53 +00:00
Ulf Lamping 2ee44b8409 from Yaniv Kaul: add a Preference setting for IP checksum validation
svn path=/trunk/; revision=16080
2005-10-03 16:24:43 +00:00
Ulf Lamping 9a42ef9536 fix #480: Change defaults for all reassembling settings to ON
I've changed all settings I could find to TRUE. It might be reasonable to change some protocol settings back to FALSE, if reassembling fails very often.

svn path=/trunk/; revision=16048
2005-09-28 22:15:38 +00:00
Guy Harris 13e99476e6 Use BASE_DEC_HEX for the identifier field; that means we don't have to
use "proto_tree_add_uint_format()", we can just let the Ethereal core
format it.

svn path=/trunk/; revision=15922
2005-09-21 02:12:24 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Ronnie Sahlberg fef5af249e remove a whole bunch of strcpy() fix minor bug where whe checked the wrong string before we display it
svn path=/trunk/; revision=15821
2005-09-15 13:31:05 +00:00
Guy Harris 25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
Ronnie Sahlberg 512b39a2e2 some sprintf removals
svn path=/trunk/; revision=15548
2005-08-27 00:09:19 +00:00
Ulf Lamping 808b6d48d0 as discussed some time ago: don't add bad checksum fields conditionally but use a subtree and use boolean flags instead
svn path=/trunk/; revision=15498
2005-08-21 15:13:47 +00:00
Ulf Lamping 33b08bdd52 snprintf -> g_snprintf
svn path=/trunk/; revision=15393
2005-08-17 22:03:21 +00:00
Guy Harris d05a356383 Squelch another const warning.
svn path=/trunk/; revision=15111
2005-07-27 01:12:44 +00:00
Ronnie Sahlberg ab0698d089 ICMP MPLS updates and a new preference option from
Brice Augustin and Maria-Luiza



svn path=/trunk/; revision=15007
2005-07-23 00:46:14 +00:00