Commit Graph

336 Commits

Author SHA1 Message Date
Guy Harris 0cadc40746 Temporarily #if 0 out code that was causing crashes.
svn path=/trunk/; revision=23893
2007-12-16 22:33:03 +00:00
Sake Blok 9a2d18d386 Changes the name of the menu item "View/Reset Coloring" to
"View/Reset Coloring 1-10" and adds sensitivity to it so that
it will be greyed out when none of the temporary color filters
are used.

(as per discussion on wireshark-dev some time ago)


svn path=/trunk/; revision=23879
2007-12-15 23:38:29 +00:00
Jaap Keuter a629334be6 With increasing number of dissectors, heuristics cause sometimes false hits on packets. It's a pain to go through the menu / enabled protocols dialog to temporarily disable such dissector. This change adds an option to the packet detail menu to do a point-and-click style temporary disable of such protocol.
svn path=/trunk/; revision=23873
2007-12-15 13:26:09 +00:00
Jaap Keuter 14141c3275 Source code cleanup.
svn path=/trunk/; revision=23860
2007-12-14 07:06:22 +00:00
Ulf Lamping a912ab234c move "Display Filter Macros" from View to Analyze menu, just below "Display Filter" - I guess it fit's much better there
svn path=/trunk/; revision=23693
2007-11-30 23:28:06 +00:00
Sake Blok e2598d0c92 Remove "Reset coloring" from context menu's to keep the GUI consistent
svn path=/trunk/; revision=23657
2007-11-28 22:36:53 +00:00
Sake Blok 069ddc1335 Add sensitivity to some temporary coloring menu items.
svn path=/trunk/; revision=23654
2007-11-28 22:07:44 +00:00
Stig Bjørlykke 311ec68206 Put double click on a frame link back.
svn path=/trunk/; revision=23644
2007-11-28 12:30:18 +00:00
Ronnie Sahlberg 2830cf2045 fix the path to include g_ascii_strcasecmp.h
svn path=/trunk/; revision=23636
2007-11-28 01:23:09 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Stig Bjørlykke 4b395e9e56 Check current_frame instead of finfo_selected before trying to build a
display filter based on the "selected" package.

svn path=/trunk/; revision=23597
2007-11-26 11:16:04 +00:00
Sake Blok 24c8b3a4b7 Check if a packet is selected before trying to build a display filter based
on the "selected" packet. Fixes bug 2020.


svn path=/trunk/; revision=23596
2007-11-26 09:10:37 +00:00
Sake Blok 61e7574a5c Reset the temporary coloring filters to defaults instead of doing it
implicitly by calling "color_filters_init()". This should probably
fix the crashes experienced when pressing ctrl-space a couple of times


svn path=/trunk/; revision=23583
2007-11-25 14:17:56 +00:00
Stig Bjørlykke e021e1441f Add a cast to make it compile again.
svn path=/trunk/; revision=23569
2007-11-24 20:55:03 +00:00
Sake Blok 9b6f806089 This patch adds (ten) temporary coloring rules which will only live until Wireshark is
quit. Temporary coloring filters can be set by:

- pressing <ctrl>-<digit> will create a conversation coloring filter based on the
  addresses of the currently selected packet (order TCP/UDP/IP/Ethernet)
  This can also be achieved from the "View|Colorize Conversation" menu.

- Rightclicking on a packet in the packet-list will give the option to
  "Colorize Conversation" just as "Conversation Filter" does.

- Rightclicking on an item in the packet-detail-list will give the option to
  "Colorize with filter" which works similar to "Apply as filter"

Temporary filters can be cleared from the same menus or by pressing <ctrl>-<space>.

This patch also adds an item to the above mentioned menu's to add a permanent color filter
in the same way.


The colors for the temporary coloring rules are now hardcoded as I do not know
how to change the color of menu-items and therefore I chose to use icons to
show the actual color of each of the ten temporary coloring rules. Is it at all
possible to have different menu items in different colors?

One other way of solving this is to recreate the icons on the fly after changing
the colors. I will have a look into that once it is clear whether I can use 
different colors within the menu structure.


svn path=/trunk/; revision=23560
2007-11-24 11:38:16 +00:00
Anders Broman f6d282b6cd Apply yet another set of the optimization patches:
- Don't call tree_view_select on first button click event, it's already done by the tree widget.
- Factorize slow gtk_text_buffer_insert_with_tags_by_name() calls

svn path=/trunk/; revision=23477
2007-11-17 08:57:20 +00:00
Stephen Fisher dc7a454b71 From didier:
Fix for bug #1876: Resizing columns changes the currently-selected packet


svn path=/trunk/; revision=23445
2007-11-14 06:39:58 +00:00
Stephen Fisher 700d8194b8 - Future improve/clean up the now generic follow stream code
- Add "Follow UDP Stream" feature


svn path=/trunk/; revision=23346
2007-11-03 04:45:35 +00:00
Stephen Fisher a3202ff86b Standardize filenames and function names for Follow TCP & SSL stream functions
svn path=/trunk/; revision=22870
2007-09-13 22:25:20 +00:00
Ulf Lamping 2efdf99f28 mark some parameters as unused
svn path=/trunk/; revision=22532
2007-08-16 23:35:28 +00:00
Ulf Lamping 4b215597ae experimental feature: dissector filters
add the possibility, that a dissector writer can provide (usually non-trivial) display filters specific for the protocol in question (with an example in packet-dcerpc-pn-io.c), that will appear in the GUI


svn path=/trunk/; revision=22530
2007-08-16 22:03:10 +00:00
Stephen Fisher 2e398bcb6e Change the export object/export object http code to only be included
in the code for GTK versions 2.4 and up instead of 2 and up.


svn path=/trunk/; revision=22455
2007-08-04 17:52:38 +00:00
Ulf Lamping 6cae0b2193 for the Ethernet conversation filter, don't use ethertype but the data link address type being Ethernet. If the ethertype field is a length (0-1500), it will contain 0 - and the filter wouldn't work that way
svn path=/trunk/; revision=22389
2007-07-23 20:18:01 +00:00
Gerald Combs f4f8079986 Add shortcuts for expanding/collapsing the packet detail.
svn path=/trunk/; revision=21910
2007-05-23 17:12:01 +00:00
Stephen Fisher 6d8d2854c8 From Sake Blok:
Fix for bug #491: Unexpected frame.time_delta behavior

This patch ... fixes bug 491. It does this by changing the
behaviour of the frame.time_delta field so it reflects the delta
time between captured packets (tshark already did this).  To keep
the delta time between displayed packets, the field 
frame.time_delta_displayed is created.


svn path=/trunk/; revision=21154
2007-03-23 18:08:17 +00:00
Stephen Fisher 2e562ea7b4 From Sake Blok (via -dev list and enhancement bug #1449):
I did however see some small errors in the
documentation that I did not notice when I sent in the patch. This
patch corrects them and adds an accelerated key:

- table 6.1 remove "Analyze" from "Identical..." column for "Copy as Filter"
- table 6.2 add "Edit" from "Identical..." column for "Copy as Filter"
- Added accelerator key for "Copy as Filter". I chose "Shift+Ctrl+C", so
  that "Ctrl+C" is still available for "standard" copy

Image figure 3.4 should be renewed, reflecting the change in the menu
structure. 


svn path=/trunk/; revision=21140
2007-03-23 00:42:45 +00:00
Ulf Lamping d877cbc394 minor "Copy" menu item fix:
split the "sensitivity control" into "Copy" and "Copy/As Filter", otherwise it's not possible to copy a field that is not filterable (e.g. text only descriptions)

svn path=/trunk/; revision=21097
2007-03-21 21:23:56 +00:00
Guy Harris 082282b6f4 Don't enable "Save As" if you don't have an unsaved live capture file
and there are no formats in which the file can be saved by some means
other than copying the raw data; "Save As" isn't a very useful function
in that case, and that prevents us from having an empty list of formats
in which the file can be saved.

svn path=/trunk/; revision=21032
2007-03-14 19:30:19 +00:00
Ulf Lamping acefba187a from Sake Blok:
I have changed the patch according to your suggestions and also changed
the doc[book] files accordingly. I tested the patch and it does seem to
work fine on my test-system.

ULFL: In addition, I've added the en-/disabling to the other (already existing) Copy menu items - some just did nothing, some crashed if nothing was selected.
I've also sligthly changed the menu seperators and made both context menus look a bit more identical.

svn path=/trunk/; revision=21005
2007-03-08 23:37:55 +00:00
Stephen Fisher f8d82fab38 Activate the File -> Export menu when a capture is in
progress in addition to when a capture file is open.


svn path=/trunk/; revision=20959
2007-03-02 21:47:34 +00:00
Stephen Fisher d3b873b60d Sync up my changes so far to the content list (now called object
list) feature for http traffic.  It's now available under File->
Export->Objects->HTTP.  More changes to come..


svn path=/trunk/; revision=20951
2007-02-28 23:20:40 +00:00
Luis Ontanon a2a25e7586 revert (most) changes in rev #20753, to avoid items being created on a wrong menu on windows.
svn path=/trunk/; revision=20928
2007-02-25 18:03:05 +00:00
Stephen Fisher 07f8ad771e Put the rest of the #if GTK_MAJOR_VERSION >= 2 preprocessor statements around parts of the Content List -> HTTP feature code.
svn path=/trunk/; revision=20869
2007-02-20 00:22:00 +00:00
Stephen Fisher 7a2bfb7a61 Initial version of the new Statistics -> Content List -> HTTP feature. This
feature lists all of the content found in an HTTP stream (images, http, etc.)
and displays it in a list that allows the user to save each one as a file that
is already reassembled by the dissectors.


svn path=/trunk/; revision=20867
2007-02-19 22:37:45 +00:00
Ulf Lamping ca590fafbe ooops, and here comes the actual context menu code change from Douglas Pratley ... already mentioned in SVN 20787
svn path=/trunk/; revision=20790
2007-02-12 05:08:33 +00:00
Luis Ontanon 7c57c05ed5 * Add a Submenu (/Views/User Tables) where UATs can be accessed.
* Remove macros_dlg, the DFMacros UAT goes in the menu with all the rest
* in packet-user_encap.c WTAP_ENCAP=XXX has become useless information for the user leave just the DLT#



svn path=/trunk/; revision=20753
2007-02-09 03:11:14 +00:00
Stephen Fisher b4a656ec1f From Douglas Pratley:
This is a patch adding items to the context menus for the packet list
and packet details panes for copying packet data to the clipboard.

New menu item on packet list pane:
Copy (sub menu) ->
        Summary (Text)          Copies fields displayed in the packet
list, tab separated
        Summary (CSV)           Copies fields displayed in the packet
list, comma separated
        Hex and Text            Copies data for the selected frame in
hex-editor style (similar to Copy\All Information in packet bytes pane)
        Text Only               Copies data for the selected frame,
dropping non-printable characters other than line breaks (similar to
Copy\Text Only in packet bytes pane)
        Hex Columns             As Hex and Text but without text
        Hex Stream              Copies data for the selected frame as an
unpunctuated list of hex values
        Binary Stream           Copies raw packet bytes to the clipboard
as MIME type application/octet-stream


svn path=/trunk/; revision=20581
2007-01-28 02:49:50 +00:00
Ulf Lamping 18cf691f7d as Bill Meier noted:
"The Help ! Contents and the Help ! User's Guide  both display the User's 
Guide."

Remove the duplicate Help!/User's Guide item

svn path=/trunk/; revision=20523
2007-01-22 04:03:17 +00:00
Luis Ontanon 80dcfb23d2 display filter macros.
NOT to be copied over to release 0.99.5


svn path=/trunk/; revision=20467
2007-01-18 02:54:56 +00:00
Ulf Lamping 2d760bf075 in effect use the User's Guide as the online help system now (for GTK > V1)!
remove ENABLE_WSUG setting from config.nmake and replace it with GLIB_MAJOR_VERSION >= 2 (as Glib 1.x cannot open a browser to show a HTML file - it's just currently? not implemented)

svn path=/trunk/; revision=20446
2007-01-16 04:08:35 +00:00
Graeme Lunt 6fd190ecec U3 support for "recent" files.
When the "recent" file is written, any references to files on the U3 device itself are modified to have the drive replace with "$U3_DEVICE_PATH". Similarly, when the recent file is read, "$U3_DEVICE_PATH" is replaced with the current U3 device path.

This ensures that if/when the U3 device path changes when inserting it into different machines, recent captures on the U3 device itself can still be opened from the recent menu.


svn path=/trunk/; revision=20417
2007-01-13 16:06:28 +00:00
Ulf Lamping fbcd16a443 change it to "Seconds Since Epoch (1970-01-01): 1234567890.123456"
svn path=/trunk/; revision=20079
2006-12-09 09:32:21 +00:00
Stephen Fisher 75acf34518 From Douglas Pratley with trivial changes and documentation changes
by myself:

Corrected patch; epan/column.c and epan/column_utils.c were not included. This
one has now been properly tested against a clean checkout of today's code.

- New menu option available under view\time display format
- New sub-option (e) to -t switch for both wireshark and tshark
- Extended recent settings code to handle new value
- Did NOT add new explicit epoch time column


svn path=/trunk/; revision=20040
2006-12-05 03:19:51 +00:00
Guy Harris d3fed959bc Have separate proto_construct_match_selected_string() and
proto_can_match_selected() routines, to more clearly separate the two
functions - but have them both call the same underlying routine, so
they both make the same decisions as to whether a match-selected string
can be constructed or not.

svn path=/trunk/; revision=19976
2006-11-24 18:25:23 +00:00
Guy Harris 37a6c02697 Rename proto_construct_dfilter_string() to
proto_construct_match_selected_string() to indicate what it does - and
have it return a Boolean indication of whether the string could be
built, returning the string through a pointer, and, if that pointer is
null, have it just return the Boolean and not construct the string.

Get rid of proto_can_match_selected() -
proto_construct_match_selected_string() can be used for that, which
means we have only one piece of code that knows whether a "match
selected" string can be constructed or not.

Have proto_construct_match_selected_string() support matching
zero-length FT_NONE (and FT_PCRE, but that shouldn't happen) fields even
if there's no epan_dissect_t, as such a match just checks whether the
field is present.

svn path=/trunk/; revision=19967
2006-11-23 21:16:46 +00:00
Gerald Combs 1ed6291425 Add additional keyboard navigation: Ctrl+Up & Ctrl+Down (under the "Go"
menu) move to the previous and next packet even if the packet list isn't
in focus (specifically, the packet detail will stay in focus if that was
already the case).  Make the return and enter keys toggle tree items in
the packet detail and the backspace key jump to the parent node.  Add a
navigation section to the User's Guide.

Make SIGNAL_EMIT_BY_NAME a simple #define, so that we can feed it
multiple arguments.  Fix up whitespace.

svn path=/trunk/; revision=19924
2006-11-18 01:47:49 +00:00
Luis Ontanon 482ded17c6 Hide the "Tools" menu if it has no items .
svn path=/trunk/; revision=19578
2006-10-17 17:52:15 +00:00
Luis Ontanon dad92a4808 Hide the "Tools" menu if unused.
svn path=/trunk/; revision=19559
2006-10-16 16:54:48 +00:00
Martin Mathieson d0c38312a4 Don't show Tools menu at all if Lua not present
svn path=/trunk/; revision=19394
2006-10-02 13:38:13 +00:00
Luis Ontanon dc6b87bd2a Avoid to add an empty menu if there's no Lua.
svn path=/trunk/; revision=19346
2006-09-28 08:57:29 +00:00