Commit Graph

17311 Commits

Author SHA1 Message Date
Ronnie Sahlberg c4c2ce2606 add new se_tree_lookup32_less_than_or_equal() call
svn path=/trunk/; revision=17663
2006-03-18 06:15:39 +00:00
Lars Roland 87e4a20bbb Make some string comparisons case insensitive in the sip dissector
svn path=/trunk/; revision=17662
2006-03-18 04:40:11 +00:00
Lars Roland b63ee69750 Add some dependencies for libethereal.dll, so it gets re-build, if someone just changes a source file in a subdirectory (e.g. a dissector)
svn path=/trunk/; revision=17661
2006-03-18 03:32:10 +00:00
Lars Roland fc81794dc9 based on a patch from Martin Mathieson:
- dissection of SIP headers containing credentials and challenges.

from me:
- add filter fields for some missing related parameters from RFC 3261
- improve calculation of parameter length.

This implements enhancement request (bug id 812)

svn path=/trunk/; revision=17660
2006-03-18 03:23:26 +00:00
Gerald Combs a0db53ba73 Remove unused internal entities. Update some bug entries. Fixup
whitespace.

svn path=/trunk/; revision=17659
2006-03-17 22:59:24 +00:00
Ulf Lamping 6ea4c2745e add missing IDispatch methods and related dissections
svn path=/trunk/; revision=17658
2006-03-17 21:41:56 +00:00
Ronnie Sahlberg b43c495d49 fix for coverity bug 41
if decryption failed there was a possibility to dereference a null pointer


svn path=/trunk/; revision=17657
2006-03-17 21:03:14 +00:00
Jaap Keuter 09f2ccdca3 Fix bug 819: make sure to always return a tvb pointer.
svn path=/trunk/; revision=17656
2006-03-17 11:46:07 +00:00
Jaap Keuter a346237ffd From Martin Warnes:
Attached is a fix that addresses a problem reading certain IBM iSeries
Communications traces.


svn path=/trunk/; revision=17655
2006-03-17 06:59:27 +00:00
Anders Broman d2ae4f4c7a From Ming Zhang:
added 3 MCC mode pages decode support.

MRW page
Write param page
capacity page

also fixed several wrong tvb_get_ntohs usage introduced in previous patch.

svn path=/trunk/; revision=17654
2006-03-17 06:26:14 +00:00
Ulf Lamping 0ef693174e fix some typos in a comment
svn path=/trunk/; revision=17653
2006-03-16 23:18:15 +00:00
Ulf Lamping bbaffabaaf we don't need to "ban" the print call any longer
svn path=/trunk/; revision=17652
2006-03-16 23:16:35 +00:00
Anders Broman 4f48d73d90 Copy a bugfix from http://www.sqlite.org/cvstrac/tktview?tn=313
svn path=/trunk/; revision=17651
2006-03-16 22:18:15 +00:00
Anders Broman 3c2c4a390a Fix dissection of QoS.
svn path=/trunk/; revision=17650
2006-03-16 21:16:30 +00:00
Anders Broman a784b12150 If version is v6 let the IPv6 dissetor handle it.
svn path=/trunk/; revision=17649
2006-03-16 20:14:47 +00:00
Anders Broman cfbc70a648 Add some extension IE:s
- APN Restriction
 - RAT Type
-  IMEI(SV)

svn path=/trunk/; revision=17648
2006-03-16 20:13:17 +00:00
Luis Ontanon e57aefead5 - Have strptime prototype being included.
- clear struct tm s before passing them to strptime.
- make sure stopttime is a valid value on every plattform.


svn path=/trunk/; revision=17647
2006-03-16 19:45:02 +00:00
Jaap Keuter c673b2f4f1 Fixed skipCount decoding. Added "relevant function" tag and put relevant function into INFO column.
svn path=/trunk/; revision=17646
2006-03-16 17:47:45 +00:00
Jaap Keuter d3efbd7284 Superfluous check on 'secret' removed.
Coverity CID 31

svn path=/trunk/; revision=17645
2006-03-16 12:27:50 +00:00
Jaap Keuter 4efe662b04 Check struct pointer before dereferencing it.
Coverity CID 142

svn path=/trunk/; revision=17644
2006-03-16 12:12:51 +00:00
Luis Ontanon 182553b988 From: Peter Johansson
have mtp3_pc_hash() explicitly returning pc.

From me:
 break; execution inside the switch.


svn path=/trunk/; revision=17643
2006-03-16 10:23:09 +00:00
Ronnie Sahlberg 107f59142d the new type of sid/rid structure is for lookupnames2 not lookupnames
svn path=/trunk/; revision=17642
2006-03-16 08:47:19 +00:00
Luis Ontanon e21b984570 One day I'll be able to do change something in windows in a single attempt
svn path=/trunk/; revision=17641
2006-03-15 22:58:40 +00:00
Luis Ontanon de1c20ad4b Define HAVE_LUA_5_1 on windows as that what we have.
svn path=/trunk/; revision=17640
2006-03-15 22:30:28 +00:00
Jaap Keuter 87212ed160 Add missing preference storage.
svn path=/trunk/; revision=17639
2006-03-15 21:22:11 +00:00
Luis Ontanon ecae4ddd06 use time_t instead of an unsigned integer to sstore the time.
svn path=/trunk/; revision=17638
2006-03-15 20:52:37 +00:00
Anders Broman b4d7dd6060 Some more variable bindings and add some mising PDU types.
svn path=/trunk/; revision=17637
2006-03-15 18:57:47 +00:00
Anders Broman 61b223303a From Greg Morris:
Modification to (proto.h) is made to add an additional expert group type of PI_REQUEST_CODE to allow Request tag information to be passed to the expert tap. This is for such reasons where a dissector would like to echo specific information about certain types of requests. For example: NCP connection request is really a request not a REPLY_CODE. Same is true for the TCP SYN request.

Changes to packet-ncp.c
1. Server broadcast message flag. Now indicates if the message is a pending message or an oplock clear notification.
2. Cleanup of packet signature detection process. Previous method had some flaws so I redesigned it. Appears to be solid now.
3. Echo NCP Server Session information to expert tap.
 
Note on item #3: NCP Connection+Task = NCP Session, a Single connection can have many tasks. The server sees each connection/task as a unique session. For this reason the NCP session information is now echoed to the expert composite statistics so that you can easily identify the different NCP processes and sessions. It is important to NCP analysis to understand that each session is most likely a different program on the requesting host sharing the same NCP connection.
 
Changes to packet-ncp2222.inc
1. Comment out the echo of NCP connection info to expert tap. Replaced by NCP sessions.
2. Add displayEID in request decode (resolves Coverity defect for dead code in NCP dissector)
 
Changes to ncp2222.py
1. Fix for endian display of bindery object type in NCP 0x1720.
2. Fix for size of bindery object type to 2 bytes instead of 4 to match other bindery NCP's.

svn path=/trunk/; revision=17636
2006-03-15 18:56:35 +00:00
Anders Broman 522757cae0 from Martim Mattieson:
This small patch will cause the current AVP dictionary to be freed and 
repopulated when relevant preferences have changed.

svn path=/trunk/; revision=17635
2006-03-15 18:55:12 +00:00
Anders Broman c26db21d54 From RABRET Laurent RD-MAPS-ISS:
Please find enclosed a patch for the BGP dissector.
A 0 length IP address is valid in NLRI dissection. It just means "0/0 address".

svn path=/trunk/; revision=17634
2006-03-15 18:53:54 +00:00
Jörg Mayer eb98b0f366 Update/add some Cisco multicast addresses
svn path=/trunk/; revision=17633
2006-03-15 10:53:33 +00:00
Ronnie Sahlberg 5dd314e53a lookupnames2 takes a different sid structure compared to lookupnames
update it to dissect it as such and create new helpers for the new structure  that takes one extra guint32 at the end of the previous structure.


svn path=/trunk/; revision=17632
2006-03-15 08:26:21 +00:00
Anders Broman beeb757f61 Start implementing the variable binding part.
svn path=/trunk/; revision=17631
2006-03-15 06:20:23 +00:00
Anders Broman 38d4e1d0c8 From Motonori Shindo:
The code assumes Template FlowSet contains only one Template Record, which is not necessarily true. Please find attached the patch to fix it.

svn path=/trunk/; revision=17630
2006-03-15 06:19:15 +00:00
Anders Broman b69c251c80 From Martin Mathieson:
> This patch:
> - adds a few filterable fields (currently there are only hidden
> boolean fields for request and response).

svn path=/trunk/; revision=17629
2006-03-15 06:17:35 +00:00
Anders Broman c6a21a1d14 From Martin Mathieson
>>>This patch:
>>>- makes it possible to turn off use of the XML AVP dictionary (which 
>>>relies upon the XML lib being installed).  A failed load results in 3 
>>>annoying dialogs popping up the first time a diameter packet is read. 
>>>Default is previous behaviour.

svn path=/trunk/; revision=17628
2006-03-15 06:16:12 +00:00
Luis Ontanon c39b333072 Fix bug 710 and avoid having it crash when more than one instance are open at once.
I think that whoever wrote the whole stats_tree thing should rewrite it ASAP, because it sucks!

I did ?!?!??

ooops!


svn path=/trunk/; revision=17627
2006-03-15 01:41:39 +00:00
Ronnie Sahlberg 329b915b66 coverity bug 139
actually allow dissection of RELEASE_LOCKOWNER call
instead of letting it hang as dead code



svn path=/trunk/; revision=17626
2006-03-14 08:11:18 +00:00
Ronnie Sahlberg 6ea1f1a77c coverity bug 68
prevent a very very long loop


svn path=/trunk/; revision=17625
2006-03-14 07:47:19 +00:00
Ronnie Sahlberg c1aa2aef89 coverity bug 43
svn path=/trunk/; revision=17624
2006-03-14 07:38:43 +00:00
Anders Broman 8d92765c4b Add strptime.obj to outfiles as well.
svn path=/trunk/; revision=17623
2006-03-14 06:42:58 +00:00
Anders Broman d7610e4c0a From Laurent Rabret,
2 patches for the "flow graph" display. It is better not to insert invalid packets into the list than to control the list is correct while using it...

svn path=/trunk/; revision=17622
2006-03-14 05:49:15 +00:00
Ronnie Sahlberg 2f37e2de15 coverity bug 44
svn path=/trunk/; revision=17621
2006-03-14 05:38:47 +00:00
Ronnie Sahlberg 0e46ae1dd6 handle coverity bug 36
svn path=/trunk/; revision=17620
2006-03-14 05:30:26 +00:00
Ronnie Sahlberg 877d757062 put the opcode as a generated field inside data pdus for scsi
svn path=/trunk/; revision=17619
2006-03-14 04:56:40 +00:00
Ronnie Sahlberg dd99a25837 prettifu getconfiguration response
svn path=/trunk/; revision=17618
2006-03-14 01:18:43 +00:00
Luis Ontanon 89c487756e missed to add strptime.obj to the editcap.
svn path=/trunk/; revision=17617
2006-03-14 00:17:22 +00:00
Ronnie Sahlberg 0398f48341 set current_proto to SCSI so that the exception handler will show the correct protocol
fix length in getconfiguration()  so that we provide the proper one (+4)
to avoid marking valid packets as malformed.



svn path=/trunk/; revision=17616
2006-03-13 22:35:14 +00:00
Luis Ontanon 3318411aa7 Use checkTextWindow instead of shiftTextWindow to fetch the window object from the stack, shiftXxx will happily (and rightfully) return a null pointer without an error.
svn path=/trunk/; revision=17615
2006-03-13 22:22:17 +00:00
Luis Ontanon fb41328889 Add -A <start time> and -B <stop time> options to editcap
svn path=/trunk/; revision=17614
2006-03-13 22:20:07 +00:00