Commit Graph

1178 Commits

Author SHA1 Message Date
Jörg Mayer 52965244cd Add GTK3_DEFINITIONS to the compiler flag when building with gtk3
svn path=/trunk/; revision=49038
2013-04-25 21:35:54 +00:00
Guy Harris 39779a7bee Send the output of the -D and -L options to the standard output rather
than the standard error.

In Wireshark on Windows, create a console before doing so and destroy it
before exiting.  Don't do that in TShark or dumpcap, as those are
console-mode programs on Windows.

This should fix bug 8609 and still allow "wireshark -D" and "wireshark
-L" to work when the standard output isn't redirected.

svn path=/trunk/; revision=49025
2013-04-25 05:47:11 +00:00
Michael Mann 4a1bd75b60 Add a "hidden" array of UAT entry data to allow separation between UAT file syntax errors and "syntactically correct, but invalid field". Now UAT files load all entries into the "hidden" array (raw_data), but only adds valid ones to the user_data, which is used by the dissectors.
This is a start to fixing bug 7471 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7471) and is being committed to get the new ABI/API in before the 1.10 release.
What remains is the "GUI portion" (GTK+qt) to indicate to users which UAT entries are invalid.

svn path=/trunk/; revision=48960
2013-04-22 02:10:49 +00:00
Anders Broman 0567069a98 Based on http://anonsvn.wireshark.org/viewvc?revision=48893&view=revision
"Cast scrolling values to gdoubles, not gfloats - GtkAdjustment have
always taken doubles that I've been able to find, and casting to floats
causes loss of precision and weird bugs when the values get enormous."

svn path=/trunk/; revision=48930
2013-04-19 16:26:27 +00:00
Irene Rüngeler e1713c142d Initialize another variable.
svn path=/trunk/; revision=48926
2013-04-19 11:54:22 +00:00
Irene Rüngeler 319e5be393 Show Forward_Tsn chunks in the graph
svn path=/trunk/; revision=48925
2013-04-19 11:34:46 +00:00
Evan Huus cba2efe285 Remove an unused variable, structure and #define caught by cppcheck.
Also fixes a small memory leak.

svn path=/trunk/; revision=48903
2013-04-17 19:52:20 +00:00
Alexis La Goutte 101489f386 Use also const char to uat_save (identical to uat_load)
svn path=/trunk/; revision=48902
2013-04-17 19:39:11 +00:00
Alexis La Goutte f9dce307d8 Fix the following GTK-CRITICAL error Gtk-CRITICAL **: gtk_list_store_get_path: assertion `iter->stamp == GTK_LIST_STORE (tree_model)->stamp' failed
Problem come from no item in list (and impossible to select the first item...)

svn path=/trunk/; revision=48901
2013-04-17 19:38:50 +00:00
Evan Huus b13e702709 Cast scrolling values to gdoubles, not gfloats - GtkAdjustment have
always taken doubles that I've been able to find, and casting to floats
causes loss of precision and weird bugs when the values get enormous.

Should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8460

svn path=/trunk/; revision=48893
2013-04-17 15:07:48 +00:00
Evan Huus 0c8abacbec Fix a minor memory leak caught by cppcheck. Also replace a whole bunch of
"This shouldn't happen" fallback strings with a single assertion.

svn path=/trunk/; revision=48888
2013-04-16 21:20:57 +00:00
Evan Huus f8f078744b Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8583
IO graph was misbehaving if the packets covered too much real time.
It's still ungodly slow, but at least it seems to work.

svn path=/trunk/; revision=48882
2013-04-16 16:16:15 +00:00
Irene Rüngeler 65043453b9 Update interface list when interface get lost and come back.
svn path=/trunk/; revision=48880
2013-04-16 15:12:38 +00:00
Evan Huus d0bd2097f0 Fix another dozen or so files with bad FSF addresses as caught by licensecheck.
svn path=/trunk/; revision=48869
2013-04-16 00:00:09 +00:00
Martin Mathieson d7c35d571d Allow MAC and RLC stats dialogs to be launched other than by menu/filter
dialogs.

svn path=/trunk/; revision=48855
2013-04-15 18:25:04 +00:00
Martin Mathieson 8067c41855 Allow zooming in on a rectangular region using left mouse.
Slightly simplified version of what tcp_graph.c does.

svn path=/trunk/; revision=48835
2013-04-13 14:54:34 +00:00
Irene Rüngeler 22e43ff352 Ifdef LibPcap
svn path=/trunk/; revision=48830
2013-04-12 13:33:22 +00:00
Irene Rüngeler 590a68a677 The button are only needed if libpcap is present.
svn path=/trunk/; revision=48829
2013-04-12 12:46:25 +00:00
Michael Tüxen d6375b1bf5 The function takes no arguments...
svn path=/trunk/; revision=48828
2013-04-12 12:12:04 +00:00
Irene Rüngeler a17ec349b4 Change the sensitivity of the start button depending on the number of interfaces selected.
svn path=/trunk/; revision=48827
2013-04-12 11:56:00 +00:00
Evan Huus 75fbfb40cb Misc. small string changes to the capture options dialog for consistency and
grammar.

Mostly adapted from some of the less controversial ideas proposed in the thread
at https://www.wireshark.org/lists/wireshark-dev/201212/msg00055.html

svn path=/trunk/; revision=48819
2013-04-11 17:22:11 +00:00
Gerald Combs 900ddabefa Replace the capture start and restart icons with a green fin similar to
wsiconcap. Make the capture stop icon red. Replace wsiconcap with an
earlier version which has gears instead of a record button.

svn path=/trunk/; revision=48818
2013-04-11 16:52:03 +00:00
Irene Rüngeler 799985b0f9 Don't select the 'any' device (in Linux), when 'capture all' is selected.
svn path=/trunk/; revision=48815
2013-04-11 12:08:48 +00:00
Irene Rüngeler bcf7a98be1 Select the interface, if only one exists.
svn path=/trunk/; revision=48813
2013-04-11 08:31:59 +00:00
Irene Rüngeler afb0e76c8b The default interface should now be selected also on Windows.
svn path=/trunk/; revision=48799
2013-04-09 08:41:01 +00:00
Jeff Morriss c2ced4a2ab Don't try to open <home>/.wireshark on Windows: Wireshark hasn't written to
that directory since 2001 and reading from that directory was only left in for
backwards compatibility with versions prior to r4702.  I think it's now safe
to remove that backwards compatibility.

This eliminates the last argument of get_persconffile_path().

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8437

svn path=/trunk/; revision=48797
2013-04-09 02:48:03 +00:00
Gerald Combs 10627830cb Nudge the fill another half pixel.
svn path=/trunk/; revision=48792
2013-04-08 18:32:51 +00:00
Gerald Combs e63161794b Decrease the width of the outer borders by half a pixel to match the
other icons more closely.

svn path=/trunk/; revision=48791
2013-04-08 18:28:33 +00:00
Gerald Combs e8aa604eed Try a blue fill for the stop capture button, using Windows Sound
Recorder as a cue.

svn path=/trunk/; revision=48790
2013-04-08 17:14:16 +00:00
Irene Rüngeler 192b62f97b Set the default interface as selected.
svn path=/trunk/; revision=48788
2013-04-08 08:13:20 +00:00
Gerald Combs 69ee73b5de Adjust the automatic update label.
svn path=/trunk/; revision=48780
2013-04-07 18:06:19 +00:00
Gerald Combs 102a6cc04b Expose the automatic update preference on Windows.
svn path=/trunk/; revision=48778
2013-04-07 17:59:44 +00:00
Gerald Combs b2f2059c41 Use a monospace font for the address resolution dialog so that tab
alignment will work. Add modelines and reindent.

svn path=/trunk/; revision=48777
2013-04-07 17:59:07 +00:00
Gerald Combs fc19abb965 Change the "stop capture" icon to a Great Big Huge Square to try to make
it more obvious (particularly at 16x16 pixels) that it and the "start
capture" icons work like media controls.

Update compress-pngs to match the latest version of pngcrush and
recompress our PNGs. Add a "clean-pixmaps" target to ui/gtk/Makefile.am
to make it easier to rebuild our pixbuf includes.

svn path=/trunk/; revision=48776
2013-04-07 17:40:28 +00:00
Pascal Quantin d40de83931 Put "Remote Interface" window on top of "Interface Management" window
svn path=/trunk/; revision=48752
2013-04-05 21:52:39 +00:00
Irene Rüngeler b34e4d5fee Add checkbox for the direction indication to the "Import from Hex Dump" dialog.
svn path=/trunk/; revision=48745
2013-04-05 06:43:38 +00:00
Anders Broman 198149f148 From Tim Ringenbach:
makes the TDMoE dissector call the LAPD bitstream dissector on the D-Channel. As a result, LAPD calls Q.931, and you can actually see call setup and tear down, instead of just a hex dump.

It adds a preference for which channel the D-Channel is.

It patches the LAPD code to fix a few bugs, not pass the checksum to Q.931 (who isn't expecting it), to register the lapd-bitstream dissector, and to mark packets with aborts or resets.

also storing more data on the lapd_byte_state_t.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8374

svn path=/trunk/; revision=48743
2013-04-05 05:09:31 +00:00
Jaap Keuter a092ef9862 Set 'details' radio button sensitivity also at the creation of the dialog.
svn path=/trunk/; revision=48736
2013-04-04 17:20:36 +00:00
Chris Maynard 998e940ec9 Use a consistent bracketing style throughout. Add modelines.
svn path=/trunk/; revision=48728
2013-04-04 14:10:44 +00:00
Guy Harris 432e914dbd Rename cf_not_saved() to cf_has_unsaved_data() to clarify what it
indicates.  (Note: "unsaved data" is more than just "unsaved changes";
it could also mean "temporary file that hasn't been saved anywhere".)

svn path=/trunk/; revision=48709
2013-04-02 20:35:46 +00:00
Guy Harris f32a839bb0 Handle the case of there being no comment view.
svn path=/trunk/; revision=48708
2013-04-02 20:19:54 +00:00
Guy Harris 019cc8fbd2 Show the comment area only if we could write out the comments were the
user to enter any.

svn path=/trunk/; revision=48707
2013-04-02 20:01:10 +00:00
Guy Harris d942759401 Add routines to file.c to indicate whether:
a save can be done ("can" in the sense of "there's something to
	save" and in the sense of "we can write that something out");

	a "save as" can be done (in the sense of "we can write what we
	have out");

	there's unsaved data to save (which might be unsaved changes or
	might be a temporary file full of packets);

and use them as appropriate.  This means that the "unsaved data"
indicator in the UI will be turned on for temporary files full of
packets as well as for files with unsaved changes; that's what we want.

svn path=/trunk/; revision=48693
2013-04-01 23:44:29 +00:00
Guy Harris f8965b7b2c If we can't write the capture out in a file format that supports
per-packet comments, don't let the user add/edit/delete per-packet
comments - they can comment all they want, but once Wireshark closes the
file, those comments will be gone.

svn path=/trunk/; revision=48692
2013-04-01 22:23:55 +00:00
Guy Harris b1ecd8d217 Add a wtap_dump_can_write() routine that indicates whether Wiretap
supports writing files with a given set of encapsulations and comment
types.  Use it, rather than asking for a list of file formats that
support the given set of encapsulation and comment types and checking
whether we got back such a list, or duplicating its logic.

Having file.c use it means that nobody's using
wtap_dump_can_write_encaps() any more; get rid of it.  Instead, have a
private routine that checks whether a given file format supports a given
set of encapsulations *and* comment types, and use that internally.

svn path=/trunk/; revision=48690
2013-04-01 21:17:50 +00:00
Guy Harris 82a602d697 Define a collection of bits for different types of capture file comments.
For each capture file type, have a bitset of comment types supported by
that capture file type.

Add a Wiretap routine that, for a given file type, returns the bitset of
comment types it supports.

Have wtap_get_savable_file_types() take a bitset of comment types that
need to be supported by the file types it returns.

Replace cf_has_comments() with a routine that returns a bitset of
capture file comment types in the capture file.

Use those routines in the capture file dialogs; don't wire in the notion
that pcap-NG supports all comment types and no other file formats
support any comment types.  (That's currently true, but we don't want to
wire that in as being forever true.)

svn path=/trunk/; revision=48689
2013-04-01 20:36:42 +00:00
Guy Harris d49404236c Get rid of main_capture_set_main_window_title(), as it just wraps
set_titlebar_for_capture_in_progress(); make the call directly, to make
it a bit clearer when it needs to be called (which helps us do the
equivalent in the Qt version).

svn path=/trunk/; revision=48687
2013-04-01 17:57:20 +00:00
Guy Harris a94307adcf Move the knowledge about what the window title should be to
ui/gtk/main_titlebar.c, with set_titlebar_for_capture_file() for either
no capture file or an opened capture file and
set_titlebar_for_capture_in_progress() for an in-progress capture.

svn path=/trunk/; revision=48683
2013-04-01 00:21:44 +00:00
Guy Harris 78ab71cc9d Rename set_display_filename() to set_titlebar_for_capture_file(), as
it affects more than just the file name, it also affects whatever "you
have unsaved changes" indicator the UI provides.

Put a comment in the Qt code as a reminder of how to set the "you have
unsaved changes" indicator.

svn path=/trunk/; revision=48680
2013-03-31 22:17:43 +00:00
Guy Harris e2eabbc883 Make the menu item for importing a hex dump text file be "Import from
Hex Dump", to clarify that it's not some sort of "generic" import
function, just one that can read a hex dump file.  ("Import from Hex
Dump Text" is another possibility.)  Use that string in the dialog title
as well.

svn path=/trunk/; revision=48665
2013-03-31 04:17:47 +00:00