Commit graph

108 commits

Author SHA1 Message Date
Stig Bjørlykke
9ebac2bff6 g_free() is NULL safe, so we don't need check against it.
svn path=/trunk/; revision=27719
2009-03-13 22:21:22 +00:00
Guy Harris
5742ede54c Add an additional "title" attribute for UAT fields; that's what's
displayed to the user.

svn path=/trunk/; revision=27462
2009-02-16 04:10:06 +00:00
Bill Meier
a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Guy Harris
ec08463198 Fix previous fix.
svn path=/trunk/; revision=26774
2008-11-13 18:26:38 +00:00
Guy Harris
373f142bcd Fix some warnings.
svn path=/trunk/; revision=26773
2008-11-13 17:58:14 +00:00
Anders Broman
1b0b2bb4b6 From Paul Stath:
Dissector fails for OIDs with MacAddress in index.

svn path=/trunk/; revision=26746
2008-11-10 20:25:38 +00:00
Jaap Keuter
49fe94aa3f Fix for bug 2823
Do not pass automatic variables back into caller space.

svn path=/trunk/; revision=26426
2008-10-13 06:56:27 +00:00
Gerald Combs
aac8e0d91d Fix a spelling error pointed out by Noam Rathaus.
svn path=/trunk/; revision=26228
2008-09-18 17:19:15 +00:00
Bill Meier
d13bc6c7f4 Fix a (probably benign) case where it appears that && should be &
svn path=/trunk/; revision=26058
2008-08-22 14:28:03 +00:00
Luis Ontanon
42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Luis Ontanon
1cbce0623f It is useless in a Protocol Analyzer to avoid the user to have a password shorter than 8 chars.
svn path=/trunk/; revision=25043
2008-04-15 12:12:20 +00:00
Gerald Combs
f8e75ecd32 Make the SMI preference a little more verbose. In the COPS and SNMP
preferences, tell the user where they can change the SMI settings. In
the 802.11 preferences, fix a tooltip.

svn path=/trunk/; revision=24620
2008-03-13 22:17:11 +00:00
Stig Bjørlykke
aa9b4bf541 Add a const.
svn path=/trunk/; revision=24592
2008-03-09 14:20:28 +00:00
Stig Bjørlykke
9f412a5a8a Show VarBind OIDs and trap enterprise OID in info column.
Initialize pdu_type in dissect_snmp_PDUs() and param_tvb in
dissect_snmp_SnmpEngineID() to avoid potential crashes.

svn path=/trunk/; revision=24591
2008-03-09 13:58:58 +00:00
Stig Bjørlykke
3c6ecbf54b Corrected a typo: octestring -> octetstring.
svn path=/trunk/; revision=24589
2008-03-09 11:24:37 +00:00
Stig Bjørlykke
293e337c2b Display agent-addr as IPv4 address.
svn path=/trunk/; revision=24588
2008-03-09 10:54:55 +00:00
Stig Bjørlykke
fdc980e79d Added an option to uat_new() to set if configuration shall be saved in the
selected profile.

Don't save SMI Paths and SMI Modules in the profiles because reloading
currently doesn't work (bug 2309).

svn path=/trunk/; revision=24580
2008-03-06 22:13:24 +00:00
Stig Bjørlykke
b091b8d26c Rewrote to use g_strlcpy and g_strlcat.
svn path=/trunk/; revision=24525
2008-03-01 17:23:39 +00:00
Stig Bjørlykke
6b59696fd7 Added missing array for hf_snmp_big_counter_value.
svn path=/trunk/; revision=24516
2008-03-01 11:43:04 +00:00
Gerald Combs
2ed9d7d43e Make sure we don't dereference a NULL pointer. Fixes bug 2277.
svn path=/trunk/; revision=24467
2008-02-26 01:17:18 +00:00
Gerald Combs
1997308ac1 Handle unsigned SMI types. This should fix bug 2292.
svn path=/trunk/; revision=24457
2008-02-25 00:00:41 +00:00
Tomas Kukosa
e6e926d5f1 get rid of get_ber_last_created_item()
svn path=/trunk/; revision=24001
2008-01-03 13:07:17 +00:00
Stig Bjørlykke
3fe2bbe38f Fetch ObjectName and its relative oid_info before handling an eventual error
value, so we have valid values to put in the VarBind entry.  Include the error
note text as the label.

This should fix bug 2144.

svn path=/trunk/; revision=23962
2007-12-28 22:19:33 +00:00
Jörg Mayer
3d22aa561b asn1/*/Makefile.nmake were not part of the source package.
Spotted by Tomas Kukosa.

svn path=/trunk/; revision=23921
2007-12-19 10:02:50 +00:00
Tomas Kukosa
1e794fc494 ANSI TCAP regenerated and tested with -T -X asn2wrs options
asn2wrs has -T (tagged types support) and -X (new BER sttructures) default behavior
remove all -T and -X usage

svn path=/trunk/; revision=23823
2007-12-10 08:35:41 +00:00
Tomas Kukosa
0ba8976eb7 fix confusion in tag handling
svn path=/trunk/; revision=23702
2007-12-03 13:48:45 +00:00
Tomas Kukosa
7eb5048da9 fix tag handling inside snmp trap
svn path=/trunk/; revision=23508
2007-11-20 13:55:39 +00:00
Ronnie Sahlberg
b638f9490f dissect_ber_choice() returns the index of the choice, not the tag of the
choice


svn path=/trunk/; revision=23454
2007-11-15 09:49:55 +00:00
Gerald Combs
7d8064f548 Initialize var_list in dissect_smux(), so that we don't use previously
ep_freed() memory and abort.

svn path=/trunk/; revision=23436
2007-11-12 18:44:29 +00:00
Anders Broman
44470bc5f4 SNMP with option -X and -T
svn path=/trunk/; revision=23352
2007-11-04 16:47:30 +00:00
Bill Meier
b337d20d4c Include winposixtypes.h only if building with GNUTLS; Bug 1942: part 2 of 2 of fix.
asn1 template file plus generated .[hc] files;
Note that the generated files include changes which are a result of previous
changes to snmp.cnf (SVN #23252) and of other changes (eg: svn 21145).

svn path=/trunk/; revision=23302
2007-10-29 01:14:51 +00:00
Anders Broman
1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Jörg Mayer
d0e34ab8c3 Remove the remaining autogenereated -exp.cnf files
svn path=/trunk/; revision=23148
2007-10-11 17:56:24 +00:00
Jörg Mayer
0e0bed500d - Remove -e option if the generated -exp.cnf file isn't used.
- Add EXPORT_FILES to all files that still contain -e.

svn path=/trunk/; revision=23145
2007-10-11 05:27:27 +00:00
Jörg Mayer
61cde0d09e - Change Makefiles to include preinc
- Add missing new directories to asn1/Makefile.nmake

svn path=/trunk/; revision=23141
2007-10-10 19:03:24 +00:00
Jörg Mayer
24470fdfae More conversions and updates to existing Makefile stuff
svn path=/trunk/; revision=23127
2007-10-10 08:09:19 +00:00
Jörg Mayer
094e2a9a5f Get rid of the remains of NET-SNMP in the build process.
svn path=/trunk/; revision=22934
2007-09-24 06:59:40 +00:00
Stig Bjørlykke
8f19616ae8 Modified some ASN1 Makefiles to compile on unix.
Added some clean targets.
Removed asn1/x501 directory.

svn path=/trunk/; revision=22886
2007-09-17 11:53:33 +00:00
Jaap Keuter
2ae2f20203 Try to get the Windows buildbot going by avoiding namespace collision.
svn path=/trunk/; revision=22871
2007-09-14 06:51:07 +00:00
Luis Ontanon
168f8923e7 eliminate an anonymous enum.
svn path=/trunk/; revision=22868
2007-09-13 20:27:05 +00:00
Luis Ontanon
fb34ef1f2c Given the opportunity I check in the changes to snmp I got in this machine.
- Indexing (implied and not) is OK now, however indexes for related tables (AUGMENT, EXTEND, etc) are registered many times.


svn path=/trunk/; revision=22861
2007-09-13 16:49:51 +00:00
Luis Ontanon
d56f4f3a68 - turn some other TC from FT_BYTES to FT_STRING so that human-readable strings become readable by humans
- Add the EngineId decoding for the contextEngineId
- Add some expert info about malformed indexed oids


svn path=/trunk/; revision=22720
2007-08-28 23:55:49 +00:00
Luis Ontanon
8d3b80e57b Add some more expert info.
Restore engine-id dissection (a "victim" of decryption support)


svn path=/trunk/; revision=22719
2007-08-28 23:19:30 +00:00
Luis Ontanon
79ea56143c Fix non implicit oid key indexes. This starts to look good!
svn path=/trunk/; revision=22718
2007-08-28 21:27:54 +00:00
Luis Ontanon
dfbac00752 SNMP:
- As noted by Thomas Anders values are not added to the tree anymore. Move the calling of subdissectors to the end of the function, so that the value is added to the tree.
 - add port 8161 to be decoded as SNMP (hey, it's on IANA's services file!)
UAT:
 - do not have the uat reloaded.
OIDS:
 - do not complain if renaming an OID to an identical name



svn path=/trunk/; revision=22704
2007-08-28 15:18:32 +00:00
Tomas Kukosa
99a2ec1c9f fix bug in snmp.variable_oid subdissector calling and call them at the end of snmp dissector (so as snmp does not overwrite COL_INFO of subdissector)
svn path=/trunk/; revision=22701
2007-08-28 07:59:35 +00:00
Luis Ontanon
392fd3f689 - packet-snmp(-template).c
- reimplement the "snmp.variable_oid" dissector table
- oids.[ch]
   - get rid of keytype_implicit in oid_value_type_t we won't use it.
   - have the windows base path for mibs be consistent to where we've put the mibs
   - oid_get_from_encoded() and oid_get_from_string(): have the subids array being computed in a prior statement of where the side-effected argument is going to be used... worked on gcc, not on windows... I deserve "have daemons flying out of my nose" for that :-).


svn path=/trunk/; revision=22684
2007-08-27 17:05:11 +00:00
Luis Ontanon
00c5e48a17 get users of oid_resolv to use the new oids, rollout packet-snmp.c
svn path=/trunk/; revision=22651
2007-08-25 01:14:24 +00:00
Jörg Mayer
b312e64f6a get_ber_length doesn't need the tree argument, get rid of it.
Rebuild asn1 dissectors.

svn path=/trunk/; revision=22627
2007-08-24 07:12:04 +00:00
Luis Ontanon
4787c0ce6a this one was missing
svn path=/trunk/; revision=22620
2007-08-24 00:41:43 +00:00