Commit Graph

2284 Commits

Author SHA1 Message Date
Gilbert Ramirez 0b3c9ad5ce Revert 16279.
svn path=/trunk/; revision=16281
2005-10-21 13:11:04 +00:00
Gilbert Ramirez 385fb3eea2 From Greg Morris.
Expert data must perform a re-dissection to trigger the NCP dissector.
Change the call cf_retap_packets() to cf_redissect_packets().

svn path=/trunk/; revision=16279
2005-10-20 18:07:03 +00:00
Gilbert Ramirez c5db51da2d From Greg Morris, patch to allow proper search/filtering of
NCP conversations.

svn path=/trunk/; revision=16278
2005-10-20 18:04:11 +00:00
Gilbert Ramirez 05bdac4d3a From Greg Morris.
Adds NCP data to conversations and SRT.

svn path=/trunk/; revision=16269
2005-10-19 14:45:24 +00:00
Ulf Lamping fab07a94e0 don't show the "stopping currently running capture" dialog, as the packet list seems to have problems updating the screen, so some ugly artefacts remain on the screen.
after I've fixed a bug in the Win32 capture stop mechanism some days(?) before (which speeds up that stopping a lot), this dialog isn't really needed

svn path=/trunk/; revision=16257
2005-10-17 19:46:29 +00:00
Ulf Lamping fafdf68095 from Richard van der Hoff:
Attached is a patch which makes the console log level (warning/message/debug etc) a configurable preference. There's no gui for setting it, but since it's pretty much only going to be useful for developers, I'm sure you'll cope...
----
I've added a small comment to the file output that it has no dialog output

svn path=/trunk/; revision=16205
2005-10-12 21:26:27 +00:00
Ulf Lamping 9759510199 fix the link to the online users-guide
svn path=/trunk/; revision=16169
2005-10-09 00:01:13 +00:00
Ulf Lamping e01a43a9bf minor bugfix: while closing a capture file, update the packets statusbar *after* closing the file
svn path=/trunk/; revision=16150
2005-10-07 04:26:29 +00:00
Ulf Lamping 4443681a9e fix Ethereal so command line capture parameter will work with kilobytes (again)
remove Byte(s) from the dropdown list of filesizes, this doesn't make sense
replace 1000 with 1024, as all (modern?) file managers are based on 1024 bytes for a kilobyte (the old KB vs. KiB controversy)

svn path=/trunk/; revision=16149
2005-10-07 03:34:27 +00:00
Ulf Lamping bb5e5d6ce1 fix a packet_list_freeze / thaw pair, if a return comes in it's way
add a g_warning() call if an error occured while reading from capture file (while doing a live update), usually shouldn't happen but is difficult to debug *if* it happens
add a new log domain LOG_DOMAIN_MAIN and the standard log handler for it
add some (partly commented out) g_log() calls, useful for GUI sequence debugging

svn path=/trunk/; revision=16136
2005-10-06 00:55:21 +00:00
Ulf Lamping ec98957e13 fix 369: we must do some more GUI stuff in capture_update_started(),
as GUI state get's cleared while switching to the next "multiple file" because of a call to cf_close()

svn path=/trunk/; revision=16134
2005-10-05 23:56:36 +00:00
Ulf Lamping aa7a238a42 fix cant_load_winpcap_err() parameter
svn path=/trunk/; revision=16123
2005-10-05 06:05:35 +00:00
Guy Harris bfcbcfb4ea Add a "capture_errs.c" routine to cough up error messages for capture
problems, and use the first routine in it in multiple places.

Get rid of DISSECTOR_SUPPORT_INCLUDES - just add its contents to
ETHEREAL_COMMON_INCLUDES.

svn path=/trunk/; revision=16109
2005-10-04 06:25:01 +00:00
Guy Harris 62948d4d6b Properly terminate some value_string tables.
svn path=/trunk/; revision=16098
2005-10-03 22:26:32 +00:00
Guy Harris 7ff9b98428 Include "gui_stat_menu.h" to declare "register_stat_menu_item()".
Fix the type of "t38_analysis_init()" to match what
"register_stat_cmd_arg()" expects.

svn path=/trunk/; revision=16097
2005-10-03 22:23:04 +00:00
Ulf Lamping 8b696f70b8 Win32: don't crash if Capture/Start is clicked and WinPcap is not installed.
svn path=/trunk/; revision=16093
2005-10-03 20:04:06 +00:00
Ulf Lamping e0e8cb76a3 move the list down to the latest message while new messages rush in. We might want to have a checkbox or alike to en/disable this (as discussed for the Statistics) lately.
svn path=/trunk/; revision=16092
2005-10-03 19:37:17 +00:00
Ulf Lamping d24ce3d4ad major Win32 bugfix: when getting messages from the capture slave, only one message was processed every 200ms (UNIX handles this differently). If more messages were initiated from the slave, they stacked up. This slowed down the display update and slowed down stopping the capture as a lot of messages had to be processed before the close really finished ...
Now the timer callback function will call the pipe read function up to 5 times to avoid this, but won't do this more often to prevent "endless blocking".

svn path=/trunk/; revision=16091
2005-10-03 19:34:58 +00:00
Ulf Lamping 5851cd1694 minor bugfix: hide main widgets, if command line file couldn't be loaded
svn path=/trunk/; revision=16090
2005-10-03 19:11:57 +00:00
Luis Ontanon ee804fcb5a This one was missing from the checkin...
svn path=/trunk/; revision=16077
2005-10-03 11:36:24 +00:00
Anders Broman 15a08ae521 From Alejandro Vaquero:
New "Fax T38 Analysis" added to the "Statistics" menu to:

- Reassemble the HDLC t30 frames and dissect the header.
- Analyze the UPDTLPacket seq num for packet lost
- Stats of V.x Data:
    - Count the Data bytes
    - Duration
    - Wrong seq num
    - Max Burst of packet lost

svn path=/trunk/; revision=16073
2005-10-03 05:55:26 +00:00
Ulf Lamping 347398ee6f code cleanup: use the prefix packet_list_ for every function mentioned in packet_list.h
svn path=/trunk/; revision=16027
2005-09-27 21:51:08 +00:00
Ulf Lamping d415c719ae fix #322, 2nd try: don't pass NULL to gtk_tree_iter_free(), this seems to cause an assert on some GTK versions
svn path=/trunk/; revision=16011
2005-09-26 19:24:06 +00:00
Ulf Lamping d3d18948b5 compiler warning removed
svn path=/trunk/; revision=16006
2005-09-26 07:08:42 +00:00
Ulf Lamping fa1647d9a6 fix #322: packet detail window -> Protocol Preferences: tree not expanded
also removed global notebook value

svn path=/trunk/; revision=16004
2005-09-25 22:46:49 +00:00
Ulf Lamping e34467a28c disable gzip output compression for now, as it won't work in some cases (see source commment for details)
svn path=/trunk/; revision=15981
2005-09-23 18:50:07 +00:00
Ulf Lamping ba1c5f49d5 do freeze/thaw in packet_list_set_selected_row only, if the list must be moved. This avoids some screen flickering.
svn path=/trunk/; revision=15965
2005-09-22 21:14:39 +00:00
Luis Ontanon 35bd5bd854 Instead of checking if this is a new packet at every call to avoid recounting the packets at every rerun remove the tap listener of this stats tree.
fixes bug 474

svn path=/trunk/; revision=15960
2005-09-22 17:01:06 +00:00
Ulf Lamping a7a1077bb5 fix 467: when using -k command line option, convert interface name display string ("user_description: devicename" from Preferences) into device name. Hopefully this won't break the UNIX version.
svn path=/trunk/; revision=15943
2005-09-21 20:33:12 +00:00
Ulf Lamping 8efa36ee51 fix #465: replace all fprintf(stderr, ...) with g_warning(...) calls
svn path=/trunk/; revision=15942
2005-09-21 20:27:32 +00:00
Ulf Lamping a8ef1df32b fix/add doxygen comments
svn path=/trunk/; revision=15941
2005-09-21 20:11:55 +00:00
Ulf Lamping 512a4983c0 fix a copy/paste error inside of a comment
svn path=/trunk/; revision=15940
2005-09-21 20:08:32 +00:00
Gerald Combs 551b9bc61d Free our flow graph strings when we're done with them. Add a note about
flow graphs to the release notes, along with other stuff.

svn path=/trunk/; revision=15928
2005-09-21 14:20:43 +00:00
Gerald Combs ad99e218ca In an attempt to fix bug 396, switch over to GStrings. There still appears
to be a problem with formatting, but we don't crash any more.

svn path=/trunk/; revision=15923
2005-09-21 03:28:22 +00:00
Guy Harris 5e5c735525 Squelch a compiler warning (the argument might be used later).
Clean up indentation.

svn path=/trunk/; revision=15917
2005-09-21 01:34:04 +00:00
Ulf Lamping 831c54c4f5 add two new callbacks:
cf_cb_file_closing (called before closing a capture file) cf_cb_file_closed will be called afterwards, but both only if a file is really closed as cf_close is called more often ...

If we are closing large capture files (~20MB), the screen looks ugly while the file is closed. Change this so the screen will immediately go back to initial state and a dialog (without buttons) is shown that the file is currently closed. As the operation which takes most of the time to close the file is a single eth_clist_clear call, we can't use a progress bar here.

cf_cb_live_capture_stopping: called when the user wants to stop the capture (toolbar or menu clicked). At least on Win32, the time between this and the actual stop completed can be noticeable (1-2 seconds), so the user doesn't know if the button press did anything at all. Do something similar as above, show a dialog box without buttons to inform that the close is in progress.

svn path=/trunk/; revision=15891
2005-09-20 08:42:35 +00:00
Ulf Lamping f14ccc2f63 if the capture child pops up it's own console, title it as such
svn path=/trunk/; revision=15889
2005-09-20 08:18:41 +00:00
Guy Harris 2bccfcd3c4 Squelch a compiler warning.
svn path=/trunk/; revision=15888
2005-09-20 08:01:00 +00:00
Ulf Lamping d0bf73d13d the buildbot has a problem not knowing sa_family_t, define eth_sa_family_t and use it here (ok, this *is* a dirty hack)
don't know why the last commit compiled on my machine and not on the buildbot.

svn path=/trunk/; revision=15887
2005-09-20 02:10:48 +00:00
Ulf Lamping 81e9a70a96 enhance simple dialog: add the possibility to use no buttons at all and add a stop icon (similar to the splash_window, but with a slightly different layout and a way to choose the icon shown)
svn path=/trunk/; revision=15886
2005-09-20 01:53:38 +00:00
Ulf Lamping 692ae2c6cb fix #340: define the missing sockaddr_storage struct to be able to use Packet32.h even with WinPcap 3.1 and without the platform SDK
svn path=/trunk/; revision=15878
2005-09-19 20:59:50 +00:00
Guy Harris 52ebbfd1ab Mark some unused and unremovable arguments as unused.
svn path=/trunk/; revision=15846
2005-09-17 00:39:52 +00:00
Guy Harris ab2dca9114 Move some headers for stuff defined by a dissector into epan/dissectors
- and rename smb.h to packet-smb.h, as it's packet-smb.c's header file.

svn path=/trunk/; revision=15845
2005-09-17 00:31:15 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Gerald Combs 33cfe1725a Sort each conversation column numerically. Fix up whitespace.
It looks like we can't put "COPYCMD=/Y" in config.nmake and expect nmake
to do the right thing.  Add a comment, and set COPYCMD explicitly in the
root Makefile.nmake.  The rest of the occurrences of xcopy will have to
be taken care of at some point.

svn path=/trunk/; revision=15840
2005-09-16 16:25:53 +00:00
Ulf Lamping 5c03646d3d fixing the fix, it's time to go to bed ...
svn path=/trunk/; revision=15830
2005-09-16 00:02:31 +00:00
Ulf Lamping c8360f8b58 bugfix: don't crash (assert), if jumping to the first packet and packet_list is currently empty. Can happen at capture start.
svn path=/trunk/; revision=15829
2005-09-15 23:44:07 +00:00
Luis Ontanon fd05837613 leak fix
svn path=/trunk/; revision=15825
2005-09-15 19:26:05 +00:00
Ulf Lamping 84cf7ce767 added compression support for capture file output. The Save/As dialog now has a checkbox "Compress with gzip"
currently limited to Ethereal and all the variants of libpcap filetypes only.

We might want to add output compression support to the other tools as well (tethereal, mergecap, ...).

We might also want to add support for the other filetypes, but this is only possible if the filetype functions doesn't use special output operations like fseek.

One bug is still left: if the input and output filetypes while saving are the same, Ethereal currently optimizes this by simply copy the binary file instead of using wiretap (so it will be faster but it will ignore the compress setting). 

Don't know a good workaround for this, as I don't know a way to find out if the input file is currently compressed or not. One idea might be to use a heuristic on the filesize (compared to the packet size summmary). Another workaround I see is to remove this optimization, which is of course not the way I like to do it ...

svn path=/trunk/; revision=15804
2005-09-14 21:57:30 +00:00
Guy Harris f34e1a97c6 Have cf_retap_packets() take an argument that indicates whether to
generate columns; use cf_retap_packets instead of cf_redissect_packets()
when running taps (the general flow graph stat uses the Info column).

svn path=/trunk/; revision=15793
2005-09-14 08:59:41 +00:00