Commit Graph

2445 Commits

Author SHA1 Message Date
Anders Broman 8953da8975 rpm-setup: Get rid of unary operator expected warning.
Change-Id: Id43f39c4d662d69a292ac433ee48fab72256a156
Reviewed-on: https://code.wireshark.org/review/36168
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-02-24 07:42:27 +00:00
Gerald Combs ae1d569322 macos-setup: Update Gcrypt to 1.8.5.
This is required for WireGuard decryption.

Change-Id: I8d27ac198a8bac161c1675e87c3685c8d73c9246
Reviewed-on: https://code.wireshark.org/review/36129
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-02-18 23:54:26 +00:00
Peter Wu b926d24b96 RPM: fix missing qt5-linguist dependency, simplify installed packages
Remove unnecessary Qt5SVG build dependency. Do not install Qt4 qt-devel.
qt5-qtbase-devel is big, try to avoid pulling unnecessary deps.

Change-Id: Id289bea10ea89de6b7a3ea77996d861ff7354560
Reviewed-on: https://code.wireshark.org/review/36058
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-02-09 13:10:12 +00:00
Pascal Quantin a6614f995c Windows: upgrade Npcap to 0.9987
Change-Id: I6f1fcbb49b0002a4273fea449cd7346f4f0f1f58
Reviewed-on: https://code.wireshark.org/review/36031
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-02-04 21:05:27 +00:00
Dario Lombardo b5c629b62d tools: add lua to bsd-setup.sh.
Change-Id: I16a5aefa11f3c73ebdd69d972136980b630892e1
Reviewed-on: https://code.wireshark.org/review/36011
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-02-02 19:52:23 +00:00
Peter Wu e0ca87cfb1 tls: update list of known CT logs to 2019-12-23
The old URL was gone and the JSON scheme has changed, so update the
generator accordingly.

Change-Id: I52ae27c7fc7dc0100e8abaa7b95b1769a7413bc6
Reviewed-on: https://code.wireshark.org/review/35983
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-29 15:50:19 +00:00
Dario Lombardo a4cb1c3234 tools: add missing package to bsd-setup.
Change-Id: I80da65063bdabc99a3ca0dd722df710be34f1285
Reviewed-on: https://code.wireshark.org/review/35955
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-26 17:41:59 +00:00
Dario Lombardo ece8da5ea6 tools: fix check in bsd-setup.
Change-Id: I3ad5793d6aeca54fc84c82b226311c0e6777c1df
Reviewed-on: https://code.wireshark.org/review/35922
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-23 16:57:13 +00:00
Pascal Quantin 3442c76bc5 Windows: fix win32 libilbc package
Change-Id: Ia59556092bce0694ba74a25fb10fdca4ee540a57
Reviewed-on: https://code.wireshark.org/review/35893
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-21 21:21:13 +00:00
Dario Lombardo 23b91bdcd0 tools: minor changes in bsd-setup script.
Changes:
- use bash
- fix list checks

Change-Id: Idb933155035091974460d6957a9f6a223f6680dc
Reviewed-on: https://code.wireshark.org/review/35872
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-21 16:22:43 +00:00
Dario Lombardo 567991b8fb toold: add libilbc to bsd-setup.
Change-Id: I471b6936cef3df0ed9aaf6cc4421ac9fa47ad27c
Reviewed-on: https://code.wireshark.org/review/35873
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Jirka Novak <j.novak@netsystem.cz>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-20 21:50:54 +00:00
Jirka Novak 12a13a6926 RTP: decode iLBC payload
It is possible to decode iLBC payload. It uses libilbc library (https://github.com/TimothyGu/libilbc).

Bug: 16314
Change-Id: Id4cad7ae32305a0e94ef32beb24e07733d7f834e
Reviewed-on: https://code.wireshark.org/review/35686
Reviewed-by: João Valverde <j@v6e.pt>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-20 07:50:08 +00:00
Joerg Mayer fc0cca0911 macos-setup.sh: Add SpeexDSP setup and install
Change-Id: I3558d398970d919b8e12992ad4c97789aac79129
Reviewed-on: https://code.wireshark.org/review/35785
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-01-17 13:11:44 +00:00
Joakim Karlsson 5ffeabc8ce pfcp: Update to 3GPP TS 29.244 V16.2.0 part3
Change-Id: Id6c50426a586405db9f15bf16bc6b6d503b9848e
Reviewed-on: https://code.wireshark.org/review/35844
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-17 09:04:04 +00:00
Gerald Combs 6e7f08781d Gen-bugnote: Another encoding fix.
Change-Id: Icf9fe7cd392cce2dac8ba45854c9f4c00a80dd38
Reviewed-on: https://code.wireshark.org/review/35791
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-13 22:12:44 +00:00
Gerald Combs 216c4b2673 Gen-bugnote: Fix an encoding issue.
Change-Id: I0b193bc2dfa68de98d53b2443773d121801271e8
Reviewed-on: https://code.wireshark.org/review/35786
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-13 21:55:33 +00:00
Andre Luyer dbfb204f48 ber: display x509af.utcTime year in 4 digits
Because:
- the 2-digit year can only be in the range 1950..2049 according to
https://tools.ietf.org/html/rfc5280#section-4.1.2.5.1
- to avoid confusion, interpreting the year/month/day in a different order may
still represent a valid date.
- now both utcTime and GeneralizedTime are displayed in exactly the same way.
- some tools, like Perl, apply a different date range when converting 2-digit years.

In packet-ber.c two parameters are added to the function dissect_ber_UTCTime:
datestrptr: if not NULL return datetime string instead of adding to tree
or NULL when packet is malformed
tvblen: if not NULL return consumed packet bytes
Also the memory allocation for outstr is now done using the recommended method
as described in the README.developer document.

The calling function in x509af/x509sat uses this to prepend the century.
Added generated files.

Change-Id: I714c2e8e7f899211caaa1f4136ca0d27cb1aba4a
Reviewed-on: https://code.wireshark.org/review/35414
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-11 18:36:35 +00:00
Dario Lombardo 1e0fa912d4 AUTHORS: remove newlines.
The text is used in a Qt widget that handles the newlines itself.
The change makes the text appear with a better look in the about
dialog.

Change-Id: I1dc9fdd1f401384f4ce2d6c2c0764adaa810a654
Reviewed-on: https://code.wireshark.org/review/35662
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-07 16:52:34 +00:00
Gerald Combs 68a21c46f6 tools: Make compress-pngs a standard utility.
Switch from using `find` to find PNGs to simply accepting a list of
files as arguments.

Pass long arguments to some compressors.

Change-Id: I37884049026fea714d0dd30b08496744c6272379
Reviewed-on: https://code.wireshark.org/review/35646
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-05 01:52:01 +00:00
Gerald Combs 4d67f06108 make-manuf.py: Add "of" to the general terms list.
Add "of" to the list of general terms to remove when shortening.

Change-Id: Idbfea2d502a89d668ba2f170bf3450cfcbb91fe5
Reviewed-on: https://code.wireshark.org/review/35627
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-02 22:57:32 +00:00
Pascal Quantin f8aa0d5c02 LPP: upgrade dissector to 37.355 v15.0.0
3GPP decided to transfer the specification from 36.355 to 37.355 now that it
covers NR also. 37.355 v15.0.0 is equivalent to 36.355 v15.5.0.

Change-Id: I63aba21f55861ffd8a5c0adbd307b0453482baaa
Reviewed-on: https://code.wireshark.org/review/35613
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-31 17:20:30 +00:00
Gerald Combs 12550ef794 make-manuf.py: Fix a shortening error.
Handle cases where we might shorten a name (e.g. "ZAO") down to
nothing.

Change-Id: I5ecb9592d2ecd8225d0ed459ef16885214af5da4
Reviewed-on: https://code.wireshark.org/review/35584
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-29 18:30:16 +00:00
Gerald Combs f8808b8bd0 make-manuf.py: Handle more business types and other fixes.
Move our business types and general terms to a list and add more. Only
convert all upper case names to title case. Remove double quotes when
shortening names.

Change-Id: I31e9799986542270350b8c2436929f293de4e36c
Reviewed-on: https://code.wireshark.org/review/35577
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-29 02:42:06 +00:00
Jaap Keuter fe9ee2c9b9 netlink: update 802.11 related netlink messages Linux kernel v5.4
Taking the Linux kernel v5.4 uapi/linux/nl80211.h file:
- Sort the enums in the generation script according to the header file
  to make incremental maintenance easier.
- Add listing of all additional enums found in the header file.
- Update the generated netlink dissector code for 802.11.

Change-Id: I9d2dc09d58d8f252d4746e662e4133d47a7525c5
Reviewed-on: https://code.wireshark.org/review/35570
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-28 14:00:04 +00:00
Gerald Combs f0be7f27d8 Lemon: Squelch an unused parameter warning.
Fixes

... tools\lemon\lemon.c(1630,14): warning C4100: 'argc': unreferenced formal parameter ...

Change-Id: I5cddbbed025e246ddebe9189edbe6fbeea883a7d
Reviewed-on: https://code.wireshark.org/review/35522
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2019-12-26 10:32:37 +00:00
Dario Lombardo a20fcccda4 test: fix CI builds on linux.
Fixes:
- sdjournal is available on linux only.
- The systemd library has been put in the right group in debian-setup.

Change-Id: Ie022f29da4313d17d55201b6e7ea1ab2ae740e18
Reviewed-on: https://code.wireshark.org/review/35478
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-12-19 08:02:37 +00:00
Pascal Quantin 5d342b01e3 Windows: upgrade Npcap to 0.9986
Change-Id: I9ee3144416eb5564aa8974aeec0e33774edc7ed7
Reviewed-on: https://code.wireshark.org/review/35498
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-19 04:57:57 +00:00
Orgad Shaneh a9c79f0159 Uncrustify: Change line length to 100 chars
80 is too small.

Change-Id: I79a702449f72fcf66ae00e3508546389b022b900
Reviewed-on: https://code.wireshark.org/review/35484
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-18 09:34:25 +00:00
Gerald Combs c656affc34 Windows: Get rid of textify.ps1.
We used textify.ps1 to ensure that the .txt files in our Windows
installers would render properly in Notepad if the user double-clicked
on them. Newer versions of Windows have a more sane Notepad, so this is
no longer necessary:

https://devblogs.microsoft.com/commandline/extended-eol-in-notepad/

Copy COPYING, NEWS, README.md, and README.windows once.

Update README.windows.

Change-Id: Ibb8b749725f13e0e49d2a2abe04603d9f2be7960
Reviewed-on: https://code.wireshark.org/review/35470
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-17 21:52:54 +00:00
Gerald Combs 31414484d4 html2text: Skip generating footnotes for self-links.
Fixes the issue described at
https://www.wireshark.org/lists/wireshark-users/201912/msg00003.html

Change-Id: Ie3fd338ab1c6b216b05eeca002545868d3474bbb
Reviewed-on: https://code.wireshark.org/review/35426
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13 05:29:54 +00:00
Orgad Shaneh 64e5ae4b9d Uncrustify: Remove newline between for and brace
Change-Id: Ib89a159bbc7125b3afcfd72d1a218cb6d7c4af39
Reviewed-on: https://code.wireshark.org/review/35421
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13 05:28:47 +00:00
Orgad Shaneh 4649512b14 Uncrustify: Add spaces between else and braces
Change-Id: Ida8f8638ee226b99804293158e57f4be7a045be8
Reviewed-on: https://code.wireshark.org/review/35420
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13 05:28:01 +00:00
Pascal Quantin 23903925a1 Windows: update c-ares 1.15.0 package
Library was regenerated using g000e963fff596d817d03f366cd49b1fd2d6ec961
to have the proper version info.

Change-Id: I33f26d70ba1ea244aa467e5121b6fb586d8ebd8a
Reviewed-on: https://code.wireshark.org/review/35398
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-10 23:01:07 +00:00
Dario Lombardo b116405139 tools: use better operators in package scripts.
Change-Id: I1de75829de5f77fa5fe6c8715b1df76148937bc5
Reviewed-on: https://code.wireshark.org/review/35326
Reviewed-by: João Valverde <j@v6e.pt>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-12-06 13:32:47 +00:00
Dario Lombardo 469228a2e5 tools: fix check of shell variables in other setup scripts.
Change-Id: I7423f994b2295ef8336c37fd2e53418d363a4327
Reviewed-on: https://code.wireshark.org/review/35309
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-05 05:37:44 +00:00
Tamir Duberstein 9879850cc3 tools/debian-setup: correctly check the value of shell variables
These conditions would previously always evalute as true.

Change-Id: I7eb35f4eae417819090ba47103a266374847cbc5
Reviewed-on: https://code.wireshark.org/review/35305
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-12-04 19:15:07 +00:00
Gerald Combs 451a241e50 Add c-ares to the required library list.
Although c-ares support was techically optional, it was either on by
default or required in all of our packaging. Go ahead and require it
globally. C-ares is widely available and synchronous name resolution can
easily result in a horrific user experience.

Change-Id: Id67c797316ed6b8a0ab5052e55a43a1b9e2a2464
Reviewed-on: https://code.wireshark.org/review/35188
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-23 22:45:59 +00:00
Graham Bloice 6a0b558ac1 tools: remove obsolete VS2015 deployment file
The xml deployment file for VS2015 is obsolete as we haven't
used that version for some time and the newer choco packages
for VS2017 & 2019 are simpler and supported.

Change-Id: I5bd29144d7a2f01a6f56147a51fbc51ce891e83c
Reviewed-on: https://code.wireshark.org/review/35189
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2019-11-23 08:25:05 +00:00
Gerald Combs 45c6ba587d cppcheck: Exclude the doc directory.
Change-Id: I8d739c7cae7b1b5676cb04e7140d2dd81ebae1d3
Reviewed-on: https://code.wireshark.org/review/35168
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-21 04:55:44 +00:00
Joerg Mayer 0468ead898 macos-setup.sh: Sparkle setup fixes
- mkdir on macos 10.14.6 doesn't have a -f parameter
- set file ownership on tar extraction

Change-Id: I5d6341aba02b56abe0c1aa48e68c4c1b6af15379
Reviewed-on: https://code.wireshark.org/review/35115
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2019-11-18 11:26:29 +00:00
Dario Lombardo e624545b95 tools: fix echo in bsd-setup.
Change-Id: I17479e30ea70e7c9d080994330388b205bcf56e8
Reviewed-on: https://code.wireshark.org/review/35099
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-11-15 22:22:31 +00:00
Gerald Combs 02057200fd macOS: Add support for automatic updates using Sparkle.
Add support for automatic updates using the Sparkle framework. Add
FindSparkle.cmake and associated CMake plumbing. Add a public key and
other info to Info.plist.in. Add ui/macosx/sparkle_bridge.{h,m}, which
wraps the Sparkle API. Make code that's specific to WinSparkle
Windows-only.

Add Sparkle installation steps to the macos-setup scripts. Sparkle
prints a warning if your bundle is unsigned (which is the case during
development) so disable installing it by default.

Updating here takes a long time. We might be able to fix that by
shipping our DSYMs separately.

Change-Id: I6cc6671db5657dadc514bda6bf6e1c8bbc9468a5
Reviewed-on: https://code.wireshark.org/review/35090
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-15 18:39:04 +00:00
Dario Lombardo 5b661c586f tools: fix typos in generate-dissector.
Change-Id: Idd41f622aa1d14bc28dea38a7b8075a0934d619b
Reviewed-on: https://code.wireshark.org/review/35092
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-15 12:19:30 +00:00
Dario Lombardo 40d822ed61 tools: add automatic C skeleton dissector generator.
Generate a dissector based on doc/packet-PROTOABBREV.c.

Change-Id: I9233c1212acb30f7166ba91e39d98bc3fb123731
Reviewed-on: https://code.wireshark.org/review/35062
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-11-14 12:33:10 +00:00
Gerald Combs ba62446a6a cppcheck: Re-ignore asn1.
The asn1 directory was moved to epan/dissectors back in 2016.

Change-Id: Id22c99fa4e0cacf19ab0c5a6055e71abf94f6159
Reviewed-on: https://code.wireshark.org/review/35074
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-12 19:31:12 +00:00
Pascal Quantin 99effcada2 Windows: upgrade Npcap to 0.9984
While we are at it, let's deactivate by default the legacy loopback adapter installation

Change-Id: I4950e9dc6de8a2faeda272c03165a9f305862f6b
Reviewed-on: https://code.wireshark.org/review/35004
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-11-06 16:37:57 +00:00
Alexis La Goutte 86b0fe361c validate-clang-check (PD): Display also warning
Change-Id: Ie9f36ddbd95b5ebe94b9fc5e2a18ab12c1fb031f
Reviewed-on: https://code.wireshark.org/review/34903
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-11-02 11:46:47 +00:00
Pascal Quantin eb4e83d589 asn2wrs.py: fix parsing of integer unions with extension
When parsing the description
ExpectedActivityPeriod ::= INTEGER (1..30|40|50|60|80|100|120|150|180|181,...)
asn2wrs.py was generating some code where the has_extension flag was
wrongly set to false, leading to a decoding error.

Bug: 16145
Change-Id: I0d54994c0656f5b48f3dcd1864218c45a4ebc308
Reviewed-on: https://code.wireshark.org/review/34837
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-23 20:16:32 +00:00
Gerald Combs 4308ae3d47 tools: Add update-appdata.py
Add a script that fills in the <releases/> section of
wireshark.appdata.xml.

Change-Id: I643a8271f2bf1a5c2cd0be9930a6ca7c71935e42
Reviewed-on: https://code.wireshark.org/review/34824
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-22 17:09:41 +00:00
Guy Harris 9f374047ad We don't compile Qt, we just install a binary.
Change-Id: Ieeaa2b393775ae58782c0f2447b51fd068ffc185
Reviewed-on: https://code.wireshark.org/review/34763
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-10-13 04:26:36 +00:00