Michael Mann
c1e75c8ff3
Add a few filters to keep checkAPIs.pl happy.
...
svn path=/trunk/; revision=50893
2013-07-25 19:11:31 +00:00
Pascal Quantin
a92ee76d3e
Add a smarter UM analysis for MCCH/MTCH channels
...
svn path=/trunk/; revision=50891
2013-07-25 17:33:57 +00:00
Guy Harris
629ee9ed81
Fix some more bugs that caused compiler warnings.
...
svn path=/trunk/; revision=50887
2013-07-25 09:53:28 +00:00
Guy Harris
166eb4f53d
Get rid of an unused variable (set, but not used).
...
Get rid of extra arguments to expert_add_info_format_text() - as with
any other printf-like routine, if the format string has no % items, you
don't need to pass any additional arguments after that - you don't have
to tack on a BASE_NONE just for the lulz.
svn path=/trunk/; revision=50886
2013-07-25 09:03:02 +00:00
Michael Mann
3b3ff69af7
1. MASSIVE conversion of proto_tree_add_text to proto_tree_add_item with the help of (and a few passes of) convert_proto_tree_add_text.pl. Tried to keep display filter names in line with existing filters.
...
2. Cleaned up a bunch of proto_tree_add_xxx that could really be proto_tree_add_item so "useless" local variables could be removed.
3. Bugfixed a few bitmask (probably) copy/pasteos.
4. Better standardized whitespace and added modelines.
5. Still think some of the "object" filters (with BASE_NONE) could be removed in favor of a single filter (value_string) with object ID number (BASE_DEC), but I'll leave that to someone more familiar with the protocol.
svn path=/trunk/; revision=50884
2013-07-25 03:16:43 +00:00
Guy Harris
b524ecebd8
Don't cast away constness (except in cases where an API makes that
...
impossible).
svn path=/trunk/; revision=50856
2013-07-23 23:42:14 +00:00
Guy Harris
8e22ded7f8
Don't cast away constness.
...
svn path=/trunk/; revision=50855
2013-07-23 23:39:37 +00:00
Anders Broman
bed8ebd289
Register BSSAP+ by name.
...
svn path=/trunk/; revision=50851
2013-07-23 19:51:14 +00:00
Jakub Zawadzki
ac16425a1f
Free all cloned tvbs, not only first one.
...
svn path=/trunk/; revision=50844
2013-07-23 17:31:39 +00:00
Alexis La Goutte
3808dfc909
Add RFC6975 (Signaling Cryptographic Algorithm Understanding in DNS Security Extensions (DNSSEC)) support ( DAU, DHU and N3U OPT(ion))
...
svn path=/trunk/; revision=50840
2013-07-23 14:54:18 +00:00
Alexis La Goutte
4806972c5e
Fix warning found by fix-encoding-args
...
svn path=/trunk/; revision=50839
2013-07-23 14:54:09 +00:00
Alexis La Goutte
4aa7dab163
Enhance DNS Dissector Make DS ( Delegation Signature 43 ) filterable (Update RFC reference...)
...
svn path=/trunk/; revision=50838
2013-07-23 14:53:59 +00:00
Pascal Quantin
802e7bed77
Try to differentiate a non filled private_data (pointer set to NULL) from an enum with value = 0
...
svn path=/trunk/; revision=50837
2013-07-23 14:34:46 +00:00
Jörg Mayer
a74c3538fc
Fix for Bug 8960 - All mongodb query show as [Malformed Packet: MONGO]
...
proto_tree_add_item doesn't link to be called with FT_STRINGZ and length -1.
svn path=/trunk/; revision=50836
2013-07-23 13:38:39 +00:00
Alexis La Goutte
99d0205c93
From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8963
...
packet-scsi.c add asc/ascq code 2C:0A
Add ASC/ASCQ code 2C:0Ah "PARTITION OR COLLECTION CONTAINS USER OBJECTS" (SPC-4
svn path=/trunk/; revision=50828
2013-07-23 10:37:01 +00:00
Alexis La Goutte
d7095ca214
From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8965
...
Packet-scsi.c: fix subtree reference: ett_sense_osd_completed
The field hf_scsi_sns_osd_object_completed should be dissected under ett_sense_osd_completed instead of ett_sense_osd_not_initiated
(It was a copy-paste error in attachment 10967 from bug 8790)
svn path=/trunk/; revision=50827
2013-07-23 10:36:52 +00:00
Alexis La Goutte
ad78694e76
From Thomas ERSFELD (GSoC13) Prepare inclusion of Follow (TCP/UDP/SSL) feature in Qtshark
...
svn path=/trunk/; revision=50819
2013-07-23 08:56:30 +00:00
Guy Harris
efd6675cf6
collectd.data.severity is unsigned, so use proto_tree_add_uint64.
...
svn path=/trunk/; revision=50816
2013-07-23 05:19:44 +00:00
Anders Broman
2efa4fa8aa
From Andreas Bachmann:
...
allows to display multiple TLVs and the bug of logInterMessagePeriod is fixed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6126
svn path=/trunk/; revision=50815
2013-07-23 04:47:18 +00:00
Anders Broman
d91b6a1872
From Michal Labedzki:
...
HCI: Improve Class of Device dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948
svn path=/trunk/; revision=50814
2013-07-23 04:23:19 +00:00
Anders Broman
0bbb2cbbaf
From Michal Labedzki:
...
HCI: Add latest Assigned Numbers
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948
svn path=/trunk/; revision=50813
2013-07-23 04:15:23 +00:00
Anders Broman
46eabdf34d
From Michal Labedzki:
...
Add initial support for 3DS Profile.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948
svn path=/trunk/; revision=50812
2013-07-23 04:09:50 +00:00
Anders Broman
24a60b1d6c
From Michal Labedzki:
...
ATT: remove trailing white characters.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948
svn path=/trunk/; revision=50811
2013-07-23 03:56:38 +00:00
Anders Broman
511757f96c
From Michal Labedzki:
...
SDP: Add support for USB Forum ProductID names.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948
svn path=/trunk/; revision=50810
2013-07-23 03:54:04 +00:00
Anders Broman
93646d0981
From Javier Godoy:
...
Remove function osd_list_collection and update scsi_osd_svcaction.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8944#attach_11229
svn path=/trunk/; revision=50809
2013-07-23 03:49:44 +00:00
Guy Harris
9f66191681
The last argument to ptvcursor_add() is an encoding value; pass it one,
...
not a Boolean endianness value.
svn path=/trunk/; revision=50803
2013-07-22 23:01:30 +00:00
Jörg Mayer
545a84185e
Fix for
...
[ 28%] Building C object epan/CMakeFiles/epan.dir/dissectors/packet-diameter_3gpp.c.o
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-diameter_3gpp.c:232:90: error:
unused parameter 'tree' [-Werror,-Wunused-parameter]
...*tvb, packet_info *pinfo _U_, proto_tree *tree, void *data _U_)
^
1 error generated.
make[2]: *** [epan/CMakeFiles/epan.dir/dissectors/packet-diameter_3gpp.c.o] Error 1
svn path=/trunk/; revision=50799
2013-07-22 21:25:04 +00:00
Anders Broman
5e56e72953
Dissect S6 feature list.
...
svn path=/trunk/; revision=50796
2013-07-22 20:44:01 +00:00
Jakub Zawadzki
7ec1a78fe8
Abuse epan_t more: add callback to get interface name.
...
svn path=/trunk/; revision=50794
2013-07-22 19:38:38 +00:00
Guy Harris
b0a94d2b98
ASes can now be 32-bits; make the fields for them 32-bit so that you can
...
filter on all possible values of them.
Fixes bug 8959.
#BACKPORT 1.10, 1.8
svn path=/trunk/; revision=50791
2013-07-22 16:56:56 +00:00
Gerald Combs
ac22b33f4f
Mark a parameter unused.
...
svn path=/trunk/; revision=50790
2013-07-22 15:41:46 +00:00
Pascal Quantin
d5922fb41f
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8958 :
...
Highlight the right number of bytes for the PadN option data field
svn path=/trunk/; revision=50787
2013-07-22 14:19:04 +00:00
Pascal Quantin
4a84c0987e
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8957 :
...
remove a copy /paste error triggering a malformed exception when dissecting IPv4 DHCP Support Mode option
svn path=/trunk/; revision=50786
2013-07-22 13:00:41 +00:00
Jörg Mayer
fb5a3b90d1
Beginnings of Nintendo StreetProtocol support
...
svn path=/trunk/; revision=50783
2013-07-22 08:01:10 +00:00
Guy Harris
39518faa36
Squelch uninitialized variable warning.
...
svn path=/trunk/; revision=50782
2013-07-22 05:51:51 +00:00
Michael Mann
c131f9a074
Make items more filterable
...
Apply consistent whitespace.
Remove unnecessary string.h
svn path=/trunk/; revision=50780
2013-07-22 00:39:30 +00:00
Evan Huus
60e25a2080
Commit real kafka dissector this time.
...
svn path=/trunk/; revision=50779
2013-07-22 00:12:42 +00:00
Evan Huus
76abdbc1cc
Remove kafka dissector, accidentally committed symlink instead of real file.
...
svn path=/trunk/; revision=50778
2013-07-22 00:11:57 +00:00
Evan Huus
fb6c9c3387
Skeleton dissector for Apache Kafka's new protocol:
...
https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol
All the core request/response matching necessary to actually decode is done, and
helpers exist for the common Kafka data types. Now it just remains to fill in
the rest of the fields.
svn path=/trunk/; revision=50777
2013-07-22 00:08:25 +00:00
Jakub Zawadzki
c702e92121
Replace relative timestamp with reference frame number. Saves 16B per frame.
...
svn path=/trunk/; revision=50772
2013-07-21 23:07:33 +00:00
Evan Huus
9e1b53539a
Remove unused variable, fix comparison to use double-equals.
...
svn path=/trunk/; revision=50768
2013-07-21 21:10:13 +00:00
Anders Broman
df9bbb93a3
Interpretation of 3gpp_feature_list depends on Application Id.
...
svn path=/trunk/; revision=50766
2013-07-21 20:58:37 +00:00
Jakub Zawadzki
5d52e16734
Add helper function to epan_session which can be used to get absolute timestamp of given frame.
...
Remove ->prev_cap, for testing purpose also replace ->prev_dis with number of previously displayed frame number.
This patch reduce size of frame_data by 8B (amd64)
This is what (I think) was suggested by Guy in comment 13 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5821#c13 )
svn path=/trunk/; revision=50765
2013-07-21 20:48:30 +00:00
Michael Mann
f1866064c3
Turn modifier field into a value_string.
...
svn path=/trunk/; revision=50748
2013-07-21 01:35:45 +00:00
Evan Huus
6635f5ef67
Replace wmem slist (singly-linked) with wmem list (doubly-linked).
...
The overhead is not large, and it makes append much faster (O(1) vs O(n)).
It also will make a queue easy to add, which I need for a dissector I'm
writing...
svn path=/trunk/; revision=50744
2013-07-20 20:33:38 +00:00
Michael Mann
19726260f1
make proto_tree_add_text calls filterable through hfs and expert info.
...
svn path=/trunk/; revision=50743
2013-07-20 02:33:34 +00:00
Jeff Morriss
23d9a348a1
Fix the fuzz failure reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8941 :
...
Storing 2 different structures on the fd proto_data (with the same key) isn't
safe: use different keys to keep them separate. I do wonder if both are
really necessary...
This fix can be back-ported to trunk-1.10 but not trunk-1.8 (which lacks the
key identifier for proto_data's).
svn path=/trunk/; revision=50734
2013-07-18 23:34:48 +00:00
Michael Mann
a0606ce0b2
Cleanup hf_ variables so they can be identified as such. "Array" of hf items not necessary and prevents "check" scripts from fully working.
...
Made ett array local to proto_register_pcep.
All this for preparing to use convert_proto_tree_add_text (which I thought should be its own patch/revision)
svn path=/trunk/; revision=50733
2013-07-18 20:13:42 +00:00
Jeff Morriss
38c4986b4b
From Marko Hrastovec via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8926 :
...
A better fix for this bug (as compared to r50532): this version takes into
account the scaling factors.
svn path=/trunk/; revision=50732
2013-07-18 20:11:55 +00:00
Michael Mann
b5cf7e1601
Add fencing for COL_INFO (which was the intent of the dissector until I accidentally removed it in rev 50730.)
...
svn path=/trunk/; revision=50731
2013-07-18 18:19:03 +00:00