Commit graph

51 commits

Author SHA1 Message Date
Jeff Morriss
b4c2ed1b86 Remove some unnecessary includes: a lot of things don't need globals.h and register.h
svn path=/trunk/; revision=34017
2010-08-30 16:10:01 +00:00
Guy Harris
2a328da4ef Instead of using a Boolean for the search direction, use an enum, so
that you can tell from examination whether the search is forward or
backward.

Make the cf_find_packet routines take the direction as an explicit
argument, rather than, in the cases where you don't want to permanently
set the direction, saving the direction in the capture_file structure,
changing it, doing the search, and restoring the saved direction.  Give
more information in the Doxygen comments for those routines.

Add a cf_find_packet_dfilter_string() routine, which takes a filter
string rather than a compiled filter as an argument.  Replace
find_previous_next_frame_with_filter() with it.

Have cf_read_frame_r() and cf_read_frame() pop up the error dialog if
the read fails, rather than leaving that up to its caller.  That lets us
eliminate cf_read_error_message(), by swallowing its code into
cf_read_frame_r().  Add Doxygen comments for cf_read_frame_r() and
cf_read_frame().

Don't have find_packet() read the packet before calling the callback
routine; leave that up to the callback routine.

Add cf_find_packet_marked(), to find the next or previous marked packet,
and cf_find_packet_time_reference(), to find the next or previous time
reference packet.  Those routines do *not* need to read the packet data
to see if it matches; that lets them run much faster.

Clean up indentation.

svn path=/trunk/; revision=33791
2010-08-13 07:39:46 +00:00
Anders Broman
65ee4e797a From Jakub Zawadzki:
New functions: cf_read_frame_r, cf_read_frame

It's much easier to write:
 cf_read_frame (cf, fdata, &err, &err_info)
Than:
 wtap_seek_read (cf->wth, fdata->file_off, &cf->pseudo_header, cf->pd,
fdata->cap_len, &err, &err_info)

svn path=/trunk/; revision=32980
2010-05-26 19:11:23 +00:00
Stig Bjørlykke
e384c2d682 Remove alloc of unused variables in sctp_analyse_cb().
This fixes bug 4064.

Set sctp_set_filter() static.
Use correct prototype for create_list().

svn path=/trunk/; revision=30195
2009-09-29 13:04:47 +00:00
Michael Tüxen
db86fb6684 Out with debug output...
svn path=/trunk/; revision=29650
2009-09-01 10:29:17 +00:00
Michael Tüxen
66e738ede6 From Irene Ruengeler: Get rid of legacy gtk code...
svn path=/trunk/; revision=29649
2009-09-01 10:12:27 +00:00
Kovarththanan Rajaratnam
80a6d3fbcf Introduce epan_dissect_init()/epan_dissect_cleanup(). These are used to initialise/cleanup stack allocated 'edt' structures. This should speed up dissection since we avoid some malloc traffic.
svn path=/trunk/; revision=29404
2009-08-13 19:42:46 +00:00
Anders Broman
6c25896d84 From Kovarththanan Rajaratnam:
No letter-shortcuts in Telephony menu.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3678

svn path=/trunk/; revision=29028
2009-07-08 18:36:31 +00:00
Guy Harris
cf91fdf16b Have tap listeners specify whether the "packet" routine requires
a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645
2009-06-05 22:42:47 +00:00
Bill Meier
3224dc5d7a Remove unnecessary use of (deprecated) gtk_button_box_set_child_ipadding();
(In each case the arg values used [4,0] were the same as the defaults).
checkAPIs.pl: gtk_button_box_set_child_ipadding: 'W' --> 'E'

svn path=/trunk/; revision=28030
2009-04-10 18:31:01 +00:00
Bill Meier
27024a1d5a As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a numeric constant in various places;
svn path=/trunk/; revision=27800
2009-03-19 17:49:11 +00:00
Stig Bjørlykke
8608c8f1de Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26641
2008-10-31 09:53:56 +00:00
Bill Meier
d3fc3b6c3e Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_button_box_set_spacing()  ==> gtk_box_set_spacing()

svn path=/trunk/; revision=25673
2008-07-08 02:43:40 +00:00
Bill Meier
56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Ulf Lamping
644a474c95 sort #includes by directories
svn path=/trunk/; revision=24969
2008-04-13 03:32:24 +00:00
Ulf Lamping
d4ccf577a8 where it's not necessary, remove #include "compat_macros.h"
svn path=/trunk/; revision=24922
2008-04-12 01:02:59 +00:00
Ulf Lamping
8e58ec7085 last round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00
Ulf Lamping
c6d13dc2c8 replace WIDGET_SET_SIZE with gtk_widget_set_size_request
svn path=/trunk/; revision=24910
2008-04-11 20:31:05 +00:00
Ulf Lamping
ae5f841083 replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
Bill Meier
77b615b79f OBJECT_..._DATA --> g_object_..._data
svn path=/trunk/; revision=24896
2008-04-11 16:55:44 +00:00
Michael Tüxen
4306c7037d Include epan/strutil.h for gtk-1.2 builds.
svn path=/trunk/; revision=24513
2008-03-01 10:23:57 +00:00
Stig Bjørlykke
7deec480ff Next attempt to cleanup some string functions, including:
strncpy -> g_strlcpy, strncat -> g_strlcat

svn path=/trunk/; revision=24504
2008-02-29 13:33:37 +00:00
Stig Bjørlykke
10a8f59e03 Rewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24239
2008-02-01 01:07:58 +00:00
Michael Tüxen
ab125d0d43 From Irene Ruengeler: Fix TSN handling in graphs.
svn path=/trunk/; revision=21894
2007-05-22 21:16:30 +00:00
Michael Tüxen
7e8098c520 A fix from Irene Ruengeler to keep assocs selected when
setting/applying filters.
Remove some warnings.


svn path=/trunk/; revision=20759
2007-02-09 21:05:43 +00:00
Anders Broman
1f99d6fc2d Fix a typo (double ;;).
svn path=/trunk/; revision=20610
2007-01-29 21:26:08 +00:00
Michael Tüxen
ed692e1c8a Improve the handling of INIT/ABORT mesage pairs.
svn path=/trunk/; revision=20608
2007-01-29 20:44:59 +00:00
Michael Tüxen
bb773be0ef Fix handling when both endpoints use the same port number.
svn path=/trunk/; revision=20570
2007-01-26 17:27:32 +00:00
Jörg Mayer
80f82b9203 Warning fixes (void) instead of (), no newline at end of file.
svn path=/trunk/; revision=19845
2006-11-07 07:47:49 +00:00
Michael Tüxen
45b5d20416 From Irene Ruengeler: Add context menu for SCTP analysis.
svn path=/trunk/; revision=18576
2006-06-26 13:18:37 +00:00
Ronnie Sahlberg
89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Michael Tüxen
501a66109d From Irene: Make buttons unselecable when nothing would happen.
svn path=/trunk/; revision=17803
2006-04-04 09:04:08 +00:00
Guy Harris
f34e1a97c6 Have cf_retap_packets() take an argument that indicates whether to
generate columns; use cf_retap_packets instead of cf_redissect_packets()
when running taps (the general flow graph stat uses the Info column).

svn path=/trunk/; revision=15793
2005-09-14 08:59:41 +00:00
Guy Harris
13e0b409cf As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so
that it doesn't appear to be part of GTK+.

svn path=/trunk/; revision=15501
2005-08-21 19:24:11 +00:00
Guy Harris
a0e68da918 Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".

Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.

Get rid of headers not declaring any functions not being used in the
module.

svn path=/trunk/; revision=15493
2005-08-21 09:48:27 +00:00
Jörg Mayer
0edcc8920e - Declare some functions static
- Add plugins_dlg.h
- Include .h files in their respective .c files
- Include .h and remove extern declarations in .c files
- set eol-style and keywords on gui_utils.[hc]

svn path=/trunk/; revision=15471
2005-08-20 14:02:00 +00:00
Ulf Lamping
eafbbbcabb renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir
svn path=/trunk/; revision=15465
2005-08-20 12:09:48 +00:00
Guy Harris
b2807e2ab6 Move the APIs for registering and processing "-z" command-line arguments
and "Statistics" menu items into "stat.h" and "stat.c", to separate them
from the core tapping APIs.  A tap could conceivably not register as a
"-z" command-line argument or "Statistics" menu item, and a stat could
conceivably not be implemented as a tap, and dissectors that implement
tapping points don't need the UI-related stuff from "stat.h", they just
want the tap-related stuff in <epan/tap.h>.

svn path=/trunk/; revision=15427
2005-08-19 09:29:41 +00:00
Ulf Lamping
149786d563 replace malloc and alike calls by their GLib pendants -> g_malloc
svn path=/trunk/; revision=15232
2005-08-05 23:58:58 +00:00
Jörg Mayer
f5b39c3ef9 Warning fixes
svn path=/trunk/; revision=15125
2005-07-28 07:51:52 +00:00
Michael Tüxen
1962844317 From Irene Ruengeler: Handle multiple gap reports correctly and use correct name of a button.
svn path=/trunk/; revision=14908
2005-07-12 21:04:05 +00:00
Michael Tüxen
8a852887ae Editorial stuff.
svn path=/trunk/; revision=14256
2005-05-01 13:55:09 +00:00
Ulf Lamping
e571cbfa9d add 12 new toolbar/menu icons
add two toolbar toggle buttons
add icons to various menu items

create new Statistics telephony group and put telephony and alike protocols in it

svn path=/trunk/; revision=14098
2005-04-16 10:53:09 +00:00
Ronnie Sahlberg
df98534657 From Didier:
optimization for COLUMNS to make ethereal faster when filtering

optimization to make the slow find_protocol_by_id() fast.
(idea from Didier, implementation modified by me to be less intrusive)



svn path=/trunk/; revision=14026
2005-04-07 12:00:03 +00:00
Michael Tüxen
ab64f95039 From Irene Ruengeler: Bugfixes and support of chunk statistics per end point.
Some cleanups of the code.

svn path=/trunk/; revision=13858
2005-03-22 10:25:07 +00:00
Jörg Mayer
8783c27b4b Warning fix: function declaration isn’t a prototype
svn path=/trunk/; revision=13693
2005-03-10 14:04:35 +00:00
Guy Harris
611508684e retap_packets() was renamed cf_retap_packets().
svn path=/trunk/; revision=13297
2005-02-05 04:37:36 +00:00
Michael Tüxen
b608b5e406 Update to versions compiling on and working on Windows and Unix.
svn path=/trunk/; revision=13295
2005-02-04 22:45:15 +00:00
Guy Harris
bebb2b7705 Get rid of C++/C99-style comments - not all C compilers accept them.
Fix some indentation.

svn path=/trunk/; revision=12710
2004-12-10 11:20:48 +00:00
Guy Harris
9e8d653b21 Set svn:eol-style to native to keep line endings canonicalized.
Set svn:keywords to Id to expand RCS IDs.

svn path=/trunk/; revision=11931
2004-09-07 20:07:08 +00:00