Commit graph

180 commits

Author SHA1 Message Date
Jeff Morriss
b4c2ed1b86 Remove some unnecessary includes: a lot of things don't need globals.h and register.h
svn path=/trunk/; revision=34017
2010-08-30 16:10:01 +00:00
Bill Meier
dac7978557 Minor cleanup of rtp graph:
- Display current value in combo boxes (pixels_per_tick, etc) to always
   match actual values being used to create graph;
 - yscale combo box entries: 
    show values >= 1 sec as sec (not s000 ms);
 - Determine max yscale label width properly as the largest of the
   top or middle label lengths;
 - Cleanup some indentation.

svn path=/trunk/; revision=33855
2010-08-19 22:04:37 +00:00
Guy Harris
2a328da4ef Instead of using a Boolean for the search direction, use an enum, so
that you can tell from examination whether the search is forward or
backward.

Make the cf_find_packet routines take the direction as an explicit
argument, rather than, in the cases where you don't want to permanently
set the direction, saving the direction in the capture_file structure,
changing it, doing the search, and restoring the saved direction.  Give
more information in the Doxygen comments for those routines.

Add a cf_find_packet_dfilter_string() routine, which takes a filter
string rather than a compiled filter as an argument.  Replace
find_previous_next_frame_with_filter() with it.

Have cf_read_frame_r() and cf_read_frame() pop up the error dialog if
the read fails, rather than leaving that up to its caller.  That lets us
eliminate cf_read_error_message(), by swallowing its code into
cf_read_frame_r().  Add Doxygen comments for cf_read_frame_r() and
cf_read_frame().

Don't have find_packet() read the packet before calling the callback
routine; leave that up to the callback routine.

Add cf_find_packet_marked(), to find the next or previous marked packet,
and cf_find_packet_time_reference(), to find the next or previous time
reference packet.  Those routines do *not* need to read the packet data
to see if it matches; that lets them run much faster.

Clean up indentation.

svn path=/trunk/; revision=33791
2010-08-13 07:39:46 +00:00
Bill Meier
99c52f1c94 (Trivial): Whitespace cleanup.
svn path=/trunk/; revision=33618
2010-07-22 20:53:24 +00:00
Gerald Combs
96558700c1 UTF-8-ize a bunch more arrows. If IE6 on XP can render them then they
*must* be safe to use, right?

svn path=/trunk/; revision=33326
2010-06-25 22:09:34 +00:00
Anders Broman
65ee4e797a From Jakub Zawadzki:
New functions: cf_read_frame_r, cf_read_frame

It's much easier to write:
 cf_read_frame (cf, fdata, &err, &err_info)
Than:
 wtap_seek_read (cf->wth, fdata->file_off, &cf->pseudo_header, cf->pd,
fdata->cap_len, &err, &err_info)

svn path=/trunk/; revision=32980
2010-05-26 19:11:23 +00:00
Bill Meier
7397bb0a74 Fix various gcc -Wshadow warnings.
svn path=/trunk/; revision=31737
2010-01-29 23:17:32 +00:00
Jaap Keuter
ac7dd7b085 Add save option to RTP graph window.
svn path=/trunk/; revision=31363
2009-12-24 21:28:38 +00:00
Anders Broman
17bce3616b From Andreas Heise:
Fix different duration format beteen directions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4327

svn path=/trunk/; revision=31254
2009-12-13 10:05:35 +00:00
Jaap Keuter
fc5cc7a7fb Fix for bug 3801:
Following r28546 and r30953 this adjusts the timescale in the RTP Graph Analysis, restoring its operation.

svn path=/trunk/; revision=31240
2009-12-11 08:53:19 +00:00
Anders Broman
141e1fb3b3 From Andreas Heise:
fix missing display of max skew in reversed d.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4320

svn path=/trunk/; revision=31235
2009-12-11 06:44:47 +00:00
Anders Broman
b16fab6435 From Alejandro Vaquero:
Add RTP player to "RTP Stream Analysis" and makeover of VoIP flow
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4240

svn path=/trunk/; revision=30967
2009-11-15 20:13:08 +00:00
Jaap Keuter
943bd2c32d Fix for bug 4120:
Calculate amount of silence samples in samples/ms i.s.o. samples/s

svn path=/trunk/; revision=30953
2009-11-13 19:51:51 +00:00
Anders Broman
9d45f50695 Option_menu -> combo_box
svn path=/trunk/; revision=30543
2009-10-12 15:27:37 +00:00
Anders Broman
4bd41da307 Remove code guarded by #ifdef USE_CONVERSATION_GRAPH
as this eems to newer have been fully implemented and the old clist is replaced now.

svn path=/trunk/; revision=30425
2009-10-09 09:56:16 +00:00
Bill Meier
1bc9f19f05 Add #include <stdio.h> in a few more places for Solaris.
svn path=/trunk/; revision=29577
2009-08-27 03:54:57 +00:00
Kovarththanan Rajaratnam
27f7d88c84 Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere.
svn path=/trunk/; revision=29490
2009-08-21 11:03:30 +00:00
Kovarththanan Rajaratnam
80a6d3fbcf Introduce epan_dissect_init()/epan_dissect_cleanup(). These are used to initialise/cleanup stack allocated 'edt' structures. This should speed up dissection since we avoid some malloc traffic.
svn path=/trunk/; revision=29404
2009-08-13 19:42:46 +00:00
Kovarththanan Rajaratnam
3512e485ca Add PNODE_FINFO. We've been using PITEM_FINFO on proto_node's. This works because proto_item is typedefed to proto_node. We shouldn't rely on this since this is an implementation detail.
svn path=/trunk/; revision=29354
2009-08-09 17:33:23 +00:00
Anders Broman
6c25896d84 From Kovarththanan Rajaratnam:
No letter-shortcuts in Telephony menu.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3678

svn path=/trunk/; revision=29028
2009-07-08 18:36:31 +00:00
Gerald Combs
e0ebc32195 Updates to create_tempfile:
- Use g_get_tmp_dir, just like get_tempfile_path.
  - Don't make the caller worry about the path buffer length.

svn path=/trunk/; revision=28915
2009-07-01 23:36:51 +00:00
Anders Broman
d2099a52a2 Add time stamp to the list.
svn path=/trunk/; revision=28649
2009-06-06 17:08:01 +00:00
Guy Harris
cf91fdf16b Have tap listeners specify whether the "packet" routine requires
a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645
2009-06-05 22:42:47 +00:00
Anders Broman
75af067043 Calculate skew and clock drift, make it possible to copy the label.
svn path=/trunk/; revision=28606
2009-06-02 19:05:20 +00:00
Stig Bjørlykke
97f65cd644 Fix a printf to make the label correct.
svn path=/trunk/; revision=28569
2009-06-01 17:52:14 +00:00
Anders Broman
ae260ddd2b Show max and mean Jitter.
svn path=/trunk/; revision=28560
2009-06-01 16:44:05 +00:00
Bill Meier
134fd85fc6 Fix a few more memory leaks & do a few other minor changes
svn path=/trunk/; revision=28553
2009-06-01 12:32:02 +00:00
Anders Broman
2b962a1134 Copy the changes from:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=28534

User: wmeier
Date: 2009/05/30 11:07 AM

Log:
 Fix the save_as functions so they work (including work-around  when save-as raises an alert box). 
 Also:
 - save_as_csv: don't skip over first line of output;
 - save_as_csv: Fix some (probably significant) memory leaks
   associated with the use of gtk_tree_view;
 - Prevent tendency for IAX2 stream window and graph window 
   to get lost behind other windows;
 - Minor save_as dialog window reformatting;
 - Misc source code cleanup & reformatting.

To RTP Analysis.

svn path=/trunk/; revision=28551
2009-05-31 19:55:30 +00:00
Anders Broman
5ed6a83dff Calculate jitter and delta in ms.
svn path=/trunk/; revision=28546
2009-05-31 17:06:04 +00:00
Anders Broman
25329d1427 Don't skipp the first entry.
svn path=/trunk/; revision=28393
2009-05-18 16:43:48 +00:00
Guy Harris
54c159cb41 Turn on -Wshorten-64-to-32 by default, and fix some issues that turned
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats).  Hopefully this will catch at least
some P64 issues on UN*X.

svn path=/trunk/; revision=28108
2009-04-21 16:57:52 +00:00
Bill Meier
3224dc5d7a Remove unnecessary use of (deprecated) gtk_button_box_set_child_ipadding();
(In each case the arg values used [4,0] were the same as the defaults).
checkAPIs.pl: gtk_button_box_set_child_ipadding: 'W' --> 'E'

svn path=/trunk/; revision=28030
2009-04-10 18:31:01 +00:00
Bill Meier
27024a1d5a As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a numeric constant in various places;
svn path=/trunk/; revision=27800
2009-03-19 17:49:11 +00:00
Stig Bjørlykke
18c5caa3d4 From Jakub Zawadzki:
Use non-formatting functions when appropriate.

svn path=/trunk/; revision=27709
2009-03-12 07:56:42 +00:00
Anders Broman
4175480de6 Get rid of a Clist and move the functon to display floats with two decimals to gui_utils.
svn path=/trunk/; revision=27621
2009-03-06 17:16:56 +00:00
Anders Broman
2c1c572d08 Code cleanup.
svn path=/trunk/; revision=27576
2009-03-02 07:31:06 +00:00
Anders Broman
25e8795a06 gtk_list_store_insert_with_values() requires GTK+ 2.6 or later.
From Jakub Zawadzki further optimisations.

svn path=/trunk/; revision=27555
2009-02-26 20:55:19 +00:00
Anders Broman
0d0d6c6621 Another small performance boost.
svn path=/trunk/; revision=27554
2009-02-26 16:46:00 +00:00
Stephen Fisher
a0b1dcb2a1 Fix (private) bug #3278: When first opening the RTP stream analysis window,
it  hangs for a while before allowing the user to interact with the window.

Fixed by setting columns to fixed height and fixed width.

Also: Don't display columns we were hiding in the CList version of this
window.


svn path=/trunk/; revision=27551
2009-02-26 07:55:09 +00:00
Anders Broman
52d4a85e21 Use gtk_file_chooser_dialog_new().
svn path=/trunk/; revision=27509
2009-02-22 15:23:06 +00:00
Stephen Fisher
01c821cd67 Mark two unused variables
svn path=/trunk/; revision=27490
2009-02-20 17:53:39 +00:00
Anders Broman
590bc1122c Replace the clists with gtk_list_store
Should fix bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3246

svn path=/trunk/; revision=27489
2009-02-20 17:13:44 +00:00
Gerald Combs
3bb0df12f5 From babi: Fix three overflows (bugs 3150 and 3151).
From me: Use a #define for the RTP analysis field name lengths.

svn path=/trunk/; revision=27064
2008-12-20 00:07:21 +00:00
Tomas Kukosa
608e51ef4c explicit cast to avoid warning which stops Windows build
svn path=/trunk/; revision=26737
2008-11-10 13:22:18 +00:00
Guy Harris
aa81efc51c Use the standard I/O routines to write out audio files, rather than
doing 1-byte, 2-byte, and 4-byte read() and write() calls.

svn path=/trunk/; revision=26735
2008-11-08 23:36:12 +00:00
Stig Bjørlykke
8608c8f1de Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26641
2008-10-31 09:53:56 +00:00
Jaap Keuter
d6df3a1f1c Fix for bug 2780:
Correct reverse direction payload save.

svn path=/trunk/; revision=25961
2008-08-08 19:57:50 +00:00
Jeff Morriss
dd6a15e1c7 Don't put (non-extern'd) prototypes for protect_thread_critical_region() and
unprotect_thread_critical_region() in every module in gtk/: instead have those
modules include main.h (which has the properly extern'd prototype).

This should fix the link error on HP-UX described in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2702

svn path=/trunk/; revision=25933
2008-08-05 17:33:14 +00:00
Bill Meier
d3fc3b6c3e Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_button_box_set_spacing()  ==> gtk_box_set_spacing()

svn path=/trunk/; revision=25673
2008-07-08 02:43:40 +00:00
Bill Meier
56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00