osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
33306 commits 23 branches 0 tags 1.3 GiB
Commit graph

52 commits

Author SHA1 Message Date
Bill Meier
2b0f6a63f1 Define some fcns & vars as static; 
Rename g_capture_in_progress to gbl_capture_in_progress (capture_if_dlg.c)
Do some whitespace cleanup.

svn path=/trunk/; revision=34490
 2010-10-12 17:39:44 +00:00
Bill Meier
9451aa90a7 (Trivial/Cosmetic) Fix signatures of some signal callback functions; 
Also:Add some missing G_CALLBACKs (even in commented out code)

svn path=/trunk/; revision=33890
 2010-08-23 15:58:48 +00:00
Bill Meier
6cdec04e59 (Minor) Cleanup some "event callback" function declarations/definitions: 
- Add missing 'user_data' arg as needed;
- Use gboolean rather than int as the type of the value returned.
Also: Cleanup whitespace & reformat long lines in a few cases.

svn path=/trunk/; revision=33679
 2010-07-30 12:41:56 +00:00
Stig Bjørlykke
060001dc95 We have no first and second block when dumping bits view, so no adjustments. 
svn path=/trunk/; revision=33433
 2010-07-05 10:53:48 +00:00
Stig Bjørlykke
591ef8ab4a Highlight correct number of bytes when highlighted hex dump ends at the end 
of the first block.

svn path=/trunk/; revision=33283
 2010-06-22 08:49:12 +00:00
Bill Meier
d5140df7e1 Rename some variables; At least one ('end') seemed to confuse the Windows debugger; 
Also: Udate some coments.

svn path=/trunk/; revision=33213
 2010-06-13 14:31:11 +00:00
Anders Broman
e87ddd657c From Jakub Zawadzki: 
Fix copy&paste error + add support for proto_tree_add_bits API
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413

svn path=/trunk/; revision=32634
 2010-05-02 15:37:23 +00:00
Anders Broman
c705b3bc88 From Jakub Zawadzki: 
Add support for multi byte entries.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413

svn path=/trunk/; revision=32525
 2010-04-20 17:32:12 +00:00
Anders Broman
132c2a43ea From Jakub Zawadzki: 
Improve bitview display

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413

svn path=/trunk/; revision=32522
 2010-04-20 07:47:33 +00:00
Jeff Morriss
50469a8fd6 Include (horizontal) tabs in the Copy (Printable Text Only) output. This 
fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2921 .

svn path=/trunk/; revision=32454
 2010-04-13 17:56:59 +00:00
Martin Mathieson
c40e31f2de Initialise a couple of variables to prevent gcc warnings. 
svn path=/trunk/; revision=32267
 2010-03-22 18:09:33 +00:00
Bill Meier
a9a997f73b Fix a typo.... 
svn path=/trunk/; revision=31787
 2010-02-04 15:03:30 +00:00
Bill Meier
16b04d41e0 Fix a crash which occurs if a progress bar is displayed while generating a hex bytes pane. 
svn path=/trunk/; revision=31786
 2010-02-04 14:41:22 +00:00
Bill Meier
538dd47d5d Fix various gcc -Wshadow warnings. 
svn path=/trunk/; revision=31731
 2010-01-29 19:09:01 +00:00
Anders Broman
98f7fe5f9a From Jakub Zawadzki: 
- Create only one marker in packet_hex_print_common.
- Set start & end values in good keys.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4403

svn path=/trunk/; revision=31669
 2010-01-25 20:58:24 +00:00
Bill Meier
e0064797fb Use more unique names for certain enum constants. 
(enum constant names are part of the global name space).
(Fixes at least one gcc -Wshadow warning).

svn path=/trunk/; revision=31572
 2010-01-19 19:37:03 +00:00
Guy Harris
982cfc5410 From Jakub Zawadzki: get rid of redundant BYTE_VIEW_WIDTH and 
BIT_VIEW_WIDTH definitions in favor of BYTES_PER_LINE and BITS_PER_LINE.

While we're at it, move the definition of BYTE_VIEW_SEP down among the
other definitions.

svn path=/trunk/; revision=31570
 2010-01-19 19:18:51 +00:00
Guy Harris
4b8554fa3c From Jakub Zawadzki: fix the return type of hex_view_get_byte(). 
svn path=/trunk/; revision=31569
 2010-01-19 19:12:55 +00:00
Guy Harris
118cd1fbb5 Clean up indentation. 
svn path=/trunk/; revision=31459
 2010-01-07 02:24:06 +00:00
Gerald Combs
01c31f7d2a Make each level color and the light gradient color in the statusbar match. 
svn path=/trunk/; revision=30836
 2009-11-05 19:45:51 +00:00
Stig Bjørlykke
58c0abee94 Simplified printing of bits in packet bytes view. 
svn path=/trunk/; revision=30835
 2009-11-05 15:40:44 +00:00
Stig Bjørlykke
146ce8f258 Restore text_end_1 vs. text_start_2 handling. 
svn path=/trunk/; revision=30833
 2009-11-05 10:26:43 +00:00
Stig Bjørlykke
7c5f1b80ac Introduce packet bytes bit view. 
svn path=/trunk/; revision=30832
 2009-11-05 10:16:49 +00:00
Stig Bjørlykke
d0ad8bcdcf Select the previous byte in the packet bytes hex view when clicking in 
the column just behind the first half and the last half.

This behavior is more user friendly.

svn path=/trunk/; revision=30831
 2009-11-05 10:11:45 +00:00
Gerald Combs
d54eea534e Add a convenience routine to convert pixbuf data generated by 
gdk-pixbuf-csource to a GtkImage. Use it to load the expert indicator
images. Add prettier indicator images. The "chat" indicator is more blue
in order to differentiate it from the "none" indicator; make the chat
text background more blue to match.

svn path=/trunk/; revision=30825
 2009-11-04 21:16:38 +00:00
Stig Bjørlykke
68778b862e Added check for valid pointers (to avoid warnings). 
svn path=/trunk/; revision=30234
 2009-10-01 14:41:34 +00:00
Anders Broman
3d1e65e2a0 Typo 
svn path=/trunk/; revision=29647
 2009-09-01 07:29:16 +00:00
Anders Broman
b787bbb334 Don't bother with a progress dialog for small Hex windows. 
svn path=/trunk/; revision=29646
 2009-09-01 05:19:24 +00:00
Anders Broman
5e4e5755a8 From Didier Gautheron: 
expert info clean up,
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3948

svn path=/trunk/; revision=29566
 2009-08-26 17:26:26 +00:00
Kovarththanan Rajaratnam
27f7d88c84 Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere. 
svn path=/trunk/; revision=29490
 2009-08-21 11:03:30 +00:00
Kovarththanan Rajaratnam
3512e485ca Add PNODE_FINFO. We've been using PITEM_FINFO on proto_node's. This works because proto_item is typedefed to proto_node. We shouldn't rely on this since this is an implementation detail. 
svn path=/trunk/; revision=29354
 2009-08-09 17:33:23 +00:00
Anders Broman
94e0026e19 From Kovarththanan Rajaratnam: 
Enable popup menu in packet list view.

svn path=/trunk/; revision=29223
 2009-07-28 20:46:23 +00:00
Stig Bjørlykke
27572c22f4 From Kovarththanan Rajaratnam via bug 3702: 
This patch optimizes the data source name processing in add_new_data_source()
by delaying it. We now simply store the constant string and lazily compute the
name when needed. This gives a performance boost because we only need the name
if we have multiple data sources.

svn path=/trunk/; revision=29066
 2009-07-12 10:19:13 +00:00
Stephen Fisher
e6d0686f7b Introduce experimental new feature: GTK2 tree view based packet list 
To use the GTK2 based packet list, define NEW_PACKET_LIST when compiling.
To do this with gcc, set the environment variable CPPFLAGS to
"-DNEW_PACKET_LIST" and re-run configure.

Many features do not yet work.  This work began with prototypes by Ulf
quite a while back.  I've put quite a bit of work into this so far and
as discussed with a few of the core team members at Sharkfest09 and it was
decided that it would be best to commit what I have so far to allow others to
help work on this.


svn path=/trunk/; revision=28892
 2009-06-30 18:05:04 +00:00
Guy Harris
432cac16f3 "main_menu.[ch]" -> "menus.[ch]"; it handles not only the main menu, but 
context menus.

Note why we have an empty hex dump pane context menu.

svn path=/trunk/; revision=28794
 2009-06-21 19:16:37 +00:00
Bill Meier
ba9afe83d5 proto_main_draw: rework packet bytes "save as" slightly: 
- Prevent "dead" save-as window if error opening/writing file
      or if a directory is entered as the filename;
      Work-around is to always kill save-as window whether success
       or an error causing alert-box popup;
   - Enable "check for file overwrite" (if GTK 2.8 or greater);
   - Fix some memory leaks.

svn path=/trunk/; revision=28577
 2009-06-01 20:52:53 +00:00
Guy Harris
54c159cb41 Turn on -Wshorten-64-to-32 by default, and fix some issues that turned 
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats).  Hopefully this will catch at least
some P64 issues on UN*X.

svn path=/trunk/; revision=28108
 2009-04-21 16:57:52 +00:00
Stig Bjørlykke
ad99387305 Show generated hidden protocol items as <[Element: value]> 
svn path=/trunk/; revision=27520
 2009-02-23 15:30:15 +00:00
Stig Bjørlykke
290ec47c55 Invalidate cfile.current_row when forcing byte view update. 
svn path=/trunk/; revision=26835
 2008-11-24 20:27:57 +00:00
Bill Meier
56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API 
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
 2008-06-29 15:51:43 +00:00
Jeff Morriss
a5cee04fad Move the file utility functions from wiretap to libwsutil so that 
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354
 2008-05-22 15:46:27 +00:00
Anders Broman
b6454e76ac Fix some of the Errors/warnings detected by checkapi. 
svn path=/trunk/; revision=25244
 2008-05-06 05:50:31 +00:00
Stig Bjørlykke
0a4ab4b039 Force foreground when background is forced in expert info dialogs. 
svn path=/trunk/; revision=25211
 2008-05-01 18:03:46 +00:00
Stig Bjørlykke
edfab8e2aa While playing with a dark theme I found it much nicer to use the 
selected background color from the packet list.

svn path=/trunk/; revision=25209
 2008-05-01 17:46:03 +00:00
Stig Bjørlykke
dd553f1906 From Frederic Peters (bug 1735): 
Force foreground when background is forced.

From me:
Do the same for expert info's.

svn path=/trunk/; revision=25207
 2008-05-01 11:02:14 +00:00
Stephen Fisher
bbf7ec011a Remove all GTK+ < 2.4 code and minimum version checks. 
svn path=/trunk/; revision=25182
 2008-04-27 07:01:58 +00:00
Stig Bjørlykke
a4f76f95a0 Added an option to display hidden protocol items. 
svn path=/trunk/; revision=25108
 2008-04-17 23:14:01 +00:00
Graeme Lunt
39ab6c51c0 Allow the folders in the About Wireshark/Folders list to be double clicked on to open the appropriate folder in explorer. 
The MIB/PIB paths have been split up to allow each one to be clicked on separately, but as a result this will lose the order if the whole list is reordered.

XXX: I have been unable to test this on MacOS or Linux. Stig? :-)
I suppose it should work, but we may need to make it WIN32 specific?


svn path=/trunk/; revision=24995
 2008-04-13 17:48:47 +00:00
Ulf Lamping
38c4ebeb4a move all code from color.c into color_utils.c 
remove color.c
rename colors.h into color_utils.h (hopefully this reduces confusion to /color.h)

svn path=/trunk/; revision=24974
 2008-04-13 12:41:22 +00:00
Ulf Lamping
6a5b1e0ec0 use the ending "_win32" for every windows specific file 
svn path=/trunk/; revision=24972
 2008-04-13 12:14:57 +00:00