Commit Graph

2990 Commits

Author SHA1 Message Date
Guy Harris bea00e22cf In a display filter expression, make a field name refer to any of the
fields with that name.

svn path=/trunk/; revision=3030
2001-02-13 18:34:51 +00:00
Guy Harris cb58c92d1d Updates from Mike Frisch.
svn path=/trunk/; revision=3029
2001-02-13 18:28:29 +00:00
Guy Harris 2833a57f09 You have to define "htolell()" on little-endian platforms, too....
svn path=/trunk/; revision=3028
2001-02-13 07:07:17 +00:00
Guy Harris b3f35be74a Changes from Chris Jepeway to
in some places use "guint64", on plaforms where it's available,
	rather than floating point (we don't yet use it universally, as
	we'd have to provide code to do 64-bit arithmetic on
	platforms/compilers where 64-bit integral types aren't
	supported);

	use .838096 microseconds rather than 1 microseconds as the time
	stamp units for NetXRay 2.x format, as those capture files seem
	to use that time stamp (that's the Sniffer "PC" time stamp;
	perhaps when Network Associates assimilated Cinco, they changed
	the time stamp units).

svn path=/trunk/; revision=3027
2001-02-13 00:50:05 +00:00
Guy Harris 35dfa54307 Updates from Neil Hunter.
svn path=/trunk/; revision=3026
2001-02-13 00:17:55 +00:00
Guy Harris 30d13244eb Changes to correctly decode BOOTP option 82, from Greg Kilfoyle.
svn path=/trunk/; revision=3025
2001-02-13 00:01:08 +00:00
Guy Harris 0196634a17 If there are multiple fields with the same name, list only one of them
in the output of "{ethereal,tethereal} -G", so that it appears only once
in the documentation.

Expand some comments to give more details.

svn path=/trunk/; revision=3024
2001-02-12 10:06:51 +00:00
Guy Harris 32a7b693f9 If you register more than one field with the same name, the dfilter code
can now handle that; this allows us to register both the modulo-8 and
the modulo-128 versions of various X.25 bitfields with "x.25.XXX" names,
which lets us get rid of the "ex.25" protocol stuff completely and use
"x.25" for both modulo-8 and modulo-128 X.25.  Do so.  (Also, fix up
some cases where we appeared to be using the modulo-8 fields when
dissecting modulo-128 X.25.)

This, in turn, allows us to register the X.25 dissector, as there's now
only one protocol with which it's associated, and make it static and
have it called only through a handle, and to, when registering it with
the "llc.dsap" dissector table, associate it with "proto_x25".

That, in turn, allows us to get rid of the "CHECK_DISPLAY_AS_DATA()"
calls, and the code to set "pinfo->current_proto", in the X.25
dissector.

The code for the display filter expression dialog would, if there are
two fields with the same name registered under a protocol, list both of
them; have it list only one of them - the fields should have the same
type, the same radix, and the same value_string/true_false_string table
if any (if they don't, they're really not the same field...).

svn path=/trunk/; revision=3023
2001-02-12 09:06:19 +00:00
Guy Harris 076c614cfb Display Ethernet protocol types in hex, not decimal (that's how they're
generally shown), and display port numbers and IP protocol numbers as
unsigned.

svn path=/trunk/; revision=3022
2001-02-12 01:17:23 +00:00
Guy Harris 6e250ba730 "Off-hoke"? What had I been smoking when I typed that?
svn path=/trunk/; revision=3021
2001-02-11 23:19:00 +00:00
Guy Harris 55662a3607 Inactivate the "Decode As" menu item if the "Decode As" dialog box
wouldn't actually offer any options to the user.

Make a bunch of routines static that aren't used outside
"decode_as_dlg.c".

Remove the declaration of the nonexistent "decode_as_register_tcpudp()"
routine.

svn path=/trunk/; revision=3020
2001-02-11 23:02:05 +00:00
Guy Harris cb1f3a8093 In an "Update list of packets in real time" capture, pass the number of
dropped packets from the child to the parent.

svn path=/trunk/; revision=3019
2001-02-11 22:46:27 +00:00
Guy Harris 56875e0937 Change the protocol between the parent and child processes in an "Update
list of packets in real time" capture so that "!" always indicates an
error, with the "!" preceded by a count of characters in the error
message and followed by the text of the error, and so that those error
messages can be sent after the capture has started.

Use that to report capture errors, and errors writing to the capture
file, while the capture is under way.

Use #defines for the message type characters in that protocol.

svn path=/trunk/; revision=3018
2001-02-11 22:36:57 +00:00
Guy Harris 35a14714c0 Report failures of "pcap_stats()", as tcpdump does.
Print the "Capturing on <interface>" message, the running count of
packets captured, and error messages to the standard error in Tethereal,
so that you can pipe the output of a live capture that's printing
packets to a program or script without that script having to worry about
parsing stuff other than dissected packet summaries or details (tcpdump
does the same).

svn path=/trunk/; revision=3017
2001-02-11 21:29:03 +00:00
Guy Harris bf0a3a32d1 In Ethereal, attempt to get the packet statistics from libpcap when
capturing; if we succeed, display the packet drops count as the "Drops"
value in the status line and as the "Dropped packets" statistics in the
summary dialog box, otherwise don't display it at all.

In Tethereal, attempt to get the packet statistics from libpcap when
capturing; if we succeed, and if there were any dropped packets, print
out the count of dropped packets when the capture finishes.

svn path=/trunk/; revision=3016
2001-02-11 09:28:17 +00:00
Gilbert Ramirez 8cd8391b9a Make boolean equality/inequality tests smarter; they don't test
for exact value matches, but just that the two values are either zero
or non-zero.

svn path=/trunk/; revision=3015
2001-02-11 03:29:53 +00:00
Gilbert Ramirez 8d34a213ec Add rule for dftest.exe
svn path=/trunk/; revision=3014
2001-02-11 03:19:45 +00:00
Gilbert Ramirez ea7ef0fb0c Remove unused variable and add copyright and RCS ID.
svn path=/trunk/; revision=3013
2001-02-11 03:12:46 +00:00
Guy Harris 0c8ed39229 Updates from Alexandre P. Ferreira.
svn path=/trunk/; revision=3012
2001-02-10 09:28:04 +00:00
Guy Harris 261f3f1a6c Check for errors when writing a capture file.
Report errors when writing or closing a capture file.

Clean up some I/O error messages.

svn path=/trunk/; revision=3011
2001-02-10 09:08:14 +00:00
Guy Harris 776490b1db Further NFSV4 updates from Mike Frisch.
svn path=/trunk/; revision=3010
2001-02-09 18:26:04 +00:00
Guy Harris 58c5f7523d When dissecting an indirect call reply, if either there's an old-style
or new-style dissector for the reply, we can dissect the reply; there
doesn't have to be a new-style dissector.

svn path=/trunk/; revision=3009
2001-02-09 08:38:13 +00:00
Guy Harris ea037e9084 For indirect RPC calls, remember the call information, and add a
dissector for indirect replies that looks up the call.  Use them in the
portmapper/RPCBIND dissector.

svn path=/trunk/; revision=3008
2001-02-09 07:59:00 +00:00
Guy Harris f190eff056 Make a "dissect_rpc_indir_call()" routine to dissect arguments to a
specified program/version/procedure, and a "rpc_proc_name()" routine to
return the name of a specified program/version/procedure, and make the
callit dissector use those, rather than doing the work itself.

Un-export various routines and declarations that can again be private to
the RPC dissector.

svn path=/trunk/; revision=3007
2001-02-09 06:49:29 +00:00
Guy Harris a6216089a8 Add "TFTP_" before the packet type names, to avoid compiler warnings on
Windows where ERROR is #defined by some header file that gets included
by "packet-tftp.c".

svn path=/trunk/; revision=3006
2001-02-09 06:08:11 +00:00
Guy Harris f116900cac Change to include Service ID field in dissection of Service Info
component of WCCP 2 messages even if the service type is
WCCP2_SERVICE_DYNAMIC, from Simharajan Srishylam.

svn path=/trunk/; revision=3005
2001-02-09 00:11:44 +00:00
Guy Harris 6742f8bec9 On at least one capture, the PIM checksum appears to be correct, so
add code to check it - I've no idea what's going on with the other
captures where it's not correct, but those captures have a different
(and apparently incorrect) checksum for packets with the *exact same
contents* (other than the checksum) as the PIM packet in the capture
where the checksum is correct, so perhaps those packets actually had bad
checksums.

svn path=/trunk/; revision=3004
2001-02-08 08:38:58 +00:00
Guy Harris d59ab05745 Don't fetch any of the fields past the BPDU type if the BPDU type isn't
0; topology change notification frames don't *have* anything past the
BPDU type to fetch.

svn path=/trunk/; revision=3003
2001-02-08 07:32:11 +00:00
Guy Harris 7f4a71ab8b Pull a lot of common code for handling 802.3 frames (i.e., frames with a
length field rather than an Ethernet type field) into a
"dissect_802_3()" routine.

In that routine, catch exceptions thrown by the IPX or LLC dissector or
dissectors under them, so that the trailer information is added to the
tree even if an exception is thrown (similar to what "ethertype()"
does).

svn path=/trunk/; revision=3002
2001-02-08 07:08:05 +00:00
Guy Harris b1eb3635c2 In "call_dissector()", if the protocol for the dissector referred to by
the handle has been disabled, return after calling "dissect_data()",
rather than driving on and calling the dissector anyway.

svn path=/trunk/; revision=3001
2001-02-08 07:06:55 +00:00
Guy Harris 1f26489d9e Set the Protocol column, and clear the Info column, before we start
fetching anything from the packet, so that if an exception is thrown
those columns don't show something from the previous protocol.

Don't fetch the protocol identifier or protocol version identifier
before you use them.

svn path=/trunk/; revision=3000
2001-02-08 03:59:12 +00:00
Guy Harris ada3b765ef If we failed to open a capture file specified by the "-r" flag, don't
attempt to free the read filter if we don't have a read filter.

svn path=/trunk/; revision=2999
2001-02-08 03:55:45 +00:00
Guy Harris fc9ed1d58b Updates from Mike Frisch.
svn path=/trunk/; revision=2998
2001-02-07 22:10:49 +00:00
Guy Harris 7cb94abef2 Add in the various payload type definitions from RFC 1890.
svn path=/trunk/; revision=2997
2001-02-07 00:20:02 +00:00
Guy Harris 2c704b496e The "short name" and "filter name" were reversed; put them in the right
order.

svn path=/trunk/; revision=2996
2001-02-06 18:43:24 +00:00
Guy Harris 967e079bfb Add support for dissecting V3 CALLIT and V4 BCAST/INDIRECT calls.
svn path=/trunk/; revision=2995
2001-02-06 06:56:19 +00:00
Guy Harris d9ee8bec53 Tvbuffify the portmap/rpcbind dissector, and implement part of CALLIT
dissection (dissection of V2 CALLIT calls; no V3/V4 stuff or reply
handling yet).

svn path=/trunk/; revision=2994
2001-02-06 06:46:10 +00:00
Guy Harris 60ce2f6158 Fix up some MSVC complaints about (narrowing) type conversions by
widening formal arguments or narrowing variables passed as actual
arguments.

svn path=/trunk/; revision=2993
2001-02-05 02:47:31 +00:00
Guy Harris 39d2be965b Maximum frame size values in the second byte of the routing control
information aren't shifted right 4 bytes when put into the protocol
tree; shift left by 4 bytes the values in the value_string table for
them.

A value of 7 means 65535 bytes.

svn path=/trunk/; revision=2992
2001-02-05 02:06:27 +00:00
Guy Harris 3ce594a981 Add a "-f" flag to the "rm", so that "make clean" won't get an error
(and cause a higher-level "make clean" to stop) if any of the files to
be removed aren't there.

svn path=/trunk/; revision=2991
2001-02-04 19:44:24 +00:00
Guy Harris 2fdb4c76a2 Pass the correct tvbuff from the Vines Fragmentation Protocol dissector
to the Vines IP dissector.

svn path=/trunk/; revision=2990
2001-02-04 10:29:49 +00:00
Guy Harris 859860013e L3PIDs are Ethertypes; display them as such.
Use "decode_boolean_bitfield()" to dissect flag bits.

svn path=/trunk/; revision=2989
2001-02-04 09:37:28 +00:00
Guy Harris 3bb7974896 Add support for replies to NLMv3 SHARE and UNSHARE requests and to the
remaining NLMv4 requests.

svn path=/trunk/; revision=2988
2001-02-04 09:04:11 +00:00
Guy Harris 52bf014948 Tvbuffify the RSVP dissector.
Display the message checksum, and check it if possible.

Fix some IPv6 entries to be 16 bytes long, not 4 bytes long.

Make the routine to fetch an IEEE floating point number and turn it into
a "long" take a tvbuff pointer and offset rather than a pointer to data.

svn path=/trunk/; revision=2987
2001-02-04 08:21:35 +00:00
Gerald Combs ebba9ea2d0 As pointed out by Aaron C. Springer (and according to RFC 1827), it's
"Encapsulating Security Payload," and not "Encapsulated Security Payload."

svn path=/trunk/; revision=2986
2001-02-03 20:08:04 +00:00
Guy Harris 0d6e9f2533 Tvbuffify the Oracle TNS dissector.
svn path=/trunk/; revision=2985
2001-02-03 08:21:47 +00:00
Guy Harris 93eea18379 Use "pinfo", not "pi", to get packet info.
svn path=/trunk/; revision=2984
2001-02-03 08:07:04 +00:00
Guy Harris 64af6d155c Tvbuffify the IRC dissector.
svn path=/trunk/; revision=2983
2001-02-03 07:58:27 +00:00
Guy Harris c1e36ebccc Use "dfilter_apply_edt()" rather than "dfilter_apply()".
svn path=/trunk/; revision=2982
2001-02-03 06:25:17 +00:00
Guy Harris cacd37893a Increment the line number for every line seen.
Fix the handling of one error case.

svn path=/trunk/; revision=2981
2001-02-03 06:10:11 +00:00