Commit Graph

51165 Commits

Author SHA1 Message Date
Jakub Zawadzki 8c870995f0 mp2t: avoid calling get_mp2t_conversation_data()
svn path=/trunk/; revision=54395
2013-12-23 18:06:33 +00:00
Michael Mann bcd2ecfc94 Add FT_SYSTEM_ID for type checking
svn path=/trunk/; revision=54394
2013-12-23 17:57:57 +00:00
Bill Meier 68e0469733 Use G_GINT64_CONSTANT(nnn) instead of nnnul in a few places;
Add a few casts to time_t;
Do a few whitespace tweaks (indentation, trailing, etc)

svn path=/trunk/; revision=54393
2013-12-23 17:20:07 +00:00
Jeff Morriss 460d57cf06 Fix up casing and code formatting in the UDP Decode-As code.
svn path=/trunk/; revision=54392
2013-12-23 17:01:37 +00:00
Jeff Morriss b20e6a20eb Make the SCTP Decode-As dialog more consistent with the TCP one.
Rename the 2nd SCTP Transport tab to "SCTP(PPID)" to make it obvious what it
is.

Fix up casing and code formatting in both SCTP and TCP Decode-As code.

svn path=/trunk/; revision=54391
2013-12-23 16:50:25 +00:00
Bill Meier 9e8306c746 Back out inadvertant change introduced in SVN #54340
to use GTK2 when building Windows Wireshark.

svn path=/trunk/; revision=54390
2013-12-23 16:47:10 +00:00
Alexis La Goutte bc7c39eab3 Make buildbot Happy
error: unused parameter 'allow_partial_value'

svn path=/trunk/; revision=54389
2013-12-23 15:58:26 +00:00
Martin Mathieson 7479af52e5 Add #if 0'd code to calculate CMAC digest, which isn't supported in windows build of libgcrypt currently getched by 'setup'.
svn path=/trunk/; revision=54388
2013-12-23 15:56:40 +00:00
Bill Meier 8ab9c55618 From Ville Skyttä: Spelling Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9591


svn path=/trunk/; revision=54387
2013-12-23 15:53:13 +00:00
Bill Meier eecbfd1f3b Reove _U_ from some function parameters ...
svn path=/trunk/; revision=54386
2013-12-23 15:35:07 +00:00
Martin Mathieson f687bd18da Change types to try to avoid warnings.
svn path=/trunk/; revision=54385
2013-12-23 15:25:05 +00:00
Evan Huus 00048cf418 Add GPLv2+ license header to headers-check.c as per private email from the
author.

svn path=/trunk/; revision=54384
2013-12-23 15:19:25 +00:00
Michael Mann 7ec4582b4f Add FT_SYSTEM_ID type and convert the dissectors that use print_system_id with FT_BYTES to now use FT_SYSTEM_ID type.
svn path=/trunk/; revision=54383
2013-12-23 15:18:48 +00:00
Martin Mathieson 5b8f078f4b Remove printf() call
svn path=/trunk/; revision=54382
2013-12-23 13:53:56 +00:00
Alexis La Goutte 5742802a73 From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9551
Dissect SCSI XCOPY and RECEIVE COPY Parameters commands

From me :
Fix encoding-args
Fix trailing whitespace

svn path=/trunk/; revision=54381
2013-12-23 13:45:07 +00:00
Martin Mathieson 9d688a9fde Call function and compare result with parsed mac-i. Now just need to do EIA2(AES) calculation
svn path=/trunk/; revision=54380
2013-12-23 13:43:13 +00:00
Stig Bjørlykke e8e3f1011b Removed a wrong sanity check in ByteArray base64_decode.
svn path=/trunk/; revision=54379
2013-12-23 12:19:16 +00:00
Martin Mathieson 27409e8f2e Use preference variable that wasn't used yet to pacify buildbot
svn path=/trunk/; revision=54378
2013-12-23 11:38:38 +00:00
Martin Mathieson 2f2b05aee2 Starting to get ready for integrity checking
svn path=/trunk/; revision=54377
2013-12-23 10:56:51 +00:00
Martin Kaiser 0566944f17 correct http2 detection
check the input tvb's length before doing tvb_get_guint8(tvb,2)
reject a short packet, don't throw an exception

svn path=/trunk/; revision=54376
2013-12-23 09:42:10 +00:00
Guy Harris eb3ff1396f Fix warning.
svn path=/trunk/; revision=54375
2013-12-23 02:19:27 +00:00
Guy Harris 8a5d226894 Fix the offset constant in SURROGATE_VALUE(), and add rather than OR it.
Expand a bunch of comments, discussing what various routines do and
should perhaps do.

Pull the core of tvb_get_ucs_2_string()/tvb_get_ucs_2_stringz() and
tvb_get_ucs_4_string()/tvb_get_ucs_4_stringz() into common routines, as
we did for tvb_get_utf_16_string()/tvb_get_utf_16_stringz().

svn path=/trunk/; revision=54374
2013-12-23 01:25:20 +00:00
Michael Mann 0ab7d560f3 Make (most) fields within packet-osi-options.c filterable.
Not sure how to handle the filter names.  Even though OSI isn't a "protocol", there's enough commonality to justify a "dissector".  Also not sure if packet-osi-options.c should just be merged with packet-osi.c to make the relationship more obvious (both files aren't that big)

svn path=/trunk/; revision=54373
2013-12-23 01:16:00 +00:00
Stig Bjørlykke df25b7a7e0 Improved out-of-bounds check in TvbRange ustringz and le_ustringz.
This functions should probably be marked as obsoleted now that we
have support for encoding in stringz.

svn path=/trunk/; revision=54372
2013-12-22 22:19:41 +00:00
Stig Bjørlykke 8a4f419f60 Made TvbRange strsize take an optional encoding argument.
svn path=/trunk/; revision=54371
2013-12-22 22:09:06 +00:00
Pascal Quantin 9de6aa8619 From Fabrice Bellard:
Add Carrier Id and detailed PHY info to MAC LTE UDP framing dissector

svn path=/trunk/; revision=54370
2013-12-22 21:16:31 +00:00
Pascal Quantin 18f68cae7e Try to pacify buildbots
svn path=/trunk/; revision=54369
2013-12-22 20:12:31 +00:00
Pascal Quantin ee0ea80d07 Fix dissection of GSM SMS PDU
svn path=/trunk/; revision=54368
2013-12-22 19:26:58 +00:00
Michael Mann 89786cc8c7 Overhaul the ISIS dissectors
1. Make real dissectors and call dissector_try_uint_new for each "isis.type"
2. Use make_register script for dissector initialization
3. Replace isis_dissect_unknown() with real expert info
4. Use convert_proto_tree_add_text.pl to make many more filterable items and gets some files off of the checkAPIs.pl naughty list.
5. Remove (now unnecessary) dissector specific header files
6. Do some reordering of functions to eliminate the need for function declarations.

Additional whitespace formatting and modelines should probably be applied to all of these dissectors.

Used capture files from bug 5354 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5354) and bug 1792 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1792) for fuzztesting.

svn path=/trunk/; revision=54367
2013-12-22 18:18:12 +00:00
Pascal Quantin 302a4cf1c0 Fix copy/paste error
svn path=/trunk/; revision=54366
2013-12-22 17:27:53 +00:00
Pascal Quantin 3fba8ea2fe proto_tree_add_text -> proto_tree_add_item
svn path=/trunk/; revision=54365
2013-12-22 16:27:21 +00:00
Bill Meier e348c13deb (Trivial)
- Minor whitespace changes;
- Fix a typo;
- Add editor modelines to tnbuff_subset.c

svn path=/trunk/; revision=54364
2013-12-22 15:47:17 +00:00
Bill Meier 523abb73f8 'L' constant modifier not needed.
svn path=/trunk/; revision=54362
2013-12-22 15:31:42 +00:00
Bill Meier e73a97a468 Constant modifier 'L' not needed;
Remove unneeded #includes;
Change several tabs to spaces;
Add editor modelines.

svn path=/trunk/; revision=54361
2013-12-22 15:22:49 +00:00
Gerald Combs 95379b9274 [Automatic manuf, services and enterprise-numbers update for 2013-12-22]
svn path=/trunk/; revision=54359
2013-12-22 15:03:44 +00:00
Bill Meier c00f8779f5 Don't use 'L' as a constant modifier.
svn path=/trunk/; revision=54358
2013-12-22 14:47:16 +00:00
Bill Meier 400a1fcd60 Use G_GINT64_CONSTANT(n) rather than 'nLL' when defining constants;
Fix a typo in a comment.

svn path=/trunk/; revision=54357
2013-12-22 14:43:35 +00:00
Stig Bjørlykke a48a5a164f Made TvbRange string and stringz take an optional encoding argument, and
removed the yet-another-string-function string_enc and stringz_enc.

Documented the encoding argument.

svn path=/trunk/; revision=54356
2013-12-22 13:08:39 +00:00
Guy Harris a1c84e00de Get rid of a set-but-unused variable.
svn path=/trunk/; revision=54355
2013-12-22 11:15:35 +00:00
Jakub Zawadzki 51ea411db7 Move expert value_string body to expert.c (from expert.h)
svn path=/trunk/; revision=54354
2013-12-22 10:52:29 +00:00
Jakub Zawadzki 1f88687d3f tvb_get_ucs_4_string: increase offset by 4
copy&paste of tvb_get_ucs_2_string?

svn path=/trunk/; revision=54353
2013-12-22 10:45:22 +00:00
Jakub Zawadzki 0f8572cb51 Avoid including definition of column_info structure in dissectors.
Move COL_* enum to <epan/column-utils.h>

XXX Later we can rename epan/column-info.h to column-int.h (or smth like this)

svn path=/trunk/; revision=54352
2013-12-22 10:41:27 +00:00
Guy Harris fc7a77189d Add UCS-4 support, and use it.
Shuffle the character ENC_ values around a bit, keeping the Unicode
encodings together, moving the Windows code pages (only one for now)
after the ISO 8859 encodings, and putting "I can't believe it's not
ASCII!" at the end.

Fix some comment typoes, and update another comment, while we're at it.

svn path=/trunk/; revision=54351
2013-12-22 08:45:57 +00:00
Guy Harris 5084f58ce2 We support ENC_UCS_2, so use that in proto_tree_add_item() and
tvb_get_string_enc() rather than using iconv to convert it to UTF-8.

svn path=/trunk/; revision=54350
2013-12-22 02:12:32 +00:00
Jörg Mayer f9cce15b35 Generated stuff does not belong into the source tree
svn path=/trunk/; revision=54349
2013-12-22 01:29:21 +00:00
Jörg Mayer 6d17d3c4d6 Beginnings of doxygen support.
Currently the doxygen.cfg files are not designed for
out-of-tree builds - that needs to be fixed first.

svn path=/trunk/; revision=54348
2013-12-22 01:21:56 +00:00
Guy Harris 48504bc5f5 Oops, added the "unknown header version" expert info to the wrong item.
svn path=/trunk/; revision=54347
2013-12-21 22:12:46 +00:00
Guy Harris 50d9d2f94f Support all the DVB ISO 8859-x encodings, now that we have ENC_ values
for all of them.

svn path=/trunk/; revision=54346
2013-12-21 22:10:49 +00:00
Jörg Mayer 80ad1520f5 Fix for
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-peekremote.c: In function ‘dissect_peekremote_new’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-peekremote.c:210:15: error: variable ‘ti_header_version’ set but not used [-Werror=unused-but-set-variable]
   proto_item *ti_header_version, *ti_header_size;
               ^
cc1: all warnings being treated as errors


svn path=/trunk/; revision=54345
2013-12-21 22:05:42 +00:00
Guy Harris f231a273f2 Add the rest of ISO-8859-n, thanks to Jakub's "generate a mapping table"
program.

Put the character-encoding cases in order.

svn path=/trunk/; revision=54344
2013-12-21 21:55:46 +00:00