osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
53778 commits 23 branches 0 tags 1.3 GiB
Commit graph

165 commits

Author SHA1 Message Date
Michael Mann
9356d5c689 convert to proto_tree_add_subtree[_format] for ASN.1 dissectors 
Change-Id: I753ca95e2e1b38bad2c09955317e648c525e40ef
Reviewed-on: https://code.wireshark.org/review/2509
Tested-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-22 21:08:21 +00:00
Guy Harris
ce3d2ff3de Rename dissector_add_handle() to dissector_add_for_decode_as(). 
Hopefully that name makes it clear what the routiner's purpose is, and
will encourage people to use it rather than using dissector_add_uint()
with a bogus integer value.

Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8
Reviewed-on: https://code.wireshark.org/review/2483
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-06-20 16:43:56 +00:00
Evan Huus
980f5f6711 batch of tvb-length conversions 
Change-Id: I5e40df8af6841e3dad71c41d7e43c7971611b15f
Reviewed-on: https://code.wireshark.org/review/2473
Reviewed-by: Evan Huus <eapache@gmail.com>
 2014-06-20 05:33:04 +00:00
Michael Mann
14824e6adf Revert "Fixup: tvb_* -> tvb_captured" 
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html

This reverts commit 246fe2ca4c.

Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-19 18:25:59 +00:00
Dario Lombardo
246fe2ca4c Fixup: tvb_* -> tvb_captured 
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-06-18 14:14:58 +00:00
Hadriel Kaplan
04c05a21e3 Fix Bug 9920 Buildbot crash due to SDP/RTP mismatch 
For details see comments in Bug 9920.

The executive summary:
Bug 9920 is a crash caused by a couple of issues:

1) The memory ownership model for the rtp_dyn_payload hashtable is split: SDP
creates the rtp_dyn_payload hashtable, but RTP can free it. Since there isn't
*one* pointer to the hashtable, RTP freeing it means SDP has a dangling
pointer.

2) Either the SDP dissector shouldn't be creating two separate, unique
hashtables for multiple media channels of the same addr:port, or RTP shouldn't
be free'ing the previous one.

Change-Id: I436e67de6882f84aa82dcbdfe60bf313fe4fd99c
Reviewed-on: https://code.wireshark.org/review/918
Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-04-03 04:40:20 +00:00
Bill Meier
1dff4e309d Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate dissectors. 
Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4
Reviewed-on: https://code.wireshark.org/review/412
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
 2014-02-26 19:38:21 +00:00
Jeff Morriss
8c608e6e82 Remove $Id$ from the ASN.1 dissectors and regenerate them. 
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954
Reviewed-on: https://code.wireshark.org/review/244
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
 2014-02-18 03:05:28 +00:00
Jakub Zawadzki
deb2b236f2 Add missing includes 
svn path=/trunk/; revision=54332
 2013-12-21 17:23:17 +00:00
Anders Broman
b693f74b89 - Forward declaration of register functions. 
svn path=/trunk/; revision=53877
 2013-12-09 06:50:09 +00:00
Jakub Zawadzki
5ac6474c94 Rename some of pint.h macros to match common style (bits number on the end). 
pntohs  -> pntoh16
   pntohl  -> pntoh32
   pletohs -> pletoh16
   pletohl -> pletoh32
   phtons  -> phton16
   phtonl  -> phton32


svn path=/trunk/; revision=53652
 2013-11-29 18:59:06 +00:00
Evan Huus
1db1b8e2bb Convert ASN1 dissectors from ep_address_to_str to address_to_str. Clean up a bit 
of ansi_tcap code while in the neighbourhood.

svn path=/trunk/; revision=53530
 2013-11-23 22:37:33 +00:00
Pascal Quantin
ea45be32c5 Add a way to retrieve a PER variable bit string length 
svn path=/trunk/; revision=53382
 2013-11-17 13:31:32 +00:00
Michael Mann
7221215cdc Add "rtp handle protection" inside srtp_add_address/rtp_add_address/bluetooth_add_address so dissectors calling it don't need to find "rtp" just for the handle check. 
svn path=/trunk/; revision=53288
 2013-11-12 22:04:03 +00:00
Michael Mann
a661864f48 Add "T.38 handle protection" inside t38_add_address() so dissectors calling it don't need to find "t38" just for the handle check. 
svn path=/trunk/; revision=53283
 2013-11-12 21:10:20 +00:00
Jakub Zawadzki
ae59b09443 Add missing includes in order to remove exceptions.h from proto.h (next commit). 
svn path=/trunk/; revision=53230
 2013-11-10 15:59:37 +00:00
Jakub Zawadzki
c9b2ee3768 include <wsutil/pint.h> only when needed. 
svn path=/trunk/; revision=53196
 2013-11-09 15:44:29 +00:00
Michael Mann
d62f92b7f1 Make LDAP dissector use ASN.1 private_data instead of pinfo->private_data. 
Cleanup a forgotten pinfo->private_data use in the H245 dissector.

svn path=/trunk/; revision=53160
 2013-11-08 02:02:43 +00:00
Michael Mann
60e3e52a53 Have asn1_ctx_t passed into the "h245.gef.name" and "h245.gef.content" subdissectors instead of using pinfo->private_data. 
svn path=/trunk/; revision=53055
 2013-11-03 02:45:22 +00:00
Michael Mann
02a8391535 Require dissector_try_string to pass a data parameter to its subdissectors. There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new. 
svn path=/trunk/; revision=53049
 2013-11-02 15:52:25 +00:00
Pascal Quantin
868b345eea Convert a few more dissectors to wmem API 
svn path=/trunk/; revision=52053
 2013-09-15 10:29:49 +00:00
Evan Huus
8441fff193 Use the pinfo pool for adding data sources in the h245 dissector. The packet 
pool is freed before the packet is displayed or otherwise processed, so adding
data sources from it leads to use-after-free errors.

Not sure why this wasn't showing up in the fuzz-bot valgrind step, there
are lots of h245 captures in the menagerie...

svn path=/trunk/; revision=50897
 2013-07-25 23:58:49 +00:00
Evan Huus
8b0f1addd9 Apparently one of our major global headers must include emem.h, because I just 
found a bunch more asn1 dissectors using emem without ever directly including
the header. Convert those to wmem as well, which involves add a number of
#include directives since dissectors do *not* automatically pull in the wmem
headers.

svn path=/trunk/; revision=50066
 2013-06-19 23:08:58 +00:00
Evan Huus
9fa4a8e6b6 Convert a batch of asn1 dissectors from emem to wmem. 
svn path=/trunk/; revision=50057
 2013-06-19 20:43:03 +00:00
Pascal Quantin
0ee4d0a00a Postfix FT_NONE fields with "_element" string to reduce number of incompatible filters in ASN.1 dissectors 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402

svn path=/trunk/; revision=49599
 2013-05-27 20:26:49 +00:00
Pascal Quantin
a37c044203 Update the ASN.1 based dissectors following the changes done in r48812 
svn path=/trunk/; revision=48820
 2013-04-11 18:14:53 +00:00
Anders Broman
3e38475176 From beroset: 
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48356
 2013-03-17 17:52:26 +00:00
Jakub Zawadzki
7a9d27c33f Regenerate asn.1 dissectors. 
svn path=/trunk/; revision=45110
 2012-09-24 19:38:46 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Michael Mann
6c0e747f61 use session allocated memory for rtp_add_address/srtp_add_address hash tables 
svn path=/trunk/; revision=44571
 2012-08-19 00:21:26 +00:00
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Bill Meier
484b58f622 Regenerated packet-h245.c (should have been included in SVN #40311: add_new_data_source() needed in several places). 
svn path=/trunk/; revision=40345
 2011-12-30 15:28:04 +00:00
Tomas Kukosa
3c7926a2c6 Fix H.460.18 and H.460.19 integration into H.245 
svn path=/trunk/; revision=39998
 2011-11-24 15:18:11 +00:00
Bill Meier
24cf0aad06 Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss; 
The only change in each file is in a comment showing the asn2wrs cmd used to build that file.

svn path=/trunk/; revision=39427
 2011-10-15 19:27:27 +00:00
Anders Broman
e12440d3d0 From Liam Sharp: 
In VoIP calls flow/graph display replace GR/GI etc with presentationTokenRequest/Response etc

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6321

svn path=/trunk/; revision=39022
 2011-09-16 04:55:58 +00:00
Anders Broman
71fc5eca2a From Liam Sharp: 
VoIP Calls->Graph TCS and OLC display corruption.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6318

svn path=/trunk/; revision=38970
 2011-09-12 08:37:36 +00:00
Anders Broman
7a0cb7ea93 from Liam Sharp: 
Info column to show subMessageIdentifier type strings for H245/H.239 packets

With a change to remove "subMessageIdentifer=" as I think that clutters up the Infocol.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6315

svn path=/trunk/; revision=38968
 2011-09-12 06:02:43 +00:00
Anders Broman
fa889d6d78 From Liam Sharp: 
(Standard)H.239 – subMessageIdentifier value strings missing from H245 dissector.
Modified to be filterable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6312

svn path=/trunk/; revision=38897
 2011-09-06 15:05:26 +00:00
Stig Bjørlykke
a7c5d642d5 Regenerate ASN.1 dissectors to update the #line directive. 
svn path=/trunk/; revision=37118
 2011-05-13 08:12:27 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Stig Bjørlykke
b9f01a15db Initialize dummy_me to avoid garbage or undefined values. 
svn path=/trunk/; revision=34788
 2010-11-05 08:28:34 +00:00
Tomas Kukosa
5fbdb1c378 Generate proper extension flags for empty constructed types SEQUENCE { ... } and CHOICE { ... } 
svn path=/trunk/; revision=34400
 2010-10-07 14:24:04 +00:00
Jeff Morriss
a0c858efcd Add a little more code to avoid not-very-useful blurbs: 
- Change spaces in the name to underscores before comparing it to the blurb.
  - Check if the type simply as T_ prepended to the name.
  - Don't put in a blurb of "NULL".

and regenerate the dissectors.

svn path=/trunk/; revision=32748
 2010-05-11 03:53:31 +00:00
Jeff Morriss
8f210cf4e0 Regenerate a few of the ASN.1 dissectors 
svn path=/trunk/; revision=32742
 2010-05-11 02:13:26 +00:00
Tomas Kukosa
590b1add10 H.245 updated to v15 (2009-12) 
svn path=/trunk/; revision=32660
 2010-05-04 19:01:25 +00:00
Jeff Morriss
67b7737481 Fix the build 
svn path=/trunk/; revision=32467
 2010-04-14 21:38:08 +00:00
Anders Broman
83ce037aa9 Use the sample rate from SDP info in RTP stream analysis. 
svn path=/trunk/; revision=32466
 2010-04-14 20:48:37 +00:00
Bill Meier
f8b92f8d0b #include <stdio.h> not needed. 
svn path=/trunk/; revision=32405
 2010-04-06 17:01:14 +00:00
Bill Meier
cbec3dba8c Fix two gcc -Wshadow warnings. 
svn path=/trunk/; revision=31736
 2010-01-29 22:16:54 +00:00
Anders Broman
a255c08b66 Get rid of check_col(); 
svn path=/trunk/; revision=31546
 2010-01-17 12:46:00 +00:00