Michael Mann
fe4b7ee625
convert to proto_tree_add_subtree[_format]
...
Change-Id: If110de1e0555637264f86f1508858d569871a9c7
Reviewed-on: https://code.wireshark.org/review/2675
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-29 13:10:02 +00:00
Michael Mann
14824e6adf
Revert "Fixup: tvb_* -> tvb_captured"
...
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html
This reverts commit 246fe2ca4c
.
Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19 18:25:59 +00:00
Dario Lombardo
246fe2ca4c
Fixup: tvb_* -> tvb_captured
...
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18 14:14:58 +00:00
Evan Huus
de00c49bd8
Convert a bunch of time_to_str functions to wmem
...
Change-Id: I24fe3cc4a3589dadc4528a77fe7ff13d06b1a983
Reviewed-on: https://code.wireshark.org/review/2245
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16 17:26:25 +00:00
Michael Mann
73217d9f3f
tvb_new_subset -> tvb_new_subset_length when length parameters are equal.
...
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is.
Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d
Reviewed-on: https://code.wireshark.org/review/1999
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-07 15:41:07 +00:00
Michael Mann
4e5424af52
packet-q931.c: proto_tree_add_text -> something filterable.
...
Change-Id: I576f8d7fcf01a4c1dc6e486f7dd0a5b46edce502
Reviewed-on: https://code.wireshark.org/review/1935
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-04 04:21:29 +00:00
Bill Meier
4fbcfc1289
(Benign) Don't use "address-of" operator on arg of VALS() (not that it makes any actual difference)..
...
Change-Id: I0766d0f130648aaa5a58d9f4062fa24e898cbdc3
Reviewed-on: https://code.wireshark.org/review/545
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-07 05:03:41 +00:00
Bill Meier
93fe4d53e2
Remove trailing whitespace.
...
Change-Id: Ia03a1cd4590aceda30ead4aa93ad413d90c6aea6
Reviewed-on: https://code.wireshark.org/review/372
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-25 16:36:38 +00:00
Pascal Quantin
a8676c2fd7
Fix dissection of BCD numbers
...
Do not use of tvb_get_string(): what we really want is the byte string, not an ASCII string
Change-Id: I8b9a8b7ccacbdaf6d9525771ff8ed883ba01ad34
Reviewed-on: https://code.wireshark.org/review/329
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-23 22:41:45 +00:00
Pascal Quantin
6ebc058f47
Add proto_tree_add_ts_23_038_7bits_item() / tvb_get_ts_23_038_7bits_string() functions and update dissectors to use it.
...
Remove gsm_sms_char_7bit_unpack() / gsm_sms_chars_to_utf8() functions.
Update documentation a bit.
svn path=/trunk/; revision=54534
2014-01-01 14:33:19 +00:00
Alexis La Goutte
09e10bb331
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
...
svn path=/trunk/; revision=54415
2013-12-23 20:13:17 +00:00
Pascal Quantin
f48dde1444
Fix a "'str' may be used uninitialized in this function" error
...
svn path=/trunk/; revision=54285
2013-12-20 08:33:18 +00:00
Pascal Quantin
f390e381e7
Fix time dissection broken in r54274
...
svn path=/trunk/; revision=54282
2013-12-20 06:55:56 +00:00
Pascal Quantin
56fa8467cd
Try to please Clang-Code-Analysis buildbot
...
svn path=/trunk/; revision=54278
2013-12-19 22:55:16 +00:00
Michael Mann
959a290961
proto_tree_add_text -> proto_tree_add_xxx conversion.
...
svn path=/trunk/; revision=54274
2013-12-19 21:51:09 +00:00
Evan Huus
a6415ece0a
Rename a couple of to_str functions to have ep_ in the name. This makes it
...
obvious that the returned string is ephemeral, and opens up the original names
in the API for versions that take a wmem pool (and thus can work in any scope).
svn path=/trunk/; revision=54249
2013-12-19 15:49:09 +00:00
Guy Harris
4a346b7188
Use tvb_get_string_enc(), or proto_tree_add_item(), rather than
...
tvb_get_unicode_string() or g_iconv stuff.
svn path=/trunk/; revision=54244
2013-12-19 03:12:59 +00:00
Evan Huus
8f665d9b36
Add a sixteenth element to all BCD digit sets to avoid garbage values when
...
decoding corrupt bytes. Some of these digit sets could probably be
deduplicated...
svn path=/trunk/; revision=54224
2013-12-18 15:54:32 +00:00
Jakub Zawadzki
c45475ab45
Fix [-Wmissing-prototypes]
...
svn path=/trunk/; revision=54135
2013-12-15 23:44:12 +00:00
Bill Meier
2ac134b3c5
whitespace fixes; mostly: remove trailing blanks
...
svn path=/trunk/; revision=52591
2013-10-13 19:56:52 +00:00
Pascal Quantin
a0c53ffaa1
emem -> wmem conversion:
...
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly
svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Pascal Quantin
2b44f1449c
Fix off by 1 error when dissecting Data Radio Bearer identity number
...
svn path=/trunk/; revision=52128
2013-09-17 20:06:48 +00:00
Michael Mann
346f803d42
Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was all manual inspection and most cases were either:
...
1. Case sensitivity differences between hf_ field name and formatted string.
2. Unnecessary whitespace between hf_ field name and colon in formatted string
There are cases where the hf_ field name doesn't quite match the proto_tree_add_uint_format, but it's close enough that one of them should be "right", I'm just not sure which is, I just know the string in proto_tree_add_uint_format is the one displayed.
svn path=/trunk/; revision=52098
2013-09-16 10:39:06 +00:00
Michael Mann
b38ee917b1
Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
...
The script didn't catch as many as I would have liked, but it's a start.
The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.
svn path=/trunk/; revision=52045
2013-09-15 01:48:30 +00:00
Michael Mann
a72fc72061
Batch of filterable expert info.
...
svn path=/trunk/; revision=51689
2013-09-03 02:26:50 +00:00
Pascal Quantin
84bf0acc00
Convert a few dissectors from EMEM to WMEM API
...
svn path=/trunk/; revision=51597
2013-08-30 14:49:55 +00:00
Pascal Quantin
00b3acf9c5
Highlight the correct byte for Timezone
...
svn path=/trunk/; revision=48751
2013-04-05 20:50:24 +00:00
Evan Huus
37600a157b
Rename value string (and similar) functions to use a consistent pattern. This
...
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).
Use a consistent coding style, and make proper use of the WS_DLL_* defines.
Group the functions appropriately in the header.
I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467
svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
Pascal Quantin
92dce1c3f0
Do not initialize ett_tree and dtap_msg_fcn when match_strval_idx does not find a match
...
svn path=/trunk/; revision=48520
2013-03-24 10:09:16 +00:00
Pascal Quantin
1af56ab0c7
Upgrade NAS disssectors to v11.6.0
...
svn path=/trunk/; revision=48427
2013-03-19 20:47:48 +00:00
Anders Broman
6bde918078
From beroset:
...
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48426
2013-03-19 20:00:52 +00:00
Pascal Quantin
86eda54fe6
As suggested by Evan Huus, use extended value_strings
...
svn path=/trunk/; revision=48407
2013-03-18 22:21:53 +00:00
Pascal Quantin
94f330030d
use enum values instead of hardcoded values
...
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487 )
svn path=/trunk/; revision=48397
2013-03-18 20:26:47 +00:00
Anders Broman
f6ce72ee04
From Joseph Chai:
...
Add aditional IE dissection.
From me patch cleanup and add set fence for multiple DTAP messages in one frame.
svn path=/trunk/; revision=48087
2013-03-05 17:38:44 +00:00
Pascal Quantin
ae61fe0158
Try to fix dissection of GSM protocol family broken by r47209.
...
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)
svn path=/trunk/; revision=47218
2013-01-22 23:25:44 +00:00
Pascal Quantin
0b20f855f0
Upgrade NAS disssectors to v11.5.0
...
svn path=/trunk/; revision=46842
2012-12-29 17:10:04 +00:00
Bill Meier
c2596fb5c7
Fix a purported [-Wshadow] warning;
...
Also: Do some minor whitespace and formatting changes.
svn path=/trunk/; revision=46195
2012-11-26 01:53:21 +00:00
Pascal Quantin
04ba20fa0e
Upgrade NAS dissector to v11.4.0 (Release 11)
...
svn path=/trunk/; revision=45325
2012-10-04 21:23:06 +00:00
Pascal Quantin
8b6bc1630a
Dissect Update UE Location Information message
...
svn path=/trunk/; revision=45047
2012-09-21 20:00:12 +00:00
Jeff Morriss
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Pascal Quantin
7da4784b25
Following r44648, revert part of r44162 and followups so as to have a top level gsm_a filter name
...
svn path=/trunk/; revision=44667
2012-08-25 13:32:41 +00:00
Bill Meier
638d74d43f
Use val_to_str_const() where appropriate;
...
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc
svn path=/trunk/; revision=44438
2012-08-10 22:55:02 +00:00
Pascal Quantin
6c8d938dd4
Follow-up of r44162: clean more filters
...
svn path=/trunk/; revision=44187
2012-08-01 14:07:18 +00:00
Pascal Quantin
8ce8431f4e
Update filter names following the changes done in r44162
...
svn path=/trunk/; revision=44168
2012-07-31 20:44:34 +00:00
Michael Mann
175851fb40
Updated GSM dissectors display filters per checkfiltername.pl
...
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name.
svn path=/trunk/; revision=44162
2012-07-31 18:54:11 +00:00
Jakub Zawadzki
b18e880040
Update FSF address - part II.
...
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Pascal Quantin
f0a74f3a5c
Upgrade GSM BSSMAP dissection to Release 9 (V9.8.0)
...
svn path=/trunk/; revision=43227
2012-06-12 21:36:55 +00:00
pascal
0ba1ab2909
Display Element ID in hexadecimal (like in 3GPP specs)
...
Display EPS bearer ID in decimal
svn path=/trunk/; revision=42755
2012-05-21 19:27:38 +00:00
pascal
254fcdfe19
Upgrade NAS dissector to Release 10 (v10.6.1)
...
svn path=/trunk/; revision=42728
2012-05-20 20:56:42 +00:00
Bill Meier
d53320919a
Remove unneeded #includes (stdlib, stdio, ctypes, time);
...
In a few cases: do some whitespace, indentation cleanup & reformatting.
svn path=/trunk/; revision=42632
2012-05-15 19:23:35 +00:00