Michael Mann
188aa9a80e
convert to proto_tree_add_subtree[_format]
...
Change-Id: Ib60ca75b7da8cfa21cfe2999c9b9448a02c332df
Reviewed-on: https://code.wireshark.org/review/2560
Tested-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-22 21:07:16 +00:00
Michael Mann
14824e6adf
Revert "Fixup: tvb_* -> tvb_captured"
...
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html
This reverts commit 246fe2ca4c
.
Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19 18:25:59 +00:00
Dario Lombardo
246fe2ca4c
Fixup: tvb_* -> tvb_captured
...
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18 14:14:58 +00:00
Alexis La Goutte
296591399f
Remove all $Id$ from top of file
...
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')
Fix manually some typo (in export_object_dicom.c and crc16-plain.c)
Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
Jakub Zawadzki
c45475ab45
Fix [-Wmissing-prototypes]
...
svn path=/trunk/; revision=54135
2013-12-15 23:44:12 +00:00
Chris Maynard
8cacdfa8ce
Reject the packet if data is NULL. Leave the DISSECTOR_ASSERT(actx != NULL) since get_asn1_ctx() also checks the signature.
...
svn path=/trunk/; revision=53953
2013-12-11 23:03:01 +00:00
Jakub Zawadzki
ea73d4a55c
Avoid calling find_dissector(), cache result of [new_]register_dissector()
...
svn path=/trunk/; revision=53353
2013-11-16 01:10:05 +00:00
Michael Mann
60e3e52a53
Have asn1_ctx_t passed into the "h245.gef.name" and "h245.gef.content" subdissectors instead of using pinfo->private_data.
...
svn path=/trunk/; revision=53055
2013-11-03 02:45:22 +00:00
Bill Meier
76d4b43a29
Minor whitespace, formatting & etc changes.
...
svn path=/trunk/; revision=52588
2013-10-13 18:14:59 +00:00
Michael Mann
98492c5619
expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicable
...
svn path=/trunk/; revision=50337
2013-07-03 02:59:31 +00:00
Michael Mann
2d37ec3cb0
Batch of filterable expert infos.
...
svn path=/trunk/; revision=49853
2013-06-09 03:28:05 +00:00
Anders Broman
ae74ef756b
From Neil Piercy:
...
AMR Frame Type uses wrong Value String.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8681
Applied by hand, patch not against trunk?
svn path=/trunk/; revision=49326
2013-05-16 05:08:16 +00:00
Jakub Zawadzki
c5a71b1006
String passed to val_to_str() must have int format specifier (%u, %d, %x, and so on...).
...
Fix some cases (easy to grep) by call to val_to_str_const().
svn path=/trunk/; revision=47807
2013-02-21 21:04:59 +00:00
Jeff Morriss
0266cceef3
Make all enum_val_t's const.
...
svn path=/trunk/; revision=46292
2012-11-29 20:15:37 +00:00
Bill Meier
52b516cfa9
General cleanup:
...
- Calls to expert...() and col_...() should not be under 'if (tree)'
- Move proto_reg_handoff...() to the end of the file as per convention;
- Localize a few variables
- Fix some whitespace (e.g., convert what appear to be '4 space tabs' to spaces)
svn path=/trunk/; revision=45591
2012-10-16 19:05:49 +00:00
Michael Mann
7fb78ec5b9
replace proto_tree_add_text with filterable items and expert info to get a few dissectors off of the checkAPIs.pl "naughty" list
...
svn path=/trunk/; revision=45572
2012-10-16 03:07:06 +00:00
Jeff Morriss
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki
b18e880040
Update FSF address - part II.
...
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Anders Broman
4d897229f6
bool value should be FALSE.
...
svn path=/trunk/; revision=42094
2012-04-16 13:29:57 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
2bf572bc41
Remove unneeded #includes: proto.h,tvbuff.h,value_string.h,stdlib.h,...
...
svn path=/trunk/; revision=38413
2011-08-08 17:59:32 +00:00
Anders Broman
0a65432f96
Use ENC_BIG_ENDIAN.
...
svn path=/trunk/; revision=38135
2011-07-20 14:09:19 +00:00
Alexis La Goutte
1b5e64fde6
Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=36708
2011-04-18 18:36:44 +00:00
Bill Meier
c6c91f8e76
Don't assign to a proto_item * if the value won't be used: Coverity 829 & 830;
...
Fix a minor bug wherein a number of proto_tree_add_...() used the wrong tree: Coverity 831;
Remove some unneeded #includes.
svn path=/trunk/; revision=36456
2011-04-04 17:49:32 +00:00
Gerald Combs
1b0516a27e
Fix various Visual C++ analysis warnings.
...
svn path=/trunk/; revision=35985
2011-02-17 19:43:16 +00:00
Anders Broman
d53865f5e3
Get rid of check_col().
...
svn path=/trunk/; revision=35823
2011-02-04 16:13:44 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Anders Broman
cfc7e8849c
Fix a couple of cut-n-paste errors.
...
svn path=/trunk/; revision=34865
2010-11-14 09:57:42 +00:00
Anders Broman
9afb5801bc
Fix a typo.
...
svn path=/trunk/; revision=34863
2010-11-13 20:09:01 +00:00
Anders Broman
2c042dcd15
Use value_string_ext.
...
svn path=/trunk/; revision=34845
2010-11-11 21:18:15 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Anders Broman
a291939fc3
Add AMR-WB to the rtp_dyn_payload_type table.
...
svn path=/trunk/; revision=32208
2010-03-16 09:12:24 +00:00
Kovarththanan Rajaratnam
17c9803cac
Sanitize epan includes
...
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman
680cf63be8
Dissect g722.2 H.245 paramaters.
...
svn path=/trunk/; revision=27972
2009-04-06 16:53:41 +00:00
Anders Broman
a7cf5b830d
Add frame type index filter for AMR if sent using bandwidth efficient mode.
...
Fix bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3148
svn path=/trunk/; revision=27078
2008-12-22 11:27:55 +00:00
Bill Meier
c544c20956
Fix various typos and spelling errors (mostly in text strings)
...
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Stig Bjørlykke
d0e33bc3c5
Fix some "format not a string literal and no format arguments" warnings.
...
svn path=/trunk/; revision=26646
2008-10-31 14:07:23 +00:00
Bill Meier
6aa5f8aa6a
Minor cleanup related to proto_reg_handoff
...
svn path=/trunk/; revision=26246
2008-09-22 16:26:41 +00:00
Bill Meier
ca34becf82
Minor cleanup primarily related to proto_reg_handoff; spacing changes
...
svn path=/trunk/; revision=26237
2008-09-19 20:42:01 +00:00
Anders Broman
6bcc12eabb
More Generic parameters.
...
svn path=/trunk/; revision=24022
2008-01-07 19:16:26 +00:00
Anders Broman
220484c1c2
From Chris Maynard:
...
Fix display filter field problems
Correct the template files in the case of generated dissectors.
svn path=/trunk/; revision=22622
2007-08-24 05:59:08 +00:00
Anders Broman
9a116d0bcf
From Stefan Wenk:
...
Following items are changed:
*) Bandwidth efficient decoding re-implemented with expert-info support.
The old implementation supported a single frame only.
*) Support for AMR-WB added
*) Fixes for IF1 and IF2 decoding
svn path=/trunk/; revision=22066
2007-06-08 05:04:54 +00:00
Bill Meier
103bf29730
Continuing the tradition: squelch some compiler warnings ....
...
svn path=/trunk/; revision=20866
2007-02-19 22:29:23 +00:00
Anders Broman
1e89a5daa8
Handle RFC 3267 Bandwidth-efficient mode.
...
svn path=/trunk/; revision=19769
2006-11-01 22:58:41 +00:00
Anders Broman
93f7312e1d
From Neil Piercy:
...
Just to add dissector name registration to the main IETF AMR dissector.
svn path=/trunk/; revision=18587
2006-06-27 19:16:38 +00:00
Anders Broman
949a2d9bf7
Handle the case with only one speech sample.
...
svn path=/trunk/; revision=18226
2006-05-27 18:25:08 +00:00
Ronnie Sahlberg
feab79e328
change a whole bunch of ethereal into wireshark
...
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Jörg Mayer
f9a57f08d1
Bill Meier:
...
Spelling fixes.
svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00