Commit Graph

29 Commits

Author SHA1 Message Date
Pascal Quantin f2e85a5a96 Display expert codes in hexadecimal (less painful for my eyes :))
svn path=/trunk/; revision=43497
2012-06-26 19:36:08 +00:00
Jeff Morriss 3fa645481f Followup to r43176, r43177, r43178, and r43179: prohibit FT_*INT*
with BASE_NONE (or other future display values).

Don't use BASE_NONE with FT_UINT32s in the expert info fields.

svn path=/trunk/; revision=43412
2012-06-20 17:25:53 +00:00
Anders Broman ff47bdf96c Use the expert system to show packet comments.
The packet comment widget should be replaced by a ListView with two columns,  packet no and Comment.

svn path=/trunk/; revision=41322
2012-03-02 13:31:16 +00:00
Chris Maynard 0a1072b083 Treat expert info as a <field> instead of a <proto> when exporting to pdml.
svn path=/trunk/; revision=40204
2011-12-14 21:13:06 +00:00
Stig Bjørlykke 4e20e37aa6 Use ENC_NA for FT_PROTOCOL.
svn path=/trunk/; revision=38125
2011-07-19 19:37:58 +00:00
Stig Bjørlykke 0d128b2c87 Revert r37702 in favour of r37705 for bug 6035.
svn path=/trunk/; revision=37706
2011-06-19 10:15:58 +00:00
Stig Bjørlykke 5faf9008af Use BASE_DEC for expert.group and expert.severity.
This fixes bug 6035.

svn path=/trunk/; revision=37702
2011-06-18 22:52:00 +00:00
Anders Broman 07cd05fa52 Use PI_UNDECODED instead.
svn path=/trunk/; revision=37392
2011-05-25 13:17:51 +00:00
Anders Broman ccecf5b98b Add a convinience function to add expert warnings for not dissected items.
svn path=/trunk/; revision=37391
2011-05-25 11:05:23 +00:00
Martin Mathieson e88b2f1fc9 Make frames containing Malformed expert items match with "malformed" display filter.
svn path=/trunk/; revision=33551
2010-07-16 11:17:32 +00:00
Jaap Keuter 9417ceec42 Clean up implementation.
svn path=/trunk/; revision=32039
2010-02-27 22:12:43 +00:00
Gerald Combs 2efa26e0e1 Fix a double-free bug which was causing a crash. Our decryption buffer
length doesn't change, so allocate it just once. Add an expert item for
a successful decryption.

svn path=/trunk/; revision=31571
2010-01-19 19:28:30 +00:00
Stig Bjørlykke 29a4a0789a Added expert info group PI_PROTOCOL.
svn path=/trunk/; revision=31308
2009-12-18 15:13:44 +00:00
Bill Meier 53b061495d Whitespace changes
svn path=/trunk/; revision=30210
2009-09-30 13:04:06 +00:00
Anders Broman 3a13c1a2a4 Modified extarct from Didier Gautheron:
optimizations patch http://wiki.wireshark.org/Development/Optimization
'patch.29854.diff.gz"

- ei->protocol is a constant.
- Don't setup expert tap data if there's no tap.

svn path=/trunk/; revision=29873
2009-09-13 13:39:09 +00:00
Kovarththanan Rajaratnam 0e5cef61be Split a bunch of init routines into init() and cleanup(). This allows us to free memory properly on shutdown.
This is an initial step. There's still some work to do.

svn path=/trunk/; revision=29754
2009-09-06 18:25:23 +00:00
Kovarththanan Rajaratnam 083729e02c Add PTREE_FINFO and use PITEM_FINFO when possible.
svn path=/trunk/; revision=29355
2009-08-09 17:57:31 +00:00
Stig Bjørlykke 3653b21838 Added missing PI_DEBUG to expert_group_vals[].
svn path=/trunk/; revision=28636
2009-06-04 14:22:16 +00:00
Bill Meier 4f34bb9b15 From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
- As suggested actually use sizeof(...) rather than a numeric constant.
  - g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.

svn path=/trunk/; revision=27772
2009-03-18 15:03:46 +00:00
Stig Bjørlykke d52fd5e311 From Jakub Zawadzki and me (bug 3283):
Added display filter for packets with expert info.

svn path=/trunk/; revision=27668
2009-03-09 00:26:25 +00:00
Ulf Lamping 3b509e89ae - add a column for the expert info severity level
- fix a column related bug introduced in SVN 20118

svn path=/trunk/; revision=22387
2007-07-23 20:11:05 +00:00
Stephen Fisher 2896811274 Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
Comment out -Werror in plugins/asn1/ until warnings can be fixed.


svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
Ulf Lamping d4499eb9a7 move value_strings from expert_dialogs into expert.c to remove duplicates
keep the highest severity level of the current file (experimental)

svn path=/trunk/; revision=19104
2006-08-31 22:56:38 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Jaap Keuter 20707c71ec Assure that pinfo is a valid pointer. Related to Coverity CID 112
svn path=/trunk/; revision=17601
2006-03-12 16:42:10 +00:00
Luis Ontanon 8e121c003c Don't se_leak expert_info records.
se_alloc them where and if  needed, not every time expert_set_info_vformat is called.


svn path=/trunk/; revision=17293
2006-02-13 23:20:38 +00:00
Ulf Lamping 5d66658184 from Greg Morris:
Composite Expert statistics, see: 
http://www.ethereal.com/lists/ethereal-dev/200511/msg00002.html
and the following discussions

svn path=/trunk/; revision=16593
2005-11-25 23:42:52 +00:00
Guy Harris d8873511a7 Frame numbers are unsigned, and they start at 1; 0 is what's used for
"unknown" for frame numbers.  Note that in epan/frame_data.h, and make
the frame number in experts unsigned, and use 0 for "unknown", and
display it as an unsigned number - and, if it's 0, don't display it at
all.

Fix the signature of "expert_dlg_draw()" to match what a tap's draw
routine's signature is expected to be.

svn path=/trunk/; revision=15760
2005-09-11 22:25:33 +00:00
Ulf Lamping 642467ad5c I'm adding the "Expert Info" prototype now, as it seems to be in a state where others might have a look and probably already find it useful :-). Anyway, we can easily disable it at one or two places in the code if it get's in our way of a new release.
Please see: http://wiki.ethereal.com/Development/ExpertInfo for a complete overview of the intended feature and it's current state of implementation.

While I'm working on this, I've also added some more status result codes to the DCE/RPC and DCOM dissectors.

svn path=/trunk/; revision=15754
2005-09-11 16:55:34 +00:00