Commit Graph

77407 Commits

Author SHA1 Message Date
Stefan Metzmacher bc5a7061a2 packet-kerberos: more PADATA-TYPE values/generate kerberos_PADATA_TYPE_vals
The new PADATA-TYPE values taken from rfc6113.txt

Change-Id: I42e50996c5694c34fc4714189b2e004bbbd501cf
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36453
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18 10:49:10 +00:00
Stefan Metzmacher b970a6bf51 packet-kerberos: always remember the toplevel msg_type in MESSAGE-TYPE
This will be useful in the following commits.
In the end there will be some recursion when dissecting FAST messages
and we'll need to know if the toplevel message.

Change-Id: I20f7ea81a8328c422785a44e3647ae2f749b89cc
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36455
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18 07:52:36 +00:00
Stefan Metzmacher 85147a17d1 packet-kerberos: avoid using actx->private_data for two different things
Let's always use kerberos_private_data_t and give it a pointer
to the optional callbacks.

Change-Id: I521bc62b98a5294ae7c307a47b64d2bd117a810e
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36473
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18 07:49:57 +00:00
Guy Harris c38f97aa22 Add support for more monitor opcodes.
Support more of what current Linux kernels generate.  We don't yet
dissect control event payloads.

While we're at it:

Opcodes are defined in the kernel source in decimal; define and show
them as decimal.

Use #defines for a bunch of enumerated values, such as opcodes

Show the opcode's numerical value in the Info column if it's not one we
know about.

Change-Id: I915981a46d1a4a544a5e036e69d9a9de8cb8cb30
Reviewed-on: https://code.wireshark.org/review/36487
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-18 06:56:22 +00:00
Jason Cohen ac82fd6353 f5ethtrailer: Add support for version 4 of low noise trailer
Change-Id: Ibdcfdd675f5c1e86b15f36f9a6c28b73e13c1616
Reviewed-on: https://code.wireshark.org/review/36480
Reviewed-by: Jason Cohen <kryojenik2@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-17 12:09:51 +00:00
Dylan Ulis ae2e83f2d8 CIP Safety: Change MacID to NodeID
This matches the wording in the Spec.

Change-Id: I566da78e88ff5aaa832c657dd74b5c590ee6b4aa
Reviewed-on: https://code.wireshark.org/review/36479
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-17 10:19:30 +00:00
Dario Lombardo fbca66fc8d rtcp: extend mantissa and bitrate to 64 bit.
This is required to allow the maximum valid exponent (63) to
be used.

Bug: 16445
Change-Id: I1473cebbe74a59785f03a882e3bc1af4b881d444
Reviewed-on: https://code.wireshark.org/review/36451
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-17 10:19:10 +00:00
Moshe Kaplan 4a8da5fbde wslua: Fix crash on TvbRange:__tostring for a zero-length TVB
Fields such as 'frame.time_delta' have no byte selection, they are added
with offset 0 and length 0, and evidently 'ws_tvb' is NULL. As
tvb_bytes_to_str expects a non-NULL tvb, explicitly check for this and
add a dummy placeholder. This is intended to be a human-readable string,
so prefer `<EMPTY>` over an empty string.

Change-Id: I32efe4cbefc6bcf0fa9fb94fcf25d7bf1628f3a7
Reviewed-on: https://code.wireshark.org/review/36440
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-16 22:42:03 +00:00
Peter Wu 2b50d124ec tools: do not install doxygen
Most people will never generate API documentation by running the
'wsar_html' target and will not notice any feature degradation.

On Ubuntu 18.04, doxygen depends on libclang1-6.0 (and indirectly
libllvm6.0), 108M can be saved by not installing these.

Change-Id: I51b58f4106696b5475c48afcdaed256f9a97cc81
Reviewed-on: https://code.wireshark.org/review/36416
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-16 21:55:32 +00:00
Stefan Metzmacher 5cb8343fb9 packet-dcerpc-netlogon: dissect and verify NETWORK_LOGON messages
We try to dissect the NTLMv2 blob and
verify the nthash against our keytab.

Change-Id: Ia33e91bcd89f72e7468f61756f0eafe9df92356d
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36406
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-16 10:37:39 +00:00
Stefan Metzmacher c67b8c4f29 packet-dcerpc-netlogon: remove unused '#ifdef HAVE_KERBEROS'
get_md4pass_list() is always available, it just returns 0
if HAVE_KERBEROS is not available.

Change-Id: I7fd8613b48c5b02f8693fa6ee15f5f38ed10643e
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36447
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2020-03-16 08:30:34 +00:00
Guy Harris 8e76178fcd Fix reporting of interface-list-fetching errors.
If the attempt to fetch the list of local interfaces failed, the model
will be empty, so "model is empty" doesn't imply "no interfaces found".
First, check whether there was an error, and report the error string;
otherwise, if the list is empty, report "No interfaces found." (and fix
the capitalization while we're at it) and, otherwise, return an empty
string.

Also, if pcap support wasn't configured in at compile time, skip all
that, and just return a string indicating that.

Change-Id: I498226888272e1bdede2355cc902f8a74b0cce72
Reviewed-on: https://code.wireshark.org/review/36446
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-16 06:51:50 +00:00
Tomasz Moń eb7774e4c1 Qt: Improve tcptrace graph drag responsiveness
Subclass QCPErrorBars with implementation that never accepts clicks.
This prevents a lot of square root computations in QCustomPlot
mousePressEvent handle and results in usable tcptrace graph.

An alternative solution to the poor performance problem could be using
QCP::srmCustom SelectionRectMode. I don't know how to implement graph
drag with QCP::srmCustom, and thus I went with simple subclass approach.

Bug: 16281
Change-Id: Id4178e59bdbd2222db4669d0635ff741ebde839f
Reviewed-on: https://code.wireshark.org/review/36413
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-16 05:05:48 +00:00
Dario Lombardo d87bce7c4f capture-wpcap: gracefully exit when has_wpcap is false.
Fix rawshark crash.

Bug: 16442
Change-Id: Id65f160d86a4ab204eedd1369e3ed9fa36f9c9e0
Reviewed-on: https://code.wireshark.org/review/36445
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 23:27:29 +00:00
Guy Harris 5b4af5b65b Remove unwanted newline.
The error message is included in parentheses as part of a larger error
message, so you don't want a newline at the end.

Change-Id: Iabff74941972504770c45b94b124e25d124b512c
Reviewed-on: https://code.wireshark.org/review/36441
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 21:06:16 +00:00
Filipe Laíns c14a887b2e USB HID: add missing usage pages
- Haptics
- Eye and Head Tracker
- Sensor
- Brailie Display
- Lighting and Illumination
- Gaming Device
- FIDO Alliance

Change-Id: I1e90bd8544b8327f376143226c7a1ea427c01277
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/36410
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-03-15 19:23:32 +00:00
Balint Reczey b5593553d4 debian: Ship codecs libraries in libwireshark0
Bug: 16430
Change-Id: I2f9b07be780d39c75898bba06fa6fb66b9895c88
Signed-off-by: Balint Reczey <balint.reczey@canonical.com>
Reviewed-on: https://code.wireshark.org/review/36433
Reviewed-by: Balint Reczey <balint@balintreczey.hu>
Petri-Dish: Balint Reczey <balint@balintreczey.hu>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 16:55:31 +00:00
Guy Harris 6bd6b1df78 More modeline fixes to put HT tab stops every 8 characters.
Change-Id: If3ea65f24e33b89784b3d9a1e7009d09728d4f7a
Reviewed-on: https://code.wireshark.org/review/36437
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 16:14:49 +00:00
Gerald Combs d77a8669df WSUG: Update the Service Response Time section.
Update the Service Response Time section of the User's Guide. The sample
captures page had a nice SMB2 capture file, so use that for the example.

Use title case for "Diameter" to match the RFCs.

Change-Id: Icff510dbe2d77db9cd42548ad58439d17282e851
Reviewed-on: https://code.wireshark.org/review/36421
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-15 16:12:57 +00:00
Mikael Kanstrup 16c315ca32 dot11decrypt: Let libgcrypt handle AES unwrap
From version 1.5.0 of libgcrypt there's support for AES unwrap. Use the
libcrypt function when available.

While at it also make AES_unwrap a static function of dot11decrypt.c

Change-Id: I4f69a766df3ea19ce25122e8d2fd1086f440995b
Reviewed-on: https://code.wireshark.org/review/36431
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-15 14:55:01 +00:00
Tomasz Moń 1d20a875e4 Qt: Fix bug causing hidden columns to be displayed
Set capture file for model and header before columnsChanged() is called
to prevent skipping model reset in PacketListModel::resetColumns() due
to cap_file_ being NULL.

Do not strech last section in packet list header. This prevents
QHeaderViewPrivate::resizeSections() from messing up the column sizes
via resize events. For some reason (unknown to me) underlying
QHeaderView implementation has different idea about the number of
visible columns than our code.

Ping-Bug: 16063
Change-Id: I482c1080adb418b7922ee99d357d4962dc086026
Reviewed-on: https://code.wireshark.org/review/36120
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2020-03-15 12:07:06 +00:00
Guy Harris 0039505dd1 Tab stops are always always always always always every 8 spaces.
That is the rule of UN*X, engraved on stone by Ken and Dennis, and
there's plenty of software used to display and edit Wireshark source
that hardwires the tab stops there.(including Boring Old cat And more).

Pick any indent you want, but do *not* put tab stops every 4 spaces,
even if putting them every 8 spaces requires you to hit your IDE over
the head to accept that.

Change-Id: I58f7c459ce2d72096f67e650afe74f2637f38649
Reviewed-on: https://code.wireshark.org/review/36434
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 11:31:24 +00:00
Guy Harris 0f0e486b91 Put common code into get_interface_list_findalldevs_ex().
Remove duplication of code.

Change-Id: I7cd1bd73ee9eda962a37468cadb72de291f1ec6a
Reviewed-on: https://code.wireshark.org/review/36432
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 10:13:39 +00:00
Filipe Laíns c939ef8246 USB HID: update modelines to match the current code style
Change-Id: Id106b1cc94038879a17970b5e9722f04bfb35df2
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/36423
Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-03-15 09:53:53 +00:00
Guy Harris 8cac5c0a3a Check for "is wpcap.dll loaded"? when getting the remote interface list.
That check is required for remote capture just as it's required for
local capture.

Change-Id: I9341ef4aeeef706db9728c8abb8531bec8306bdc
Reviewed-on: https://code.wireshark.org/review/36430
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 09:41:49 +00:00
Gerald Combs ee39cd988f [Automatic update for 2020-03-15]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ib60abbe864e82b50de408d4b89236f022cae6ffc
Reviewed-on: https://code.wireshark.org/review/36426
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-03-15 08:17:19 +00:00
Filipe Laíns b4da2c09d2 USB HID: fix incorrect format string when annotating top level rdesc items
Change-Id: Iaac5f85e75e93278e2c485bd2e52756ac23f6e9a
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/36390
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-03-15 07:30:03 +00:00
Tony Ciavarella 9567bf0595 packet-dis: fix dissection of Entity State Update PDUs
The dissector for Distributed Interactive Simulation reports malformed packets
for Entity State Update PDUs because the offset for the Number of Variable
Records field is off-by-one.  The Padding field dissection is also off-by-one.

This change fixes the problem by not incrementing the offset returned by the
parseField_Entity function which is already past the Entity ID field.  The
offset must be incremented after dissecting the Number of Variable Records
field to get to the start of the Entity Linear Velocity.

Change-Id: I942123be7a1d4e4e4fc587f757cb030a3daf8ef2
Reviewed-on: https://code.wireshark.org/review/36420
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-15 06:08:54 +00:00
Guy Harris fd34c09ffe Remove an out-of-date comment.
We always use pcap_findalldevs(), as we now require it.

Change-Id: Ia0897ccd80c836dbb8b5f1d9890cf8d4aef05c14
Reviewed-on: https://code.wireshark.org/review/36425
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 02:10:16 +00:00
Guy Harris eee9f0e4aa Remove no-longer-necessary tests.
wpcap.dll now won't load if pcap_findalldevs() or pcap_freealldevs() are
missing, so if it's loaded, we know they were found.

Change-Id: I981816561c1213a4c5c60fae90bd05dbbb9d2f1d
Reviewed-on: https://code.wireshark.org/review/36424
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 01:24:06 +00:00
Guy Harris c4f652397b Don't check for ancient libpcap versions on HP-UX.
We require libpcap 0.8 or later, so somebody's *really* have to go out
of their way to get a version of Wireshark running with a pre-0.6
libpcap.

Change-Id: I329b3a37cd37ca5d9e76db447daabfe1dc47e75d
Reviewed-on: https://code.wireshark.org/review/36422
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15 00:55:37 +00:00
Stefan Metzmacher e091ee5212 packet-dcerpc-netlogon: add expert info to dissect_secchan_verf()
It's good to see where the session key for decryption was learned.

Change-Id: I2c18c6367eb60796744a3a4d4330244493c29688
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36405
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 22:27:50 +00:00
Stefan Metzmacher 44c923737f packet-dcerpc-netlogon: add expert info for NetrServerAuthenticate*
It's useful to see which keys where used, if we have a keytab to
verify things!

Change-Id: I77d887cd28b8ebe57c6c897797b0ab320a390699
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36404
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 22:27:40 +00:00
Stefan Metzmacher b26ea6eab2 packet-dcerpc-netlogon: let NetrServerAuthenticate use common code
By passing a real int version to
netlogon_dissect_netrserverauthenticate023_reply() it can also
handle NetrServerAuthenticate instead of only
NetrServerAuthenticate2 and NetrServerAuthenticate3.

Change-Id: Icb3aa3aee52a844b3c34c4bce8b7b3a65f0bdae7
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36403
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 19:51:38 +00:00
Stefan Metzmacher 0e7e70ac96 packet-ntlmssp: add expert info for session keys too
Change-Id: I65a99a31524bcf96e434f4313a3fa0663bd31801
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36412
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 19:51:16 +00:00
Mikael Kanstrup e83b3aead7 tests/suite_decryption: Skip CCMP-256 test with libgcrypt < 1.6
CCMP-256 decryption support is only available with libgcrypt >= 1.6 so
skip corresponding test if lib is too old.

Fixes: v3.3.0rc0-733-geed31f13be ("ieee80211: Add CCMP-256 decryption support")
Change-Id: I6145f2ec49e19d1356915b9b1d8da54332a4a16a
Reviewed-on: https://code.wireshark.org/review/36414
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-14 17:53:48 +00:00
Mikael Kanstrup cf4c0552e7 ieee80211: GCMP decryption support
Add support for decrypting GCMP/GCMP-256 encrypted IEEE 802.11 traffic

Bug: 16197
Change-Id: I907d772665141c8be10a9f4a187bd76594c8d2e4
Reviewed-on: https://code.wireshark.org/review/36346
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-14 17:53:36 +00:00
Stefan Metzmacher f3a9d9abed packet-ntlmssp: factor out a ntlmssp_create_session_key() helper
This can also be used by packet-dcerpc-netlogon later.
in order to verify authentications.

Change-Id: I2f145ee1197fc83c77efabc180bac52ebbb0cd60
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36400
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 17:53:21 +00:00
Stefan Metzmacher b30e823301 packet-ntlmssp: cleanup the setup of conv_ntlmssp_info->client_challenge
Change-Id: I7c5baa7dfcc158919de125743dc890756fb95de1
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36399
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 17:52:59 +00:00
Stefan Metzmacher d835d59290 packet-ntlmssp: rename gbl_nt_password to ntlmssp_option_nt_password
This is no longer required to be global.

Change-Id: I38c308888ede32780722e68d2bab691bd659d143
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36411
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 17:52:15 +00:00
Peter Wu 7e89bd873a gitlab-ci: test nopcap build with gcc-7 instead of gcc-8
gcc-7 is included with build-essential on Ubuntu 18.04, not installing
an additional gcc-8 saves 110M on disk. The coverage should more or less
be the same, even very old compilers will catch typical build failures.

Change-Id: I03c95dcd1c83b02390489a47de7e2a8d2d757232
Reviewed-on: https://code.wireshark.org/review/36415
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-14 16:56:30 +00:00
Filipe Laíns 01f706af65 USB HID: fix interpretation of unit exponent field
Change-Id: Id9752da61cca8a00e98049d7cf3f990e9199a684
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/36395
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-03-14 16:16:27 +00:00
Stefan Metzmacher 14c71587ef packet-dcerpc-netlogon: make use of get_md4pass_list() from packet-ntmssp
Change-Id: Ide0dd6464a72640c03ad00a9a5a00c5f73d13299
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36402
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 15:50:30 +00:00
Stefan Metzmacher fff3776cdd packet-ntlmssp: export get_md4pass_list() to be used in packet-dcerpc-netlogon
We only need that logic once.

Change-Id: Ibc3e28c70dd6e52de3cbc8d5dca0316816f70e5d
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36398
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 15:05:56 +00:00
Stefan Metzmacher d430932b4e packet-ntlmssp: don't pass 'gbl_nt_password' to create_ntlmssp_v[1|2]_key()
Instead use it directly where needed.

I follow up patch will rename gbl_nt_password to
ntlmssp_option_nt_password and make that static to packet-ntlmssp.c

Change-Id: Iceb75ebbdb70814cb4a235ad3e8ed5e9ec2be10c
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36397
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 15:05:38 +00:00
Stefan Metzmacher d947c7d8a2 packet-dcerpc-nt: split out cb_str_postprocess_options()
Change-Id: I4e6b5bada1247fda34f4380027756f6ebb7482e4
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36401
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-14 14:50:25 +00:00
Filipe Laíns 8882c22851 USB HID: dissect the missing fields from input/output/feature items
We try to provide as much useful information as we can in the top level
item without it being too much. The approach on how to handle theese
items was copied from hid-tools.

Change-Id: I1c6b24c6fcd989b5188391cad8e7a629c58beebb
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/36391
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-03-14 11:56:38 +00:00
Filipe Laíns 64c3b2dfff USB HID: provide item string for the unicode usage page
Change-Id: Ib3db8854cc05c716ae4951b03caf452683c2e917
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/36393
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-03-14 09:31:50 +00:00
Filipe Laíns 975d99cbac USB HID: have a consistent style
Change-Id: I2c2b89e6f7d2bce6af3043365d3f4c771044420b
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/36392
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-03-14 08:46:59 +00:00
Filipe Laíns 93f5d130c9 USB HID: fix bug where logical min/max were being dissected as unsigned
Change-Id: Icf1b1b591ad76e2082b14344db19f1c0e8601455
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/36389
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-03-14 08:43:55 +00:00