Chris Maynard
baf569188a
Reject the packet if data is NULL.
...
svn path=/trunk/; revision=53709
2013-12-02 02:31:33 +00:00
Chris Maynard
9b38829b34
Reject the packet if data is NULL without doing anything else.
...
svn path=/trunk/; revision=53708
2013-12-02 02:31:04 +00:00
Chris Maynard
acc5fd78e4
Reject the packet if data is NULL.
...
svn path=/trunk/; revision=53707
2013-12-02 02:18:21 +00:00
Chris Maynard
42a64c3557
If data is NULL, the bug, if any, is not with *this* dissector, but with whichever one failed to pass the data properly.
...
svn path=/trunk/; revision=53706
2013-12-02 02:07:42 +00:00
Chris Maynard
a9900375b4
Fix Coverity CID 1134045: Printf format string issue. (As documented in the printf man page for the ' option, "Note that many versions of gcc(1) cannot parse this option and will issue a warning." (r47940 reverted a similar change, so this keeps things consistent.)
...
svn path=/trunk/; revision=53705
2013-12-02 01:53:13 +00:00
Chris Maynard
87d36305f9
Fix Coverity CID 1134046: Structurally dead code.
...
svn path=/trunk/; revision=53704
2013-12-02 00:45:44 +00:00
Anders Broman
9baa93519c
Update to V11.7.1 (2013-09)
...
svn path=/trunk/; revision=53700
2013-12-01 20:34:21 +00:00
Michael Mann
0c9aa51ec5
Patch to include YAML export. Bug 9452 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452 )
...
From Deon van der Westhuysen
From me: use switch statements instead of if-else
svn path=/trunk/; revision=53698
2013-12-01 15:44:22 +00:00
Michael Mann
7ee8d48670
Add MPLS dissector to "ppp.protocol" table. Bug 9492 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9492 )
...
From Peter Paluch
svn path=/trunk/; revision=53694
2013-12-01 13:47:11 +00:00
Jörg Mayer
402df00544
Looks like the problem with redefined symbols is not new, it
...
just got a few new ones.
Add HAVE_STRING_H and HAVE_STDLIB_H to the list.
svn path=/trunk/; revision=53691
2013-12-01 10:10:24 +00:00
Martin Mathieson
a9bd097e71
Start teid_data field from the correct offset
...
svn path=/trunk/; revision=53688
2013-12-01 08:52:06 +00:00
Martin Mathieson
da7af5c1f7
Also add filter and expert info for ICMPv6 requests with no responses.
...
svn path=/trunk/; revision=53687
2013-12-01 08:51:07 +00:00
Michael Mann
9972e5f24a
Move codecs.[ch] out of epan and into codecs directory.
...
This may break easy_codec plugins, but it appears a better/more consistent way is needed to register codecs. See Guy's comments in bug 7893 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893 )
svn path=/trunk/; revision=53686
2013-12-01 03:53:57 +00:00
Michael Mann
ac9b982868
Better fix for uninitialized variable warning. Part of bug 9452 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452 )
...
From Peter Wu.
From me: Leave the "result" variable initialized because I'm not sure code analyzers will consider g_assert_not_reached() enough prevention from using uninitialized "result"
svn path=/trunk/; revision=53679
2013-11-30 21:00:21 +00:00
Michael Mann
e2d2d12098
Replace "btsdp" tap with function to query service_infos tree, since that's all dissectors were doing with it. Not used outside of dissectors and cuts down on a few redundant global variables.
...
svn path=/trunk/; revision=53677
2013-11-30 19:26:18 +00:00
Pascal Quantin
021efe411c
Try to please GCC 4.3.2
...
svn path=/trunk/; revision=53675
2013-11-30 12:31:36 +00:00
Guy Harris
d62b116380
Make the code testing the Rx MCS Bitmask subfield of the Supported MCS
...
Set field of the HT Capabilities element a bit clearer, and add
comments.
Fix it so it doesn't assign a variable to itself, as clang warns about
that.
svn path=/trunk/; revision=53674
2013-11-30 10:17:30 +00:00
Pascal Quantin
4e3d8291fe
From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9490 :
...
Couple packets in RTPproxy dissector not only with CookieID but also with Call-IDs
svn path=/trunk/; revision=53673
2013-11-30 09:50:04 +00:00
Michael Mann
e1532f39ec
Tx MCS set is not interpreted properly in WLAN beacon frame. Bug 8894 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8894 )
...
#BACKPORT
svn path=/trunk/; revision=53670
2013-11-30 01:35:03 +00:00
Michael Mann
6d3d1556dc
STANAG 5066 DTS Layer dissector. Bug 9217 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9217 )
...
From İbrahim Can Yüce
From me: Update to new tcp_dissect_pdus format, minor whitespace issues noticed in wiretap files.
svn path=/trunk/; revision=53669
2013-11-30 01:18:22 +00:00
Michael Mann
00737f834b
Add wifi display port to the RTSP dissector. Bug 9339 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9339 )
...
From chaitanya
From me: Add another obsolete preference and cleanup whitespace
svn path=/trunk/; revision=53667
2013-11-30 00:30:56 +00:00
Guy Harris
216f631e8a
Casts required from void * in C++.
...
svn path=/trunk/; revision=53664
2013-11-30 00:05:24 +00:00
Guy Harris
1d80b1e16c
Constify to squelch some warnings.
...
svn path=/trunk/; revision=53663
2013-11-30 00:02:46 +00:00
Guy Harris
52cfff996e
Squelch some "use parentheses" warnings.
...
Use tab indentation uniformly.
svn path=/trunk/; revision=53662
2013-11-29 23:57:23 +00:00
Guy Harris
488e61fea0
Rename variable to avoid collisions with standard function names.
...
Use the st_format_type type.
svn path=/trunk/; revision=53661
2013-11-29 23:54:12 +00:00
Guy Harris
1ca96130b3
A typedef has to actually define a type.
...
svn path=/trunk/; revision=53659
2013-11-29 23:46:48 +00:00
Pascal Quantin
68c8c7ef0a
From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9487 :
...
Use RTP payload descriptions from RTP dissector in RTPproxy codec param value
svn path=/trunk/; revision=53658
2013-11-29 22:56:34 +00:00
Michael Mann
60d6b05e23
Stats_tree enhancements for sorting, averages and burst rate. Bug 9452 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452 )
...
From Deon van der Westhuysen
- Bug fix: object leak in stats_tree after a tap reset (for example apply statistics preferences with a stats_tree window open)
- Bug fix: correct sample code in README.stats_tree
- Add: slash in plug-in name now creates submenu as docs describe (was a bug?)
- Add: menu separator before the stat_tree registered plug-ins
- Add: stats_tree can now calculate averages for nodes; automatically calculated for range nodes. Add section in README.stats_tree describing averages.
- Add: stats_tree can now calculate burst rate of each node (like rate but with a shorter, sliding time window)
- Add: sorting for stats_tree plug-ins. Can sort on node name, count, average, min, max values and burst rate.
- Add: preferences for stats_tree system (default sort column, burst calc params)
- Add: stats_tree window copy to clipboard and export and plain text, csv and XML.
- Added sample of new functionality in $srcdir/plugins/stats_tree/pinfo_stats_tree.c
- Moved all stats_tree sample plug-ins to "IP Statistics" submenu.
svn path=/trunk/; revision=53657
2013-11-29 22:47:59 +00:00
Jakub Zawadzki
82e2675f45
Avoid including <wiretap/wtap.h> in dissectors.
...
svn path=/trunk/; revision=53655
2013-11-29 20:53:00 +00:00
Jakub Zawadzki
d99fdfda63
Replace macros: BSWAP16, BSWAP32, BSWAP64 with glib-version.
...
XXX, people are not aware that expression of this macros might be evaluated multiple times, like:
- BSWAP16(tvb_get_letohs(tvb, off)) : \
+ GUINT16_SWAP_LE_BE(tvb_get_letohs(tvb, off)) : \
Should be tvb_get_ntohs() called?
svn path=/trunk/; revision=53653
2013-11-29 19:21:20 +00:00
Jakub Zawadzki
5ac6474c94
Rename some of pint.h macros to match common style (bits number on the end).
...
pntohs -> pntoh16
pntohl -> pntoh32
pletohs -> pletoh16
pletohl -> pletoh32
phtons -> phton16
phtonl -> phton32
svn path=/trunk/; revision=53652
2013-11-29 18:59:06 +00:00
Jakub Zawadzki
288efa5128
Expand macros: htoles(), htolel(), htolell()
...
svn path=/trunk/; revision=53651
2013-11-29 18:44:00 +00:00
Michael Mann
9c9a038428
General "Prosody" placeholder parameter ("prosody-") is broken down to a 6 new "Prosody" specific parameters. Bug 9425 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9425 )
...
From zeljko
svn path=/trunk/; revision=53650
2013-11-29 17:51:56 +00:00
Martin Mathieson
73f042aa35
Fix number of selected bytes for gtp.teid_data. Also remove some stray tabs and unneeded _U_
...
svn path=/trunk/; revision=53649
2013-11-29 17:42:08 +00:00
Gerald Combs
27089d62a9
Clean up whitespace.
...
svn path=/trunk/; revision=53648
2013-11-29 15:46:50 +00:00
Michael Mann
bf9fdc8e8f
Bugfix timestamp formatting of Gigamon trailer. Bug 9433 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9433 )
...
From Sandeep Dahiya
svn path=/trunk/; revision=53646
2013-11-29 14:55:49 +00:00
Michael Mann
8821cb7e2d
Bugfixes of r53636, part of bug 9423 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9423 )
...
From DSR Corporation
svn path=/trunk/; revision=53645
2013-11-29 13:42:09 +00:00
Pascal Quantin
9a48c7e8da
Improve request / response tracking in case you have several open / close commands in the capture
...
svn path=/trunk/; revision=53644
2013-11-29 10:38:00 +00:00
Alexis La Goutte
5cb8483d82
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
...
svn path=/trunk/; revision=53642
2013-11-29 08:33:51 +00:00
Alexis La Goutte
09e1e860d4
Enable by default UDP conversation (Needed by udp.stream)
...
svn path=/trunk/; revision=53641
2013-11-29 08:02:39 +00:00
Alexis La Goutte
7e0645563a
Add udp.stream display filter
...
The result is the same filter used by Follow UDP (may be reuse the new filter in Follow)
svn path=/trunk/; revision=53640
2013-11-29 08:02:30 +00:00
Alexis La Goutte
110795132b
Add HTTP2 heuristic when it is encapsulated in SSL
...
the heuristic may be leak (only check if type > 10...)
svn path=/trunk/; revision=53638
2013-11-29 08:02:09 +00:00
Michael Mann
563cf65155
Improved ZCL dissectors. Bug 9423 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9423 )
...
From DSR Corporation
svn path=/trunk/; revision=53636
2013-11-29 03:40:16 +00:00
Gerald Combs
5acdfae070
Restore disabled "decode as" settings.
...
svn path=/trunk/; revision=53635
2013-11-29 03:14:24 +00:00
Jakub Zawadzki
9e0cd5d1d8
Fix typo (r53633) in one more place, fix typo in filename, make hex numbers capital.
...
svn path=/trunk/; revision=53634
2013-11-28 23:09:55 +00:00
Guy Harris
26446f8882
Fix (presumed) tpyo.
...
svn path=/trunk/; revision=53633
2013-11-28 22:36:10 +00:00
Jakub Zawadzki
3bbfb68ffa
Move MPEG section table id defines to packet-mpeg-sect.h
...
svn path=/trunk/; revision=53632
2013-11-28 22:31:55 +00:00
Pascal Quantin
37660f413b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9478 :
...
GSM SMS User Data header fill bits are wrong when using a 7 bits ASCII / IA5 encoding
svn path=/trunk/; revision=53631
2013-11-28 21:59:02 +00:00
Guy Harris
710feed2e0
GUINT_TO_POINTER() does just enough casting to suppress complaints about
...
32-bit integers and 64-bit pointers, so it needs to be handed a guint
(or equivalent type); it doesn't suppress warnings about 8-bit or 16-bit
integers, so those have to be cast up to guint first.
svn path=/trunk/; revision=53630
2013-11-28 20:40:46 +00:00
Michael Mann
a31d10208b
Bluetooth: HSP: Add support for HSP. Bug 9446 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9446 )
...
HSP is modest version of HFP.
From Michal Labedzki.
svn path=/trunk/; revision=53629
2013-11-28 18:33:26 +00:00