Commit graph

23 commits

Author SHA1 Message Date
Guy Harris
76258fe8e3 Constify a bunch of structure members and function arguments, to squelch
compiler warnings.

Clean up indentation.

svn path=/trunk/; revision=14739
2005-06-24 01:32:42 +00:00
Guy Harris
71217a8007 As we've made the tap_specific_data field of a tap_packet_t structure a
const pointer (so that we don't get complaints when we make the
tap-specific data argument to "tap_queue_packet()" a const pointer,
allowing dissectors to hand const data to a tap without a complaint), we
should make the tap per-packet function take a const pointer as an
argument as well.  Do so.

In some taps, use _U_, or actually use the argument, rather than
sticking in dummy "X = X" assignments to fake use of parameters.  (This
means that the tap functions in question no longer have the notion that
they act on a particular static structure wired in.)

svn path=/trunk/; revision=12910
2005-01-01 02:57:02 +00:00
Guy Harris
e75910e7cb In column sort routines, make the row pointers "const" pointers, as the
arguments passed in corresponding to those pointers are gconstpointers.

svn path=/trunk/; revision=12884
2004-12-31 00:33:54 +00:00
Guy Harris
8a8b883450 Set the svn:eol-style property on all text files to "native", so that
they have LF at the end of the line on UN*X and CR/LF on Windows;
hopefully this means that if a CR/LF version is checked in on Windows,
the CRs will be stripped so that they show up only when checked out on
Windows, not on UN*X.

svn path=/trunk/; revision=11400
2004-07-18 00:24:25 +00:00
Ulf Lamping
92ddb18b8c move "extern GtkWidget *main_display_filter_widget" from
various stats files to gtkglobals.h

svn path=/trunk/; revision=11073
2004-06-02 07:12:11 +00:00
Ulf Lamping
bd96071d8c rename context menu items:
Match -> Apply as Filter
Prepare -> Prepare a Filter
and prepended a ... at appropriate submenu items

svn path=/trunk/; revision=10814
2004-05-07 12:15:24 +00:00
Ronnie Sahlberg
55aab5b071 make service response time statistics work for "unknown" rpc programs.
all proicedures will however get "interesting" names such as "proc-1" etc
except procedure 0 which is ALWAYS "NULL"

svn path=/trunk/; revision=10557
2004-04-07 04:31:32 +00:00
Ulf Lamping
7b62a629e8 replaced sprintf / snprintf by g_snprintf,
various other string related changes

svn path=/trunk/; revision=10373
2004-03-13 15:15:26 +00:00
Guy Harris
6064ef84c2 Add a "force" argument to "filter_packets()" and
"main_filter_packets()", to force the filtering to be done even if the
filter is the same as the current one; this is necessary in order to
make sure "Follow TCP Stream" gets the packets processed even if you're
filtering the stream that's currently filtered in.

svn path=/trunk/; revision=10209
2004-02-23 22:48:52 +00:00
Ulf Lamping
5297f06717 replaced every appearance of gtk_scrolled_window_new() with
scrolled_window_new().
added gtk_scrolled_window_set_policy(AUTOMATIC,AUTOMATIC) to
scrolled_window_new()
added GTK2's gtk_scrolled_window_set_shadow(GTK_SHADOW_IN)
to every place needed

svn path=/trunk/; revision=9999
2004-02-06 19:19:12 +00:00
Guy Harris
1980fa5dbf Pass ESD_BTN_OK rather than NULL as a second argument to
"simple_dialog()"; NULL might be #defined to be a pointer expression on
some platforms, causing compiler warnings (and, on platforms where a
null pointer doesn't have all its bits 0, possibly causing misbehavior,
although I don't think there are any such platforms on which Ethereal
runs).

Don't allow 0 as button mask argument to "simple_dialog()".

Squelch a compiler warning.

Report fatal problems as errors, not warnings.

Report file I/O errors with "file_open_error_message()".

Report file write errors (including those reported by "close()", e.g.
some errors writing to an NFS server) when saving raw packet data to a
file.

svn path=/trunk/; revision=9915
2004-01-31 03:22:42 +00:00
Ulf Lamping
c890e29a99 apply automatically generated filters strings to the recent dropdown list,
e.g. when applying a "Follow TCP stream",
fix a bug in the recent function, discarding the newest entries when
saving a full list (now discarding the oldest).

svn path=/trunk/; revision=9849
2004-01-25 18:51:26 +00:00
Guy Harris
64bc566ea8 In GTK+ 2.x, "gtk_entry_get_text()" returns a "const gchar *"; assign
its value to pointer-to-const variables.

svn path=/trunk/; revision=9161
2003-12-04 00:45:39 +00:00
Ronnie Sahlberg
f16f83b154 update for LDAP
measure the response time for some LDAP commands and
add a service response time dialog for it

svn path=/trunk/; revision=8885
2003-11-05 09:04:17 +00:00
Ronnie Sahlberg
e75b86fab1 Add a ColorizeProcedure menu option to the ServiceResponseTime statistics dialog
svn path=/trunk/; revision=8659
2003-10-10 08:59:17 +00:00
Ronnie Sahlberg
8969b36861 Add a Find Next/Previous menu option to the ServiceResponseTimeStatistics dialog
svn path=/trunk/; revision=8658
2003-10-10 08:52:19 +00:00
Ronnie Sahlberg
95b3b8ca6d Add a popup to the ServicveResponseTime tables where the user can select
Prepare/Match/FindFrame similar to chat the ConversationList has.

Only enabled for SMB and ONC-RPC at this point

svn path=/trunk/; revision=8391
2003-09-05 10:26:44 +00:00
Ronnie Sahlberg
bb21d8c03c fix to various stats tables.
The code used to rely on min_time==0 to determine whether this was the first
packet or not and whereby we had to initialize min_time to the current value.

This obviously does not work for capture files with poor timestamp resolution
where the response time is actually, according to the capture file, 0
and we got all sorts of weird effects like average response time being less than the minimum response time.

note, the bug only affected the minimum response time in the tables and not max or average response time.
it would "miss" tose minimum response times that were ==0 and display the minumin response time in the capture that were >0

svn path=/trunk/; revision=8358
2003-09-03 10:10:18 +00:00
Gerald Combs
c150ac467b From Lars Roland: Fix the service response time functions to work with GTK2.
svn path=/trunk/; revision=7911
2003-06-22 04:00:21 +00:00
Ronnie Sahlberg
8165fcdfe8 Cosmetic bug.
When creating a new CList to display SRT stats,  make the DECEND arrow for
the second column be displayed since this is how the table will be sorted
by default

svn path=/trunk/; revision=7908
2003-06-21 06:45:49 +00:00
Ronnie Sahlberg
99addd9f7a Make the default sorting for the list be column 2 in descending order so we
get the rocedures with the most number of calls at the top.

Fix a bug added in previous checkin.
When the table can be sorted in different ways than just the procedure number sorted in ascending order, the row for a specific procedure may change everytime we drawi/sort the table.
Add code to keep track of which row a procedure is currently positioned at in the list so that we statistics are added to the correct entry.

svn path=/trunk/; revision=7906
2003-06-21 05:57:34 +00:00
Ronnie Sahlberg
f97314ba3d Update the ServiceResponseTime helper routines so that the columns
can be sorted.

"borrowed" lots of code for this from gtkclist.c

Columns 0,1  sort in ascending order by default
Columns 2-5 sort in ascending order by default

svn path=/trunk/; revision=7905
2003-06-21 05:39:45 +00:00
Ronnie Sahlberg
dea1a0a6e4 Break out the code for the ahndling of the Service Response Time (formerly known as RoundTripTime) table and change the table into a scrollable
CList.

As a first conversion to use the helper routines, convert DCERPC SRT statistics to use the new interface.
This prevents some interfaces (SAMR/LSA) that contains a huge number of procedures from creating a huge table that does not fir on the screen.

Later changes to the helpers may be to make the different columns sortable
or to hide those procedures that has not been seen in the capture.

svn path=/trunk/; revision=7903
2003-06-21 01:42:46 +00:00