FT_UINT16; the xDLC code requires control fields to be FT_UINTn, as it
uses "proto_tree_add_uint_format()" to add that field to the protocol
tree.
Always pass TRUE as the "is_extended" argument to
"dissect_xdlc_control()" - the V.120 spec says "The data link control
sublayer provides the procedures and formats of fields for data link
layer peer-to-peer communication. ... For formats and the elements of
procedures, see Recommendation Q.922", and Q.922 seems to at least allow
for modulo 128 operation; it also speaks of SABME, as does V.120, and I
*think* the "extended" in "Set asynchronous balanced mode extended"
means "modulo 128".
Dissect the terminal adaptation sublayer header field after dissecting
the control field, so that the V.120 tree shows the data in sequential
order.
Calculates the length of the V.120 header based on the control field
type (using the "XDLC_CONTROL_LEN()" macro) and the length of the
terminal adaptation sublayer header ("dissect_v120_header()" now returns
the length of what it dissects).
Call "dissect_data()" on the V.120 payload, so you at least know how
much data there is, and can click on an item to see it highlighted.
svn path=/trunk/; revision=1727
proto_tree_add_protocol_format()
proto_tree_add_uint_format()
proto_tree_add_ipxnet_format()
proto_tree_add_ipv4_format()
proto_tree_add_ipv6_format()
proto_tree_add_bytes_format()
proto_tree_add_string_format()
proto_tree_add_ether_format()
proto_tree_add_time_format()
proto_tree_add_double_format()
proto_tree_add_boolean_format()
If using GCC 2.x, we can check the print-format against the variable args
passed in. Regardless of compiler, we can now check at run-time that the
field type passed into the function corresponds to what that function
expects (FT_UINT, FT_BOOLEAN, etc.)
Note that proto_tree_add_protocol_format() does not require a value field,
since the value of a protocol is always NULL. It's more intuitive w/o the
vestigial argument.
Fixed a proto_tree_add_item_format-related bug in packet-isis-hello.c
Fixed a variable usage bug in packet-v120.c. (ett_* was used instead of hf_*)
Checked in Guy's fix for the function declearation for proto_tree_add_text()
and proto_tree_add_notext().
svn path=/trunk/; revision=1713
Guy Harris