Commit Graph

6 Commits

Author SHA1 Message Date
Gerald Combs b3e70f9a7e Qt: Refactor the packet list scroll bar.
Split OverlayScrollBar into parent and child scroll bar widgets. This
gives us two packet list scroll bars: a packet map, which draws and
operates on nearby packets and a normal scroll bar.

The packet map is drawn to the left of the child scroll bar. This gives
us more room to draw and doesn't obscure the scroll bar itself (which is
a problem on newer versions of Windows). When the user clicks on a
portion of the map, scroll to that part of the packet list.

Draw marked packet ticks over the normal scroll bar. Marked & ignored
are on the left, time references are on the right.

To do:

- Borrow more from packet fence and graph something (packet size? time
  delta?)

Change-Id: Ie952fcbd98fd0e047200f2279cb63227feabf5b1
Reviewed-on: https://code.wireshark.org/review/15046
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-04-28 17:18:41 +00:00
Gerald Combs 2227b6fa70 Add a comment about improvements for the OverlayScrollBar.
Change-Id: I2953deaa29691a2d12cb158456a650202dfeec77
Reviewed-on: https://code.wireshark.org/review/13171
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-10 18:43:12 +00:00
Gerald Combs d51d83bea5 Fix the selected packet indicator width.
Change-Id: Ic792c232524b4124bb4607cbe1979cdce8fd7e23
Reviewed-on: https://code.wireshark.org/review/9866
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-04 17:01:13 +00:00
Gerald Combs 4d6ef27b52 Qt < 5.1 doesn't have devicePixelRatio().
Change-Id: I490617db6b645c0129c565eb4b6efceeece9d535
Reviewed-on: https://code.wireshark.org/review/9751
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-23 03:21:06 +00:00
Gerald Combs 1514fe06cd Show the current selection in the overlay scrollbar.
Change-Id: Ie92b7ae170938eac71ede751d9067e1d47293092
Reviewed-on: https://code.wireshark.org/review/9750
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-23 00:24:08 +00:00
Gerald Combs 255d53dfc1 Draw packet colors in the packet list scrollbar.
Inspired by (but not as fancy as) Packet Fence, an enhancement written
for Ethereal a loooong time ago by Martin Visser:

https://www.wireshark.org/lists/ethereal-dev/200011/msg00122.html

Several text editors call this a "minimap".

Color each scrollbar raster line to match the color of up to 7 packets.
Note in the comments why this number was chosen.

If we have any flagged frames (marked, ignored, time ref) indicate them
on either side of the scrolbar.

Handle HiDPI (retina) displays. This means that your window size depends
on the height of your scrollbar *and* your monitor resolution.

Qt's idea of the slider rect doesn't match up with the slider on OS X.
This might be local to my build -- I can replicate it Qt Creator.

Change-Id: Ia089d2d766ce37bab11e22d1a5721b4908935304
Reviewed-on: https://code.wireshark.org/review/8982
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Tested-by: Gerald Combs <gerald@wireshark.org>
2015-07-16 22:57:31 +00:00