Commit Graph

81777 Commits

Author SHA1 Message Date
Orgad Shaneh fa1f76a83f rtpdump: Fix usec value in header
usec is nsec / 1000.
2021-07-28 06:51:36 +00:00
ismaelrti 9b69d05c2f RTPS: UDPv4 Wan locator bitfied not dissected properly
UDPv4 WAN locator bitfield was using the wrong offset thus the data
shown was not correct.
2021-07-28 06:35:17 +00:00
Dylan Ulis a1e05d09c6 CIP: Updates to match current specification
1. Connection Manager parameter is called 'Redundant Owner' instead of 'Exclusive'
2. Add new CIP Class Names
3. Support new time types: UTIME, STIME, NTIME
4. Add units to data type
2021-07-28 06:18:56 +00:00
David Perry 6e8c7283d6 Change some `wmem_packet_scope()` to `pinfo->pool` 2021-07-27 21:36:43 +00:00
Gtker 6d8bfc146d WOWW: Refactor SMSG_CHAR_ENUM to use ptvcursor 2021-07-27 19:08:52 +00:00
Gtker 7e9e2dac0f WOWW: Convert body fields to use `ptvcursor`
This significantly reduces boilerplate required for adding fields.

The changes to SMSG_CHAR_CREATE from ENC_LITTLE_ENDIAN to ENC_NA are
intentional, as are the changes to CMSG_CHAR_RENAME from realm_name to
character_name.
2021-07-27 19:08:52 +00:00
Gtker f864dd7e9d WOWW: Use dots in abbreviations instead of underscores
As directed in PR.
2021-07-27 19:08:52 +00:00
Gtker 8fbf781a7f WOWW: Make abbreviations fit variable names 2021-07-27 19:08:52 +00:00
Gtker 1a2169acf5 WOWW: Add CMSG_CHAR_CREATE fields
Wiki reference:
https://wowdev.wiki/CMSG_CHAR_CREATE
2021-07-27 19:08:52 +00:00
Gtker 22694dffeb WOWW: Add CMSG_CHAR_RENAME field
Wiki reference:
https://wowdev.wiki/CMSG_CHAR_RENAME
2021-07-27 19:08:52 +00:00
Gtker eafb670ee1 WOWW: Add fields for SMSG_NAME_QUERY_RESPONSE
https://wowdev.wiki/SMSG_NAME_QUERY_RESPONSE
2021-07-27 19:08:52 +00:00
Gtker 1fe0f6d2e0 WOWW: Add fields that only require result
The `login_result` field is reused for all results, since there's
nothing about the field that makes it specific to logging in and the
same values can appear in all 3 fields.

Wiki reference:
https://wowdev.wiki/SMSG_CHAR_DELETE

https://wowdev.wiki/SMSG_CHAR_CREATE

https://wowdev.wiki/SMSG_CHARACTER_LOGIN_FAILED
2021-07-27 19:08:52 +00:00
Gtker d2af1dee46 WOWW: Add CMSG_PING and SMSG_PONG fields
Wiki reference:
https://wowdev.wiki/CMSG_PING

https://wowdev.wiki/SMSG_PONG
2021-07-27 19:08:52 +00:00
Gtker 159eaaa37a WOWW: Add SMSG_TUTORIAL_FLAGS fields
Wiki reference:
https://wowdev.wiki/SMSG_TUTORIAL_FLAGS
2021-07-27 19:08:52 +00:00
Gtker 706f940ca8 WOWW: Add fields that only require GUID
Wiki reference:
https://wowdev.wiki/CMSG_NAME_QUERY

https://wowdev.wiki/CMSG_SET_ACTIVE_MOVER

https://wowdev.wiki/CMSG_CHAR_DELETE

https://wowdev.wiki/CMSG_SET_SELECTION
2021-07-27 19:08:52 +00:00
Gtker e31baaf99b WOWW: Add SMSG_LOGIN_VERIFY_WORLD fields 2021-07-27 19:08:51 +00:00
Gtker 08ceeec81e WOWW: Fix multi message PDUs using incorrect data
Previously the offset into the decrypted header tvb was used, which was
always 4 or 6, instead of the offset into the entire PDU tvb.
2021-07-27 19:08:51 +00:00
Gtker 44ce2d5173 WOWW: Add CMSG_PLAYER_LOGIN fields 2021-07-27 19:08:51 +00:00
Gtker aa650610b4 WOWW: Add equipment values to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker a5bdac52a1 WOWW: Add pet family and first login to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 9ea1b8f9ea WOWW: Add guild id and flags to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 4c232104aa WOWW: Add character positions to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker d9f6c1e59e WOWW: Add map and zone to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 49c5045728 WOWW: Add level to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker fccca6ee7b WOWW: Add character looks to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker b1e1d0b755 WOWW: Add class and gender to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 6294bf5600 WOWW: Add character race to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 3fd67e6a0f WOWW: Add initial fields of SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker db8db29e0c WOWW: Add SMSG_AUTH_RESPONSE fields
The enum is used for other opcodes as well, including SMSG_CHAR_CREATE.

Wiki reference:
https://wowdev.wiki/SMSG_AUTH_RESPONSE

Wiki reference for enum:
https://wowdev.wiki/Account_Result_Values
2021-07-27 19:08:51 +00:00
Gtker 9663f6fcf3 WOWW: Add CMSG_AUTH_SESSION fields
Wiki reference:
https://wowdev.wiki/CMSG_AUTH_SESSION
2021-07-27 19:08:51 +00:00
Gtker 2252f76075 WOWW: Add SMSG_AUTH_CHALLENGE field body
Wiki reference:
https://wowdev.wiki/SMSG_AUTH_CHALLENGE
2021-07-27 19:08:51 +00:00
Jaap Keuter afb1aff845 RakNet: Fix address bytes highlighting
Closes #17509
2021-07-27 10:41:33 +00:00
Martin Mathieson a9c6e34958 NFAPI: Fix some spellings 2021-07-27 10:34:14 +01:00
Guy Harris c4d3716ce8 macos-setup: install the current version of Ninja.
1.10.2 is the latest version, and is the first version to ship as a fat
x86-64/ARM64 binary, so that we have native binaries for both platforms
supported by macOS.
2021-07-27 00:26:28 -07:00
Evan Huus d09fb571fe asn1: convert most dissectors to pinfo->pool
Part 2/2 as the commits were too big for CI.

Largely find/replace, with a few manual tweaks. Then regenerate the asn1
dissector sources and make sure everything still builds. There are a
handful of cases I skipped as too complex, but this covers most of the
asn1 dissectors.
2021-07-26 14:00:09 -04:00
Evan Huus e69446aa55 asn1: convert most dissectors to pinfo->pool
Part 1/2 as the commits were too big for CI.

Largely find/replace, with a few manual tweaks. Then regenerate the asn1
dissector sources and make sure everything still builds. There are a
handful of cases I skipped as too complex, but this covers most of the
asn1 dissectors.
2021-07-26 15:30:11 +00:00
João Valverde 3467b98eb7 CMake: Make LTO default off, restrict to release build
Link Time Optimizations increases build time a lot so restrict
this optimization to release builds. Follow our build bots and
make this option default off.

Also LTO requires CMake >= 3.9 so make the LTO CMake option
universally conditional on that requirement.
2021-07-26 15:13:38 +00:00
João Valverde 925e01b23f Remove duplicate format_size() function
We have two format_size()s, with and without wmem scoped memory.
Move the wmem version to wsutil and add a convenience macro to
use g_malloc()ed memory.
2021-07-26 14:56:11 +00:00
João Valverde 133b0c583f Move epan/wmem/wmem_scopes.h to epan/
This header was installed incorrectly to epan/wmem_scopes.h.

Instead of creating additional installation rules for a single
header in a subfolder (kept for backward compatibility) just
rename the standard "epan/wmem/wmem.h" include to
"epan/wmem_scopes.h" and fix the documentation.

Now the header is installed *correctly* to epan/wmem_scopes.h.
2021-07-26 14:56:11 +00:00
João Valverde 7f9c1f5f92 Move wmem to wsutil
This allows wmem to be used from other libraries, namely wsutil.
It is often the case that a funtion exists in wsutil and cannot
be used with a wmem scope, requiring some code duplication or
extra memory allocations, or vice-versa, code in epan cannot be
moved to wsutil because it has a wmem dependency.

To this end wmem is moved to wsutil. Scope management remains part
of epan because those scope semantics are specific to dissection.
2021-07-26 14:56:11 +00:00
João Valverde 8310665ae7 Normalize some dissector includes 2021-07-26 14:56:11 +00:00
João Valverde 6a619212c3 Resync ASN.1 dissector sources 2021-07-26 14:09:37 +00:00
Martin Mathieson a7b5eec265 check_typed_item_calls.py: check add_bitmask() functions 2021-07-26 10:31:15 +00:00
Guy Harris 92f49886cc dumpcap: clean up capture device open errors.
1) Consistently say "capture device"; not all capture devices are
"interfaces" in the sense of "network interfaces' ("any" means "all
network interfaces", and capturing may be supported on a USB bus or on
D-Bus or....)

2) Use double quotes to quote the device specifier (it probably won't
have spaces in its name, but...).

3) Make sure that there's a space between "capture device" and the
quoted device name.
2021-07-26 01:32:23 -07:00
Gerald Combs 94d7b7846c GitLab CI: Add a retry to the Windows builds.
The Windows runners (Win32 in particular) sometimes time out during
tests. Add a retry.
2021-07-25 22:13:38 +00:00
Guy Harris 436a9fabcb btatt: fix reported dissector bug.
For better or worse, currently, if you have a field that is broken into
bitfields, the top-level field must be integral, so the entire field's
value is shown.  A case could be made that FT_NONE should be supported,
but that's not the case now.

Fixes issue #17505.
2021-07-25 13:56:40 -07:00
Guy Harris cb98aa3730 nettrace 3GPP 32.423: move the name related code together.
Initialize name_str right before we fill it in if the name is present,
and note what we're doing, to make it a bit clearer what the
initializing code is doing.
2021-07-25 13:34:11 -07:00
João Valverde 6ab67e2aa6 wslog: Minor fixes and cleanups 2021-07-25 18:21:31 +00:00
Moshe Kaplan 49ca5fa8ab libwiretap: Avoid using uninit variable
Within wiretap/nettrace_3gpp_32_423.c,
set the first byte of the buffer
to a null byte to avoid potentially
accessing uninitiliazed memory.
Fixes Coverity 1471685.
2021-07-25 17:25:44 +00:00
Gerald Combs 120b4c7e78 [Automatic update for 2021-07-25]
Update manuf, services enterprise numbers, translations, and other items.
2021-07-25 09:29:17 +00:00