wireshark

osmith

wireshark

forked from osmocom/wireshark

Fork 0

Commit Graph

Author	SHA1	Message	Date
João Valverde	d54e22b872	safe-math: Remove unnecessary clutter	2022-03-31 15:49:43 +01:00
João Valverde	e15658d1c0	safe-math: Fix non-existent built-ins Divison and modulo are not built-ins implemented by GCC or Clang. Replace the spurious macro definition with the internal implementation.	2022-03-31 15:49:43 +01:00
João Valverde	2a9cb588aa	dfilter: Add binary arithmetic (add/subtract) Add support for display filter binary addition and subtraction. The grammar is intentionally kept simple for now. The use case is to add a constant to a protocol field, or (maybe) add two fields in an expression. We use signed arithmetic with unsigned numbers, checking for overflow and casting where necessary to do the conversion. We could legitimately opt to use traditional modular arithmetic instead (like C) and if it turns out that that is more useful for some reason we may want to in the future. Fixes #15504.	2022-03-31 11:27:34 +01:00

Author

SHA1

Message

Date

João Valverde

d54e22b872

safe-math: Remove unnecessary clutter

2022-03-31 15:49:43 +01:00

João Valverde

e15658d1c0

safe-math: Fix non-existent built-ins

Divison and modulo are not built-ins implemented by GCC or Clang.

Replace the spurious macro definition with the internal implementation.

2022-03-31 15:49:43 +01:00

João Valverde

2a9cb588aa

dfilter: Add binary arithmetic (add/subtract)

Add support for display filter binary addition and subtraction.

The grammar is intentionally kept simple for now. The use case
is to add a constant to a protocol field, or (maybe) add two
fields in an expression.

We use signed arithmetic with unsigned numbers, checking for
overflow and casting where necessary to do the conversion.
We could legitimately opt to use traditional modular arithmetic
instead (like C) and if it turns out that that is more useful for
some reason we may want to in the future.

Fixes #15504.

2022-03-31 11:27:34 +01:00

3 Commits