Commit graph

11038 commits

Author SHA1 Message Date
Anders Broman
b2992b2310 ldap.cnf:782: warning: ISO C90 forbids mixed declarations and code
svn path=/trunk/; revision=35476
2011-01-11 11:41:03 +00:00
Jaap Keuter
1ea96b1e30 From Slava K:
FCoIB – Fibre Channel over InfiniBand. The protocol enables transmission of
Fibre Channel frames over InfiniBand networks. It is based on encapsulation of
Fibre Channel frames over InfiniBand UD transport. The discovery protocol is
based on the FIP protocol (not supported by this patch).

This patch adds an FCoIB dissector to Wireshark. It is based in large part on
the existing FCoE dissection code.

This code is submitted on behalf of Mellanox Technologies Ltd.

svn path=/trunk/; revision=35475
2011-01-11 08:22:16 +00:00
Ronnie Sahlberg
3079c9c931 From Matthieu Patou <mat@samba.org>
Dissect LDAP DirSyncFlags to show the bits of this bitmap.



svn path=/trunk/; revision=35474
2011-01-11 02:27:41 +00:00
Ronnie Sahlberg
27f36858fd Add a missing procedure name for NFS-ACL
svn path=/trunk/; revision=35466
2011-01-10 22:31:05 +00:00
Stephen Fisher
fe06217c35 Stop gcc warning about type-punned pointer breaks strict anti-aliasing
rules.  (Is this the right fix?  I had to remove a now meaningless
comparison of psm > 0x1000 (4096) since psm is now a guint8 not a guint16.)


svn path=/trunk/; revision=35463
2011-01-10 21:23:25 +00:00
Gerald Combs
1b4d847a90 Add 2869 to the list of HTTP ports: http://support.microsoft.com/kb/886257
svn path=/trunk/; revision=35461
2011-01-10 20:23:21 +00:00
Anders Broman
096e3737bc Add an expert item about not dissected IE's
svn path=/trunk/; revision=35460
2011-01-10 19:48:15 +00:00
Anders Broman
275c3c8818 Shorten long winded strings.
svn path=/trunk/; revision=35456
2011-01-10 17:34:00 +00:00
Bill Meier
e0424dde5d Move some DISSECTOR_SRC & DISSECTOR_INCLUDES entries so they are (more or less) in alpha order.
svn path=/trunk/; revision=35454
2011-01-10 15:19:18 +00:00
Jeff Morriss
03c7b7093e Give a couple commented-out hf's abbreviations (to keep checkAPIs happy).
svn path=/trunk/; revision=35452
2011-01-10 14:40:10 +00:00
Anders Broman
b321c5d5ea Add application/vnd.3gpp.cw+xml
svn path=/trunk/; revision=35450
2011-01-10 12:28:56 +00:00
Jaap Keuter
a1ea8ad71b Clean up the blurbs indicated by checkAPIs.
svn path=/trunk/; revision=35449
2011-01-10 07:39:15 +00:00
Jeff Morriss
dc22fbfc50 Give CSID an abbreviation.
svn path=/trunk/; revision=35446
2011-01-10 03:02:43 +00:00
Jaap Keuter
65ca06b9c6 Make comment a real comment, trying to fix the buildbot.
svn path=/trunk/; revision=35445
2011-01-09 22:34:20 +00:00
Anders Broman
b9eddc7117 Update value_strings
svn path=/trunk/; revision=35442
2011-01-09 20:41:19 +00:00
Anders Broman
589d38b8f4 More field related fixes.
svn path=/trunk/; revision=35440
2011-01-09 19:37:35 +00:00
Anders Broman
30c2b245cd Fix:
20:15:19          Err  Field 'Link-local Address' (pmip6.lila_lla) is an FT_IPv6
 but is being displayed as BASE_HEX instead of BASE_NONE

svn path=/trunk/; revision=35439
2011-01-09 19:17:39 +00:00
Anders Broman
fab599ffc0 Fix:
packet-mip6.c:801: warning: 'hf_pmip6_opt_ipack' defined but not used
packet-mip6.c:802: warning: 'hf_pmip6_opt_ipack_res' defined but not used

svn path=/trunk/; revision=35438
2011-01-09 19:15:11 +00:00
Anders Broman
40acaf76ce Add 26 Link-local Address Option.
Comments and whitespace changes.

svn path=/trunk/; revision=35436
2011-01-09 17:49:31 +00:00
Anders Broman
a2bbf3d7cc Put sgsap in the right place.
svn path=/trunk/; revision=35433
2011-01-09 13:50:41 +00:00
Anders Broman
5c6ab22ff3 Get rid of check_col().
svn path=/trunk/; revision=35432
2011-01-09 13:50:03 +00:00
Anders Broman
f23d884631 Try to fix:
packet-gtpv2.c:2648: warning: return type defaults to 'int'
packet-gtpv2.c: In function 'dissect_udp_s_port_nr':
packet-gtpv2.c:2690: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_fq_csid':
packet-gtpv2.c:2845: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_emlpp_pri':
packet-gtpv2.c:2927: warning: implicit declaration of function 'be_emlpp_prio'
packet-gtpv2.c: At top level:
packet-gtpv2.c:3056: warning: initialization from incompatible pointer type

svn path=/trunk/; revision=35431
2011-01-08 20:26:35 +00:00
Anders Broman
b6427b53b5 Further IE dissection updates.
svn path=/trunk/; revision=35430
2011-01-08 20:09:29 +00:00
Guy Harris
785f7b5191 Use report_failure() to report problems reading the RADIUS dictionary,
so it shows up in the GUI in Wireshark.

svn path=/trunk/; revision=35427
2011-01-08 17:06:04 +00:00
Guy Harris
132f13c2f9 If the lack of a peer conversation is a bug, use one of the
dissector-bug macros.  If it's just that we're missing some packets, we
should handle that as best we can and, if there's stuff we can't do,
maybe put something into the protocol summary or tree saying "not enough
information".  Don't just spit out a warning message which the user
might not even see.

svn path=/trunk/; revision=35426
2011-01-08 16:40:46 +00:00
Sake Blok
ea4ac173d0 Add "tcp.window_size_value" and "tcp.window_size_scalefactor" conform
the discussion in bug 5541. Since we now have the window size value as
well as the scaled window size, there is no need anymore for the
tcp preference "tcp_window_scaling".


svn path=/trunk/; revision=35425
2011-01-08 15:51:38 +00:00
Chris Maynard
4a8fa72830 Append text to INFO column. Closes out bug 4472.
svn path=/trunk/; revision=35423
2011-01-07 19:22:09 +00:00
Jeff Morriss
bf2796ab92 Don't try to display a string in BASE_DEC. Also delete duplicate registration of hf_gtpv2_pti.
svn path=/trunk/; revision=35422
2011-01-07 19:01:17 +00:00
Anders Broman
f235eadf25 ** (process:23326): WARNING **: Field 'Reserved bit(s)' does not have an
abbreviation

** ERROR **: Field 'IPv4 Address' (gtpv2.ipv4_addr) is an FT_IPv4 but is being
displayed as BASE_DEC instead of BASE_NONE

svn path=/trunk/; revision=35420
2011-01-07 18:04:03 +00:00
Anders Broman
6d801a2052 Fix buildbot.
svn path=/trunk/; revision=35419
2011-01-07 16:12:01 +00:00
Jeff Morriss
2c2990fc08 Fix the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5554 :
Don't assume that g_strsplit() found and returned 3 strings.

svn path=/trunk/; revision=35418
2011-01-07 15:59:26 +00:00
Anders Broman
863e3f80a6 Add dissection of more IE:s
svn path=/trunk/; revision=35417
2011-01-07 15:21:23 +00:00
Guy Harris
1718ab7691 If we get an unknown reply status, don't print a g_warning message -
just put the reply body, if any, into the protocol tree as a blob.  The
protocol tree will note that it's an unknown status.

svn path=/trunk/; revision=35414
2011-01-07 00:26:57 +00:00
Anders Broman
bdc3fa5463 From Alexis La Goutte:
- Update RFC Draft (draft-vida-mld-v2-08.txt) to Final RFC
(RFC 3810)
- Make MLD field filterable 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5552

svn path=/trunk/; revision=35413
2011-01-07 00:19:28 +00:00
Guy Harris
b711e23baa Don't use g_warning() - either you have a dissector bug, and should use
one of the macros to report that, or you have a problem with the packet,
in which case you should note that in the protocol tree, or you have
something you don't understand, in which case you should dissect
whatever of it you do understand and put something appropriate, if
possible, into the protocol tree for the rest.

(And, if the length isn't right, there's not much you can do about it -
you have to trust the length, and manage to fail somewhere else.)

svn path=/trunk/; revision=35408
2011-01-06 22:52:40 +00:00
Stephen Fisher
802308ca01 More misc. CLDAP improvements for Active Directory including updating
field names and adding descriptions, changing the Domain GUID in the "LDAP
ping" response to a FT_GUID instead of FT_BYTES, etc.


svn path=/trunk/; revision=35407
2011-01-06 22:24:10 +00:00
Jeff Morriss
9335685106 Fix the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5550 :
In dissect_amqp_0_10_array() if the 'type' is unknown, don't loop (for
potentially a very long time) adding the same element over and over again
(since the type is unknown, we don't know how much to increase the offset so
an exception is never thrown).

svn path=/trunk/; revision=35406
2011-01-06 21:07:58 +00:00
Stephen Fisher
a9761c53b7 More minor cleanup/fixes for MS Active Directory's use of CLDAP.
svn path=/trunk/; revision=35404
2011-01-06 18:50:39 +00:00
Stephen Fisher
89d9b73e47 Minor corrections to NtVer dissection for NETLOGON_NT_VERSION Options Bits
in MSCLDAP packets per Microsoft's MS-ADTS specification, section 7.3.1.1,
revision 26 (11/19/2010).  Also re-format code a bit.


svn path=/trunk/; revision=35403
2011-01-06 18:08:14 +00:00
Stephen Fisher
ab377e1e09 When showing a DNS query response containing a SRV record, display items
in the tree of the service record broken out.  For example,
"_ldap._tcp.domain.com" shows:

	Service: ldap
	Protocol: tcp
	Name: domain.com


svn path=/trunk/; revision=35401
2011-01-06 17:15:50 +00:00
Jeff Morriss
18f751d877 (After discussion on -dev) revert 35393: the old code is faster (and it is safe).
svn path=/trunk/; revision=35400
2011-01-06 16:08:56 +00:00
Jeff Morriss
8934e6bf26 strtoull() doesn't exist on Windows, use g_ascii_strtoull() instead.
svn path=/trunk/; revision=35399
2011-01-06 15:02:46 +00:00
Jeff Morriss
5a2ef3cb01 Use tvb_memeql() instead of memcmp()+tvb_get_ptr().
svn path=/trunk/; revision=35398
2011-01-06 03:08:03 +00:00
Jeff Morriss
eaea469533 Actually use proto_tree_add_item().
svn path=/trunk/; revision=35397
2011-01-06 02:58:26 +00:00
Jeff Morriss
6f1c903e18 There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_string: just use proto_tree_add_item().
svn path=/trunk/; revision=35396
2011-01-06 02:56:10 +00:00
Jeff Morriss
eea559bc2c There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_string: just use proto_tree_add_item().
svn path=/trunk/; revision=35395
2011-01-06 02:52:00 +00:00
Jeff Morriss
0b49360059 Rather than creating strtoul{l} functions that can deal with possibly non-NULL
terminated strings (retrieved with tvb_get_ptr()), just use
tvb_get_ephemeral_string() and the standard strtoul{l} functions.

svn path=/trunk/; revision=35394
2011-01-06 02:45:01 +00:00
Jeff Morriss
fb7450a8df Use tvb_get_ephemeral_stringz() instead of tvb_get_strsize() plus (sometimes multiple) calls to tvb_get_ptr().
svn path=/trunk/; revision=35393
2011-01-06 02:18:36 +00:00
Jeff Morriss
9b3eb1ff4b Reset the global pdu_type *before* returning.
svn path=/trunk/; revision=35391
2011-01-05 22:40:47 +00:00
Jeff Morriss
61317d2dbd Remove an unreached return.
svn path=/trunk/; revision=35390
2011-01-05 22:33:25 +00:00