Commit Graph

50413 Commits

Author SHA1 Message Date
Jakub Zawadzki 6aec20c782 Rmove packet_info argument from packet_list_append(), never used.
Part of attachment 12060, from Didier Gautheron (bug #9419).

svn path=/trunk/; revision=53544
2013-11-24 12:49:50 +00:00
Guy Harris 92fba9d072 Actually, the "1632" types do exist, and are 16-bit for NDR and 32-bit
for NDR64, and we handle them.  The real problems are elsewhere.

svn path=/trunk/; revision=53543
2013-11-24 04:39:27 +00:00
Guy Harris 0a2519f39c These are two of the problems that pidl has with dfs.idl.
svn path=/trunk/; revision=53542
2013-11-24 04:15:25 +00:00
Guy Harris 61cce924e4 Get rid of trailing spaces, fix some proto_tree_add_item() calls as per
the result of pidl on dce.idl.

(We can't just regenerate it, as there are some pidl bugs that cause bad
code to be generated.)

svn path=/trunk/; revision=53541
2013-11-24 04:14:00 +00:00
Guy Harris f7e5e2d594 The issue with misc.idl was a .cnf file that needed to be updated.
Give details of the problems with the other files.

svn path=/trunk/; revision=53540
2013-11-24 03:33:17 +00:00
Guy Harris eb223ff796 Regenerate - new API changes, get rid of trailing whitespace.
svn path=/trunk/; revision=53539
2013-11-24 03:21:50 +00:00
Guy Harris f070b9e0e2 Fix to match API changes.
svn path=/trunk/; revision=53538
2013-11-24 03:20:25 +00:00
Guy Harris 9410fcccbc Fix line endings, set svn:eol-style to native.
svn path=/trunk/; revision=53537
2013-11-24 03:18:22 +00:00
Guy Harris d30959df3e Update a date, explain what the problems are with a bunch of IDL files,
add another file that *might* be generating incorrect code.

svn path=/trunk/; revision=53536
2013-11-24 02:58:26 +00:00
Guy Harris 3f6b85ecbe Regenerate - for whatever reason, the fields come out in a different
random order, but nothing else changes.

svn path=/trunk/; revision=53535
2013-11-24 02:57:24 +00:00
Guy Harris 70cea27d59 Regenerated with the current version of pidl; mainly removes trailing
white space, but also gets rid of an apparently-unnecessary _U_ for one
argument.

svn path=/trunk/; revision=53534
2013-11-24 02:51:36 +00:00
Guy Harris cafef8b111 Updates to:
suggest using our version of pidl, given that its Wireshark
	parser generator has changes to support the current internal
	Wireshark APIs for dissectors;

	suggest using "--includedir ." to make IDL files in
	subdirectories of epan/dissectors/pidl work;

	update the list of IDL files with issues;

	reformat to 80x66 (if it's good enough for Herman Hollerith,
	it's good enough for me!).

svn path=/trunk/; revision=53533
2013-11-24 02:45:38 +00:00
Jeff Morriss de2a922b55 Some patches from Peter Harris to make it possible to build the X11 dissector
again (and some various other improvements):

Rebuild the dissector with the latest xcbproto and mesa.


Subject: [PATCH 01/11] X11 dissector: Support CARD64 and INT64 types
These types are used by the new Present extension.

Subject: [PATCH 02/11] X11 dissector: Un-blacklist a few structures
The xinput structs are used by the latest xcb/proto, and the xkb
struct has been removed.

Subject: [PATCH 03/11] X11 dissector: Add hack for xinput:ChangeProperty
xinput:ChangeProperty should use switch/case, but only switch/bitcase
is supported at the moment. Add (hopefully temporary) hack.

Subject: [PATCH 04/11] X11 dissector: Use namespace for types
In particular, the name of the xsync struct 'INT64' collides with a
basic type of the same name.

Subject: [PATCH 05/11] X11 dissector: Add support for "Generic" events
All new extensions are using the new "Generic" events instead of
traditional events, because there aren't enough traditional event
numbers.

Denoted by <event xge="true"> in xcb/proto.

Subject: [PATCH 06/11] X11 dissector: Blacklist unused structures

Subject: [PATCH 07/11] X11 dissector: Support multiple enumref in a bitcase
XKB is weird.

Subject: [PATCH 08/11] X11 dissector: Support sumof

Subject: [PATCH 09/11] X11 dissector: Stop generating unused-but-set variables
(This patch also reverts r53298/r53299.)

svn path=/trunk/; revision=53532
2013-11-24 01:32:55 +00:00
Jeff Morriss a434d9647e Some patches from Peter Harris to make it possible to build the X11 dissector
again (and some various other improvements):

Rebuild the dissector with the latest xcbproto and mesa.


Subject: [PATCH 01/11] X11 dissector: Support CARD64 and INT64 types
These types are used by the new Present extension.

Subject: [PATCH 02/11] X11 dissector: Un-blacklist a few structures
The xinput structs are used by the latest xcb/proto, and the xkb
struct has been removed.

Subject: [PATCH 03/11] X11 dissector: Add hack for xinput:ChangeProperty
xinput:ChangeProperty should use switch/case, but only switch/bitcase
is supported at the moment. Add (hopefully temporary) hack.

Subject: [PATCH 04/11] X11 dissector: Use namespace for types
In particular, the name of the xsync struct 'INT64' collides with a
basic type of the same name.

Subject: [PATCH 05/11] X11 dissector: Add support for "Generic" events
All new extensions are using the new "Generic" events instead of
traditional events, because there aren't enough traditional event
numbers.

Denoted by <event xge="true"> in xcb/proto.

Subject: [PATCH 06/11] X11 dissector: Blacklist unused structures

Subject: [PATCH 07/11] X11 dissector: Support multiple enumref in a bitcase
XKB is weird.

Subject: [PATCH 08/11] X11 dissector: Support sumof

Subject: [PATCH 09/11] X11 dissector: Stop generating unused-but-set variables
(This patch also reverts r53298/r53299.)

svn path=/trunk/; revision=53531
2013-11-24 01:32:20 +00:00
Evan Huus 1db1b8e2bb Convert ASN1 dissectors from ep_address_to_str to address_to_str. Clean up a bit
of ansi_tcap code while in the neighbourhood.

svn path=/trunk/; revision=53530
2013-11-23 22:37:33 +00:00
Michael Mann 318d38b576 Use 32bit key in p_add_proto_data() and friends. Bug 9453 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9453)
From Dirk

svn path=/trunk/; revision=53529
2013-11-23 22:29:31 +00:00
Evan Huus d97c9e2ff4 Implement address_to_str which is like ep_address_to_str and se_address_to_str
except it takes a wmem scope instead. Add the two emem equivalents to checkAPI
as (weakly) deprecated.

svn path=/trunk/; revision=53528
2013-11-23 22:17:27 +00:00
Evan Huus df1aec4a6b Remove old (2009) and no-longer-necessary compatibility macro.
svn path=/trunk/; revision=53527
2013-11-23 22:03:48 +00:00
Michael Mann ea63042f9b Bluetooth improvements. Bug 9446 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9446)
From Michal Labedzki 

svn path=/trunk/; revision=53525
2013-11-23 21:41:08 +00:00
Guy Harris 84e23ce90f Set a field to squelch a Coverity warning.
svn path=/trunk/; revision=53524
2013-11-23 20:10:02 +00:00
Guy Harris a18cf1975f Always check cf->edt before dereferencing it, so that Coverity doesn't
say "you checked it here, but you dereferenced it later even if it was
null when you checked it".

This obviates the need for some checks of frame_selected, as cf->edt
will be non-null iff cf->current_frame is non-null.

Always check *cf, not cfile, in set_menus_for_selected_packet(). 
Currently, cf always == &cfile, but we aren't guaranteeing that will be
true forever.

svn path=/trunk/; revision=53523
2013-11-23 19:51:02 +00:00
Michael Mann 55c6869980 Remove ip_ttl from packet_info structure.
Part of the fix includes having the IPv6 dissector populate as much of a ws_ip structure as possible to pass to subdissectors of the "ip.proto" table, so the ttl value can be picked up.

svn path=/trunk/; revision=53522
2013-11-23 19:16:05 +00:00
Pascal Quantin 9150571bf3 Check the packet length when using the "Force decoding of unknown USB control data as MBIM" option to reduce false positives.
Align text in info column.

svn path=/trunk/; revision=53521
2013-11-23 12:30:19 +00:00
Michael Mann 9b7fb8a811 Create the ability to have packet scoped "proto" data. Bug 9470 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470)
I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future.  And search/replace of a function name is easy enough to do.

The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As.

All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope().  All other dissectors were converted to using file_scope() which was the original scope for "proto" data.

svn path=/trunk/; revision=53520
2013-11-23 02:20:13 +00:00
Gerald Combs b3a24c5cc4 Replace similar code with a common routine.
svn path=/trunk/; revision=53519
2013-11-23 01:06:30 +00:00
Evan Huus 11d8147ab5 Add exception for cmake/TestWindowsFSeek.c it is copied from upstream under a
valid license, but has no recognizable header and there's no reason to carry the
delta.

svn path=/trunk/; revision=53518
2013-11-22 23:46:00 +00:00
Guy Harris 455ccca701 Slap a BSD checksum onto in_cksum.h.
svn path=/trunk/; revision=53517
2013-11-22 20:54:30 +00:00
Gerald Combs 213d47a82e Fix packet list selection signaling.
It looks like resetting the packet list model during freezing and
thawing disconnects the selection changed signal between the model and
the main window. Rename the packet list's setMenusFollowStream signal to
packetSelectionChanged and use it to trigger menu updates in the main
window.

svn path=/trunk/; revision=53516
2013-11-22 17:59:15 +00:00
Gerald Combs 779f95ab61 Make the "decode as" dialog modal (for now, at least).
svn path=/trunk/; revision=53515
2013-11-22 17:53:25 +00:00
Martin Mathieson 65e3e91208 Tweak filter names for expert items, mostly to consistently use - rather than _
svn path=/trunk/; revision=53514
2013-11-22 17:18:11 +00:00
Martin Mathieson a906b1f5fe Tidy up some TODOs
svn path=/trunk/; revision=53513
2013-11-22 16:52:28 +00:00
Alexis La Goutte f482d8737f Fix unused-const-variable error when build with clang 3.4
svn path=/trunk/; revision=53512
2013-11-22 14:52:25 +00:00
Alexis La Goutte 2350754b88 Fix unused-const-variable error when build with clang 3.4
svn path=/trunk/; revision=53511
2013-11-22 14:52:15 +00:00
Alexis La Goutte 14ee1a5a86 Fix unused-const-variable error when build with clang 3.4
svn path=/trunk/; revision=53510
2013-11-22 14:52:04 +00:00
Alexis La Goutte 0d20064172 Fix unused-const-variable error when build with clang 3.4
svn path=/trunk/; revision=53509
2013-11-22 14:51:52 +00:00
Alexis La Goutte f39f943db0 Fix unused-const-variable error when build with clang 3.4 (with ugly hack... Maybe remove all ugly INIT_FIELD/ ADD_FIELD macro)
svn path=/trunk/; revision=53508
2013-11-22 14:51:43 +00:00
Alexis La Goutte 001d79cac3 Add -Wheader-guard to Autotools and CMake
svn path=/trunk/; revision=53507
2013-11-22 14:51:31 +00:00
Pascal Quantin cebc175814 Make use of ctrl_ack_vals value_string array
svn path=/trunk/; revision=53506
2013-11-22 11:22:46 +00:00
Alexis La Goutte 6e2b1c91f4 Fix typo in top filename
svn path=/trunk/; revision=53505
2013-11-22 08:53:05 +00:00
Michael Mann 9ba190f2a5 Create multiple dissection functions if packet_info->ipproto is used to distinguish behavior.
svn path=/trunk/; revision=53504
2013-11-22 02:52:41 +00:00
Michael Mann 237c580bd7 Replace packet_info->ipproto with packet_info->layers loop to determine TCP/UDP.
svn path=/trunk/; revision=53503
2013-11-22 02:49:00 +00:00
Gerald Combs 635a5b196c Fix qmake builds on Unix.
tap_register.variable_out adds wireshark-tap-register.c to SOURCES. We
don't have to add it again ourselves.

svn path=/trunk/; revision=53502
2013-11-22 02:11:40 +00:00
Gerald Combs 629d5f1697 Mark a parameter unused.
svn path=/trunk/; revision=53501
2013-11-22 01:25:17 +00:00
Gerald Combs e5c9616fd2 Remove a commented-out duplicate dissector_table definition.
svn path=/trunk/; revision=53500
2013-11-22 01:11:49 +00:00
Gerald Combs 78266fe17e Add an initial "Decode As" dialog. Currently read-only.
Fixup some of the Statistics menu items.

svn path=/trunk/; revision=53499
2013-11-22 01:07:36 +00:00
Gerald Combs 70709e1b35 Move common "decode as" preference code to epan.
We presumably want "decode as" behavior to be consistent across UIs so
call load_decode_as_entries() from read_prefs().

svn path=/trunk/; revision=53498
2013-11-22 00:20:23 +00:00
Bill Meier fc5adb9b66 Comment out *many* unused vars found by CLANG;
Fix 2 minor bugs wherein an incorrect (NULL) tree was always used;
Remove some unneeded initializers;
Localize some variables;
Use consistent indentation & whitespace formatting
Add editor modelines.

svn path=/trunk/; revision=53497
2013-11-21 23:21:49 +00:00
Bill Meier 9f485b9e89 #if 0 some unused vars found by CLANG
svn path=/trunk/; revision=53496
2013-11-21 23:17:59 +00:00
Martin Kaiser a5317f8646 From Abhik Sarkar
improve relative offset calculations for Kyoto-Tycoon protocol

from me:
use col_append_sep_str()
set the correct length in dissect_kt()

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9418

svn path=/trunk/; revision=53495
2013-11-21 22:30:55 +00:00
Martin Kaiser 36f11a79cc next unprocessed descriptor 0xFF means that
all descriptors were processed

svn path=/trunk/; revision=53494
2013-11-21 21:54:31 +00:00