Commit graph

58 commits

Author SHA1 Message Date
Stig Bjørlykke
11c616f11e Do not redraw graph and goto frame 1 if selecting an "item" outside the list
in Graph Analysis list.

svn path=/trunk/; revision=23770
2007-12-05 13:32:09 +00:00
Sake Blok
e8ca13de9e After taking a closer look at SVN 23089, I believe it was intended only to add the
file-name to the window title and not change the rest of the name.
(the graph window is both used from "Flow Graph" and from "VoIP calls")


svn path=/trunk/; revision=23695
2007-12-01 02:10:03 +00:00
Sake Blok
e825cba61b Give the flow graph window the correct title.
svn path=/trunk/; revision=23689
2007-11-30 18:55:34 +00:00
Alejandro Vaquero
4bf238547f VoIP Calls changes: Add the file name to the title window in VoIP calls, Voip graph and RTP player windows. Make the calls selection using standard multiple selection using the GTK buildin functions. Add a 'Select All' buttom to the VoIP calls window.
svn path=/trunk/; revision=23089
2007-10-08 00:31:26 +00:00
Stephen Fisher
c638ab8e6d Fix bug #1530 this time for GTK1 builds.
svn path=/trunk/; revision=22009
2007-05-30 19:43:33 +00:00
Stephen Fisher
d3454df68a Update to revision 22000: change #if GTK_MAJOR_VERSION > 2 to >= 2
svn path=/trunk/; revision=22001
2007-05-30 03:28:12 +00:00
Stephen Fisher
6049eda556 Wrap call to gtk_window_set_destroy_with_parent() within check for GTK_MAJOR_VERSION > 2 to get the Windows build-bot going again. This means that bug #1530 has to be reopened awaiting a fix that covers GTK1 also.
svn path=/trunk/; revision=22000
2007-05-30 02:37:37 +00:00
Stephen Fisher
5eb2b42d30 Fix for bug #1530: Graph Analysis window misbehaves if Flow Window that
created it is closed.

The fix is to close the graph analysis window when the flow graph setup
window is closed since closing the flow graph window first destroys all
of the data structures.


svn path=/trunk/; revision=21994
2007-05-29 23:09:09 +00:00
Bill Meier
cb92dd7019 Another fix to allow gtk1 to compile w/o warnings....
svn path=/trunk/; revision=21512
2007-04-22 22:23:19 +00:00
Ronnie Sahlberg
872398a417 some updates to allow gtk1 to compile without warnings
svn path=/trunk/; revision=21500
2007-04-22 15:43:01 +00:00
Stephen Fisher
1909b97d4d Remove all warnings under Unix for the gtk/ directory.
svn path=/trunk/; revision=21160
2007-03-24 00:45:11 +00:00
Luis Ontanon
529c65f713 voip_calls.c:
- instead of wrongly using the h248 call counter use tapinfo's counter

graph_analysis.c:
- beautify  the code (I was trying to the bug that got fixed by bzeroing m3ua tap data however this looks better!).

svn path=/trunk/; revision=21063
2007-03-19 00:36:42 +00:00
Jeff Morriss
8c6bda4db5 Squelch a couple (false) uninitialized variable warnings
svn path=/trunk/; revision=20858
2007-02-19 10:26:21 +00:00
Ulf Lamping
1587983aff from Stephen Fisher:
A user asked what file format the flow graph is saved as, which isn't 
apparent by looking at the dialog.  I had to try saving a file and check 
its type -- plain text file.  Could someone please apply the attached 
patch or similar change to graph_analysis.c.  My patch updates the title 
of the dialog box from "Wireshark: Save graph to file" to "Wireshark: 
Save graph to text file".

However, I used the term "plain text file" instead ;-)

svn path=/trunk/; revision=20510
2007-01-20 17:52:39 +00:00
Gerald Combs
5da5bf2567 When dumping the graph data to a file, don't walk past the end of a buffer.
Should fix bug 396.

svn path=/trunk/; revision=19499
2006-10-11 23:25:51 +00:00
Guy Harris
92552c2d76 Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUI
strings, and function names.

svn path=/trunk/; revision=18205
2006-05-22 07:29:40 +00:00
Ronnie Sahlberg
89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Guy Harris
84aef00bad Move the file selection dialog routines to file_dlg.c, and give it a
header file.

#if 0 out some includes; if none of the builds have a problem with
that, I'll remove them.

svn path=/trunk/; revision=18036
2006-04-30 01:47:58 +00:00
Anders Broman
d7610e4c0a From Laurent Rabret,
2 patches for the "flow graph" display. It is better not to insert invalid packets into the list than to control the list is correct while using it...

svn path=/trunk/; revision=17622
2006-03-14 05:49:15 +00:00
Jaap Keuter
e6ca05b8d8 From Laurant Rabret:
Please find enclosed 2 patches.
- Voip_calls_dlg.c.patch fixes a problem that appears with a release
compiled with GTK 2.8 + Visual Studio 2003. It seems g_snprintf can
corrupt memory when a length bigger than the array size is provided in
the second parameter (even if the generated string is smaller than the
array actual size!!)
- graph_analysis.c.patch fixes a memory corruption problem easy to
reproduce. Just open the pcap file enclosed, select "Statistics"->"Flow
Graph" and activate the "Network source/destination addresses" radio
button before pressing OK. You'll see a crash dump.
Thanks to check in
Best Regards
Laurent

svn path=/trunk/; revision=17543
2006-03-09 07:07:35 +00:00
Jaap Keuter
1f5ada6df0 Fix left open file (coverity CID 108) and g_string leak. Clean up double width line drawing.
svn path=/trunk/; revision=17515
2006-03-08 07:06:42 +00:00
Anders Broman
1fd7fbdb1d From Alejandro Vaquero:
a patch for the VoipCalls to fix a couple of issues:
- a problem with the RTP Events (RFC2833) not been handle correctly
- Display the RTP stream in time order when the setup frame is after the 
RTP stream.
- fix a init issue that caused the H245 packet to not been displayed 
correctly.

svn path=/trunk/; revision=17383
2006-02-23 20:02:23 +00:00
Luis Ontanon
bd63d8d003 I commented out this a while ago as they caused a crash in GTK2.8/cairo on my box. I checked it in by mistake with a lot of more files, even worst I did not pay attention to an e-mail on the list regarding the damage caused. Luckily Alejandro Vaquero contacted me directly.
svn path=/trunk/; revision=17363
2006-02-21 23:35:13 +00:00
Luis Ontanon
fcf7b3789c add an userdata argument to register_stat_cmd_arg() and its callback to use the callback for multiple registrations.
svn path=/trunk/; revision=17252
2006-02-11 13:05:24 +00:00
Ulf Lamping
c3187174bf replace *a lot* of file related calls by their GLib counterparts. This is necessary for the switch to GTK 2.6 (at least on WIN32).
to do this, I've added file_util.h to wiretap (would file_compat.h be a better name?), and provide compat_macros like eth_open() instead of open(). While at it, move other file related things there, like #include <io.h>, definition of O_BINARY and alike, so it's all in one place.

deleted related things from config.h.win32

As of these massive changes, I'm almost certain that this will break the Unix build. I'll keep an eye on the buildbot so hopefully everything is working again soon.

svn path=/trunk/; revision=16403
2005-11-06 22:43:25 +00:00
Anders Broman
15a08ae521 From Alejandro Vaquero:
New "Fax T38 Analysis" added to the "Statistics" menu to:

- Reassemble the HDLC t30 frames and dissect the header.
- Analyze the UPDTLPacket seq num for packet lost
- Stats of V.x Data:
    - Count the Data bytes
    - Duration
    - Wrong seq num
    - Max Burst of packet lost

svn path=/trunk/; revision=16073
2005-10-03 05:55:26 +00:00
Gerald Combs
551b9bc61d Free our flow graph strings when we're done with them. Add a note about
flow graphs to the release notes, along with other stuff.

svn path=/trunk/; revision=15928
2005-09-21 14:20:43 +00:00
Gerald Combs
ad99e218ca In an attempt to fix bug 396, switch over to GStrings. There still appears
to be a problem with formatting, but we don't crash any more.

svn path=/trunk/; revision=15923
2005-09-21 03:28:22 +00:00
Anders Broman
06c1f4ad6c From Alejandro Vaquero.
svn path=/trunk/; revision=15778
2005-09-13 04:53:36 +00:00
Ronnie Sahlberg
6d5d4f8bec From Graeme Hewson
Fix for infinite loop of configure events that were present for early GTK 2.4 in addition to 2.2



svn path=/trunk/; revision=15517
2005-08-24 07:28:28 +00:00
Ulf Lamping
eafbbbcabb renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir
svn path=/trunk/; revision=15465
2005-08-20 12:09:48 +00:00
Jörg Mayer
e9ea42eed9 Fix more "no previous declaration" warnings
svn path=/trunk/; revision=15173
2005-08-02 04:47:15 +00:00
Luis Ontanon
37636903bc From Alejandro Vaquero:
fix a crash when graphing packets whose src and dst is the same address


svn path=/trunk/; revision=15023
2005-07-24 01:48:01 +00:00
Luis Ontanon
4545d72483 Avoid the selected item been white on white by making all analysis widows colored.
Fixes bug 286.


svn path=/trunk/; revision=14961
2005-07-19 21:40:12 +00:00
Ronnie Sahlberg
31590a170f GTK 1.2 does not define the macro GDK_IS_DRAWABLE which made compilation of the recent flow analysis fail to compile.
For the time being, just add a dummy define for this symbol making it always TRUE for gtk-1.x users so that it compiles.

this should be fixed properly at a later stage, but i guess there are very few users of gtk-1.2 anyway  so no urgency.


svn path=/trunk/; revision=14949
2005-07-18 08:29:03 +00:00
Luis Ontanon
b231e455c7 From Francisco Alcoba
Flow Graphs for any protocol


svn path=/trunk/; revision=14948
2005-07-17 23:12:12 +00:00
Anders Broman
c8b69874cb From Alejandro Vaquero
- avoid the clist of the calls dlg to be refreshed multiple times when 
first appear.
- destroy the Graph window when the data is not valid anymore.
- fixes an H245 packet count error
- resizing the Graph windows when is displayed (up to 5 columns).
With a change to leave static voip_calls_tapinfo_t the_tapinfo_struct =
	{0, NULL, 0, NULL, 0, 0, 0, 0, NULL, 0, 0, 0, 0, 0, 0, 0, 0, 0};
alone.

svn path=/trunk/; revision=14852
2005-07-05 05:16:28 +00:00
Ronnie Sahlberg
cc3b0df4ca From Alejandro, fix for GTK1 graph_analysis issue.
svn path=/trunk/; revision=14757
2005-06-26 00:12:15 +00:00
Anders Broman
abcecaaf90 From Alejandro Vaquero:
glib-object.h is is glib2 only.
 graph_analysis.c:47:25: glib-object.h: No such file or directory
 a patch for ths issue and also to correct the "first_item" 
issue reported in "RE: [Ethereal-dev] Voip graph analysis "Save as" button"

svn path=/trunk/; revision=14577
2005-06-07 15:21:22 +00:00
Anders Broman
936bcef09d From Alejandro Vaquero:
- Add a pane to contain  the main graph and the comments to be able to 
split them
- Change the main graph area to be a scrolled_window
- Change the look of the selected item to be blue with white text color
- Gray color the title area
- Change the conversations color to more "soft" colors (it was difficult 
to read in some cases before)

svn path=/trunk/; revision=14556
2005-06-06 14:01:04 +00:00
Ulf Lamping
af9bcf3bf8 prevent unused function warning
svn path=/trunk/; revision=14463
2005-05-28 11:04:11 +00:00
Ronnie Sahlberg
0938d01e38 GdKEventScroll is not available in GTK-1.2
svn path=/trunk/; revision=14451
2005-05-27 05:04:03 +00:00
Ulf Lamping
abab83d6e4 fix #203: the scroll event handler used an inappropriate implementation to get event values, fixed this. On win32 this was working before and after the changes, so the bug *might* remain ...
svn path=/trunk/; revision=14448
2005-05-26 23:18:10 +00:00
Lars Roland
13f019e952 From Francisco Alcoba:
- change the "write to file" to "save as"
- avoid the segmentation fault reported by Ruud Linders in another mail

svn path=/trunk/; revision=14069
2005-04-13 23:12:41 +00:00
Ronnie Sahlberg
6ac7c99cc5 From Francisco Alcoba
Very cool ASCII art version of viop graphs


svn path=/trunk/; revision=14023
2005-04-07 09:14:35 +00:00
Luis Ontanon
27915a0f80 From Alejandro Vaqero:
- Fix a problem when pressing a key when  the "Graph" is  displayed
without any frame selected.

   - Add support for RTP Payload changes. Now the graph will show any
change in the RTP payload type. This is useful for example to show DTMF
2833 in a call.

-This line, and those below, will be ignored--

M    gtk/graph_analysis.c
M    gtk/voip_calls.c
M    gtk/voip_calls.h

svn path=/trunk/; revision=13651
2005-03-07 19:10:21 +00:00
Luis Ontanon
f7d5537137 From Alejandro Vaquero:
patch to the voip calls facility to:

- Add a horizontal scrollbar in the "Graph" to scroll the "comments"
- Fix a "state" bug in H323 and SIP calls
- Fix a bug that can make the "graph" to crash, and also clean up the "address" when the window is close



svn path=/trunk/; revision=13565
2005-03-01 16:19:46 +00:00
Lars Roland
2ed9ca813b By Francisco Alcoba:
Support for name resolution and IPv6 in VoIP Call Analysis

svn path=/trunk/; revision=13501
2005-02-24 21:31:20 +00:00
Luis Ontanon
516d559fe8 From Alejandro Vaquero
voip_calls_dlg.c
    Change the "prepare filter" function to be protocol independent. Now it uses the
    "frame_num"s  from the Graph structure to create the filter. This also add support
    to MGCP and H323 LRQ/LCF filters that were not supported before.

graph_analysis.c:
    Change the mouse scroll wheel implementation to make a 3 line step change instead of 1 line.


svn path=/trunk/; revision=13489
2005-02-24 04:15:40 +00:00
Ulf Lamping
bb3310bd9d prevent messages like "Couldn't load font x, falling back to y", see comment for details
svn path=/trunk/; revision=13468
2005-02-22 07:53:54 +00:00