Commit Graph

1797 Commits

Author SHA1 Message Date
Chris Maynard 3369a97da7 If the user turns off printing of the packet summary line, disable the column headings checkbox; otherwise, enable it.
svn path=/trunk/; revision=50053
2013-06-19 19:16:35 +00:00
Gerald Combs ba951e1a4d Try to make it more obvious that you can select unselected task list
items.

svn path=/trunk/; revision=50052
2013-06-19 18:48:20 +00:00
Chris Maynard f655e90d8b Remove col_headings_cb from print_cmd_toggle_detail() altogether. It's not needed since if summary isn't printed, neither are column headings anyway.
svn path=/trunk/; revision=50051
2013-06-19 18:44:42 +00:00
Evan Huus 50da1aacf9 Try and keep r50047 and still fix
print_dlg.c:916: warning: value computed is not used

svn path=/trunk/; revision=50050
2013-06-19 18:38:52 +00:00
Jörg Mayer 95a68da158 Fix for
Building C object ui/gtk/CMakeFiles/gtkui.dir/print_dlg.c.o
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/print_dlg.c: In function ‘print_cmd_toggle_detail’:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/print_dlg.c:910:38: error: variable ‘col_headings_cb’ set but not used [-Werror=unused-but-set-variable]
   GtkWidget *print_bt, *summary_cb, *col_headings_cb, *details_cb;
                                      ^
cc1: all warnings being treated as errors

No idea wether the fix is correct. Compile tested only.

svn path=/trunk/; revision=50047
2013-06-19 18:30:04 +00:00
Chris Maynard 909d2eb309 Allow for column headers not to be printed in order to make it possible to export packets as plain text in a format that could then have a chance of being imported again (assuming other factors such as packet bytes were printed, etc.) in order to recover the original pcap file.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1636

svn path=/trunk/; revision=50036
2013-06-19 15:22:56 +00:00
Pascal Quantin d09ffee44e Add ability to export decrypted IPsec PDUs
svn path=/trunk/; revision=50022
2013-06-18 23:01:46 +00:00
Alexis La Goutte b381ca4f58 Fix qt make buildbot step
Qt make don't like cp ../../lib/lib{wireshark,wiretap,wsutil}.* .
cp: cannot stat `../../lib/lib{wireshark,wiretap,wsutil}.*': No such file or directory

svn path=/trunk/; revision=49994
2013-06-17 22:56:35 +00:00
Martin Mathieson 860b920383 Make the B->A graph label show as A<-B to be consistent with the column
heading.

svn path=/trunk/; revision=49954
2013-06-16 02:35:51 +00:00
Guy Harris ca0f8ee6da Make the libwiretap Buffer routines usable from C++, and fix the C++ UI
code to handle the API changes for the seek-read routines.

svn path=/trunk/; revision=49950
2013-06-16 01:40:04 +00:00
Guy Harris 8c9edf1280 Have the seek-read routines take a Buffer rather than a guint8 pointer
as the "where to put the packet data" argument.

This lets more of the libwiretap code be common between the read and
seek-read code paths, and also allows for more flexibility in the "fill
in the data" path - we can expand the buffer as needed in both cases.

svn path=/trunk/; revision=49949
2013-06-16 00:20:00 +00:00
Chris Maynard 2c71f23d1e Make use of text metrics and devmode data to properly format a page for printing. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7543
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=49946
2013-06-15 12:57:32 +00:00
Chris Maynard 14b65f91a4 Ensure that Wireshark isn't obscured by the system taskbar or by any other desktop toolbars. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3034
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=49937
2013-06-14 17:47:54 +00:00
Gerald Combs af02ac36ac On OS X set the toolbar icon size to match our current icons.
svn path=/trunk/; revision=49919
2013-06-13 18:58:29 +00:00
Jeff Morriss 51b02ed94d From Peter Hatina via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8793 :
Fix crash if you cancel the Flow Graph window while the Graph Analysis window
is still open: close the Graph Analysis window when the user cancels the Flow
Graph window.

From me: do the same thing for the window-delete case.

svn path=/trunk/; revision=49908
2013-06-12 15:50:37 +00:00
Gerald Combs f5e892cbac Check for QtMacExtras, and if we have it use it to switch to a native
title + toolbar on OS X.

svn path=/trunk/; revision=49873
2013-06-10 21:21:51 +00:00
Gerald Combs 3d59df0ed6 Removing libui_dirty.a in r48976 broke CMake + Qt Creator builds. Fix
it.

svn path=/trunk/; revision=49872
2013-06-10 19:04:13 +00:00
Guy Harris 0b8d569887 If, after editing the settings for a particular interface, we don't have
a Capture Options window to update, don't try to update it.

#BACKPORT

svn path=/trunk/; revision=49850
2013-06-09 00:24:28 +00:00
Jakub Zawadzki a12ee2e673 Fix 'Misaligned columns in hex dump pane' [1]
Old code was broken for all pango version < 1.20

[1] http://www.wireshark.org/lists/wireshark-dev/201306/msg00015.html

svn path=/trunk/; revision=49848
2013-06-08 18:57:49 +00:00
Stig Bjørlykke e4893f0448 Ensure we only put private profiles directly in the profiles menu and
put global profiles in the "New from Global" menu.

svn path=/trunk/; revision=49830
2013-06-07 06:53:24 +00:00
Alexis La Goutte a4d78ca253 From report of IgorVK via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8736 Crash analyzing VoIP Calls
Wireshark crashes when analyzing Telephony->VoIP Calls from the pcap file attached.

From me :
Some packets is detect to be T38 and ->stop_fd is not initialize

#Backport 1.10 and 1.8

svn path=/trunk/; revision=49804
2013-06-06 16:00:23 +00:00
Chris Maynard b4414c61d9 As of r49659, StatisticsMenu is now just Statistics.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8770

svn path=/trunk/; revision=49788
2013-06-05 16:42:22 +00:00
Gerald Combs 8b4b8154a4 The CommDlg_OpenSave_GetFilePath macro fetches the path+name of the most
recently selected file in the current file dialog. This isn't the proper
routine to use when trying to figure out the save/export file name. We
have to dig through the OPENFILENAME struct instead. Fixes bug 8224.

#Backport 1.10

svn path=/trunk/; revision=49765
2013-06-04 18:07:59 +00:00
Anders Broman 78e334b845 From Mike Garratt:
Friendly Names support causing unnecessary delay when Wireshark starts.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8034

svn path=/trunk/; revision=49752
2013-06-04 04:36:19 +00:00
Chris Maynard 27872a9324 Apply the same tooltip for the text entry as for the updated label tooltip in r49726, but with a typo fix: "thefield" -> "the field".
svn path=/trunk/; revision=49727
2013-06-03 20:34:50 +00:00
Gerald Combs a0823d82c9 Custom columns are specified using display filter field names, not
display filters.

svn path=/trunk/; revision=49726
2013-06-03 20:01:15 +00:00
Guy Harris 00ea06430a Implement PARAM_UINT as a spin button with a range of 0 to G_MAXUINT.
svn path=/trunk/; revision=49669
2013-06-01 01:23:59 +00:00
Guy Harris a8e7b7ccfe Neither gtk_mac_lte_stat_init() nor gtk_rlc_lte_stat_init() are referred
to outside the files that define them; make them static.

svn path=/trunk/; revision=49664
2013-05-31 23:07:51 +00:00
Guy Harris 6c4ceb643b The SIP and WSP statistics taps register themselves; get rid of their
hardcoded menu items.

svn path=/trunk/; revision=49663
2013-05-31 23:05:40 +00:00
Guy Harris e8947ae24d Add a REGISTER_STAT_GROUP_TELEPHONY_SCTP, make the SCTP chunk counter
register itself in that group, and get rid of its hardcoded menu item.

Also, as the H.225 counter is registering itself, get rid of its
hardcoded menu item.

svn path=/trunk/; revision=49662
2013-05-31 23:00:39 +00:00
Guy Harris cfebdcd2f5 The BOOTP/DHCP statistics tap registers itself; get rid of the explicit
menu item for it.

svn path=/trunk/; revision=49660
2013-05-31 22:10:43 +00:00
Guy Harris a24a4db3f8 Consistently use "/Statistics", rather than "/StatisticsMenu", in action
names, to avoid confusion.  (Action names are not, in fact, paths; we're
just using path syntax for them as a convention.)

svn path=/trunk/; revision=49659
2013-05-31 22:07:11 +00:00
Guy Harris c7bd9ae115 Add a REGISTER_STAT_GROUP_TELEPHONY_LTE for the Telephony/LTE menu, and
use it o register the MAC and RLC statistics dialogues.  Get rid of the
explicit menu items for them, as they now show up in the menu as a
result of the tap registering itself.

svn path=/trunk/; revision=49658
2013-05-31 21:57:15 +00:00
Balint Reczey 6974bcecb1 Don't call gtk_widget_unregister_window() in bytes_view_unrealize() after GTK+ 3.8.0
to prevent double invocation causing crash.

This fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8604 .
The patch is from Jakub Zawadzki.

svn path=/trunk/; revision=49655
2013-05-31 20:57:07 +00:00
Guy Harris 15894ac4dd Use #ifdefs in the XML to include or exclude the packet-editor and
capture menu items, rather than hiding them at run time.

For the capture menu items, translate the GtkAction callback calling
sequence to the normal widget callback calling sequence with individual
routines for each action, rather than a generic translator.

svn path=/trunk/; revision=49649
2013-05-31 07:06:10 +00:00
Ronnie Sahlberg eb8217a371 IOSTAT: plot LOAD y-axis in number of I/O not number of I/O times 1000
svn path=/trunk/; revision=49647
2013-05-31 02:14:19 +00:00
Guy Harris ecf32a1e7a Put back some conversation list and endpoint list statistics presumably
lost in the conversion to GTKUiManager.

svn path=/trunk/; revision=49642
2013-05-30 22:40:31 +00:00
Guy Harris d34f9683b0 Add a stat group REGISTER_STAT_GROUP_TELEPHONY_GSM for the Telephony/GSM
statistics menu.

Have the CAMEL counter register itself in that menu, rather than having
main_menubar.c create the menu item for it.

svn path=/trunk/; revision=49641
2013-05-30 22:32:10 +00:00
Balint Reczey c7501cbf67 Use gtk_widget_register_window() and gtk_widget_unregister_window()
instead of deprecated gdk_window_set_user_data() for GTK+ 3 >= 3.8

svn path=/trunk/; revision=49633
2013-05-30 16:42:32 +00:00
Gerald Combs d98b0cc231 Fix and clarify name resolution preference tooltips. Print the
description before the name+type since that's presumably what people
are looking for.

svn path=/trunk/; revision=49622
2013-05-29 18:01:03 +00:00
Michael Mann f57fbb614f Bugfix crash when 'SCTP' -> 'Prepare Filter for this Association' has no associations. Bug 8731 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8731)
Dialog (wants to) pop up noting no associations, but sctp_set_filter() wants to press on assuming there is an association. Added NULL check to prevent assumption.

svn path=/trunk/; revision=49610
2013-05-29 13:50:45 +00:00
Evan Huus d986c63c17 In ICMP taps, don't use g_slist_insert_sorted (which results in
n^2 time on the number of packets). Just prepend to the list, then sort
it when we actually need to calculate the statistics.

Should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8721

svn path=/trunk/; revision=49606
2013-05-28 23:20:44 +00:00
Alexis La Goutte 66c859e765 Object::connect: No such signal WiresharkApplication::captureCaptureUpdateContinue(capture_options*) Object::connect: (sender name: 'qtshark')
An omission with latest change in capture_session...

svn path=/trunk/; revision=49579
2013-05-25 15:20:42 +00:00
Alexis La Goutte e9a6053b71 Apply change of Bug 8706 ( "Stream" should be changed to "Follow Stream" in the 'Font and Colors' dialog ) / revision 49488 to Qtshark
svn path=/trunk/; revision=49577
2013-05-25 15:20:23 +00:00
Guy Harris a8023c97a3 Menu labels aren't paths, they're just the strings shown to the user for
the menu item.

svn path=/trunk/; revision=49572
2013-05-25 02:37:51 +00:00
Guy Harris 3598d9e2ac Have register_param_stat() add menu items, rather than having the menu
items hardcoded into ui/gtk/main_menubar.c

Get rid of more stuff implying that the code for adding menu items is
used only by Lua, as it's also used by register_param_stat().

Add the items to the menu list sorted by the menu item name shown to the
user.

Get rid of some const declarations that are lies.

Use the label given for a menu item as the label in the menu, rather
than parsing it from a token.

svn path=/trunk/; revision=49552
2013-05-24 03:10:56 +00:00
Guy Harris 4caa94335d And another (cosmetic) change for that.
svn path=/trunk/; revision=49550
2013-05-24 01:11:07 +00:00
Guy Harris 699f06760c A long-overdue rename of register_dfilter_stat() to
register_param_stat() to reflect that it's for arbitrary statistics tap
parameters, not just a display filter.

svn path=/trunk/; revision=49549
2013-05-24 01:10:16 +00:00
Guy Harris 3c41347f67 Rename register_lua_menu_bar_menu_items() to
register_menu_bar_menu_items(), to emphasize that it's not just for Lua.

svn path=/trunk/; revision=49548
2013-05-24 01:05:39 +00:00
Guy Harris dcdfc836c2 We don't want to restrict the ability to dynamically add statistics
menus to Lua taps.

svn path=/trunk/; revision=49547
2013-05-23 23:32:20 +00:00