Commit graph

2074 commits

Author SHA1 Message Date
Guy Harris
77780b3697 "time_t", not "timer_t".
svn path=/trunk/; revision=13669
2005-03-09 02:39:31 +00:00
Ronnie Sahlberg
0aad06dea5 use the rc4 functions from epan/crypt-rc4 instead of those in heimdal
so that we dont have to include <rc4.h> from heimdal

hopefully the build on freebsd will succeed now


svn path=/trunk/; revision=13668
2005-03-08 23:47:29 +00:00
Ronnie Sahlberg
0f5bac2858 New protocol : KINK
From Taekshi Nakashima   the KINK protocol


svn path=/trunk/; revision=13667
2005-03-08 22:32:43 +00:00
Ronnie Sahlberg
176c87d3dd remove some dependencies of libgssapi
svn path=/trunk/; revision=13665
2005-03-08 21:13:14 +00:00
Ronnie Sahlberg
95532c9493 remove the need to include <gssapi.h> from heimdal
svn path=/trunk/; revision=13664
2005-03-08 20:22:07 +00:00
Ronnie Sahlberg
5cfb848064 If ethereal is linked with HEIMDAL
and Kerberos decryption is enabled in preferences
and if we have the keytab file available

then attempt to decrypt Secure LDAP



svn path=/trunk/; revision=13660
2005-03-08 09:46:24 +00:00
Ronnie Sahlberg
6e6e082d34 when HEIMDAL is linked with :
make spnego able to decrypt data wrapped inside
 GSSAPI/SPNEGO/KRB5 arcfour-hmac

This code will be more etherealified and evolve into being able to link with MIT as well.



svn path=/trunk/; revision=13659
2005-03-08 09:45:19 +00:00
Ronnie Sahlberg
9d20ee0a39 gssapi decryption nees a few new fields to pass the blobs from application layer dissector all the way down to spnego or friends and back.
svn path=/trunk/; revision=13658
2005-03-08 09:43:36 +00:00
Lars Roland
9a1a762922 remove remnants of the old plugin api from dissectors and plugins
svn path=/trunk/; revision=13656
2005-03-07 21:40:29 +00:00
Anders Broman
d8d583a587 Add a g723 dissector to dissect the first byte to find the rate and if speech is pressent or not.
svn path=/trunk/; revision=13652
2005-03-07 20:11:03 +00:00
Luis Ontanon
8b481b2ab9 From Florian Lohoff:
Add Netscreen vendor specific attributes


svn path=/trunk/; revision=13650
2005-03-07 11:35:52 +00:00
Jörg Mayer
8de6e67f08 Fix a small typo that would prevent compilation with MIT Kerberos
svn path=/trunk/; revision=13647
2005-03-07 10:15:03 +00:00
Ronnie Sahlberg
31a9522aa2 export some symbols we will need later.
svn path=/trunk/; revision=13646
2005-03-07 09:02:33 +00:00
Jörg Mayer
f2bab830dc Make packet-kerberos.c compile again:
Replace the use of the undefined type krb5_keyusage (at least with heimdal)
in decrypt_krb5_data with the old int. The change wasn't complete anyway
as the .h file wasn't changed and the third implemenitation of
decrypt_krb5_data was left out also.

Disclaimer: I only made sure it compiles again, I don't know whether the
  change has any side effects.


svn path=/trunk/; revision=13645
2005-03-07 08:47:48 +00:00
Guy Harris
802859d3fd Call the "new-style init" routine for plugins a "register" routine, as
it serves the same purpose as the register routine in a built-in
dissector, and don't require all dissectors to have one, as they might
just be taps.

Get rid of the stats tree's init routine, as it's just a tap, and as it
doesn't do anything.

Update the idl2eth Python script to generate plugins with register routines.

svn path=/trunk/; revision=13644
2005-03-07 02:44:41 +00:00
Guy Harris
ab32b090b7 Back out the BACnet application layer dissectin code - its use of
recursion instead of iteration means that packets with sufficiently
large lists can cause it to overflow the stack and crash.

svn path=/trunk/; revision=13643
2005-03-07 01:22:55 +00:00
Ronnie Sahlberg
7a43aeb457 minor update, add an extra parameter to a call to prepare for decryption of GSSAPI wrapped data
svn path=/trunk/; revision=13642
2005-03-06 22:52:58 +00:00
Ronnie Sahlberg
26dd060797 export decrypt_krb5_data
svn path=/trunk/; revision=13641
2005-03-06 22:34:13 +00:00
Guy Harris
722832f739 The length field in the "BACnet encoding rules" is limited to 32 bits
("Data lengths larger than 2^32-1 are not encodable using primitive
tags"), so it doesn't need to be a "guint64" - but it *can* be that big,
so we should handle the 65536-2^32-1 case.

Don't gratuitously throw away the upper 24 bits of various lengths by
casting them to guint8.

Show signed values as such.

Don't use "match_strval()" - it returns a null pointer if it doesn't
find the value in the value_string table; instead, use "val_to_str()" so
we don't blow up if the value isn't found.

svn path=/trunk/; revision=13640
2005-03-06 22:14:24 +00:00
Luis Ontanon
c57a54f3ec Add a preference for another alternate tcp port
svn path=/trunk/; revision=13638
2005-03-06 21:32:13 +00:00
Anders Broman
2f4c6bf770 Fix a minor bug with FT_BOOLEAN.
svn path=/trunk/; revision=13637
2005-03-06 20:54:01 +00:00
Luis Ontanon
e23d044fb8 add format_text() to the plugin API
svn path=/trunk/; revision=13636
2005-03-06 20:43:54 +00:00
Guy Harris
e41c4740c9 Handle XNS IDP socket numbers.
Handle SMB-over-SPP.

svn path=/trunk/; revision=13635
2005-03-06 20:13:58 +00:00
Guy Harris
e27279e14d "report_err.h" declares "report_failure()", so it doesn't need to be
declared in "epan.h", and, as "epan/plugins.c" now includes
"report_err.h", it doesn't need to include "epan.h".

svn path=/trunk/; revision=13634
2005-03-06 19:37:09 +00:00
Luis Ontanon
cb90b0da79 - replace tabs with spaces while printing
- get rid of a warning in windows compile

svn path=/trunk/; revision=13631
2005-03-06 17:06:55 +00:00
Jörg Mayer
8b13213e85 Warning fix:
plugins.c:236: warning: implicit declaration of function
        'report_failure'


svn path=/trunk/; revision=13625
2005-03-06 09:40:58 +00:00
Jörg Mayer
9432483a14 Warning fix:
packet-sdp.c:74: warning: 'reset_sdp_packet_info' declared 'static'
        but never defined


svn path=/trunk/; revision=13624
2005-03-06 09:33:44 +00:00
Guy Harris
177e6f1bc2 From Yaniv Kaul: show the protocol name in every record.
svn path=/trunk/; revision=13623
2005-03-06 04:42:51 +00:00
Guy Harris
1a4502d5a9 Squelch some compiler warnings.
svn path=/trunk/; revision=13622
2005-03-06 04:41:42 +00:00
Guy Harris
a313c47a59 Get rid of an unused variable.
svn path=/trunk/; revision=13621
2005-03-06 04:41:00 +00:00
Guy Harris
f63c9301b2 No, the code is the numerical value, not the vendor ID.
svn path=/trunk/; revision=13618
2005-03-06 03:38:17 +00:00
Guy Harris
c9826f64d8 From Ben Turner: fix an addVendor() call.
svn path=/trunk/; revision=13617
2005-03-06 03:28:41 +00:00
Guy Harris
84f0170f07 Add a newline to the end of the file.
svn path=/trunk/; revision=13616
2005-03-06 03:25:19 +00:00
Guy Harris
b21ab2a5e0 Get rid of "unknown transport" warnings - don't spam the user just
because we haven't yet written a dissector for a particular protocol.

svn path=/trunk/; revision=13615
2005-03-06 03:19:34 +00:00
Guy Harris
2ad3b256f4 Handle the "32-bit length is > 2^31-1, so the protocol tree routines
will treat it as negative" problem by first calling
"tvb_ensure_bytes_exist()" - if the length is *that* large, it will run
past the end of the tvbuff, so the exception that
"tvb_ensure_bytes_exist()" will throw with a negative argument will be
the correct exception.

svn path=/trunk/; revision=13614
2005-03-06 03:11:24 +00:00
Guy Harris
39ad72864f No, they don't use BER for the variable portion of a PDU; update the
comment appropriately.

Make a bunch of routines static.

Don't just dissect stuff past the end of the variable portion as data -
the protocol spec doesn't appear to say there's anything after that.

Don't pass the offset to the routines to dissect the different types of
PDUs, just have them start at 0.

Use guint8 for 8-bit unsigned quantities.

Rename the routine to dissect Abort PDUs to match the other PDU
dissectors.

svn path=/trunk/; revision=13611
2005-03-06 02:24:49 +00:00
Guy Harris
476c8da086 Don't use "long" and "%l[doux]" for 64-bit quantities, use guint64 and %
followed by PRIu64.

Don't use C++/C99-style comments.

Use "tvb_reported_length()" to get packet lengths - don't use
"tvb_length()", and especially don't directly refer to the "length"
field of the tvbuff.

svn path=/trunk/; revision=13609
2005-03-06 01:53:56 +00:00
Jörg Mayer
8940beb1e2 Martin Mathieson: Add information sources
svn path=/trunk/; revision=13607
2005-03-06 01:15:29 +00:00
Guy Harris
ea23bf66f9 From Herbert Lischka: implement some (not all) tags according to BACNET
application handbook.

svn path=/trunk/; revision=13605
2005-03-06 00:17:37 +00:00
Guy Harris
4576918110 For OSPF versions other than 2 or 3, stop dissecting the packet after
the checksum (which is the last header field common to V2 and V3).

svn path=/trunk/; revision=13603
2005-03-05 23:36:07 +00:00
Ronnie Sahlberg
7d6a1b502c From Mike Duigou updates to JXTA
svn path=/trunk/; revision=13602
2005-03-05 21:00:41 +00:00
Guy Harris
30a19a9b3c Clean up indentation.
Strings don't have a base, so use BASE_NONE with them, not BASE_DEC or
BASE_HEX.

svn path=/trunk/; revision=13600
2005-03-05 20:36:03 +00:00
Ronnie Sahlberg
aaa9cb5150 New Protocol : DTP
From Charlie Lenahan   initial DTP support


svn path=/trunk/; revision=13598
2005-03-05 11:12:01 +00:00
Ronnie Sahlberg
a7ca6143e7 from susanne edlund : make tlli appear in the tree
also change value_length and total_length signed to eliminate a compiler warning



svn path=/trunk/; revision=13597
2005-03-05 10:51:30 +00:00
Lars Roland
00273300e7 Preparations for dropping the old plugin api.
Introduce a new init routine for plugins, 
which does not take the plugin api table as an 
argument and allows etheral to distinguish 
between plugins using the old and the new api.

Update README.plugins accordingly

Change all g_warnings() in epan/plugins.c to report_failue().
On windows we do not have a log console open while
loading the plugins, because a log console cannot be opened before the prefs have been read. Thus g_warnings()
does not work for reporting problems with plugins.

svn path=/trunk/; revision=13596
2005-03-05 06:28:10 +00:00
Guy Harris
1a7b3ec143 From Susanne Edlund: filter on NRI values in BSSGP.
svn path=/trunk/; revision=13595
2005-03-05 04:58:13 +00:00
Guy Harris
001b5aaba6 From Chris Waters: correct an error with the decoding of signal
strength information in 802.11 captures.

svn path=/trunk/; revision=13594
2005-03-05 01:03:22 +00:00
Guy Harris
5ba3adf134 Omit some stuff when building without a Kerberos library, as it's unused
if you don't have a Kerberos library to do decryption.

svn path=/trunk/; revision=13593
2005-03-05 01:00:15 +00:00
Michael Tüxen
10edbd81c3 Enable details in protocol tree by default like TCP and UDP.
svn path=/trunk/; revision=13592
2005-03-05 00:51:33 +00:00
Lars Roland
e434150f99 fix kerberos dissector for those having no kerberos decryption
svn path=/trunk/; revision=13591
2005-03-05 00:21:46 +00:00
Ronnie Sahlberg
413deb9130 from Carlos Pignataro
update MPLS to support MPLS Echo



svn path=/trunk/; revision=13590
2005-03-04 22:32:06 +00:00
Ronnie Sahlberg
7671b98bac make kpasswd privide subdissectors to handle the user-data field for the KRB_PRIV structure for kpasswd requests and replies.
decrypt and behold the new password in plaintext in all its glory
(given you have the keytab with the old one of course)


svn path=/trunk/; revision=13586
2005-03-04 13:39:15 +00:00
Ronnie Sahlberg
6fec8dca5f some authentication stuff from metze
svn path=/trunk/; revision=13584
2005-03-04 12:28:00 +00:00
Ronnie Sahlberg
2f4cb22585 make ethereal able to decrypt KRB_PRIV which kpasswd uses
svn path=/trunk/; revision=13583
2005-03-04 12:21:40 +00:00
Ronnie Sahlberg
bb77a3224f the unknown stuff in the decrypted blobs in mapi are just uninitialized buffer padding so dont show them in the decode tree
svn path=/trunk/; revision=13582
2005-03-04 11:08:03 +00:00
Luis Ontanon
5ef5e77434 From Francisco Alcoba,
do not look for data blocks in ACK packets


svn path=/trunk/; revision=13581
2005-03-03 13:59:52 +00:00
Guy Harris
fa7eb4fdeb From Anders Broman: fix a fault in the CODEC LIST routine where offset
was wrongly calculated, and clean up some other miscellaneous stuff.

svn path=/trunk/; revision=13580
2005-03-03 10:23:29 +00:00
Guy Harris
8ff4e8160e Oops, forgot packet-idp.h.
svn path=/trunk/; revision=13579
2005-03-03 09:36:19 +00:00
Guy Harris
0de93bd590 From Yuriy Sidelnikov: correctly display User Information
field in release request/response PDu if the Reason field
is absent.

svn path=/trunk/; revision=13578
2005-03-03 08:54:00 +00:00
Guy Harris
282080e26d Add support for what appears to be 3Com's scheme for encapsulating XNS
over Token Ring (and presumably other link layers using 802.2 LLC), and
for the XNS IDP and SPP protocols.

svn path=/trunk/; revision=13577
2005-03-03 08:34:48 +00:00
Guy Harris
439a65b82f Use "tvb_get_string()" to fetch strings from the packet, rather than
filling up a fixed-length buffer.

Add a bunch of length checks.

Clean up indentation.

svn path=/trunk/; revision=13574
2005-03-02 21:08:47 +00:00
Anders Broman
7cb9e36324 Present diameter time as UTC time rather than the local time zone of the machine running Ethereal is at.
Insert a comment that time before 1970 will not be presented properly.

svn path=/trunk/; revision=13573
2005-03-02 20:16:18 +00:00
Guy Harris
e84c3d927c Handle the CRC correctly:
don't do it if we don't have the entire packet, including the
	CRC value;

	fetch the CRC value from the packet with tvb_get_letoh24(),
	and compare that against the computed CRC, rather than comparing
	the computed CRC (presumably in host byte order) with the
	little-endian CRC in the packet (that doesn't work if host byte
	order is big-endian).

svn path=/trunk/; revision=13571
2005-03-02 00:21:33 +00:00
Guy Harris
bb7d0d43e8 Set the svn:keywords and svn:eol-style properties appropriately, and
give it an RCS ID.

svn path=/trunk/; revision=13568
2005-03-01 21:47:54 +00:00
Luis Ontanon
ecea5fac96 In packets with more than one req/resp the items of all the req/resp subtrees always pointed to the offset of the first req/resp.
svn path=/trunk/; revision=13564
2005-03-01 11:37:26 +00:00
Ronnie Sahlberg
175815e0fe If errorrecoverylevel==0 is used and the A bit is clear in a DataIn PDU
the iscsi layer will not hold the LUN value (it is reserved)
so we need to remember if from the initial Command PDU.

make the LUN reporting work for errorrecoverylevel==0 targets


svn path=/trunk/; revision=13563
2005-03-01 10:09:53 +00:00
Guy Harris
dfc51396ee Show NTP times correctly.
svn path=/trunk/; revision=13562
2005-03-01 06:32:56 +00:00
Guy Harris
fc96a5d5f3 Show NTP times in a fashion more similar to that used for other times.
svn path=/trunk/; revision=13561
2005-03-01 06:04:31 +00:00
Guy Harris
cfb9cf0129 Show NTP times correctly.
svn path=/trunk/; revision=13560
2005-03-01 06:03:08 +00:00
Guy Harris
3d5b1d5f13 From Graeme Hewson: rename the global preferences file to "preferences"
(it's now in an "ethereal" directory, so there's no need for it to have
a name that distinguishes it from files for other programs) - if it's
not found as "preferences", try "ethereal.conf" for compatibility - and
update the man pages appropriately.

Fix a typo in the section color filters (the file name is "colorfilters",
not "color filters").

svn path=/trunk/; revision=13559
2005-03-01 00:05:57 +00:00
Luis Ontanon
88ffe08066 even if unharmful, this was simply ugly.
change

do {
 if (i == 0) break;
 ...
} while (i);

for a propper

while(i) {
 ...
}


svn path=/trunk/; revision=13557
2005-02-28 22:39:03 +00:00
Luis Ontanon
d018dcf663 few changes to http
- stat_infos are mantained in a GPtrArray to avoid leaking and overwriting them
- added http_host and request_uri to http_info_value_t 


svn path=/trunk/; revision=13555
2005-02-28 22:27:24 +00:00
Anders Broman
aae42374bc Change the RADIUS ATTRIBUTES for some 3GPP AVP:s to display them as (UTF8)Strings, also
added some more AVP:s from a later spec.

svn path=/trunk/; revision=13554
2005-02-28 20:51:23 +00:00
Anders Broman
3167213f5d Undo change of return (addVendor(atoi(id), code, name)); as it wasn't correct.
svn path=/trunk/; revision=13553
2005-02-28 20:49:34 +00:00
Anders Broman
e09fcce637 Correct presentation of IMSI digits and highlight correct bytes.
svn path=/trunk/; revision=13552
2005-02-28 20:48:23 +00:00
Guy Harris
daf2a17826 Add a link to an RX spec, and ask whether the Epoch really should be
dissected as a UN*X time.

svn path=/trunk/; revision=13551
2005-02-28 19:47:46 +00:00
Guy Harris
6421106005 Fix capitalization.
svn path=/trunk/; revision=13549
2005-02-28 09:21:59 +00:00
Guy Harris
66a1da065b Map "llcgprs.ignore_cipher_bit" to "llcgprs.autodetect_cipher_bit".
svn path=/trunk/; revision=13548
2005-02-28 09:21:19 +00:00
Luis Ontanon
693f9f3838 Add register_all_plugin_tap_listeners() to libethereal.def
svn path=/trunk/; revision=13544
2005-02-27 23:43:12 +00:00
Guy Harris
dd4b0b718b The stats tree stuff should ultimately allow us to have plugin taps, so
add infrastructure for them, and display the plugin type (which could be
both dissector *and* tap) in the list of plugins.

svn path=/trunk/; revision=13543
2005-02-27 22:04:48 +00:00
Anders Broman
e18e3db225 Avoid trying to display a time before 00:00:00 UTC, January 1, 1970 as it currently will be displayed wrongly.
svn path=/trunk/; revision=13542
2005-02-27 21:33:32 +00:00
Luis Ontanon
36833b76d8 From Stefano Pettini
1) added _U_ tags in RMT dissectors to suppress "unused parameter" warnings.

2) added a dissector_add_handle("ip.udp", ip_handle) to IP dissector, to
allow the following chain of protocols: IP over UDP over IP. It seems
uncommon, but it's used by implementations of experimental protocols
(e.g. TCP-XM) that run a userspace IP stack (e.g. lwIP) over UDP. The
dissector of IP over UDP must be enabled explicitly using the "decode
as..." window.



svn path=/trunk/; revision=13540
2005-02-27 20:26:55 +00:00
Ulf Lamping
fed921bff9 add missing reinit_stats_tree symbol, so MSVC can compile again
svn path=/trunk/; revision=13536
2005-02-27 18:27:30 +00:00
Luis Ontanon
93c46dde91 Several fixes to the stats_tree
- Avoid creating a copy of every branch at reinitialization
       this used to cause some GTK warnings and a leakage of tree nodes

- propperly check the optarg to avoid getting junk in the filter text
       this caused a crash


svn path=/trunk/; revision=13534
2005-02-27 16:55:24 +00:00
Guy Harris
5639b87daf The Kerberos-over-UDP dissector can decide not to dissect packets, so it
needs to be a new-style dissector and explicitly reject them so that
other dissectors can pick them up.

svn path=/trunk/; revision=13528
2005-02-26 00:14:22 +00:00
Guy Harris
c68bde2e82 The Kerberos 4 dissector is now a dissector that can reject packets, so
register it with "new_register_dissector".

svn path=/trunk/; revision=13527
2005-02-25 23:47:21 +00:00
Guy Harris
9105f362c2 Make the DCE transport type an "int" so that -1 is a valid value and the
compiler doesn't say "that's unsigned, it can't possibly be equal to -1".

svn path=/trunk/; revision=13526
2005-02-25 23:44:44 +00:00
Lars Roland
b9325102e6 Add another function from epan/stats_tree.c to the list of exported functions in libethereal.def
Finally ethereal can be built again on windows.

svn path=/trunk/; revision=13525
2005-02-25 23:37:14 +00:00
Ronnie Sahlberg
9087bf8e45 start dissecting serviceactionin16
svn path=/trunk/; revision=13523
2005-02-25 23:03:24 +00:00
Lars Roland
f4f37d0fdf Add another function from epan/stats_tree.c to the list of exported functions in libethereal.def
svn path=/trunk/; revision=13520
2005-02-25 22:06:00 +00:00
Lars Roland
13e4abf336 Add some functions from epan/stats_tree.c to the list of exported functions in libethereal.def
svn path=/trunk/; revision=13519
2005-02-25 21:51:29 +00:00
Michael Tüxen
a88d115a38 Show prot numbers in protocol tree, if wanted. Suggested by Jeff Morris.
svn path=/trunk/; revision=13518
2005-02-25 21:03:48 +00:00
Michael Tüxen
22012f92d0 Add higher SI values.
svn path=/trunk/; revision=13517
2005-02-25 20:33:28 +00:00
Ronnie Sahlberg
7f86cffa58 add support to call krb4 for suspected krb4 stuff soming in on udp port 88
weirdo krb4 implementations apparently do this.


svn path=/trunk/; revision=13516
2005-02-25 11:38:56 +00:00
Ronnie Sahlberg
4a338216da pinfo->private_data was a quite subptimal idea
change the decodeas for dcerpc so that it actually works again for dcerpc over smb



svn path=/trunk/; revision=13515
2005-02-25 10:30:21 +00:00
Guy Harris
76ed6a51e1 There's no "tick_range_with_parent_name()" routine.
svn path=/trunk/; revision=13513
2005-02-25 09:56:04 +00:00
Guy Harris
35bba3db57 Add the stats tree routines.
Alphabetize, in dictionary order (case-insensitive).

svn path=/trunk/; revision=13510
2005-02-25 07:48:51 +00:00
Luis Ontanon
8d189d27cc change to int the return type of manip_stat_node() so that it can be used as a parent
svn path=/trunk/; revision=13508
2005-02-25 05:14:38 +00:00
Luis Ontanon
51913513e2 Get stats_tree compiled
svn path=/trunk/; revision=13507
2005-02-25 04:02:00 +00:00
Luis Ontanon
ca67abe524 some more work for
- beautify the text output
- make gtk1 textbox implementation usable (I hope)


svn path=/trunk/; revision=13506
2005-02-25 03:56:12 +00:00