Commit graph

58 commits

Author SHA1 Message Date
Anders Broman
6300621b52 Check if we have a handle for "v110".
svn path=/trunk/; revision=30823
2009-11-04 16:40:52 +00:00
Bill Meier
d4a921730b (Trivial) Fix a typo in a comment
svn path=/trunk/; revision=30560
2009-10-15 02:39:06 +00:00
Bill Meier
741bc8368e #include <stdio.h> not req'd;
Adjust some spacing.

svn path=/trunk/; revision=30552
2009-10-12 20:57:01 +00:00
Kovarththanan Rajaratnam
00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings
* Remove check_col guards

svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Kovarththanan Rajaratnam
8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Kovarththanan Rajaratnam
56369978ae Custom columfication:
* Deprecate COL_CIRCUIT_ID (Circuit ID). Use iax2.call

svn path=/trunk/; revision=29515
2009-08-23 09:52:57 +00:00
Kovarththanan Rajaratnam
27f7d88c84 Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere.
svn path=/trunk/; revision=29490
2009-08-21 11:03:30 +00:00
Kovarththanan Rajaratnam
8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam
ac463d2697 Don't guard col_clear with col_check
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam
6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman
c91a384702 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28356
2009-05-13 19:46:11 +00:00
Bill Meier
6f92b028aa Use some default true_false_string's.
svn path=/trunk/; revision=27983
2009-04-07 12:20:41 +00:00
Jaap Keuter
6acffc2357 Get the build going again on non-Windows compilers.
svn path=/trunk/; revision=27697
2009-03-11 07:35:43 +00:00
Anders Broman
564846935a From Carlos Mendioroz:
IAX2 calls statistics window ala RTP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3217

svn path=/trunk/; revision=27696
2009-03-11 06:43:46 +00:00
Bill Meier
c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Guy Harris
92f318bb83 Add Linux AF_ values to epan/aftypes.h; IAX2 implicitly uses them.
Have the IAX2 dissector include <epan/aftypes.h> and use the Linux AF_
values from it.  Point to the IAX2 I-D, and add some clarifying
comments.

svn path=/trunk/; revision=25962
2008-08-08 20:07:23 +00:00
Jeff Morriss
bb72192654 Change a string's declaration from guint8 to a gchar
svn path=/trunk/; revision=25708
2008-07-11 19:30:10 +00:00
Anders Broman
df8081391b Fix bug "iax2 dissector always reports retransmission bit to be false"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2666

svn path=/trunk/; revision=25652
2008-07-01 21:05:45 +00:00
Bill Meier
33af75a599 Fix some warnings reported by gcc -Wshadow ...
svn path=/trunk/; revision=25628
2008-06-28 21:09:57 +00:00
Anders Broman
1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Jaap Keuter
cf95f5ccfd Fix the build
svn path=/trunk/; revision=22466
2007-08-08 07:04:28 +00:00
Richard van der Hoff
0982bc011c remember to dissect IEs which we rely on elsewhere, even when there is no
packet tree.

svn path=/trunk/; revision=22464
2007-08-07 22:49:31 +00:00
Jaap Keuter
a286ab2d9b Fix for bug 1585:
Add new frame types for IAX protocol and modem subclass dissection.

svn path=/trunk/; revision=22226
2007-06-29 19:00:46 +00:00
Guy Harris
847846d825 memmove() is needed only if the source and destination might overlap.
svn path=/trunk/; revision=21589
2007-04-26 05:35:04 +00:00
Guy Harris
f16cd039c9 Make ADD_ADDRESS_TO_HASH() take a pointer to an address as an argument,
as the other address macros do.

svn path=/trunk/; revision=21588
2007-04-26 04:30:41 +00:00
Guy Harris
febd662cf3 Get rid of unused variable.
svn path=/trunk/; revision=21582
2007-04-26 02:36:24 +00:00
Guy Harris
d78cbd4b00 Get rid of no-longer-needed variable.
svn path=/trunk/; revision=21580
2007-04-26 01:35:26 +00:00
Guy Harris
bba0b00392 Rename HASH_ADDRESS to ADD_ADDRESS_TO_HASH, to make it clearer what it
does (i.e., it will add the address bytes to the value that's already
there - it will not initialize the value, so you have to clear it before
doing any hashing).

svn path=/trunk/; revision=21578
2007-04-26 01:01:27 +00:00
Guy Harris
1ed26d317c Add a macro for hashing the bytes of an address into a hash value.
Use it in the IAX2 dissector and in the conversation code.

svn path=/trunk/; revision=21577
2007-04-26 00:51:33 +00:00
Guy Harris
41cafa2212 The data pointer of an address structure is a void *; convert it to a
guint8 * in order to look at the raw bytes of the address.

svn path=/trunk/; revision=21576
2007-04-26 00:03:41 +00:00
Stephen Fisher
8fd3ee0560 Remove almost all of the casts I committed recently and in place of
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it.


svn path=/trunk/; revision=21253
2007-03-28 21:55:11 +00:00
Stephen Fisher
ab8f589336 Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors
svn path=/trunk/; revision=21233
2007-03-27 22:50:11 +00:00
Ulf Lamping
7994794ad9 fix a lot more warnings
svn path=/trunk/; revision=21142
2007-03-23 01:29:52 +00:00
Anders Broman
f34fa9c0ef From Richard van der Hoff:
This patch makes the defragmentation code in the iax2 dissector handle 
pinfo->desegment_len=DESEGMENT_ONE_MORE_SEGMENT, in line with
Ronnie's changes to the tcp dissector of 11 November.

svn path=/trunk/; revision=20892
2007-02-21 06:48:28 +00:00
Ronnie Sahlberg
142763b216 coverity 174
ifdef out a few lines of dead code for a feature that is not yet finished

remove two compiler warnings about uninitialized variables (they are not uninitialized, just gcc being dumb)



svn path=/trunk/; revision=18558
2006-06-23 12:04:00 +00:00
Ronnie Sahlberg
feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Jörg Mayer
f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Anders Broman
8402972003 From Richard van der Hoff
Here's another rework of the iax desegmentation logic, which 
fixes bug 515 and its dupes.

svn path=/trunk/; revision=16193
2005-10-11 19:44:59 +00:00
Anders Broman
24a1fd561d From Richard van der Hoff
I've spotted a bug in the new desegmentation in iax2, which 
means that higher-level PDUs aren't dissected when they ought to be, but 
tend to be grouped together in later packets - I've attached a patch 
against svn r16110 to fix this; it also makes the code a bit clearer...

svn path=/trunk/; revision=16121
2005-10-04 20:21:18 +00:00
Guy Harris
f34436d517 Don't assume that every packet has a non-null "call_data" value. Fixes
bug 497 (as well as a crash on an *unfuzzed* IAX2 capture!).

Set "pinfo->can_desegment" before calling dissectors; that's expected
for dissectors that do TCP-style desegmentation.

svn path=/trunk/; revision=16099
2005-10-04 01:16:06 +00:00
Ulf Lamping
376e1adf58 from Peter Johansson:
The supplied patch resolves an issue with the use of the not yet initialized variable "fid".

/ Regards, Peter 

svn path=/trunk/; revision=16079
2005-10-03 15:52:14 +00:00
Anders Broman
093040a179 From Jeff Snyder
00-iax.diff
 Modifications to the IAX2 dissector so that it offers desegmentation to 
subdissectors using the same API as TCP offers (pinfo->desegment_len etc)

01-amr.diff
 Modifications to the AMR dissector to allow AMR IF2 data to be dissected via 
call_dissector() from packet-h223.c. This patch also causes the AMR dissector 
to append the frame type string to the info column, so that the info column 
shows what protocols an H.223 frame contains.

02-h263-data.diff
 Modifications to packet-h263.c to separate the dissection of h.263 RTP 
encpasulation from the dissection of the actual h.263 data. The data 
dissection functions are added as a second dissector. This data-only 
dissector is used to dissect the video channel in our h.223 streams. As with 
the AMR modification, this makes the H.263 dissector append to the info 
column.

svn path=/trunk/; revision=16068
2005-10-02 20:59:54 +00:00
Guy Harris
b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Guy Harris
4ea949e8f2 Put back a subtraction of 1 millisecond that was lost.
svn path=/trunk/; revision=15596
2005-08-28 19:28:04 +00:00
Ulf Lamping
6f43fbb2f0 EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...

What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.

As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.

Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...

As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...

svn path=/trunk/; revision=15520
2005-08-24 21:31:56 +00:00
Ulf Lamping
994496a184 several times replacing:
sprintf -> g_snprintf
snprintf -> g_snprintf
vsnprintf -> g_vsnprintf
strdup -> g_strdup

svn path=/trunk/; revision=15412
2005-08-18 19:31:15 +00:00
Ronnie Sahlberg
c30eeef7d8 some more gmemchunk -> se_alloc() updates
there are only 5 gmemchunks left   but they have different litetime for their allocations   than the 100+   ones that have been removed.

The remaining 5 should be converted some other way.




svn path=/trunk/; revision=15328
2005-08-13 01:29:31 +00:00
Guy Harris
960f9cb5e7 In an "address" structure, "data" is a pointer; dereferencing "&data"
doesn't give you the address value, it gives a pointer to the address
value.

Don't assume that pointer is aligned on a 32-bit boundary.

svn path=/trunk/; revision=15300
2005-08-12 07:47:27 +00:00
Jörg Mayer
050b3b5a97 Separate declaration from initialization with non-static values
svn path=/trunk/; revision=15216
2005-08-04 22:54:04 +00:00