Commit graph

23 commits

Author SHA1 Message Date
Luis Ontanon
d56f4f3a68 - turn some other TC from FT_BYTES to FT_STRING so that human-readable strings become readable by humans
- Add the EngineId decoding for the contextEngineId
- Add some expert info about malformed indexed oids


svn path=/trunk/; revision=22720
2007-08-28 23:55:49 +00:00
Luis Ontanon
450767fb93 Report loading failures to the user
svn path=/trunk/; revision=22712
2007-08-28 19:07:39 +00:00
Luis Ontanon
dfbac00752 SNMP:
- As noted by Thomas Anders values are not added to the tree anymore. Move the calling of subdissectors to the end of the function, so that the value is added to the tree.
 - add port 8161 to be decoded as SNMP (hey, it's on IANA's services file!)
UAT:
 - do not have the uat reloaded.
OIDS:
 - do not complain if renaming an OID to an identical name



svn path=/trunk/; revision=22704
2007-08-28 15:18:32 +00:00
Jaap Keuter
22cb9fb03f Fix warnings "dereferencing type-punned pointer will break strict-aliasing rules"
svn path=/trunk/; revision=22699
2007-08-28 05:59:09 +00:00
Luis Ontanon
5e7a8a9a87 Do not throw, some of this functions get called outside TRY blocks.
svn path=/trunk/; revision=22692
2007-08-27 21:29:20 +00:00
Luis Ontanon
4e26d3ad2e cast a guint64 down to guint32 before assignment to get windows build running
svn path=/trunk/; revision=22689
2007-08-27 19:37:48 +00:00
Luis Ontanon
1b760a7ae5 Fixed an ep_ buffer overflow (off by one) in oid_subid2string()
Abort on integer overflow in oid_string2subid() and oid_encoded2subid()





svn path=/trunk/; revision=22688
2007-08-27 19:14:30 +00:00
Guy Harris
49dbf60a03 Get rid of extra newlines at the end of epan/oids.h, and give one of
them to epan/oids.c. :-)

svn path=/trunk/; revision=22687
2007-08-27 18:44:55 +00:00
Luis Ontanon
392fd3f689 - packet-snmp(-template).c
- reimplement the "snmp.variable_oid" dissector table
- oids.[ch]
   - get rid of keytype_implicit in oid_value_type_t we won't use it.
   - have the windows base path for mibs be consistent to where we've put the mibs
   - oid_get_from_encoded() and oid_get_from_string(): have the subids array being computed in a prior statement of where the side-effected argument is going to be used... worked on gcc, not on windows... I deserve "have daemons flying out of my nose" for that :-).


svn path=/trunk/; revision=22684
2007-08-27 17:05:11 +00:00
Luis Ontanon
9a850615d1 Give the files its propper title
Keep libsmi's default path and append the user given one


svn path=/trunk/; revision=22677
2007-08-26 21:37:11 +00:00
Luis Ontanon
6ce4115354 Turns out that smiGetMinSize() and smiGetMaxSize() exists only in libsmi's HEAD... ;-)
Official releases do not have them yet, avoid using them.


svn path=/trunk/; revision=22662
2007-08-25 23:49:09 +00:00
Luis Ontanon
782c19a0c5 get libsmi into the picture
svn path=/trunk/; revision=22661
2007-08-25 20:27:58 +00:00
Luis Ontanon
bcd55f4c8e replace oid_to_str_buf() and oid_to_str()
fix a potential buffer overflow due to a very liberal estimate by oid_repr_len()


svn path=/trunk/; revision=22659
2007-08-25 17:29:55 +00:00
Luis Ontanon
7c174c63f8 Initialize to zero all subids in oid_string2subid() to avoid creating bogus oids. This is aspirin for a buffer overflow somewhere in the code that reads cretificates, that dimensions a buffer probably assumung oid subids are few digits while they can actually be bigger.
Place two DISSECTOR_ASSERT() guards to avoid an (I believe impossible) buffer overflow of the ep_allocated subid array in  oid_string2subid() and oid_encoded2subid().


svn path=/trunk/; revision=22656
2007-08-25 14:15:56 +00:00
Luis Ontanon
00c5e48a17 get users of oid_resolv to use the new oids, rollout packet-snmp.c
svn path=/trunk/; revision=22651
2007-08-25 01:14:24 +00:00
Richard van der Hoff
b2f5d183fa fix 'unused variable' warning
svn path=/trunk/; revision=22631
2007-08-24 12:43:38 +00:00
Luis Ontanon
e7d5e2fc2d Another iteration, the new code is almost there, We're missing just the implied octetstrings indexes.
svn path=/trunk/; revision=22618
2007-08-24 00:26:30 +00:00
Luis Ontanon
cfc4b0efc8 Implement Resolution of conceptual table indexing
So far this has being tested only for integer indexes.


svn path=/trunk/; revision=22606
2007-08-23 19:45:31 +00:00
Luis Ontanon
4e3372473b Prepare the oids dataset for managing conceptual table indexing
svn path=/trunk/; revision=22596
2007-08-22 22:56:36 +00:00
Luis Ontanon
76658ef0f1 A further iteration in the code, things start to look good!
svn path=/trunk/; revision=22575
2007-08-21 21:32:00 +00:00
Luis Ontanon
a5efe69a79 Filtering on snmp variables starts to work so I put it there in case anyone wants to start playing with it. I'll leave the generated dissector in place and the rest off the Makefiles so that others are not bothered by this.
TODO:
- Global
   - add libsmi to autoconf (I modified CFLAGS and LDADDs in the makefile.ams appending my own values, that's good only for me)
   - have other users of oid_resolv.h get to use the new functions in oids.h
   - add a menu item or preference setting for the smi_modules UAT ( the smi_modules file has one dquoted string per line with the name of each module to be loaded)
- SNMP
  - put complete information in the labels of the VarBind Items
  - add oids to COL_INFO
  - negative testing (Well, testing in general)
- OIDS
  - implement "ALL" modules 
  - some functions are not yet tested or implemented

I'll put a TO-DO list on the wiki for people (incl. me) to add more items




svn path=/trunk/; revision=22556
2007-08-19 23:00:47 +00:00
Luis Ontanon
b782333f20 - It's just-a-bad-idea(tm) to redefine anything from a foreign library, Don't.
- Allow to look for value-types by name.

[still largelly  untested]

svn path=/trunk/; revision=22524
2007-08-16 06:48:51 +00:00
Luis Ontanon
05bdebe45d I'm at the end of the second iteration, so far this compiles OK still haven't tested it but it does not go in the Makefiles, I need this as a reference point.
svn path=/trunk/; revision=22508
2007-08-15 19:52:44 +00:00