Commit Graph

2877 Commits

Author SHA1 Message Date
Anders Broman b05b62d64a From Andrei Emeltchenko:
OMA again has changed the format of the 2 RTCP packets:

RTCP Grant and RTCP Taken

In RTCP Grant instead of spare 2 bytes there are: magic number and item_len.

In RTCP Taken there is an extra field "Number of participants" like in Grant.
http://www.openmobilealliance.org/release_program/docs/CopyrightClick.asp?pck=PoC&file=V1_0-20051104-C/OMA-TS-PoC-UserPlane-V1_0-20051104-C.pdf

svn path=/trunk/; revision=17125
2006-01-30 05:35:39 +00:00
Anders Broman ae9e7131f9 Actually use the valuestring...
svn path=/trunk/; revision=17122
2006-01-29 22:12:26 +00:00
Guy Harris 9958e6b581 Fix indentation, add a /* FALLTHRU */ comment.
svn path=/trunk/; revision=17121
2006-01-29 21:41:44 +00:00
Lars Roland eb4a79cc7a As suggested by Ilja Maslov, display values of
gsm_a.cell_lac and gsm_a.cell_ci in hex
and decimal.


svn path=/trunk/; revision=17120
2006-01-29 21:00:00 +00:00
Lars Roland de4522f70d Fix an infinite loop in gsm_a dissector and a wrong offset in uma dissector.
This fixes bug 716.

svn path=/trunk/; revision=17119
2006-01-29 15:54:10 +00:00
Guy Harris e01909c0ea Use tvb_format_text() on the message, to handle non-printable characters
(including tabs and newlines).

svn path=/trunk/; revision=17118
2006-01-29 12:57:14 +00:00
Guy Harris f9eaba6d69 Add an option to dissect purported RTP packets with a version number of
0 as T.38 rather than STUN.

svn path=/trunk/; revision=17116
2006-01-29 00:40:40 +00:00
Guy Harris b0a28a8080 Squelch a compiler warning.
svn path=/trunk/; revision=17115
2006-01-28 23:27:17 +00:00
Guy Harris 54ac396346 Expand the set of #defines in afn.h (and give a URL for the *current*
list of address families) and the list of strings in afn.c, and use them
in packet-lldp.c instead of having it define its own.

svn path=/trunk/; revision=17114
2006-01-28 23:18:19 +00:00
Guy Harris 5186e33416 Fix missing closing */ in comment.
svn path=/trunk/; revision=17113
2006-01-28 22:49:53 +00:00
Guy Harris 360b71a3ce Fix missing brackets in if statement.
svn path=/trunk/; revision=17112
2006-01-28 22:34:22 +00:00
Ronnie Sahlberg dab77d86f1 rewrite of the tcp sequence number analysis code to hopefully make it cleaner and easier to maintain and extend.
i have tested it with many captures   but this used to be fragile and delicate code  so there might be some regressions that will need to be addressed once identified.





svn path=/trunk/; revision=17107
2006-01-26 22:50:16 +00:00
Anders Broman 65530eb912 Add the abillity to translate MCC.
svn path=/trunk/; revision=17105
2006-01-26 06:54:52 +00:00
Ulf Lamping 84794a9bc3 from Gisle Vanem:
This file uses SEH which AFAIK is only available for MS Visual-C.
I build using MingW/gcc, so the attached patch is needed. 

svn path=/trunk/; revision=17102
2006-01-25 21:34:04 +00:00
Luis Ontanon aeaf2c6cf6 Bind IuUP to RTP
svn path=/trunk/; revision=17100
2006-01-25 20:49:42 +00:00
Luis Ontanon e469d2af12 Use the right tree
svn path=/trunk/; revision=17099
2006-01-25 20:48:37 +00:00
Anders Broman 33b9a9c90d - Add new IE:s
- White space and comment changes.
- IE type fixes.
- Print timezone data.

svn path=/trunk/; revision=17098
2006-01-25 17:56:27 +00:00
Ulf Lamping 3f3aae1681 minor code cleanup
svn path=/trunk/; revision=17093
2006-01-24 19:03:09 +00:00
Jaap Keuter 1fb3bc7c86 Derived some more assumptions from NLB traffic
svn path=/trunk/; revision=17091
2006-01-24 11:54:27 +00:00
Luis Ontanon 1ff8c4272f Add register_postdissector() to the API.
Dissectors registered with register_postdissector() will be called after all other dissectors have been called.

Use it to register mate.


svn path=/trunk/; revision=17089
2006-01-24 00:26:57 +00:00
Guy Harris 878a077605 Add some more sanity checking of the Radiotap header.
svn path=/trunk/; revision=17085
2006-01-23 23:21:02 +00:00
Anders Broman d31de2bdb4 Bugfix: network address not dissected correctly
svn path=/trunk/; revision=17084
2006-01-23 22:13:08 +00:00
Guy Harris 41c941b49c Call capture_radiotap() when capturing on a device supplying Radiotap
headers.

Fix capture_radiotap() to check for padding between the 802.11 header
and the 802.11 payload and to call different capture routines depending
on whether it's present or not, and create capture_ieee80211_datapad()
to handle the case where it's present.

Fix capture_radiotap() to convert the Radiotap header length from
little-endian, and to do some sanity checking of that length.

Fix capture_ieee80211_common() to use the offset supplied to it to fetch
the frame control field, as that offset isn't necessarily 0.

svn path=/trunk/; revision=17083
2006-01-23 16:56:34 +00:00
Guy Harris 2ab3f01671 Rename all the COOK_ macros to indicate the field from which they're
extracting data (except for the association ID field, where adding
ASSOC_ID would be redundant).

svn path=/trunk/; revision=17081
2006-01-23 10:17:07 +00:00
Guy Harris d269468356 From Sam Leffler:
1. Fix a bug in caclulating the 802.11 header length for QoS
	   data frames (way bad regression from previous code). 

	2. Add support for packets w/ data padding between the 802.11
	   header and the payload (as indicated in the radiotap flags).

	3. Add support for handling FCS indication in the radiotap
	   flags. 

	4. Fix display of TSF (previous code was not byte swapping).

	5. Update ieee80211_mhz2ieee in radiotap.c to handle more
	   channels. 

	6. Nuke some #if 0 code I left in radiotap.c a while back.

Also, clean up the various macros that extract stuff from 802.11 header
fields or define bitfields within those header fields:

	group them by the fields from which they extract and the values
	they extract, or the header fields to which they belong;

	get rid of some of the COOK_ in the names - COOK_ really doesn't
	indicate anything useful, such as the field from which they're
	extracting (we should get rid of the rest);

	put in some more comments explaining what they do;

	get rid of some unused macros;

	get rid of some values that aren't flag values - they're values
	to test whether something's a data frame with a particular byte
	set in the subtype field, but they're only used on data frames,
	so we only need to test the bit in question, so we define macros
	to test the bit and name them to indicate that they're for use
	on data frames.

Consistently use "CF-Ack" and "CF-Poll" in the strings for various data
frame type/subtype values, and get rid of "802.11" (it should be obvious
to one and all that this is 802.11...).

Comment out some variables used only in commented-out code.

Get rid of some unused variables.

Fix up one "proto_tree_add_text()" call where the format string didn't
match the arguments.

svn path=/trunk/; revision=17080
2006-01-23 09:20:06 +00:00
Jaap Keuter 287e228fc5 Implemention of T38 TCP defragmentation by Alejandro Vaquero
svn path=/trunk/; revision=17079
2006-01-23 07:12:26 +00:00
Anders Broman be6277f8c8 From Marc Petit-Huguenin:
This patch for the STUN dissector fixes a bug (wrong value for DATA_INDICATION attribute) and adds the decoding of IPv6 address in attributes.


svn path=/trunk/; revision=17078
2006-01-23 06:14:31 +00:00
Guy Harris f371ed6d3d Get rid of unused variables, fix indentation, don't assign NULL to
non-pointer variables.

svn path=/trunk/; revision=17077
2006-01-22 23:14:58 +00:00
Guy Harris 6967e5bef7 "size_t" can be "unsigned int" or "unsigned long", so cast it to
"unsigned long" and print it with %lu.

svn path=/trunk/; revision=17076
2006-01-22 23:08:15 +00:00
Anders Broman 1c5874e2e3 Dissect CellGlobalIdOrServiceAreaIdOrLAI and RAIdentity
svn path=/trunk/; revision=17075
2006-01-22 21:16:33 +00:00
Ulf Lamping c73ed3c6d5 add Win32 Structured Exception Handling (SEH) at the same place we're already doing the Portable Exception Handling.
This way we (hopefully) can continue dissecting with the next packet, even if a more serious exception had occured, e.g. a memory access violation or a divide by zero exception.

Obviously, not all problems solved, as SEH won't protect us from other problems, e.g. endless loops and such

svn path=/trunk/; revision=17070
2006-01-22 02:22:14 +00:00
Anders Broman fded8deafc RANAP - Dissect ProtocolExtensionField IE:s
GSM A - Service Request; Mobile identity element is LV type

svn path=/trunk/; revision=17069
2006-01-21 19:12:52 +00:00
Ulf Lamping 864edeb5ac add matched coloring rule name and string to the frame dissector output (or nothing if no coloring rule matched or none was set)
svn path=/trunk/; revision=17068
2006-01-21 17:49:00 +00:00
Jörg Mayer a052b3a98b packet-bgp.c: Fix incorrect use of g_snprintf return value
mp_addr_to_str was unnecessary 'complex' - simplified it
packet-dns.c: Fix incorrect use of g_snprintf return value
packet-dcm.c: Fix incorrect use of g_snprintf return value
        Someone who understands the protocol should look at the
        "vr, tr might be used uninitialized..." warning.
packet-x11.c: Fix incorrect use of g_snprintf return value
packet-kerberos.c: Fix incorrect use of g_snprintf return value
        Someone should take a look at the
        "longjump might clobber ..." messages
packet-diameter.c: Fix incorrect use of g_snprintf return value
        Get rid of unsigned < 0 check
packet-pgm.c: Fix incorrect use of g_snprintf return value
packet-nbns.c: Fix incorrect use of g_snprintf return value
packet-winsrepl.c: Collateral damage to packet-nbns.c fix
packet-netbios.c: Collateral damage to packet-nbns.c fix
packet-netbios.h: Collateral damage to packet-nbns.c fix
packet-kerberos.c: Collateral damage to packet-nbns.c fix
packet-nbipx.c: Collateral damage to packet-nbns.c fix


svn path=/trunk/; revision=17065
2006-01-20 21:18:18 +00:00
Anders Broman f194c9eddb Dissect:
- PDPcontext
 - GSN-Address
 - QoS

svn path=/trunk/; revision=17063
2006-01-20 19:41:31 +00:00
Anders Broman f2bc8ad4a8 Handle sgmented XUDT:s
svn path=/trunk/; revision=17060
2006-01-20 19:32:59 +00:00
Jörg Mayer 256225d73f Mike Hall:
This will add the ability to configure a .1q vlan column in ethereal.

Me:
Change 1q -> 1Q

svn path=/trunk/; revision=17058
2006-01-20 08:48:43 +00:00
Gerald Combs b3d0b97635 Make sure we don't use the ADNS version of inet_aton; it's broken.
This fixes bug 523, but exposes more of bug 658.

The TACACS and SDP dissectors don't call inet_aton(), so don't include it.

svn path=/trunk/; revision=17056
2006-01-19 23:01:24 +00:00
Anders Broman 9d6de675a4 ext_qos_subscribed was not correctly decoded in Camel and GSM MAP
Change to use proto_add_item in packet-gsm_a.c for some octets and export value strings.

svn path=/trunk/; revision=17055
2006-01-19 18:20:14 +00:00
Anders Broman 28e69752b2 Dont dissect XDT data in case of Segmentation as that will give [Malformed packet] and the Segmentation IE will n ot be dissecterd.
svn path=/trunk/; revision=17054
2006-01-19 05:51:59 +00:00
Ulf Lamping 67e90082a7 add "RPC_E_TIMEOUT" to the reject status codes
svn path=/trunk/; revision=17053
2006-01-19 02:00:28 +00:00
Jaap Keuter ac3e6ed312 Add option presentation, solving bug 697
svn path=/trunk/; revision=17052
2006-01-18 21:41:34 +00:00
Gerald Combs f816511ea9 In packet-cops.c use proto_item_append_text() instead of creating a
separate buffer.  Fixes the current Buildbot failure.

Don't let the sprint_realloc_* functions reallocate ep_allocated memory.
Add comments warning against this in the future.

In emem.c, make sure we don't use an extra 100k every stinkin' time
someone wants to allocate memory when debugging is enabled.

Fixup whitespace.

svn path=/trunk/; revision=17051
2006-01-18 20:02:19 +00:00
Anders Broman 4ecd261cfb Change some OPCODE decodes from respons to Invoke (bug fix), let gsm_a decode som IE:s.
svn path=/trunk/; revision=17050
2006-01-17 21:52:30 +00:00
Anders Broman dbf15d9e0b Add ethertypes and value_str for IEC 61850
svn path=/trunk/; revision=17049
2006-01-17 21:50:43 +00:00
Jörg Mayer 467de087cc According to 802.11e D11, 7.3.2.13, station count is a 16 bit value.
Accoding to 802.11, 7.1.1, numbers are little endian.

svn path=/trunk/; revision=17047
2006-01-17 13:13:29 +00:00
Jörg Mayer f905ad1862 packet-fcswils.c: Fix incorrect use of g_snprintf return
packet-wccp.c: Fix incorrect use of g_snprintf return
packet-cops.c: Fix incorrect use of g_snprintf return value
packet-wtp.c: Fix incorrect use of g_snprintf return value


svn path=/trunk/; revision=17046
2006-01-17 10:56:06 +00:00
Jörg Mayer be27196e0a - Replace snprintf by g_snprintf
- Beginning of incorrect g_snprintf retval ussage fixes
- Make qbss station count a byte again until we know
  whether the count is a 2 byte le value instead

svn path=/trunk/; revision=17045
2006-01-17 10:54:23 +00:00
Jaap Keuter d0c1a48a34 Fix typo, solving bug 693
svn path=/trunk/; revision=17044
2006-01-17 06:39:57 +00:00
Ulf Lamping c59c716e7a MSVC compiler warnings:
packet-ldap.c(784) : warning C4101: 'seq_len' : unreferenced local variable
packet-ldap.c(782) : warning C4101: 'length' : unreferenced local variable
packet-ldap.c(785) : warning C4101: 'header_bytes' : unreferenced local variable

svn path=/trunk/; revision=17041
2006-01-17 00:01:22 +00:00