osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
35,028 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

152 Commits

Author SHA1 Message Date
Martin Mathieson d4e9304fd2 Add a way for configuration protocol (e.g. RRC) to configure MAC-> RLC mappings, and add a preference to use this or the static UAT. 
API is not yet called by RRC.

svn path=/trunk/; revision=36676
 2011-04-17 11:22:03 +00:00
Martin Mathieson 960376a8f3 Show max UEs/TTI in MAC stats window (UL/DL separately). 
svn path=/trunk/; revision=36658
 2011-04-16 10:56:18 +00:00
Martin Mathieson ae149510e6 Keep track of how many UL/DL UEs in a TTI, and attach this info to each UL-SCH/DL-SCH frame.. 
svn path=/trunk/; revision=36657
 2011-04-15 23:32:44 +00:00
Martin Mathieson a8f1a17b68 - for UL/DL HARQ, show number of ms since previous tx 
- for SR state-machine problems, show UEId in report
- incomplete beginnings of support for grouping/counting UEs per TTI

svn path=/trunk/; revision=36564
 2011-04-11 21:33:33 +00:00
Martin Mathieson 4611533752 There can be up to 15 DL HARQ processes (depending upon TDD config index). 
svn path=/trunk/; revision=36250
 2011-03-22 14:39:02 +00:00
Martin Mathieson d36178cd5d Improve expert info output when detect Scheduling Request 'state machine' problem. 
svn path=/trunk/; revision=36147
 2011-03-06 22:52:33 +00:00
Martin Mathieson 2f6486166f Allow linking back to previous UL tx 32 ms ago. 
svn path=/trunk/; revision=36119
 2011-03-02 11:33:46 +00:00
Martin Mathieson c5c0195362 Don't overwrite isPhyRetx field for UL frames with DL check. 
svn path=/trunk/; revision=36118
 2011-03-02 11:16:28 +00:00
Martin Mathieson 3fac9089cb After SR failure, allow for another attempt in SR state machine (presumably with a subsequent RACH happening in-between...) 
svn path=/trunk/; revision=36109
 2011-03-01 14:58:51 +00:00
Martin Mathieson 93333d8fa1 Make UL retx use warning, rather than error, expert level. 
svn path=/trunk/; revision=36090
 2011-02-28 12:24:45 +00:00
Martin Mathieson 1660ed63ab Previous UL frame may be 8 OR 16 subframes ago. 
svn path=/trunk/; revision=36020
 2011-02-21 14:43:16 +00:00
Martin Mathieson f30d00e00a Show subheaders summary in subheader root item. 
svn path=/trunk/; revision=35908
 2011-02-11 00:29:40 +00:00
Jeff Morriss 50e1634f4c Modify proto_tree_add_bytes_format() and proto_tree_add_bytes_format_value() 
so that if the start_ptr is NULL the bytes are extracted from the given TVB
using the given offset and length.

Replace a bunch of:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, tvb_get_ptr(tvb, offset, length), [...])

with:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, NULL, [...])

svn path=/trunk/; revision=35896
 2011-02-10 16:31:00 +00:00
Martin Mathieson 82cbbca3e5 Add and use accessors to get/set per-packet data for LTE MAC. 
This will allow plugins to use the dissector.

svn path=/trunk/; revision=35774
 2011-02-02 23:21:16 +00:00
Martin Mathieson b5a32fe8ef Improve/rework the way we look for the original frame when there is a DL. retransmission. 
svn path=/trunk/; revision=35682
 2011-01-27 16:09:24 +00:00
Martin Mathieson 7205313026 - Use correct data pointer during a comparison. 
- Add expert info to show when DRX command is received
- Get rid of some tabs


svn path=/trunk/; revision=35568
 2011-01-17 15:01:22 +00:00
Jeff Morriss 8d32d2066a There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or
tvb_get_const_stringz().

Use tvb_memeql() & tvb_memcmp().

svn path=/trunk/; revision=35558
 2011-01-16 20:51:21 +00:00
Martin Mathieson 51170aa0fc When looking for previous frame for UL/DL retx, use harq-id + ndi bit. 
svn path=/trunk/; revision=35535
 2011-01-14 14:25:24 +00:00
Martin Mathieson b1dd79a122 Rather than repairing out-of-range subframe numbers, make sure error gets reported (and then are not used to access beyond subframe arrays). 
svn path=/trunk/; revision=35531
 2011-01-14 11:21:28 +00:00
Gerald Combs 73f5cb2503 From non-customers via bug 5530: Fix a buffer overflow in the MAC LTE 
dissector.  From me: Add a define, ep_allocate the buffer.

svn path=/trunk/; revision=35292
 2010-12-28 20:47:48 +00:00
Martin Mathieson ee714ffac4 Only a new transmission grant should end a Scheduling Request. 
svn path=/trunk/; revision=35268
 2010-12-26 23:40:22 +00:00
Martin Mathieson 7cd3ff263b Add more PHY attributes to MAC frames. 
svn path=/trunk/; revision=35125
 2010-12-05 23:34:11 +00:00
Martin Mathieson a8b6aca90c From Pascal Quantin: 
- Set a default RNTI value for each type, in case optional RNTI value isn't supplied.
- Improve range checking of given type against acceptable range of values
- fix misplaced return (this fixed bug 5392)

svn path=/trunk/; revision=34859
 2010-11-13 15:32:29 +00:00
Martin Mathieson a067c3bb8a Check given RNTI value is consistent with given RNTI-type. 
As suggested in bug 5382.  The reported crash didn't happen for me...

svn path=/trunk/; revision=34852
 2010-11-12 16:59:22 +00:00
Martin Mathieson fb0bfc17da Show some reserved bits as hex, not decimal. 
svn path=/trunk/; revision=34792
 2010-11-05 16:47:22 +00:00
Martin Mathieson 829ee8752b Add 'ndi' and 'harq-id' as new MAC-PHY DL attributes. 
svn path=/trunk/; revision=34753
 2010-11-02 15:20:38 +00:00
Jeff Morriss f5d3a16225 Make tvb_strneql()'s size parameter be a size_t. Remove some now-unnecessary casts. 
svn path=/trunk/; revision=34725
 2010-10-30 18:18:12 +00:00
Guy Harris 17d4d51b7d Make the third argument to a UAT copy callback a size_t (not that any of 
the callbacks we have use that argument - is it really needed?).

svn path=/trunk/; revision=34694
 2010-10-29 21:11:33 +00:00
Martin Mathieson 81a49eec81 In heuristic dissector, don't check/allocate struct until/unless signature pattern matches. 
svn path=/trunk/; revision=34582
 2010-10-20 09:58:40 +00:00
Martin Mathieson 7e938c7071 Don't clear info column when showing MAC or RLC-level info. 
svn path=/trunk/; revision=34559
 2010-10-18 17:02:19 +00:00
Martin Mathieson 1077ec28f6 Improve info column when showing PHY info for MAC frames. 
svn path=/trunk/; revision=34529
 2010-10-15 21:32:35 +00:00
Martin Mathieson 62e6b6aceb Add more CRC failure codes. 
svn path=/trunk/; revision=34401
 2010-10-07 14:44:00 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34227
 2010-09-23 21:46:31 +00:00
Jeff Morriss 381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 : 
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
 2010-09-21 03:14:49 +00:00
Martin Mathieson 4b5c69c0d9 Add bandwidth figures per UE. 
svn path=/trunk/; revision=34061
 2010-09-03 16:45:05 +00:00
Martin Mathieson c642bae035 From Pascal Quantin: 
The decoder expects to do not have any extra byte after the RAR bodies.

But according to 3GPP 36.321 8.8.0 chapter 6.1.5, the eNodeB is allowed to put padding at the end of the RAR PDU:

" A MAC PDU consists of a MAC header and zero or more MAC Random Access Responses (MAC RAR) and optionally padding as described in figure 6.1.5-4.
[...]

Padding may occur after the last MAC RAR. Presence and length of padding is implicit based on TB size, size of MAC header and number of RARs."

svn path=/trunk/; revision=33783
 2010-08-12 09:03:05 +00:00
Jörg Mayer 8c03a4472a Updading opensuse 11.2 -> 11.3 updated gcc to 4.5.0, which created 
a few warnings that needed fixing when compiling with -Werror.

svn path=/trunk/; revision=33587
 2010-07-20 08:27:34 +00:00
Martin Mathieson 703635b979 Give up dissecting a MAC PDU if we see control LCIDs after data ones. 
This saves us getting into a mess trying to keep track of PDU sizes in an array...

svn path=/trunk/; revision=33582
 2010-07-19 14:14:47 +00:00
Martin Mathieson db478debbd Allocate tap structs rather than using one static struct. 
svn path=/trunk/; revision=33503
 2010-07-13 16:25:34 +00:00
Martin Mathieson b2a872cd9f Show grant-subframe from context info. 
svn path=/trunk/; revision=33437
 2010-07-05 16:45:36 +00:00
Martin Mathieson b7f136ae41 Check range of supplied subframe number. If out, set back to max (9) and 
add expert info error.  Should fix bug 4970.

svn path=/trunk/; revision=33432
 2010-07-05 10:50:27 +00:00
Martin Mathieson 735ec2d6d2 For DL HARQ retx, support knowing result or not. 
svn path=/trunk/; revision=33431
 2010-07-05 10:35:17 +00:00
Martin Mathieson 97df849b98 Add new strings/dissector function for signalling RRC messages that will add 
lte_rrc root to the protocol tree. Makes filtering on call signalling easier.

TODO: same for other RRC entry points...

svn path=/trunk/; revision=33251
 2010-06-18 07:07:55 +00:00
Martin Mathieson 4fcd48495f Add the direction to so expert info texts. 
svn path=/trunk/; revision=33207
 2010-06-10 15:28:41 +00:00
Martin Mathieson 98c68fc8ec Check that the PDU isn't bigger than the reported grant size. Thought I was already doing this... 
svn path=/trunk/; revision=32934
 2010-05-24 16:28:34 +00:00
Martin Mathieson 5ed2e2f914 Trivial: Update AUTHORS entry, remove out-of-date comments, minor formatting 
svn path=/trunk/; revision=32611
 2010-04-30 17:15:59 +00:00
Martin Mathieson 0d7425872e Set TA control element expert info based on improved understanding of spec. 
svn path=/trunk/; revision=32539
 2010-04-22 17:46:12 +00:00
Martin Mathieson 5a39a9ef39 - Lower severity on expert items about Timing Advance if <= 31 
- Detect original frame for DL HARQ retx also 9 SFs ago (have even seen 10...)
- Getting ready to log 'grant subframe' for UL frames (only interesting for TDD)

svn path=/trunk/; revision=32538
 2010-04-22 13:54:30 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Martin Mathieson cfb6f1531a Improve reporting of Scheduling Request failure. 
svn path=/trunk/; revision=32272
 2010-03-23 13:24:01 +00:00