Evan Huus
6fd7e5ba33
Remove more deprecated tvb_length calls
...
Change-Id: I56260a82b19001ab2f87f4be34a9510f127f841f
Reviewed-on: https://code.wireshark.org/review/9050
Reviewed-by: Evan Huus <eapache@gmail.com>
2015-06-23 03:54:13 +00:00
Michael Mann
2d448f0d5d
Eliminate proto_tree_add_text from some dissectors.
...
Change-Id: Ief4c377d56748e1a8ed0ef7fe5ba03b9be00cd8d
Reviewed-on: https://code.wireshark.org/review/6267
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-08 14:30:52 +00:00
Bill Meier
36ce5e1b90
Fix encoding-arg mostly for FT_UINT_STRING; Also: Do misc as needed.
...
Misc: (as needed)
- Add editor modelines;
- Adjust whitespace.
Change-Id: I0e5d877a2a6273842ad8e771ac0c0acbfcb83200
Reviewed-on: https://code.wireshark.org/review/4173
Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-18 15:07:58 +00:00
Michael Mann
9d5f9141af
Eliminate proto_tree_add_text from some dissectors.
...
Other minor cleanup while in the area.
Change-Id: Id8d957d3d68a2e3dd5089f490bd59d773e1be967
Reviewed-on: https://code.wireshark.org/review/3427
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-05 07:36:26 +00:00
Michael Mann
14824e6adf
Revert "Fixup: tvb_* -> tvb_captured"
...
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html
This reverts commit 246fe2ca4c
.
Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19 18:25:59 +00:00
Dario Lombardo
246fe2ca4c
Fixup: tvb_* -> tvb_captured
...
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18 14:14:58 +00:00
Dario Lombardo
971ffd683e
Fixup: tvb_get_string(z) -> tvb_get_string(z)_enc
...
Change-Id: I63a3704effe3fcab01a193dc39b6a22e9f1cf3fe
Reviewed-on: https://code.wireshark.org/review/2376
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18 14:13:58 +00:00
Michael Mann
b40cb1adea
Apply found fix-encoding-args.pl errors in the dissector directory.
...
I coincidentally found a few files with errors, so I thought it might be time to run it on the whole directory again.
Change-Id: Ia32e54b3b1b94e5a418ed758ea79807c8bc7e798
Reviewed-on: https://code.wireshark.org/review/978
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-06 15:11:36 +00:00
Alexis La Goutte
296591399f
Remove all $Id$ from top of file
...
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')
Fix manually some typo (in export_object_dicom.c and crc16-plain.c)
Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
Michael Mann
e4e536bf1d
Remove need for match_port #define in packet_info.h and just replace existing calls.
...
svn path=/trunk/; revision=52815
2013-10-24 15:04:38 +00:00
Pascal Quantin
a0c53ffaa1
emem -> wmem conversion:
...
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly
svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Michael Mann
0f0c111119
Remove check_col() and the occasional tree.
...
svn path=/trunk/; revision=49920
2013-06-14 01:02:11 +00:00
Anders Broman
2e52e2ac99
[-Wmissing-prototypes]
...
Use explicit casts.
svn path=/trunk/; revision=48347
2013-03-17 09:11:21 +00:00
Jeff Morriss
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Bill Meier
638d74d43f
Use val_to_str_const() where appropriate;
...
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc
svn path=/trunk/; revision=44438
2012-08-10 22:55:02 +00:00
Michael Mann
1d9c472cae
convert some simple uses to use ephemeral memory
...
svn path=/trunk/; revision=44413
2012-08-10 02:05:19 +00:00
Guy Harris
bdf148e3ea
Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
...
argument.
svn path=/trunk/; revision=43806
2012-07-18 23:30:45 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Guy Harris
dc06d2643a
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
(The field is a counted string, so the byte order is in theory relevant,
although the count is, in this case, a single byte.)
svn path=/trunk/; revision=42482
2012-05-07 19:38:26 +00:00
Jeff Morriss
891c9db19b
As suggested in http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html :
...
Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no
endianism, so ENC_NA is more appropriate.
svn path=/trunk/; revision=42297
2012-04-27 18:58:37 +00:00
Bill Meier
8fce627622
Thou shalt not stop dissecting after doing processing for COL_INFO ....
...
svn path=/trunk/; revision=41083
2012-02-20 20:23:56 +00:00
Bill Meier
0fee9f56d2
Minor updates:
...
- checkcol() not req'd in a few cases;
- Add an XXX comment about the (mis?)use of tvb_length();
- lenght -> length;
svn path=/trunk/; revision=40505
2012-01-14 17:03:34 +00:00
Alexis La Goutte
d5f64d59fb
From Juha Takala via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6654
...
ELCOM dissector needs small fixes for some protocol sub-field texts
svn path=/trunk/; revision=40131
2011-12-09 16:39:18 +00:00
Alexis La Goutte
380dbe41d0
Enhance Elcom dissector
...
Fix indent and update modelines
svn path=/trunk/; revision=40092
2011-12-04 18:40:19 +00:00
Alexis La Goutte
c2447153e2
Enhance Elcom dissector
...
Replace proto_tree_add_* by proto_tree_add_item
Replace switch/case by value_string
svn path=/trunk/; revision=40091
2011-12-04 18:19:18 +00:00
Chris Maynard
13e3688b64
Fix 2 newly reported Coverity CID's 1331 & 1332: UNUSED_VALUE.
...
svn path=/trunk/; revision=40086
2011-12-03 22:53:55 +00:00
Anders Broman
f5447edd58
From Juha Takala:
...
dissector for ELCOM communication protocol. This protocol is
used mainly by power utilities, to exchange historical, cyclic, and event based
data between SCADA systems.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6616
svn path=/trunk/; revision=40071
2011-12-02 22:05:14 +00:00