was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).
Use a consistent coding style, and make proper use of the WS_DLL_* defines.
Group the functions appropriately in the header.
I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467
svn path=/trunk/; revision=48634
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().
Change some data types to avoid those implicit conversion warnings.
When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.
Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers. Cast
away those warnings in some cases where an API we don't control forces
us to do so.
Enable a bunch of additional warnings by default. Note why at least
some of the other warnings aren't enabled.
randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.
If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.
svn path=/trunk/; revision=46748
them and then copying them over). The "all" target to builds these dissectors
now (instead of "generate_files" and/or "copy_files").
asn2wrs's "-O" option now means "the dissector goes in this directory" (rather
than "all output goes in this directory"); it also means that the "-s" (single
output file) option is now required.
Fix things up so that it's possible to build all of the ASN.1 dissectors in
one shot.
Fix building of conformance files when doing out-of-source-tree builds.
Unfortunately "make all" in the asn1 directory always builds something--I think
because of circular depedencies.
svn path=/trunk/; revision=39333
argument indicating whether to include the time zone in the string. If
we're constructing a display filter, don't include the time zone,
otherwise do. Fixes bug 4756.
svn path=/trunk/; revision=32913
date as YYYY/DDD, where DDD is a 1-origin day of year. Move the formats
to a "time_fmt.h" file, included by the headers that use it. Have
abs_time_to_str() and abs_time_secs_to_str() take the date format value,
rather than a Boolean "show this as UTC" flag, as an argument. Document
the ABSOLUTE_TIME_ formats a bit better. Use that format in the CCSDS
and VCDU dissectors, rather than having those dissectors do the
formatting themselves.
svn path=/trunk/; revision=32034
The asn1 definition of AlternateAccessSelection of the MMS dissector was wrong.
It didn't allow object access with nested AlternatedAccess.
I changed the definition as in ISO 9506-2 (2003).
I also added MMSString which was not present.
I also added the definition for UtcTime as in the annex G of IEC61850-8-1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4404
svn path=/trunk/; revision=31585
The asn1 definition of AlternateAccessSelection of the MMS dissector was wrong.
It didn't allow object access with nested AlternatedAccess.
I changed the definition as in ISO 9506-2 (2003).
I also added MMSString which was not present.
I also added the definition for UtcTime as in the annex G of IEC61850-8-1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4404
svn path=/trunk/; revision=31584
of the branch and not the tag value so one cant use it with
val_to_str()
(well one can in this instance since by luck the tag values match the
indices)
svn path=/trunk/; revision=23452
- gsmmap: uncomment -s option in gsmmap.cnf
- Fix cyclic dependencies:
+ Remove EXPORT_CNF from dependencies for cnf files
+ Replace all INCLUDE ...-exp.cnf with IMPORT ...-exp.cnf
svn path=/trunk/; revision=23202
Here's a patch that decodes MMS(Manufacturing Messaging
Specification) when transported over COTP/TPKT/TCP. Previously, MMS would only be decoded if the OSI Presentation Layers were present. Now MMS/COTP/TPKT/TCP is dissected.
With a change to use more functions from packet-ber
svn path=/trunk/; revision=21608
The problem is the slash in e.g.:
@$(PYTHON) ../../tools/make-dissector-reg.py
is interpreted as an option instead of being part of the path.
I didn't wanted to use backslashes as this might introduce new problems with cygwin's python port.
svn path=/trunk/; revision=19730
make mms bitstrings easier to read
--
Hi, this is my new mms with some changes in order to display some data in
binary instead of hex.
Excuse me because is not a diff from the repository, but I don't know how to
create a diff.
I also have the compiled packet-mms.c and packet-mms.h if you want it only
mail me.
svn path=/trunk/; revision=18974
- remove obsolete -X option from makefiles
- not generate enumerated map table for BER
dissector will be regenerated later
svn path=/trunk/; revision=18199
Michael Mann