Enhance RSN Info (48), Extended Capabilities information element (127)
* Replace proto_tree_add_uint*/boolean/text by proto_tree_add_item
* use ENC_* macro for encoding
svn path=/trunk/; revision=36680
In the explanation of TCP Option 78 (Riverbed Transparency), the labels
are "CSH IP Addr/Port" and "SSH IP Addr/Port". This should be "Src SH IP
Addr/Port" and "Dst SH IP Addr/Port".
The filter keys for these labels are correct.
svn path=/trunk/; revision=36667
packet-rohc.c: In function 'dissect_rohc_ir_rtp_profile_dynamic':
packet-rohc.c:285: warning: 'val_len' may be used uninitialized in this function
packet-rohc.c:186: warning: 'num_bits' may be used uninitialized in this function
packet-rohc.c:186: note: 'num_bits' was declared here
svn path=/trunk/; revision=36663
Adds BMC protocol, including adding support for MAC and RLC CTCH channels to carry it.
From me:
Removed hf blurbs = def and removed check_col added tp CMakeList.
svn path=/trunk/; revision=36662
Current NetFlow V9/IPFIX dissector treats IN_BYTES (IE=1) and
IN_PERMANENT_BYTES (IE=85) exactly in the same way. The same applies to IN_PKTS
(IE=2) and IN_PERMANENT_PKTS (IE=86). However, IN_BYTES/IN_PKTS and
IN_PERMANENT_BYTES/IN_PERMANENT_PKTS have different semantics so they should be
distinguishable when they are displayed or specified in a filter. Please find
attached the patch
which does that.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5807
svn path=/trunk/; revision=36661
From me: Use lower-case v9template_max_fields instead of upper-case to avoid
any confusion with that variable being a define. Use STRINGIFY() so we always
keep the default and the displayed default the same. Fix bug introduced by
Andrew's patch where option_scope_field_count was inadvertently changed to
option_field_count. Append "Maximum value can be adjusted ..." message to all
relevant expert infos.
svn path=/trunk/; revision=36643
Update to last RPL Draft (19)
Add new ICMPv6 Option: Proxy Signature (PS) draft-ietf-csi-proxy-send-05
Fix 2 Clang Warning (unused variable):
packet-icmpv6.c:2755:9: warning: Value stored to 'oplength' is never read
oplength = tvb_get_guint8(tvb, rr_offset);
packet-icmpv6.c:2916:5: warning: Value stored to 'nb_mcast_records' is never read
nb_mcast_records = tvb_get_ntohs(tvb, mldr_offset);
svn path=/trunk/; revision=36641
- use 4-bytes hex for messages ids
- reorder skinny messages ids
- remove obsolete C-comments about status
- rewrite field names (from camel case to plain words)
From me:
Replaced meaningless hf blurbs with NULL
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5824
svn path=/trunk/; revision=36638
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5827
The radiotap header has a pile of optional fields, and uses a bitmask field to
indicate which fields are present. Wireshark marks the fields it decodes, and
then decodes the payload.
The recently-added MCS field is decoded now, but the bit is not displayed as
recognized. This was presumably an oversight, as this bit is recognized and the
field decoded properly.
svn path=/trunk/; revision=36632
Don't assign to a proto_item * if the value won't be used: Coverity 1040 & 1041.
Remove some unneede #includes;
Do some minor indentation & whitespace cleanup.
svn path=/trunk/; revision=36630
Enhance Tag ERP Information (42), TS Delay (43), TCLAS Processing (44)
* Replace proto_tree_add_uint*/boolean/text by proto_tree_add_item
* use ENC_* macro for encoding
svn path=/trunk/; revision=36625
Move test out of switch statement.
Remove unused variable.
Remove trailing whitespace.
Whitespace in that file is a mess.
svn path=/trunk/; revision=36621
Coverity sees that two calls to tvb_length_remaining() with an offset
of 0 may return -1 (for an "out of bounds" condition), which would lead
to an assignment of -1 to an unsigned variable and then passing it
to functions further down that cannot accept negative values.
Use tvb_ensure_length_remaining() to throw an exception in a case of
out of bounds access (though unlikely with an offset of 0) instead of
tvb_length_remaining(), which would return -1.
svn path=/trunk/; revision=36615
Michael Tüxen