Commit graph

20 commits

Author SHA1 Message Date
Bill Meier
b5d7b7ab6e Cleanup use of #includes in non-generated epan/dissector/*.c
Specifically:
- Set packet.h to be the first wireshark #include after
   config.h and "system" #includes.
   packet.h added as an #include in some cases when missing.
- Remove some #includes included (directly/indirectly) in
   packet.h. E.g., glib.h.
   (Done only for those files including packet.h).
- As needed, move "system" #includes to be after config.h and
   before wireshark #includes.
- Rework various #include file specifications for consistency.
- Misc.

Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95
Reviewed-on: https://code.wireshark.org/review/5923
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-21 05:46:22 +00:00
Michael Mann
3fa5625ea0 Eliminate proto_tree_add_text from some dissectors.
Change-Id: Ib6024307e85d6c23decf40e9759f549c19ffe136
Reviewed-on: https://code.wireshark.org/review/3318
Petri-Dish: Michael Mann <mmann78@netscape.net>
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-08-03 16:29:16 +00:00
Michael Mann
14824e6adf Revert "Fixup: tvb_* -> tvb_captured"
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html

This reverts commit 246fe2ca4c.

Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19 18:25:59 +00:00
Dario Lombardo
246fe2ca4c Fixup: tvb_* -> tvb_captured
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18 14:14:58 +00:00
Alexis La Goutte
296591399f Remove all $Id$ from top of file
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
Guy Harris
138987aea0 Use tvb_get_string_enc() rather than tvb_get_string(). The version of
the AR.drone Developer Guide I found online mentioned ASCII but not
UTF-8.

svn path=/trunk/; revision=54923
2014-01-23 02:24:34 +00:00
Bill Meier
226e9caf9c (Trivial)
- Remove two lines of commented out code;
 - Specify 'tab-width: 8' (not 4) in editor modelines;
 - Rework/add whitespace;

svn path=/trunk/; revision=53982
2013-12-12 20:35:58 +00:00
Anders Broman
32bc65aa8c Try to make more efficient heuristick checks.
svn path=/trunk/; revision=52468
2013-10-09 16:20:54 +00:00
Pascal Quantin
a0c53ffaa1 emem -> wmem conversion:
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Anders Broman
516f145eaa Use "cheaper" length check.
svn path=/trunk/; revision=52064
2013-09-15 16:47:31 +00:00
Michael Mann
7e8e5b347e Batch of filterable expert_infos.
svn path=/trunk/; revision=49581
2013-05-25 17:06:40 +00:00
Anders Broman
27fc641a79 - [-Wmissing-prototypes]
- explicit casts.

svn path=/trunk/; revision=48274
2013-03-12 23:09:37 +00:00
Gerald Combs
fad8b88242 Capitalize the short name.
svn path=/trunk/; revision=47555
2013-02-08 03:17:13 +00:00
Michael Mann
a71824a38b Replace THROW(ReportedBoundsError) with expert infos
Follow up to rev 47408

svn path=/trunk/; revision=47421
2013-02-01 16:32:15 +00:00
Jeff Morriss
be111f2192 Fix the fuzz failure reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8284 :
Throw an exception if we don't find the guint8 we're looking for.  (This could
also be done as expert infos; throwing an exception is a bit brute force but
anyway the -1 return case has to be dealth with.)

Maybe there should be a version of tvb_find_guint8() which throws an
exception...

svn path=/trunk/; revision=47408
2013-02-01 03:55:49 +00:00
Chris Maynard
eb5fcc8d01 Fix Coverity CID 971261: Unused pointer value. Additionally, #if 0 two unused value_string's (should they be deleted altogether?), minor whitespace cleanup, delete a continuation character, try to use a consistent bracketing style throughout. [Is "Movment" a typo?]
svn path=/trunk/; revision=47387
2013-01-31 17:07:19 +00:00
Guy Harris
a4902853a5 Constify a variable to which C string pointers will be assigned.
svn path=/trunk/; revision=47385
2013-01-31 06:50:24 +00:00
Guy Harris
094e30f9db Fix RCS ID.
svn path=/trunk/; revision=47384
2013-01-31 06:49:34 +00:00
Guy Harris
7999b06d76 Get rid of CR's, and set the appropriate properties.
svn path=/trunk/; revision=47383
2013-01-31 06:49:05 +00:00
Michael Mann
9ee8360e4a Add Parrot AR Drone dissector.
Bug 7493 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7493)

svn path=/trunk/; revision=47382
2013-01-31 03:52:06 +00:00