osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
33230 commits 23 branches 0 tags 1.3 GiB
Commit graph

80 commits

Author SHA1 Message Date
Guy Harris
ceb7f5e9d5 Get rid of some no-longer-necessary includes of simple_dialog.h (now 
that cf_read_frame() and cf_read_frame_r() pop up an alert box on an
error, its callers no longer do so).

svn path=/trunk/; revision=33792
 2010-08-13 08:13:23 +00:00
Guy Harris
2a328da4ef Instead of using a Boolean for the search direction, use an enum, so 
that you can tell from examination whether the search is forward or
backward.

Make the cf_find_packet routines take the direction as an explicit
argument, rather than, in the cases where you don't want to permanently
set the direction, saving the direction in the capture_file structure,
changing it, doing the search, and restoring the saved direction.  Give
more information in the Doxygen comments for those routines.

Add a cf_find_packet_dfilter_string() routine, which takes a filter
string rather than a compiled filter as an argument.  Replace
find_previous_next_frame_with_filter() with it.

Have cf_read_frame_r() and cf_read_frame() pop up the error dialog if
the read fails, rather than leaving that up to its caller.  That lets us
eliminate cf_read_error_message(), by swallowing its code into
cf_read_frame_r().  Add Doxygen comments for cf_read_frame_r() and
cf_read_frame().

Don't have find_packet() read the packet before calling the callback
routine; leave that up to the callback routine.

Add cf_find_packet_marked(), to find the next or previous marked packet,
and cf_find_packet_time_reference(), to find the next or previous time
reference packet.  Those routines do *not* need to read the packet data
to see if it matches; that lets them run much faster.

Clean up indentation.

svn path=/trunk/; revision=33791
 2010-08-13 07:39:46 +00:00
Stig Bjørlykke
abb629c4f8 Fixed removing a Time Reference from a column not matching the display filter. 
svn path=/trunk/; revision=33334
 2010-06-26 22:53:36 +00:00
Stig Bjørlykke
59e35b0fbc Always show packets with Time Reference (as in the old packet list). 
Recreate visible rows when removing a Time Reference which has not passed
the display filter.

svn path=/trunk/; revision=33332
 2010-06-26 21:30:36 +00:00
Stig Bjørlykke
beb4314276 Introduce "Show Resolved" as an option in custom columns. This will determine 
if we show the value or the string representing the value.

This setting is not stored in the preferences file yet, and the option is
not available in the columns preferences window.

svn path=/trunk/; revision=33317
 2010-06-25 06:42:34 +00:00
Gerald Combs
17807a6b21 From Jakub Zawadzki via bug 4273: 
After appending new record set packet_list->columnized to FALSE.

From me:

Use g_ptr_array_sort_with_data instead of g_qsort_with_data in case the
GPtrArray internals ever change.

svn path=/trunk/; revision=33011
 2010-05-28 18:04:56 +00:00
Anders Broman
65ee4e797a From Jakub Zawadzki: 
New functions: cf_read_frame_r, cf_read_frame

It's much easier to write:
 cf_read_frame (cf, fdata, &err, &err_info)
Than:
 wtap_seek_read (cf->wth, fdata->file_off, &cf->pseudo_header, cf->pd,
fdata->cap_len, &err, &err_info)

svn path=/trunk/; revision=32980
 2010-05-26 19:11:23 +00:00
Guy Harris
9d819eb925 Don't assume that certain address columns are always constant strings - 
they're no more guaranteed to be constant strings than the columns we're
*not* assuming are constant strings.  Fixes bug 4771.

svn path=/trunk/; revision=32906
 2010-05-20 07:15:27 +00:00
Stephen Fisher
5ab074c7f8 Update the comment about being based on the GTK Tree View Tutorial, 
including putting /tutorial/ at the end of the URL because the 
main web-site is something unrelated to the tutorial.


svn path=/trunk/; revision=32668
 2010-05-05 02:33:34 +00:00
Gerald Combs
3c8db1cae5 Several dissectors fill in custom custom data in the source and 
destination address columns. Don't clobber it in the new packet list.

svn path=/trunk/; revision=32609
 2010-04-29 23:53:57 +00:00
Guy Harris
c8112bc620 Read the packet into private areas (private pseudo-header and packet 
data), rather than overwriting the information in the cinfo structure. 
This at least appears to fix bug 4056.

svn path=/trunk/; revision=31844
 2010-02-09 09:15:08 +00:00
Anders Broman
7789513924 Issue a row_inserted signal if the model is connected 
svn path=/trunk/; revision=31746
 2010-02-01 06:23:16 +00:00
Bill Meier
538dd47d5d Fix various gcc -Wshadow warnings. 
svn path=/trunk/; revision=31731
 2010-01-29 19:09:01 +00:00
Stig Bjørlykke
63fa42c5ab Added correct sorting for custom numeric columns. 
svn path=/trunk/; revision=31097
 2009-11-27 15:33:34 +00:00
Stig Bjørlykke
3c4f5186fa Use the highest time value when calculating widest column string for 
time columns.  Not the one different from the previous, which in most
cases is the last one in the list.

svn path=/trunk/; revision=31061
 2009-11-24 00:12:10 +00:00
Stig Bjørlykke
0dbfde8b6d Removed some unused variables and unused assignments. 
svn path=/trunk/; revision=30918
 2009-11-10 12:05:25 +00:00
Anders Broman
db24f90c2d From Jakub Zawadzki: 
Don't duplicate empty string in col_text

svn path=/trunk/; revision=30725
 2009-10-27 05:11:52 +00:00
Stig Bjørlykke
f88e3c3b84 From Jakub Zawadzki via bug 3764: 
Don't call strcmp() when pointers are the same.

svn path=/trunk/; revision=30685
 2009-10-24 15:51:10 +00:00
Anders Broman
5fa3b703a9 Use a "String pool" in the new packet list to reduce memory usage. 
svn path=/trunk/; revision=30400
 2009-10-08 13:57:19 +00:00
Anders Broman
0474a38cc4 Add myself and Kovarththanan Rajaratnam as co authors. 
svn path=/trunk/; revision=30006
 2009-09-20 09:12:56 +00:00
Kovarththanan Rajaratnam
8767b75876 Use G_STRLOC 
svn path=/trunk/; revision=29991
 2009-09-20 07:46:12 +00:00
Anders Broman
ea43f2d906 Try to get the Solaris build going... 
(Google is your friend)

svn path=/trunk/; revision=29966
 2009-09-17 13:43:43 +00:00
Gerald Combs
3dbbc4cc4e svn path=/trunk/; revision=29868 2009-09-11 20:36:01 +00:00
Anders Broman
1e137770e6 Allocate col_text and col_text_len when the fdata struct is allocated. 
svn path=/trunk/; revision=29817
 2009-09-09 08:50:06 +00:00
Kovarththanan Rajaratnam
de23d92163 Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter. 
svn path=/trunk/; revision=29806
 2009-09-08 19:00:54 +00:00
Kovarththanan Rajaratnam
d75778eb4a Custom columnfication: 
* Deprecate COL_DCE_CTX ("Context ID). Use dcerpc.cn_ctx_id

svn path=/trunk/; revision=29797
 2009-09-08 14:59:26 +00:00
Stig Bjørlykke
bc52d8079d Fixed initialization of fdata. 
svn path=/trunk/; revision=29788
 2009-09-08 10:12:01 +00:00
Kovarththanan Rajaratnam
4662b8c326 Rename packet_list_dissect_and_cache => packet_list_dissect_and_cache_iter 
svn path=/trunk/; revision=29781
 2009-09-07 19:50:19 +00:00
Kovarththanan Rajaratnam
3efea601d4 Make sure that we fill in the frame_data before passing it onto col_fill_in_frame_data 
svn path=/trunk/; revision=29780
 2009-09-07 19:43:05 +00:00
Kovarththanan Rajaratnam
450de61a1e Auto resize rest of the frame_data columns 
svn path=/trunk/; revision=29779
 2009-09-07 19:07:30 +00:00
Kovarththanan Rajaratnam
33b8efd375 Auto size COL_NUMBER, COL_PACKET_LENGTH and COL_CUMULATIVE_BYTES 
svn path=/trunk/; revision=29778
 2009-09-07 18:53:17 +00:00
Kovarththanan Rajaratnam
1ce02f035d Add progress bar while constructing columns (which is time consuming) 
svn path=/trunk/; revision=29777
 2009-09-07 17:45:37 +00:00
Kovarththanan Rajaratnam
ff7fda0df5 Track how many const strings we're storing. This is guarded by NEW_PACKET_LIST_STATISTICS 
svn path=/trunk/; revision=29775
 2009-09-07 17:09:09 +00:00
Kovarththanan Rajaratnam
72c9662da6 ntroduce some seasonal address name lookup functions which we use when NEW_PACKET_LIST is defined. This change partially reverts some parts of r29768, which didn't seem to work because it assumed that get_addr_name() would always return a seasonal string. This wasn't the case if the adddress type was AT_STRINGZ. 
svn path=/trunk/; revision=29771
 2009-09-07 16:05:37 +00:00
Anders Broman
3abd049a9b Use constant strings for Addresses saves some memory. 
svn path=/trunk/; revision=29768
 2009-09-07 14:03:05 +00:00
Kovarththanan Rajaratnam
4fbc99e411 Auto resize non frame_data based columns 
svn path=/trunk/; revision=29766
 2009-09-07 13:10:59 +00:00
Kovarththanan Rajaratnam
cd8831c72d Track length of columns strings. We'll need this in order to resize columns quickly 
svn path=/trunk/; revision=29759
 2009-09-07 11:33:38 +00:00
Kovarththanan Rajaratnam
0e5a101815 Fix target of assignment not really an lvalue error 
svn path=/trunk/; revision=29743
 2009-09-06 12:27:32 +00:00
Kovarththanan Rajaratnam
ecd9ddd845 Tigthen the condition under which we create a protocol create while sorting 
svn path=/trunk/; revision=29740
 2009-09-06 10:41:35 +00:00
Kovarththanan Rajaratnam
8edec9be91 Sort the visible list while traversing the physical row list. This halves the time needed to sort 
svn path=/trunk/; revision=29738
 2009-09-06 09:36:21 +00:00
Kovarththanan Rajaratnam
5c51aacb21 Add NEW_PACKET_LIST guard to color_filters_colorize_packet() 
svn path=/trunk/; revision=29729
 2009-09-06 06:07:53 +00:00
Kovarththanan Rajaratnam
2ab0685d8a Make sure that we can enable/disable color filtering. 
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=11&rev2=12

svn path=/trunk/; revision=29728
 2009-09-06 05:49:00 +00:00
Kovarththanan Rajaratnam
0326f65bf3 Don't copy constant column strings. This reduces memory foot print because COL_PROTOCOL is usually a constant string. This saves us 3-4 bytes for each frame 
svn path=/trunk/; revision=29723
 2009-09-05 19:07:04 +00:00
Kovarththanan Rajaratnam
f493e75db6 Dissect-on-the-fly when we have columns that are empty, i.e. columns containing strings (COL_INFO + friends). This allows us to sort on _all_ columns now. 
svn path=/trunk/; revision=29718
 2009-09-05 16:35:05 +00:00
Kovarththanan Rajaratnam
e1eaab161d Move new_packet_list_dissect() to packet_list_store.c. We need to have it there in order to dissect columns on the fly when we have to sort 
svn path=/trunk/; revision=29717
 2009-09-05 15:46:47 +00:00
Kovarththanan Rajaratnam
fb54567dae Restore original condition in packet_list_iter_n_children() 
svn path=/trunk/; revision=29713
 2009-09-05 13:46:17 +00:00
Kovarththanan Rajaratnam
fcf25fe42b Get rid of row_data_t 
svn path=/trunk/; revision=29711
 2009-09-05 13:27:34 +00:00
Kovarththanan Rajaratnam
2d5a1323e1 Make sure that we can resort with an active display filter 
svn path=/trunk/; revision=29710
 2009-09-05 13:24:16 +00:00
Kovarththanan Rajaratnam
2db51a0b3e Bail out gracefully on colums we cant sort on yet instead of crashing 
svn path=/trunk/; revision=29707
 2009-09-05 11:58:44 +00:00
Stig Bjørlykke
f91c46757a Make it build without warnings. 
svn path=/trunk/; revision=29706
 2009-09-05 11:15:50 +00:00