osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
33230 commits 23 branches 0 tags 1.3 GiB
Commit graph

13827 commits

Author SHA1 Message Date
Stig Bjørlykke
e7a8e117fc Cleanup reassembly hf entries. 
svn path=/trunk/; revision=34292
 2010-09-30 19:40:02 +00:00
Stig Bjørlykke
f5a210b2e8 Cleanup reassembly hf entries. 
svn path=/trunk/; revision=34291
 2010-09-30 19:35:51 +00:00
Jaap Keuter
733183a170 From Colin O'Flynn / Owen Kirby: 
The 6LoWPAN dissector had as a TODO the 'stateful address compression' mode.
This patch fixes that TODO, up to HC-13.
This patch also updates to HC-08, where the PANID is no longer used in forming
the short address.

svn path=/trunk/; revision=34290
 2010-09-30 19:23:31 +00:00
Stig Bjørlykke
7c3f2513ee Remove unneeded includes. 
svn path=/trunk/; revision=34289
 2010-09-30 19:20:59 +00:00
Stig Bjørlykke
46749e843c Use the name from hf_fragment instead of hf_fragments when we only have 
one fragment to reassemble.

svn path=/trunk/; revision=34285
 2010-09-30 09:53:51 +00:00
Stig Bjørlykke
65e0721f71 Constructed octet strings may contain zero encodings. 
(X.690 chapter 8.7.3)

svn path=/trunk/; revision=34284
 2010-09-30 06:19:32 +00:00
Balint Reczey
6094889963 Fix the libsmi workaround by adding missing brackets. 
From Grzegorz Głowacki <g.glowacki@wasko.pl>

svn path=/trunk/; revision=34280
 2010-09-29 15:46:35 +00:00
Anders Broman
72ac77046f From Pascal Quantin: 
[NAS EPS] Add dissection of EPS network feature support IE

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5264

svn path=/trunk/; revision=34279
 2010-09-29 15:41:27 +00:00
Jaap Keuter
fc1cf15ea4 Let the protocol column show we're having Secure RTCP when we do. 
svn path=/trunk/; revision=34278
 2010-09-28 21:22:35 +00:00
Jaap Keuter
f0428e7d0b Add the missing Signature-capable flag to the Hello message. 
Add missing SRT(C)P setup information to Conf2ACK message.

svn path=/trunk/; revision=34277
 2010-09-28 21:20:57 +00:00
Bill Meier
e5bb2e0541 Oops: remove a // comment (note to myself) 
svn path=/trunk/; revision=34272
 2010-09-28 15:26:58 +00:00
Bill Meier
9dcccb0e6a Improve dissection: 
1. Negotiation/Challenge/Authoriation messages:
   - dissect Version field (if present);
2. Authorization messages:
   - Dissect fields following session-key (flags/... if present) even 
     when session key is empty;
   - Dissect "MIC" field (if present);
3. Challenge message:
   - Rename "Domain" field to "Target Name" as per Microsoft spec (MS-NLMP).

svn path=/trunk/; revision=34271
 2010-09-28 14:14:12 +00:00
Ronnie Sahlberg
888227b0d2 update the RQUOTA dissector and add support for version 2 of the protocol 
svn path=/trunk/; revision=34270
 2010-09-28 05:50:54 +00:00
Stig Bjørlykke
6bf3129f17 Fix the offset errors reported in bug 5261. 
svn path=/trunk/; revision=34267
 2010-09-27 21:01:54 +00:00
Anders Broman
d7e6928096 Add PDUs to value_string. 
svn path=/trunk/; revision=34266
 2010-09-27 20:09:08 +00:00
Jeff Morriss
22475e4bce Some hf cleanup: make the field names different from the hf variable name 
and/or the abbreviation.

svn path=/trunk/; revision=34264
 2010-09-27 19:31:36 +00:00
Jeff Morriss
3f92ed92c7 Some hf cleanup: make the field names different from the hf variable name 
and/or the abbreviation.

svn path=/trunk/; revision=34263
 2010-09-27 19:05:43 +00:00
Anders Broman
0d4a4542ba From Vincent Helfre: 
Display the bits for 
.... .00. = PCID_Pattern: 0

svn path=/trunk/; revision=34262
 2010-09-27 12:53:42 +00:00
Anders Broman
a498b71098 Initialize subtree. 
svn path=/trunk/; revision=34261
 2010-09-27 10:11:40 +00:00
Anders Broman
415691da9d From Vincent Helfre: 
Release 8 june 2010 parameters decoding for SI2quater and Measurement Information messages.

svn path=/trunk/; revision=34260
 2010-09-27 08:45:16 +00:00
Anders Broman
8fef9edf1c Add a link to the protocol description. 
svn path=/trunk/; revision=34259
 2010-09-27 06:16:29 +00:00
Anders Broman
f1bdb63766 From Yaniv Kaul: 
[PATCH] Add specific names to 'Flags' in packet-scsi.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5259

svn path=/trunk/; revision=34258
 2010-09-27 06:05:24 +00:00
Gerald Combs
138b249153 [Automatic manuf and enterprise-numbers update for 2010-09-26] 
svn path=/trunk/; revision=34253
 2010-09-26 15:03:40 +00:00
Sake Blok
7ec231f7f1 Fix the output of columns with "show resolved" disabled when all occurrences are displayed. 
Limit the input field for occurrence to 4 characters to prevent an overflow.
Make sure "... as filter" does not result in an invalid filter string if all occurrences are displayed.


svn path=/trunk/; revision=34247
 2010-09-25 09:33:29 +00:00
Stephen Fisher
4bb182799a Add option to generate MD5 hash for payload in data dissector. Useful for 
tracking the same data when the headers are different (NAT, TCP seq #
randomization, etc).  Copied from packet-frame.c.


svn path=/trunk/; revision=34245
 2010-09-24 23:05:30 +00:00
Jeff Morriss
9238e29ae3 Don't use an abbreviation as the name of an hf entry. 
svn path=/trunk/; revision=34241
 2010-09-24 20:28:00 +00:00
Jörg Mayer
c749fe000c Comparing type II and III traces of the same packet 
indicate that the last 4 bytes of both types are similar.
So the extra bytes in type III are inserted before those
last bytes.

svn path=/trunk/; revision=34238
 2010-09-24 18:12:45 +00:00
Stig Bjørlykke
21319003d5 Added an extra validity check for cust_format_info. 
svn path=/trunk/; revision=34235
 2010-09-24 13:19:03 +00:00
Jeff Morriss
cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34230
 2010-09-24 02:51:40 +00:00
Jeff Morriss
3edbdc151d Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34229
 2010-09-24 01:34:45 +00:00
Jeff Morriss
72516cc39e Replace another blurb that matches the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34228
 2010-09-24 01:32:27 +00:00
Jeff Morriss
0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34227
 2010-09-23 21:46:31 +00:00
Jörg Mayer
72c3e35672 - trunkated -> truncated 
- Print "Type II" and "Type III" as versionstrings.
- Make sure that version = 1 or 2

svn path=/trunk/; revision=34222
 2010-09-23 20:44:11 +00:00
Jörg Mayer
320de7eb14 Jason Masker: 
- Add decoding of direction bit for version 2 (type III) erspan.

Me:
- Decode the original direction bit as unknown in case of version 2.
- The original unknown3 value seems to indicate whether the packet
  was too long to fit into a single mtu (trunkated).
- "Timestamp(s)" -> "Timestamp"


svn path=/trunk/; revision=34221
 2010-09-23 19:42:20 +00:00
Stig Bjørlykke
f5ab6c1930 Store "Show Resolved" setting for custom columns. 
svn path=/trunk/; revision=34220
 2010-09-23 19:41:55 +00:00
Bill Meier
123347da00 (Trivial) Whitespace cleanup. 
svn path=/trunk/; revision=34217
 2010-09-23 18:16:26 +00:00
Bill Meier
b98e9422f9 Make value_string ipproto_val static; It should only be referenced using ipproto_val_ext 
svn path=/trunk/; revision=34215
 2010-09-23 18:00:06 +00:00
Bill Meier
3b48b69866 Use extended ipproto value_string (ipproto_val_ext). 
svn path=/trunk/; revision=34214
 2010-09-23 17:55:11 +00:00
Bill Meier
a41e679b78 Whitespace cleanup: convert "4 space tabs" to spaces. 
svn path=/trunk/; revision=34213
 2010-09-23 17:52:29 +00:00
Bill Meier
f66669274f Whitespace cleanup: Convert "4 space tabs" to spaces. 
svn path=/trunk/; revision=34212
 2010-09-23 17:49:43 +00:00
Anders Broman
1252ff8350 From Pascal Quantin: 
NAS EPS] Wrong dissection of Non-current native NAS key set identifier

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5253

svn path=/trunk/; revision=34210
 2010-09-23 14:07:32 +00:00
Jörg Mayer
527f5d5653 Jason Masker <jason at masker.net>: 
Updates for the Cisco ERSPAN type III (version 2) protocol.

svn path=/trunk/; revision=34209
 2010-09-23 13:31:28 +00:00
Jeff Morriss
dfcc9ec3f7 Add some more casts. 
svn path=/trunk/; revision=34208
 2010-09-23 13:26:41 +00:00
Stig Bjørlykke
6087210f45 Updates from Lukasz Kotasa. 
svn path=/trunk/; revision=34207
 2010-09-23 09:22:12 +00:00
Stig Bjørlykke
907cfc535a Corrected check for attribute flag bits. 
svn path=/trunk/; revision=34203
 2010-09-23 07:42:20 +00:00
Stig Bjørlykke
c403378c36 Show Abort source in info column. 
svn path=/trunk/; revision=34202
 2010-09-23 07:39:38 +00:00
Jörg Mayer
de68ad3066 H. Sivank <hsivank@gmail.com> 
I try to configure Wireshark with cmake on macosx 10.6.
It fails with : set_target_properties called with incorrect number of arguments.
Attached a patch to fix this issue.


svn path=/trunk/; revision=34201
 2010-09-23 07:02:33 +00:00
Jaap Keuter
57a7873857 Fix for bug 5252: 
Use real IPv6 destination address when RH0 has 0 segments left.

svn path=/trunk/; revision=34199
 2010-09-23 06:58:55 +00:00
Jeff Morriss
f12ef203b3 Revert 34191 and add some casts instead 
svn path=/trunk/; revision=34193
 2010-09-23 06:00:22 +00:00
Jeff Morriss
7cdf98c245 Use gsize (size_t) in a couple of places to make the Win64 build happy. 
svn path=/trunk/; revision=34191
 2010-09-23 01:14:44 +00:00
Sake Blok
558d6a761e Make buildbot happy again... 
svn path=/trunk/; revision=34189
 2010-09-22 22:46:36 +00:00
Sake Blok
7364bef1b3 When using a custom column, make it possible to select which occurrence to show if the field has multiple occurrences. 
svn path=/trunk/; revision=34186
 2010-09-22 20:56:14 +00:00
Bill Meier
8e278e7f90 - reassembly code shouldn't be under 'if (tree)' 
- ECDH Parameter - Content:  Packet Bytes highlighting was off-by-one.

svn path=/trunk/; revision=34185
 2010-09-22 18:32:15 +00:00
Bill Meier
4a1b968738 Code cleanup: 
- Fix incorrect uses of val_to_str which could cause inv mem refs;
- Use tvb_reported_length instead of tvb_length;
- (Trivial) Remove some unneeded '= NULL' initializations;
- (A few other trivial changes).

svn path=/trunk/; revision=34183
 2010-09-22 15:52:53 +00:00
Stig Bjørlykke
70e4898377 Code cleanup: Changed proto_tree_add_boolean() and proto_tree_add_bytes() 
to proto_tree_add_item().

svn path=/trunk/; revision=34182
 2010-09-22 13:31:49 +00:00
Stig Bjørlykke
630893d158 From Lukasz Kotasa and Lukasz Suchy via bug 5248: 
Added dissector for WAI authentication protocol.

From me:
Some cleanup.

svn path=/trunk/; revision=34181
 2010-09-22 13:18:23 +00:00
Stig Bjørlykke
df7f6aa8ff From Lukasz Kotasa via bug 5248: 
Added ETHERTYPE_WAI.

svn path=/trunk/; revision=34180
 2010-09-22 13:14:46 +00:00
Anders Broman
b596b69f66 From Pascal Quantin: 
[NAS EPS] Use Request Type IE defined in 3GPP 24.008

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5246

svn path=/trunk/; revision=34179
 2010-09-22 10:38:45 +00:00
Anders Broman
f80f4ae05f From Pascal Quantin: 
[NAS EPS] Traffic Flow Template IE dissection bugs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5243

svn path=/trunk/; revision=34177
 2010-09-22 07:06:15 +00:00
Anders Broman
6dc449e99c The CLDAP attribute value on a CLDAP reply is no longer being decoded 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5239

It got broken in Revision 33390 I think, if attr_type is unset at this point it should be set in the calling function.
http://anonsvn.wireshark.org/viewvc/trunk/asn1/ldap/ldap.cnf?r1=33388&r2=33390

svn path=/trunk/; revision=34176
 2010-09-21 14:56:55 +00:00
Jeff Morriss
381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 : 
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
 2010-09-21 03:14:49 +00:00
Jeff Morriss
46ef82837f Add a cast 
svn path=/trunk/; revision=34164
 2010-09-21 03:06:54 +00:00
Jeff Morriss
79e39c7ecb Use size_t to keep the Windows compiler happy 
svn path=/trunk/; revision=34163
 2010-09-21 02:41:29 +00:00
Jeff Morriss
f2d070f19e From Jakub Zawadzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3336 : 
We parse host & request page from headers, so we easily can construct full http
uri.

I was thinking about making it as field, so we could filter, print in column
info, or do other fancy stuff, but for now this is imho enough.


From me: add it as a (filterable) item.  Clean up spacing and indentation in a
few places.

svn path=/trunk/; revision=34162
 2010-09-21 02:12:21 +00:00
Martin Mathieson
5d84e780d9 Fix sequence numbers reported when duplicate SN detected. 
svn path=/trunk/; revision=34161
 2010-09-20 17:01:22 +00:00
Stig Bjørlykke
e6dac92931 Put Abort reason in info column. 
svn path=/trunk/; revision=34159
 2010-09-20 12:49:52 +00:00
Gerald Combs
b08297d7ef [Automatic manuf and enterprise-numbers update for 2010-09-19] 
svn path=/trunk/; revision=34155
 2010-09-19 15:03:36 +00:00
Jaap Keuter
12b574e628 Fix for bug 5220: 
- Don't list codecs which are deleted by using port 0.
- Use real concatenation i.s.o. reprint, which seems to fail in some circumstances.

svn path=/trunk/; revision=34154
 2010-09-18 13:12:03 +00:00
Jeff Morriss
9ac49c557d Copy the rev 34143 changes to packet-snmp.c over to the asn1 source. 
hf_snmp_engineid_enterprise is now a BASE_EXT_STRING, not BASE_RANGE_STRING.  This fixes
the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5233 

svn path=/trunk/; revision=34151
 2010-09-17 14:03:05 +00:00
Bill Meier
7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[]; 
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
 2010-09-17 04:51:21 +00:00
Jeff Morriss
d643e0366a Remove check_col(). Clean up some spacing/indentation too. 
svn path=/trunk/; revision=34142
 2010-09-17 02:22:37 +00:00
Jeff Morriss
f2cfa4e453 From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5197 : 
The NFS dissector (all versions) show access types that have not been requested
to be checked as "not allowed" in the call and reply.  This is incorrect and
misleading.  At present one must manually compare what was requested in order
to assess if access was actually denied for that type.  When there are hundreds
or thousands of these ACCESS requests in a capture, it is not possible or
practical to manually check each one.  

The submitted patch does the following:

* Passes the access mask in the call to the reply for comparison
* Adds filterable fields for each supported (v4) and access type
* Adds a pseudo field, nfs.access_denied
* Lists the access types to be checked in the summary and tree
* Separately lists the supported, denied, and allowed access types in the 
  summary and tree

The changes are applied to all NFS versions.


From me: a couple of small changes to make it compile without warnings.

svn path=/trunk/; revision=34141
 2010-09-17 02:03:09 +00:00
Bill Meier
252df40cc2 Extensive V9/V10 code clean up, bug fixing & dissection display improvements: 
Bugs fixed:
 - Invalid time display for various time fields;
     Millisecs for types 152, 153 are actually stored as 64 bit integers;
     Microsecs, nanosecs are actually stored  in "NTP format";
     Times for fields 158, 159 are relative to "export time";
     SystemInitTime displayed incorrectly;
     ...
 - Options template not cached when only scope fields in template.
 - Templates not processed on first pass thru capture file:
    (In some cases data flows might not be handled until options template later displayed).
 - V9: number of options template entries limited to about 8 instead of intended 42;
 - Multiple options temlate flows in an Options Template flowset not handled;
 - "NotSentOctets" dislayed as "NotSentPackets";
   ...

Cleanups:
 - Options and data template processing code more or less rewritten;
 - options template displayed with format similar to that used for data templates;
 - Handling and display of PEN field (including use to indicate REVERSE) improved;
 - Don't use same filter name for two similar fields which only differ in size;
 - Handling & dislay of "variable length" fields improved;
 - sminmec lookup (PEN) done only during template processing & cached for later use;
   ...
 - Whitespace/Formatting

svn path=/trunk/; revision=34140
 2010-09-17 01:45:29 +00:00
Stephen Fisher
034f2739d2 Add "(BE)" to the big endian representations of the ICMP identifier and 
sequence number fields to match the "(LE)" ones.


svn path=/trunk/; revision=34136
 2010-09-16 18:22:45 +00:00
Stig Bjørlykke
2d93bc5e9a Make "4 NOP in a row" work again after changing the NOP name for TCP and IP 
in revisions 34095 and 34097.

svn path=/trunk/; revision=34134
 2010-09-16 12:29:22 +00:00
Sake Blok
84c08f1472 From Juha Siltanen : 
When sorting a capture by protocol, some RTP packets are shown only as FLIP,
even though the dissection windows shows the RTP tree.

(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5215)


svn path=/trunk/; revision=34128
 2010-09-15 21:17:35 +00:00
Stephen Fisher
c3beba4fd1 Bug #5127 from Guenter Strubreiter: 
for avoiding doubled definition of a table needed also by a tcap subdissector
plugin a definition in libwirshark.def is needed:

isup_calling_partys_category_value

Me: Change extern to WS_VAR_IMPORT in header file


svn path=/trunk/; revision=34126
 2010-09-15 20:29:31 +00:00
Martin Mathieson
dcf1ce54da Missed this one (check_col() removal) 
svn path=/trunk/; revision=34125
 2010-09-15 16:17:16 +00:00
Martin Mathieson
a5532739d6 Remove a few more calls to check_col() 
svn path=/trunk/; revision=34124
 2010-09-15 16:16:23 +00:00
Martin Mathieson
fbf198ae9b Add expert info for timing adjustment control message, and tweak a label. 
svn path=/trunk/; revision=34123
 2010-09-15 15:52:30 +00:00
Jeff Morriss
4584a81149 Revert 34081 and 34093 in preparation for a cleaner fix. 
svn path=/trunk/; revision=34121
 2010-09-15 15:13:17 +00:00
Jeff Morriss
2b52159449 Follow up to bug 5209 and rev 34115: 
%hh is C99 so remove it from packet-ssl-utils and add it to the banned list
(similar to %ll) in checkAPIs.pl .


svn path=/trunk/; revision=34120
 2010-09-15 14:10:25 +00:00
Stephen Fisher
0583c64d8f Clean up the icmp info column per discussion in bug #4014. 
Change to using new ENC_[BIG|LITTLE]_ENDIAN instead of FALSE and TRUE
in the proto_tree_add_item() calls for the identifier and sequence numbers.


svn path=/trunk/; revision=34119
 2010-09-14 21:38:54 +00:00
Stephen Fisher
07c7d3046a Remove duplicate register_all_protocol_handoffs entry 
svn path=/trunk/; revision=34117
 2010-09-14 16:03:34 +00:00
Stephen Fisher
fe45005420 Bug #5211 from Guenter Strubreiter: 
for writing a TCAP subdissector as a plugin some functions are needed in
libwireshark.def for export



svn path=/trunk/; revision=34116
 2010-09-14 15:54:12 +00:00
Gerald Combs
436ab95472 From Cal Turney via bug 5209: 
Decode of SETCLIENTID calls in the Windows x86 version fail with "[Dissector
bug, protocol NFS: STATUS_ACCESS_VIOLATION: dissector accessed an invalid
memory address]".  This error occurs in packet-nfs.c in
dissect_nfs_clientaddr4() where vars 'protocol' and 'universal_ip_address' get
stepped on following the call to scanf().  The b1-b10 vars are declared as
quint8.  While "hh" modifier used in the scanf() is documented in Linux to
correspond to an a signed/unsigned char arg, I cannot find a similar
designation in Windows (MSDN). The Windows C compiler interprets %hhu as
corresponding to a int16 rather than int8.

svn path=/trunk/; revision=34115
 2010-09-14 15:43:19 +00:00
Anders Broman
97d69446ea From tieuthunhi: 
Add new time source for Gigamon header.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5210

svn path=/trunk/; revision=34114
 2010-09-14 14:43:56 +00:00
Anders Broman
14b9a4c56a From Vincent Helfre: 
Incorrect decoding of List of ARFCN in BCCH frequency list.
When the range 1024 is selected, it can happen that 2 bytes need to be read for
W1, and also for W2. In the current version, when W1 ends on a byte boundary,
W2 will get an incorrect value, since it will be truncated by 1 bit.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5214

svn path=/trunk/; revision=34113
 2010-09-14 14:24:39 +00:00
Gerald Combs
4c74418400 Attempt to fix the stack overflow reported at 
http://seclists.org/bugtraq/2010/Sep/87 .

Unfortunately no one from the NCNIPC pen test team has contacted us or
provided a sample capture so the fix hasn't been verified.

svn path=/trunk/; revision=34111
 2010-09-13 18:49:55 +00:00
Anders Broman
5a28b5317e From Yaniv Kaul: 
[PATCH] Add SSL cipher 'Transport Layer Security (TLS) Renegotiation Indication Extension' (RFC 5746)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5207

svn path=/trunk/; revision=34110
 2010-09-13 16:51:10 +00:00
Anders Broman
6117e317c6 Remove deprecated check_col(). 
svn path=/trunk/; revision=34107
 2010-09-12 19:29:05 +00:00
Gerald Combs
bc8ce9e9e3 [Automatic manuf and enterprise-numbers update for 2010-09-12] 
svn path=/trunk/; revision=34102
 2010-09-12 15:03:34 +00:00
Balint Reczey
cfbd48b785 Decode SLL payloads using a dissector table based on sll.ltype. 
The idea and the original patch came from Sebastian Reichel
<elektranox@gmail.com> in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594390

svn path=/trunk/; revision=34101
 2010-09-12 01:13:42 +00:00
Stig Bjørlykke
894941e532 Only check for 4 NOP in a row within a uint32 boundary. 
svn path=/trunk/; revision=34100
 2010-09-10 21:24:32 +00:00
Stig Bjørlykke
633e4e324b From Martin Peylo via bug 5198: 
Added missing OIDs in CRMF (RFC 4211) dissector.

svn path=/trunk/; revision=34099
 2010-09-10 21:22:29 +00:00
Stig Bjørlykke
f2e302eee0 Follow TCP and expand description for "NOP" and "EOL" options to "No-Operation (NOP)" 
and "End of Options List (EOL)" respectively.

svn path=/trunk/; revision=34097
 2010-09-10 16:48:00 +00:00
Stephen Fisher
0e0641f079 Put the ": %u (multiply by %u)" back on the TCP window scaling option, so 
users don't have to expand the tree to see the details that were there 
before rev 34094.


svn path=/trunk/; revision=34096
 2010-09-10 16:33:46 +00:00
Stephen Fisher
f2e2be709a Expand description for "NOP" and "EOL" options to "No-Operation (NOP)" and 
"End of Options List (EOL)" respectively.


svn path=/trunk/; revision=34095
 2010-09-10 16:23:58 +00:00
Stephen Fisher
8d3e472866 Enhance the TCP option display for window scaling. 
svn path=/trunk/; revision=34094
 2010-09-10 16:12:17 +00:00
Jeff Morriss
a81a10a63a From BBA via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 : 
Followup to 34081: move libwsutil _all_ the way forward so that our inet_pton
is always linked in before wsock32's.  This means that our Windows-7 Win64
builds (on which there is a native inet_pton in wsock32) will still work on
pre-Vista Win64's.

svn path=/trunk/; revision=34093
 2010-09-10 13:52:42 +00:00
Stig Bjørlykke
aca8a4d989 Update dsfield ECN according to RFC3168. 
svn path=/trunk/; revision=34092
 2010-09-10 11:16:29 +00:00
Jeff Morriss
11ee648da3 Add some hf blurbs (for fields whose description is an acronym) 
svn path=/trunk/; revision=34091
 2010-09-09 18:36:20 +00:00
Stephen Fisher
ff5cfee491 Turn the TCP timestamp option into a subtree to also show the option kind, 
option length and values with proto_tree_add_item() intead of _add_text().
The options tree still shows the same information as before until the sub-
tree is expanded.

The goal is to do this with all TCP and IP options.


svn path=/trunk/; revision=34088
 2010-09-08 23:10:52 +00:00
Stig Bjørlykke
d968bc8b61 Mask out the header length from th_flags. 
svn path=/trunk/; revision=34087
 2010-09-08 21:25:14 +00:00
Stephen Fisher
b17b2eb187 Make the Windows buildbot happy: guint8 -> guint16 for flags variable in 
definition of tcp_analyze_sequence_number(). 


svn path=/trunk/; revision=34086
 2010-09-08 21:11:45 +00:00
Stephen Fisher
e12fc91a33 Minor correction to SVN revision 34084: we better only try up to the 9 
available values in flags[], so we don't run past the end of the array
if one of the reserved flags is set. 


svn path=/trunk/; revision=34085
 2010-09-08 20:52:00 +00:00
Stephen Fisher
dfacac4421 Expand the TCP flags to include the low nibble of the byte that has 
the header length in the high nibble.  The only new flag is nonce (NS);
the remaining three bits are still reserved.


svn path=/trunk/; revision=34084
 2010-09-08 20:43:19 +00:00
Stephen Fisher
4c6864b29b From Frank Lahm via bug #5169: Provide initial support for the undocumented 
AFP FPSpotlightRPC call. 


svn path=/trunk/; revision=34083
 2010-09-08 19:01:41 +00:00
Stig Bjørlykke
e71daa1fc1 Revert revision 33780, because the checksum is only calculated 
from the header and not the content.

svn path=/trunk/; revision=34080
 2010-09-08 13:38:47 +00:00
Stig Bjørlykke
c1a591cd37 Support negative values when viewing seconds with hours and minutes. 
svn path=/trunk/; revision=34079
 2010-09-08 10:29:06 +00:00
Stig Bjørlykke
9562d30a13 Allow for proto_tree_add_item() with FT_ABSOLUTE_TIME and FT_RELATIVE_TIME 
to have length == 4 (only seconds).

svn path=/trunk/; revision=34078
 2010-09-08 09:33:53 +00:00
Stig Bjørlykke
bc11261a75 From Yaniv Kaul via bug 5193: 
Dissect NTLMSSP type 0x5 (DNS Forest name).

svn path=/trunk/; revision=34077
 2010-09-08 09:24:53 +00:00
Tomas Kukosa
eb503df011 Do not report undecoded message to expert info for ReturnResult without result filed 
svn path=/trunk/; revision=34076
 2010-09-08 09:02:16 +00:00
Stig Bjørlykke
4e4ee5e199 Fake proto_item_prepend_text() in reassemble_test. 
svn path=/trunk/; revision=34075
 2010-09-08 06:45:04 +00:00
Stig Bjørlykke
79ec447f8b Put the number of fragments/segments in front of the element to avoid 
conflict when they are named fragments instead of segments and to avoid
duplicating the fragments/segments text.

svn path=/trunk/; revision=34074
 2010-09-07 20:40:39 +00:00
Stig Bjørlykke
1af02462fd From Yaniv Kaul via bug 4550: 
Show number of segments which were used in the desgementation.

svn path=/trunk/; revision=34072
 2010-09-07 14:06:43 +00:00
Stig Bjørlykke
bd3906e8d6 From yami via bug 3310: 
SMB2 create context response fix.

svn path=/trunk/; revision=34070
 2010-09-06 19:59:15 +00:00
Stig Bjørlykke
ca111463e7 From Pascal Quantin via bug 5186: 
Fix the decoding of the maximum/guaranteed bit rates for uplink/downlink.

svn path=/trunk/; revision=34069
 2010-09-06 17:31:17 +00:00
Gerald Combs
5e686039a0 [Automatic manuf and enterprise-numbers update for 2010-09-05] 
svn path=/trunk/; revision=34064
 2010-09-05 15:03:42 +00:00
Stig Bjørlykke
42d0e5b2a8 Request-Line can contain an empty Request-URI. 
I don't want to change get_token_len() to not skip multiple spaces,
because I don't know if other protocols depends on this behaviour.
We should maybe check this...

This fixes bug 5181.

svn path=/trunk/; revision=34063
 2010-09-05 12:16:14 +00:00
Anders Broman
187baa00fa GTPv2: IMSI is decoded improperly. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5179

svn path=/trunk/; revision=34062
 2010-09-03 17:10:52 +00:00
Martin Mathieson
4b5c69c0d9 Add bandwidth figures per UE. 
svn path=/trunk/; revision=34061
 2010-09-03 16:45:05 +00:00
Martin Mathieson
055d654cc2 Add bandwidth figures to RLC stats (per-UE and per-channel). 
svn path=/trunk/; revision=34059
 2010-09-03 15:22:28 +00:00
Tomas Kukosa
a974e115ce Fix start offset and length handling in SEQUNCE OF (caused Gtk crash for sequences at the end of frame) 
svn path=/trunk/; revision=34058
 2010-09-03 10:31:56 +00:00
Stig Bjørlykke
d2a3935fb7 Code cleanup: Remove Begin/End comments on each and every code block, 
this only makes the code hard to read.

svn path=/trunk/; revision=34056
 2010-09-03 09:10:32 +00:00
Stig Bjørlykke
16db2dd4f5 Check if using tree before adding the octet string. 
svn path=/trunk/; revision=34055
 2010-09-03 08:44:00 +00:00
Anders Broman
05642bcab3 Add doxygen coments. 
svn path=/trunk/; revision=34053
 2010-09-03 07:28:51 +00:00
Anders Broman
4e907d2a70 From Michael Lum: 
ANSI-A dissector does not recognize service option 73
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5176

svn path=/trunk/; revision=34050
 2010-09-03 06:18:29 +00:00
Anders Broman
956ddcb4b9 From Michael Lum: 
The EVRC dissector does not handle service option 73 (EVRC-NW).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5177

svn path=/trunk/; revision=34049
 2010-09-03 05:50:55 +00:00
Stig Bjørlykke
67a4451239 Apply the quick fix from bug 2952. 
And it's true, this dissector really needs an overhaul!

svn path=/trunk/; revision=34048
 2010-09-02 21:30:54 +00:00
Jeff Morriss
7d20440ff0 Introduce 2 new environment variables: WIRESHARK_EP_VERIFY_POINTERS and 
WIRESHARK_SE_VERIFY_POINTERS that control whether or not we verify if a given
pointer is ep_ or se_ allocated, respectively.

Turn the behavior off by default for speed reasons (the speed difference isn't
huge, but...).

Turn the behavior on when fuzz testing.

Document these two new variables in the man pages.

svn path=/trunk/; revision=34046
 2010-09-02 18:02:06 +00:00
Jeff Morriss
8ffbb8ade8 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5173 : 
Don't call col_set_str() on a string returned from val_to_str() (which may be
ep_ allocated).

svn path=/trunk/; revision=34045
 2010-09-02 17:13:36 +00:00
Stephen Fisher
de23882f07 Fix typo in comment: datat -> data 
svn path=/trunk/; revision=34044
 2010-09-02 17:11:48 +00:00
Anders Broman
136dec3980 From Pascal Quantin: 
Patch that allows the dissection of the Feature Group Indicators bit string. I tested it with our UE and it works fine.

svn path=/trunk/; revision=34035
 2010-08-31 20:03:46 +00:00
Stig Bjørlykke
afd6761f46 A GString has it's own length. 
svn path=/trunk/; revision=34034
 2010-08-31 18:28:59 +00:00
Stig Bjørlykke
f75b4ae02b Support space in list of hidden columns. 
This fixes bug 5163.

svn path=/trunk/; revision=34033
 2010-08-31 15:02:03 +00:00
Anders Broman
fc87f4a4c1 Add stub code for future dissection of featureGroupIndicators. 
svn path=/trunk/; revision=34032
 2010-08-31 10:50:54 +00:00
Stig Bjørlykke
85b4d16277 Update the header length after dissecting the header. 
This fixes bug 5162.

svn path=/trunk/; revision=34031
 2010-08-31 10:24:08 +00:00
Jeff Morriss
16653c5a6c Fix the crash reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5157 : 
If get_unicode_or_ascii_string() returns a NULL pointer, return a pointer to an
empty string back to our caller.

svn path=/trunk/; revision=34018
 2010-08-30 17:05:37 +00:00
Jeff Morriss
05f5bf510b Use the top-level isprint.h instead of redefining isprint ourselves. 
svn path=/trunk/; revision=34016
 2010-08-30 15:33:32 +00:00
Anders Broman
e17efa574d Doxygen fix. 
svn path=/trunk/; revision=34013
 2010-08-30 14:22:49 +00:00
Stig Bjørlykke
4382dcffad Call dfilter_macro_uat->post_update_cb instead of using cfile. 
svn path=/trunk/; revision=34012
 2010-08-30 09:31:52 +00:00
Stig Bjørlykke
835a43312f Always update the display filter when changing a display filter macro 
and when changing profile.  Not sure why I have to invalidate cfile.dfilter
in macro_update(), because this will be done in macros_post_update(),
but unless this we get a crash when renaming a macro...

This is a fix for bug 5002.

svn path=/trunk/; revision=34011
 2010-08-30 08:47:26 +00:00
Stig Bjørlykke
4f6e546d4d Always call post_update_cb() in uat_load_str(). 
svn path=/trunk/; revision=34010
 2010-08-30 08:43:03 +00:00
Anders Broman
6d1a0a2e86 Doxygen related changes. 
svn path=/trunk/; revision=34009
 2010-08-30 05:39:02 +00:00
Bill Meier
7ebd25f59e Various: 
1. Re-arrange proto_reg_handoff... code to follow the "standard idiom" for init/set of port prefs;
2. Define all fcns as static (except proto_register and proto_reg_handoff);
3. ethereal --> Wireshark;
4. Remove some uneeded/unused prototypes;
5. Fix a few function description comments.

svn path=/trunk/; revision=34006
 2010-08-30 01:14:08 +00:00
Anders Broman
687eb5a2a6 Fix for Bug Packet details have errors when decode MAP V2 PRN_ACK msg 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5076

Use:
/*
 * Dissect Multiple Choice Message
 * This function is used to decode a message, when several encoding may be used.
 * For exemple, in the last MAP version, the Cancel Location is defined like this:
 * CancelLocationArg ::= [3] IMPLICIT SEQUENCE
 * But in the previous MAP version, it was a CHOICE between a SEQUENCE and an IMSI
 * As ASN1 encoders (or software) still uses the old encoding, this function allows
 * the decoding of both versions.
 * Moreover, some optimizations (or bad practice ?) in ASN1 encoder, removes the
 * SEQUENCE tag, when only one parameter is present in the SEQUENCE.
 * This explain why the function expects 3 parameters:
 * - a [3] SEQUENCE corresponding the recent ASN1 MAP encoding
 * - a SEQUENCE for old style
 * - and a single parameter, for old version or optimizations
 *
 * The analyze of the first ASN1 tag, indicate what kind of decoding should be used,
 * if the decoding function is provided (so not a NULL function)
 */

svn path=/trunk/; revision=34001
 2010-08-29 17:34:44 +00:00
Sake Blok
93cfe5571b From Cal Turney (bug 5132): 
TCP bytes_in flight becomes inflated with lost packets 

This patch suspends Bytes-in-Flight calculation when missing packets are detected.


svn path=/trunk/; revision=33994
 2010-08-29 15:27:20 +00:00
Gerald Combs
0d6000b5ff [Automatic manuf and enterprise-numbers update for 2010-08-29] 
svn path=/trunk/; revision=33992
 2010-08-29 15:03:30 +00:00
Anders Broman
a009cc0605 Doxygen changes. 
svn path=/trunk/; revision=33990
 2010-08-29 10:47:38 +00:00
Gerald Combs
2f6dd574b7 Display 6to4 gateway IPv4 addresses and SLA IDs. 
svn path=/trunk/; revision=33984
 2010-08-28 20:55:32 +00:00
Bill Meier
b3ed77c1b0 #inlude <emem.h> not req'd; 
Use tvb_strncmp to compare for "ESIO" string in packet;
Use consistent indentation conforming to the "editor modelines";
Minor other whitespce cleanup.

svn path=/trunk/; revision=33983
 2010-08-28 19:50:00 +00:00
Gerald Combs
5fb37af39a De-obfuscate the Teredo client address and add a de-obfuscated port. 
svn path=/trunk/; revision=33982
 2010-08-28 19:46:20 +00:00
Anders Broman
a96e6b2047 Doxygen changes. 
svn path=/trunk/; revision=33981
 2010-08-28 19:27:19 +00:00
Gerasimos Dimitriadis
fe34e9a3fb Support for eMLPP Priority IE in BSSMAP 
svn path=/trunk/; revision=33971
 2010-08-27 21:30:12 +00:00
Guy Harris
43ae1a4b2b Update some links. 
svn path=/trunk/; revision=33969
 2010-08-27 21:28:24 +00:00
Guy Harris
add0764bc2 Allow Dissect As... to select the Ethernet-without-FCS dissector for a 
given UDP port; this is to handle the output for the Cisco CMTS "cable
intercept" command - it encapsulates Ethernet frames in UDP packets, but
the UDP port is user-defined.

svn path=/trunk/; revision=33964
 2010-08-27 21:13:26 +00:00
Gerasimos Dimitriadis
6f6fb2fd80 MNC, SANC, ISPC lists updated up to OB 960 
svn path=/trunk/; revision=33963
 2010-08-27 21:09:05 +00:00
Stig Bjørlykke
355e2bed0a From Owen Kirby via bug 5149: 
Added a new dissector for SCoP.

svn path=/trunk/; revision=33962
 2010-08-27 21:05:02 +00:00
Stig Bjørlykke
ec94791339 From Frank Lahm via bug 5136: 
Correct volume flags for FPGetSrvrParms.

svn path=/trunk/; revision=33961
 2010-08-27 20:54:21 +00:00
Gerald Combs
a3cbcbffb8 Display Teredo encapsulated IPv4 server and client addresses. 
svn path=/trunk/; revision=33959
 2010-08-27 19:52:17 +00:00
Stig Bjørlykke
1249a53f09 From Christian Durrer via bug 5155: 
Added a new dissector for Ether-S-I/O protocol.

svn path=/trunk/; revision=33954
 2010-08-27 17:18:28 +00:00
Stig Bjørlykke
551093a39a From Matthieu Lochegnies via bug 5153: 
Show multiples DRDA commands from the same frame.

svn path=/trunk/; revision=33952
 2010-08-27 16:30:38 +00:00
Martin Mathieson
31099a13aa Allow 3GPP release info to be displayed. 
svn path=/trunk/; revision=33950
 2010-08-27 13:54:05 +00:00
Stig Bjørlykke
598b89ab7f Added a check for constructed octet string to avoid a loop. 
This fixes bug 5154.

svn path=/trunk/; revision=33949
 2010-08-27 11:55:14 +00:00
Jaap Keuter
ccc74ae967 Take in updates from the TLS registery. 
svn path=/trunk/; revision=33948
 2010-08-27 06:28:17 +00:00
Anders Broman
a20bf7af0d Fix doxygen errors. 
svn path=/trunk/; revision=33938
 2010-08-26 19:40:08 +00:00
Stephen Fisher
36c2954387 Show a text string of the Windows version (if Windows 2000 or higher.) 
svn path=/trunk/; revision=33936
 2010-08-26 18:06:56 +00:00
Anders Broman
1c2b3b0eb9 Fix a number of doxygen directives. 
svn path=/trunk/; revision=33930
 2010-08-26 15:24:49 +00:00
Stig Bjørlykke
113fac8b77 From Juha Siltanen via bug 5144: 
Added support for payload dissecting.

svn path=/trunk/; revision=33928
 2010-08-26 13:49:23 +00:00
Anders Broman
48ac5f90ff - Try to fix a couple of doxygen comments. 
- whitspace changes.

svn path=/trunk/; revision=33926
 2010-08-26 06:46:30 +00:00
Gerald Combs
607b228df6 Add ws_load_library and ws_module_open, which respectively call 
LoadLibrary and g_module_open only for the program directory and system
directory on Windows. Use them to replace a bunch of LoadLibrary and
g_module_open calls. Use the extension ".dll" for all the DLLs that we
load. Add comments about DLL loading in Python.

svn path=/trunk/; revision=33924
 2010-08-25 20:30:59 +00:00
Tomas Kukosa
f5e1f23cac Fix wrong length of CSeq Method parameter 
svn path=/trunk/; revision=33920
 2010-08-25 14:10:58 +00:00
Martin Mathieson
c53d8b200b Let DCT2000 tree extend to end of ipprim or sctpprim bytes. 
svn path=/trunk/; revision=33919
 2010-08-25 13:27:27 +00:00
Martin Mathieson
3852415572 Show (again?) MAC-d PDUs inside MAC-es PDUs. 
svn path=/trunk/; revision=33918
 2010-08-25 13:01:00 +00:00
Stig Bjørlykke
ce99177a00 Display content entry (with length) in tree. 
svn path=/trunk/; revision=33914
 2010-08-24 15:47:10 +00:00
Stig Bjørlykke
98493ff110 Rewrote to fetch content_tvb from dissect_ber_octet_string(). 
Display eContent entry (with length) in tree.

svn path=/trunk/; revision=33912
 2010-08-24 15:43:32 +00:00
Stig Bjørlykke
1a5f73299e Display octet string fragments for RTSE segment data. 
svn path=/trunk/; revision=33911
 2010-08-24 15:09:11 +00:00
Stig Bjørlykke
8b6c6a3dbf Display constructed octet strings with correct hf_id. 
Show octet string fragments as for reassembly.

svn path=/trunk/; revision=33910
 2010-08-24 15:08:07 +00:00
Stig Bjørlykke
f3f59dbf95 Indicate abort and abort-reason in info column. 
svn path=/trunk/; revision=33908
 2010-08-24 11:36:10 +00:00
Anders Broman
5371cb66b9 From Christian Durrer: 
Not all Ether-S-Bus telegrams are recognized and displayed correctly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5123

svn path=/trunk/; revision=33903
 2010-08-24 05:38:49 +00:00
Gerald Combs
a875855c39 Display ISATAP encapsulated IPv4 addresses. 
svn path=/trunk/; revision=33900
 2010-08-24 00:24:44 +00:00
Stephen Fisher
b4addc04fe The ARP hardware type and operation code are listed with the IANA in decimal notation, not hex. 
svn path=/trunk/; revision=33898
 2010-08-23 23:09:32 +00:00
Stig Bjørlykke
d0dfefaca8 Fix for attribute boolean, from bug 5127. 
svn path=/trunk/; revision=33887
 2010-08-23 09:17:03 +00:00
Gerald Combs
66c34b8293 [Automatic manuf and enterprise-numbers update for 2010-08-22] 
svn path=/trunk/; revision=33881
 2010-08-22 15:03:30 +00:00
Gerald Combs
a766c88c52 Add a "summary in tree" option similar to v4. 
svn path=/trunk/; revision=33878
 2010-08-21 17:45:03 +00:00
Jeff Morriss
486562f263 Add some code to prefs_cleanup() to free (most of the) memory associated with the preferences. This only happens during shutdown so it's not fixing a memory leak, but it makes me more comfortable to know where the preferences memory is freed. 
svn path=/trunk/; revision=33874
 2010-08-21 04:26:26 +00:00
Jeff Morriss
b05ee41bc0 Remove duplicate definition of COL_MAX_LEN and COL_MAX_INFO_LEN: apparently no one needs them in this file (probably because they're marked as "don't use"). Now they are only defined in column_info.h . 
svn path=/trunk/; revision=33871
 2010-08-21 03:31:30 +00:00
Gerald Combs
71c99df326 If we have something that looks like a stateless autoconfiguration 
address, add the corresponding MAC address to the tree.

svn path=/trunk/; revision=33870
 2010-08-21 00:19:32 +00:00
Jeff Morriss
1fcaf7fb3f Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5114 (infinite loop in 
bootp dissector when dissecting packetcable MTA capabilities).

Limit the tlv_len to G_MAXUINT16 to prevent an integer overflow from causing us to
increment the working offset by 0 (thus causing us to loop).

svn path=/trunk/; revision=33846
 2010-08-19 02:17:01 +00:00
Gerasimos Dimitriadis
296be75cb8 Fix for Bug 5052: 
Good ZigBee Beacon detected as malformed

In ZigBee 2006 the Tx-Offset is optional, while in the 2007 and
later versions, the Tx-Offset is a required value. Since both 2006 and
and 2007 versions have the same protocol version (2), we should treat
the Tx-Offset as well as the update ID as optional elements

svn path=/trunk/; revision=33842
 2010-08-18 21:12:26 +00:00
Martin Mathieson
b7158c4e2d Fix ipprim IPv6 port number offsets. 
svn path=/trunk/; revision=33840
 2010-08-18 10:47:21 +00:00
Martin Mathieson
75af18e3a8 Show IPv6 addresses in ipprim summary line. 
svn path=/trunk/; revision=33839
 2010-08-18 10:33:54 +00:00
Anders Broman
1b9da2fcf0 Fix indentation. 
svn path=/trunk/; revision=33838
 2010-08-18 08:09:37 +00:00
Gerasimos Dimitriadis
6ebc2acff4 Updates due to ITU Operational Bulletins 956 and 957 
svn path=/trunk/; revision=33833
 2010-08-17 22:48:39 +00:00
Gerasimos Dimitriadis
27b4dfa426 The Mobile Status msg in BSSAP+ has IMSI as first possible IE 
svn path=/trunk/; revision=33832
 2010-08-17 21:35:26 +00:00
Martin Mathieson
a0387bbbc6 Change a channel type #define to be contiguous with others. 
svn path=/trunk/; revision=33831
 2010-08-17 16:12:29 +00:00
Jörg Mayer
90b105c5e6 Commit 33815 renamed packet-nt-sonmp.c to packet-ndp.c 
svn path=/trunk/; revision=33827
 2010-08-17 07:00:58 +00:00
Bill Meier
09e845ba03 Fix two typos/bugs (introduced by me in the previous commit). 
svn path=/trunk/; revision=33825
 2010-08-17 01:01:48 +00:00
Bill Meier
3398f73455 From Tom Hughes: FastCGI dissector. 
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5067

From me: - Fix one bug;
         - Add a comment about some code which doesn't display info
            in COL_INFO as intended due to what seems to be a Wireshark bug in 
            tcp_dissect_pdus() when there are multiple records in a 
            TCP frame.

svn path=/trunk/; revision=33824
 2010-08-17 00:51:44 +00:00
Stephen Fisher
139d2e3af2 Clarify that the "Sequence number" is given in big endian representation and the "Sequence number (LE)" is little endian. 
svn path=/trunk/; revision=33822
 2010-08-16 22:28:23 +00:00
Stephen Fisher
62a058ef5d Change the protocol name from "Nortel NDP" to "Nortel Discovery Protocol" in the protocol registration. 
svn path=/trunk/; revision=33821
 2010-08-16 22:01:12 +00:00
Stephen Fisher
67aa3ba7d1 Fix display of Client's FQDN and clear up the confusion with the S, O and N bits from the RFC descriptions. 
svn path=/trunk/; revision=33820
 2010-08-16 21:41:29 +00:00
Stephen Fisher
a81a8dd250 Modernize the SONMP ("SynOptics Network Management Protocol") dissector by renaming it to NDP ("Nortel Discovery Protocol") and do some basic cleanup. 
svn path=/trunk/; revision=33815
 2010-08-16 17:19:42 +00:00
Guy Harris
cd67ad0047 Clean up indentation. 
svn path=/trunk/; revision=33814
 2010-08-16 17:19:15 +00:00
Anders Broman
9da9ac87d3 Typo - wrong IE code for APN aggregate maximum bit rate in message 
Activate default EPS bearer context request.

svn path=/trunk/; revision=33813
 2010-08-16 15:31:13 +00:00
Martin Mathieson
d8be0764d3 Set length of 'PDU Block Header' subtrees. 
svn path=/trunk/; revision=33812
 2010-08-16 15:14:01 +00:00
Anders Broman
63bffd3ac5 From rodebiet: 
tvb_get_bits32 produces malformed_packet if no_of_bits < 25 and tvb remaining = 3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5080

svn path=/trunk/; revision=33811
 2010-08-16 15:13:54 +00:00
Stig Bjørlykke
3b07f8f423 Removed some TAB's. 
svn path=/trunk/; revision=33810
 2010-08-16 09:12:39 +00:00
Stig Bjørlykke
8f4b929469 Added Info for RTTPapdu. 
svn path=/trunk/; revision=33809
 2010-08-16 09:11:01 +00:00
Anders Broman
03dc7a7f67 From Slava: 
This patch adds to the Infiniband dissector the ability to dissect EoIB
(Ethernet-over-Infiniband) traffic which uses Mellanox Technologies Ltd's
standard for encapsulating Ethernet traffic inside Infiniband packets.

This patch is submitted on behalf of Mellanox Technologies Ltd.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5061

svn path=/trunk/; revision=33808
 2010-08-16 05:48:40 +00:00
Anders Broman
fbb6393e18 From Christian Durrer: 
- Support for extended packet size for read/write block telegrams
- Added expert info for bad CRC, telegram retries and NAK responses
- Removed amount of retries which has not been displayed correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5088

svn path=/trunk/; revision=33807
 2010-08-16 05:42:01 +00:00
Anders Broman
4d450d131e From Stephen Donnelly: 
Add BFS extension header decoding to ERF dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5113

svn path=/trunk/; revision=33806
 2010-08-16 05:34:12 +00:00
Gerald Combs
1f118813e7 [Automatic manuf and enterprise-numbers update for 2010-08-15] 
svn path=/trunk/; revision=33801
 2010-08-15 15:03:33 +00:00
Stig Bjørlykke
90cb202dbd Added proto_item_prepend_text(). 
svn path=/trunk/; revision=33800
 2010-08-14 17:24:21 +00:00
Stig Bjørlykke
026f4dfa7b Fixed guint64 printf modifier. 
svn path=/trunk/; revision=33799
 2010-08-14 17:22:22 +00:00
Anders Broman
856f205c27 Fix up decoding of bitfields in the aligned variant. 
svn path=/trunk/; revision=33798
 2010-08-14 16:42:41 +00:00
Anders Broman
b2f660f0d3 Add missing break, should fix bug 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5110

svn path=/trunk/; revision=33794
 2010-08-13 11:57:18 +00:00
Stig Bjørlykke
30875d714c Do not load lua-scripts starting with '.' 
svn path=/trunk/; revision=33793
 2010-08-13 11:18:44 +00:00
Jaap Keuter
05397615d1 Update ZRTP dissector to draft-22. 
svn path=/trunk/; revision=33789
 2010-08-12 16:39:29 +00:00
Martin Mathieson
dbb4538ec8 Improve the way the encoded FP variant is interpreted. 
svn path=/trunk/; revision=33785
 2010-08-12 15:30:56 +00:00
Stig Bjørlykke
e3aab56e64 Added support for RFC5482: User Timeout Option. 
svn path=/trunk/; revision=33784
 2010-08-12 14:09:08 +00:00
Martin Mathieson
c642bae035 From Pascal Quantin: 
The decoder expects to do not have any extra byte after the RAR bodies.

But according to 3GPP 36.321 8.8.0 chapter 6.1.5, the eNodeB is allowed to put padding at the end of the RAR PDU:

" A MAC PDU consists of a MAC header and zero or more MAC Random Access Responses (MAC RAR) and optionally padding as described in figure 6.1.5-4.
[...]

Padding may occur after the last MAC RAR. Presence and length of padding is implicit based on TB size, size of MAC header and number of RARs."

svn path=/trunk/; revision=33783
 2010-08-12 09:03:05 +00:00
Martin Mathieson
bbc98aa015 Fix a duplicate/copy-pasted filter field name. 
svn path=/trunk/; revision=33782
 2010-08-12 08:53:08 +00:00
Stig Bjørlykke
dfb24f48d8 From Chris Maynard via bug 5105: 
IP should not compute the header checksum if within an error packet
such as ICMP.

svn path=/trunk/; revision=33780
 2010-08-12 06:26:21 +00:00
Anders Broman
3f9913f7ed Do DISSECTOR_ASSERT_NOT_REACHED(); if golmb coded data is > 32 bits. 
svn path=/trunk/; revision=33778
 2010-08-11 21:56:19 +00:00
Anders Broman
b1568cb247 Update the comment. 
svn path=/trunk/; revision=33777
 2010-08-11 21:52:35 +00:00
Anders Broman
ccf8787370 Add a warning message if H264 profile-level-id parameter wasn't 
posible to parse.

svn path=/trunk/; revision=33776
 2010-08-11 21:39:22 +00:00
Stig Bjørlykke
7de3dc3167 Call tvb_get_bits32() if leading_zero_bits > 16. 
svn path=/trunk/; revision=33775
 2010-08-11 21:37:04 +00:00
Stig Bjørlykke
894f256912 Added check for valid tvb before calling tvb_length(). 
svn path=/trunk/; revision=33774
 2010-08-11 21:27:35 +00:00
Jeff Morriss
0c4308e2c6 Remove non-ASCII characters. 
svn path=/trunk/; revision=33771
 2010-08-11 13:42:28 +00:00
Stig Bjørlykke
742655b349 Make it compile. 
svn path=/trunk/; revision=33770
 2010-08-11 12:30:33 +00:00
Anders Broman
ce06f1f63e Remove redundant chek_col. 
svn path=/trunk/; revision=33769
 2010-08-11 12:13:24 +00:00
Anders Broman
936eb850a1 From Frank Schorr: 
NetrLogonControl2 - Control_data_information "name" not being decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5071

svn path=/trunk/; revision=33768
 2010-08-11 12:07:25 +00:00
Anders Broman
a14663836a From Holger Freyther: 
packet-gsm_ipa.c: Decode MGCP that is encapsulated inside the stream.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5068

svn path=/trunk/; revision=33767
 2010-08-11 11:59:47 +00:00
Anders Broman
e9f4c63c1d From Aamer Akhter: 
NetFlow forwarding status and template fixes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5083

svn path=/trunk/; revision=33766
 2010-08-11 11:54:25 +00:00
Anders Broman
90a6c7d484 From Herbert Lischka: 
Resolves problems reported in bug #5090
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5090

I have 3 potentially risks of endless loop eliminated
the rest is cosmetic

svn path=/trunk/; revision=33765
 2010-08-11 11:43:04 +00:00
Anders Broman
4b9747a74d Add a komment about the format of the MSRP path parameter. 
svn path=/trunk/; revision=33764
 2010-08-11 11:33:40 +00:00
Anders Broman
26274eb701 From Cal Turney: 
Remember folder of capture selected from Welcome screen file dialog.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5038

svn path=/trunk/; revision=33758
 2010-08-10 11:36:18 +00:00
Stig Bjørlykke
92312f16e9 Declare error as volatile to avoid warning on opensolaris: 
variable 'error' might be clobbered by `longjmp' or `vfork'

svn path=/trunk/; revision=33754
 2010-08-10 07:43:05 +00:00
Guy Harris
9a45206220 Dissect SMB_FILE_ATTRIBUTES, when used as file attributes rather than 
search attributes, as a 16-bit quantity, with only the bits specified by
section 2.2.1.2.4 of [MS-CIFS].  Use dissect_file_ext_attr() in all
cases where we're dissecting SMB_EXT_FILE_ATTR, as specified by section
2.2.1.2.3 of [MS-CIFS].

svn path=/trunk/; revision=33753
 2010-08-10 07:04:20 +00:00
Gerald Combs
e1fff26bbe Future-proof a for loop. 
svn path=/trunk/; revision=33752
 2010-08-09 22:54:03 +00:00
Jaap Keuter
61e6d3eb0e From David Aggeler: 
- Finally, better reassembly using fragment_add_seq_next().
  The previous mode is still supported.
- Fixed sporadic decoding and export issues. Always decode 
  association negotiation, since performance check (tree==NULL)
  is now only in dissect_dcm_pdv_fragmented(). 
- Added one more PDV length check
- Show Association Headers as individual items
- Code cleanup. i.e. moved a few lookup functions to be closer 
  to the dissection.

svn path=/trunk/; revision=33751
 2010-08-09 19:28:09 +00:00
Bill Meier
dd678865b8 Fix another compile error. 
(Note to self: take the time to read *all* the compiler error output before committing).

svn path=/trunk/; revision=33750
 2010-08-09 18:53:18 +00:00
Bill Meier
349242d7bc Fix another compile error :( 
svn path=/trunk/; revision=33749
 2010-08-09 18:46:23 +00:00
Bill Meier
012503635f Fix a compile error. 
svn path=/trunk/; revision=33748
 2010-08-09 18:40:12 +00:00
Bill Meier
6de0c799d8 From Herbert Lischka: "corrected the dissection of reassembled UDP packets". 
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5051

From me:
- Move proto_register... and proto_reg_handoff.. to the end of the file;
- Define a function as static;
- Minor reformatting and whitespace cleanup.

svn path=/trunk/; revision=33747
 2010-08-09 18:20:07 +00:00
Stephen Fisher
9e9e052224 Fix typo in my last commit that broke compilation 
svn path=/trunk/; revision=33746
 2010-08-09 16:53:44 +00:00
Stephen Fisher
a9c7d90278 Update to latest device descriptions 
svn path=/trunk/; revision=33745
 2010-08-09 16:50:08 +00:00
Stig Bjørlykke
6f5b3e381c Make it compile without HAVE_C_ARES and HAVE_GETHOSTBYNAME2. 
svn path=/trunk/; revision=33742
 2010-08-09 11:19:15 +00:00