Before accessing at offset+3, we need to make sure that the buffer
is large enough. In some cases, e.g. when only the MS Timing
Offset IE is left in the tail, the dissector would crash and mark
the packet as malformed, leaving the rest undissected.
Instead of calling ssl_sha_init() and ssl_sha_cleanup() in
a loop, call the newly-created ssl_sha_reset(), to avoid
creating and releasing contexts.
Also, do the same for ssl_md5_init() and ssl_md5_cleanup().
Besides the performance improvement,
this should also fix Coverity 1450156 and 1450693,
which detect the multiple calls to ssl_sha_cleanup()
and ssl_md5_cleanup() as a double-free.
New link type DLT_ETW is added for write and read Event Trace on Windows.
This change updates MBIM dissector to decode a MBIM message from
a DLT_ETW packet.
Enable PKCS #11 support in macOS builds with macos-setup.sh (already
supported on macOS via Homebrew and on all other OSes with GnuTLS 3.4
or greater) by installing p11-kit (and its dependency libtasn1) and
building nettle and GnuTLS against it.
Update versions of xz, lzip, gettext, libgpg, libgpg-error, libgcrypt, gnutls and gmp
to newest releases.
Also update glib but only to last version with autotools support - meson build is left
for another time.
Current versions of glib require a libpcre with unicode enabled which the Catalina system
version does not provide, so install the current version of libpcre as well.
Update some additional tools to commit 3a42bf0de2b9e35efcc3cea38153ab95cb71b352:
brotli, libmaxminddb, lz4, and snappy
Instead of successively calling ssl_md_cleanup() and
ssl_md_init(), call the newly-created ssl_md_reset(),
to avoid creating and releasing contexts.
Besides the minor performance improvement,
this should also fix Coverity 1450690,
which detects the second call to ssl_md_cleanup()
as a double-free.
Add case_dissect_protobuf and case_dissect_grpc in test/suite_dissection.py.
Add *.proto into the sub directories of test/protobuf_lang_files/.
Run command like 'pytest --program-path .\run\Debug\ -k "grpc or protobuf"'
in build directory (in windows) to test these cases only.
Improve the D-Bus dissector to support all types, including containers
(arrays, structs, dict entries, variants). Add new protocol fields for
D-Bus header fields like `dbus.destination` or `dbus.path` to make
filtering for specific messages possible. Add lots of expert infos for
possible errors. Update Info column to include method / signal name and
path.
Instead of calling ssl_hmac_init() and ssl_hmac_cleanup() in
a loop, call ssl_hmac_reset(), to avoid creating and releasing
contexts. This should also fix Coverity 1450768, which
detects the multiple calls to ssl_hmac_final() as a double-free.
Back in 2017, commit d7bab0b46e introduced
printing the TEI in COL_INFO. Unfortunatelky it contained a typo and
stated "TEI:1%u" instead of "TEI:%u". So TEI 0 became TEI 10, etc. -
causing some confusion.
Let's remote that extraneous '1' and at the same time print the sapi
with two digits for better alignment of multiple lines. It is a
two-digit decimal value (0..63).
Originally we only learned about the protocol from looking at hexdumps
without any specification or the like.
Due to a GPL request to ip.acecss, we actually do have an 'official'
resource: The packet-ipa.c from their wireshark-1.0.6ipa27.tar.gz
Let's use its contents to complete our definitions here.
Use tvb_new_octet_aligned() to get an octet aligned tvbuff with the
4 bit offset instead of using tvb_get_ptr() and doing the alignment
in the dissector.
Add SMCD(v2) clc proposal/accept/confirm and decline support.
Proposal and decline parsing routines are used by SMC-R and SMC-D(v2).
Enhance the existing SMC-R protocol dissector in such
a generic way that it supports both SMC-R and SMC-D(v2)
protocols. These two protocols are similar to each other.
SMC-D has a version 1 and version 2.
Signed-off-by: Guvenc Gulce <guvenc@linux.ibm.com>
QFont::ForceIntegerMetrics is deprecated, and the floating-point
variant of QFontMetrics is no longer used anyway since 96eec0beb9.
Change the font_width_ member to int, as should have been done in
that commit.
Convert wiretap/ascend.y.in from Bison/YACC to Lemon and rename it to
wiretap/ascend_parser.lemon. Tighten up some of our scanning and
parsing. Make the indentation in it and related files consistent. Aside
from the recent IPv4 fragment offset changes, this produces identical
output to the 3.4 branch for the Ascend trace files I have here.
Remove the comment about supporting other commands. Another timeline
might have an Ascend that successfully pivoted to DSL or 15625B+1D
gigabit ISDN, but this one has neither.
This was our last/only Bison/YACC file, so remove Bison/YACC as a
development and packaging dependency and remove references to it from
the documentation.
That's QoS-frame only; for non-QoS frames, the +HTC/Order subfield
doesn't mean there's an HT Control field.
Update the reference to the part of the 802.11 standard mentioning that
subfield to 802.11-2016.
CaptureOptionsDialog allocates a SparkLineDelegate in its constructor.
It should set itself as parent of the SparkLineDelegate.
Without a parent, the SparkLineDelegate is never freed and each
invocation of Capture / Options leaks memory.
Change
case DATA_FRAME:
if (condition) {
do stuff;
break;
}
do other stuff;
break;
to
case DATA_FRAME:
if (condition) {
do stuff;
} else {
do other stuff;
}
break;
to make it clearer that it's "do this if condition is true, else do
that".
The Get Attribute Response Info contains attributes requested by the
Get Attributes message. It contains the same attributes which can be part
an OML message.
Change the wording of the sequence number context information from
"Wrong" to the more accurate description that this is a retransmit.
Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
Add context information for next expected sequence number so that
analysing for acknowledgedment or request for retransmit can be done
without comparing packets manually.
Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
Gerald Combs
Harald Welte