Commit Graph

2232 Commits

Author SHA1 Message Date
Ulf Lamping a9e1c71b7a bugfix: don't crash, if current_frame->ns == NULL
svn path=/trunk/; revision=15967
2005-09-22 21:18:19 +00:00
Ulf Lamping 5305988e3d enhance heuristics:
some Siemens SIMATIC protocols also use COTP, and shouldn't be 
misinterpreted as SES.
the starter in this case is fixed to 0x32 (SES_MINOR_SYNC_ACK for SES), 
so if the following parameter type is unknown, it's probably SIMATIC and not SES

svn path=/trunk/; revision=15966
2005-09-22 21:16:54 +00:00
Ulf Lamping ca662b74b0 change ConnectCR flag item sequence, so the "most significant" bit will come first (as done in the other req/responses)
svn path=/trunk/; revision=15964
2005-09-22 21:12:51 +00:00
Ulf Lamping 6f98654a6a bugfix: don't simply use length field value from packet data, ensure the bytes really exist
svn path=/trunk/; revision=15963
2005-09-22 21:09:02 +00:00
Ulf Lamping 9d1af7d6fb add two more bind reject reasons from the specs
svn path=/trunk/; revision=15962
2005-09-22 21:07:25 +00:00
Luis Ontanon 88dd585d23 in register_dtd() do not leak the elements hash
svn path=/trunk/; revision=15959
2005-09-22 16:41:53 +00:00
Tomas Kukosa 81a2feddab Call H245 decoding and tunelled protocols decoding at the end of H225 dissector. I makes less confusion in info column.
svn path=/trunk/; revision=15958
2005-09-22 14:40:26 +00:00
Jörg Mayer 1c0667858e Add the cisco url as well
svn path=/trunk/; revision=15957
2005-09-22 10:07:26 +00:00
Jörg Mayer 41911c041a Add a comment on packets with opcode 3
svn path=/trunk/; revision=15956
2005-09-22 10:00:40 +00:00
Ulf Lamping 6af80b98cb replace match_strval with val_to_str, where the output was used by string output, but not expecting NULL
svn path=/trunk/; revision=15954
2005-09-22 02:18:19 +00:00
Guy Harris 23661240d7 Squelch some compiler warnings.
svn path=/trunk/; revision=15953
2005-09-22 02:08:03 +00:00
Ulf Lamping 031d7beea0 prevent output of NULL strings
svn path=/trunk/; revision=15950
2005-09-22 01:16:25 +00:00
Ulf Lamping 714c04d3a8 replace match_strval with val_to_str in several places, where the output was used by string output, but not expecting NULL
svn path=/trunk/; revision=15949
2005-09-22 01:09:01 +00:00
Guy Harris c5b0fc27d7 Fix a bunch of places where we were calling "dissect_ber_octet_string()"
with a non-null pointer-to-pointer-to-tvbuff and not checking whether
the returned tvbuff pointer was non-null.

svn path=/trunk/; revision=15948
2005-09-22 00:51:11 +00:00
Guy Harris 341a2f503d dissect_ber_octet_string() can return a null tvbuff pointer, if the
putative octet string isn't one; always check before using it to
dissect, and don't call the dissector if the tvbuff is null.  This
should fix bug 472.

svn path=/trunk/; revision=15946
2005-09-21 23:23:58 +00:00
Guy Harris ced076f8d4 OIDs are put into the protocol tree as strings containing a textual
representation of the OID, so the fields for them should be of type
FT_STRING.  This should fix bug 470.

svn path=/trunk/; revision=15945
2005-09-21 23:07:07 +00:00
Ronnie Sahlberg 8b32f13476 get rid of strcpy in packet-ntp.c
at the same time  change ntp_fmt_ts to return a pointer to ian ep-allocated buffer.
remove the redundant buffer parameter in the signature and change all callers.


svn path=/trunk/; revision=15939
2005-09-21 20:05:13 +00:00
Guy Harris 4e09b5e0b3 Some compilers don't allow a static declaration of a function inside
another function, so move the declaration of
dissect_spnego_PrincipalSeq() to the top of the file.

svn path=/trunk/; revision=15938
2005-09-21 18:27:28 +00:00
Guy Harris 0fb81e221e An InnerContextToken comes with an OID for the mechanism, which is what
we use to determine how to interpret the token; don't bother fetching
the OID attached to the frame or conversation, as we're not using it.

Indent code in the .cnf file to match the code generated by asn2eth.

The mechListMIC in a NegTokenInit is sometimes a sequence containing a
string; check the header of the mechListMIC and dissect it as such a
sequence or as a regular item depending on whether it's a sequence or
not.

If we see a supportedMech in a NegTokenTarg, save next_level_value for
that OID with the conversation.

Dissect a responseToken in a NegTokenTarg, and a mechListMIC in a
NegTokenTarg, appropriately.

Get rid of "gssapi_dissector_handle()", and just use
next_level_value->handle - it was never being called if next_level_value
was null.

When we're dissecting a KRB5 blob, just use get_ber_identifier() to get
the header, so we don't report an ASN.1 error if there isn't a BER
identifier there; dissect the identifier and length only if we know we
have them.

svn path=/trunk/; revision=15937
2005-09-21 17:42:11 +00:00
Guy Harris fa2779e00d Don't fill in a data structure for the packet while dissecting; we use
almost none of the data - fill in only variables for what we need, and
use proto_tree_add_item() in most cases.

Move what's left of the packet-winsrepl.h header into packet-winsrepl.c,
and get rid of the header.

Dissect the name flags field in detail, as per the Samba code.

We don't do any checks for whether the packet is a valid WINS
replication packet, so don't make the dissector a new-style dissector.

svn path=/trunk/; revision=15936
2005-09-21 17:33:04 +00:00
Guy Harris 6c0328f7f3 Don't fill in a data structure for the packet while dissecting; we use
almost none of the data - fill in only variables for what we need, and
use proto_tree_add_item() in most cases.

Move what's left of the packet-winsrepl.h header into packet-winsrepl.c,
and get rid of the header.

Dissect the name flags field in detail, as per the Samba code.

We don't do any checks for whether the packet is a valid WINS
replication packet, so don't make the dissector a new-style dissector.

svn path=/trunk/; revision=15935
2005-09-21 17:32:21 +00:00
Gerald Combs a493fdd54b Use a proper length for booleans. If we have a malformed packet, throw an
exception.  Fixes bug 468.

svn path=/trunk/; revision=15934
2005-09-21 16:18:30 +00:00
Ronnie Sahlberg 7e2eed2a30 remove some strcpy() with g_snprintf()
svn path=/trunk/; revision=15931
2005-09-21 15:38:12 +00:00
Gerald Combs 71f16f2a3f If pinfo->match_string is null (e.g. when we're called from the Jabber
dissector), don't try to look it up in a hash table.  Fixes the current
Buildbot failure.

svn path=/trunk/; revision=15929
2005-09-21 15:03:19 +00:00
Ulf Lamping 85ae3a8086 fix #372: the bug raised a "division by zero" exception. I've add a check for this and simply replaced the expression with 0 in that case. Don't know if it's correct to do so, but fixes the exception at least :-)
svn path=/trunk/; revision=15927
2005-09-21 10:29:22 +00:00
Ulf Lamping 853067c739 bugfix: break out of an endless loop, if dissect_sip_common() returns 0 or -2, found in a file send to me by david martin in an attempt to fix #372
svn path=/trunk/; revision=15926
2005-09-21 10:22:14 +00:00
Jörg Mayer 8e8d66c2a9 manpages are now done automagically
svn path=/trunk/; revision=15925
2005-09-21 09:50:09 +00:00
Guy Harris 13e99476e6 Use BASE_DEC_HEX for the identifier field; that means we don't have to
use "proto_tree_add_uint_format()", we can just let the Ethereal core
format it.

svn path=/trunk/; revision=15922
2005-09-21 02:12:24 +00:00
Guy Harris c952476658 Squelch some compiler wranings, and fix up the creation of a subset
tvbuff.

Fix indentation.

svn path=/trunk/; revision=15921
2005-09-21 01:47:46 +00:00
Guy Harris eecbe6a8de Squelch a compiler warning.
svn path=/trunk/; revision=15920
2005-09-21 01:39:39 +00:00
Guy Harris 551f589cb9 Fix a compiler warning.
svn path=/trunk/; revision=15916
2005-09-21 01:33:16 +00:00
Guy Harris 7ae7aaf75c Fix a comment.
svn path=/trunk/; revision=15915
2005-09-21 01:15:32 +00:00
Guy Harris 81a1fbfcd7 Put in some comments based on stuff seen in the Samba code
(include/nameserv.h, code in wrepld).

svn path=/trunk/; revision=15914
2005-09-21 00:00:43 +00:00
Guy Harris 52c5f6f07b Give it an RCS ID.
svn path=/trunk/; revision=15913
2005-09-20 22:55:48 +00:00
Guy Harris c4e374785e Fix the name in the comment.
Give it an RCS ID.

svn path=/trunk/; revision=15912
2005-09-20 22:53:31 +00:00
Guy Harris 2f6530246c Give them RCS IDs.
svn path=/trunk/; revision=15911
2005-09-20 22:52:31 +00:00
Guy Harris c4d9915be6 Give them RCS IDs.
svn path=/trunk/; revision=15910
2005-09-20 22:51:42 +00:00
Guy Harris 0a93fcdcd3 Give it an RCS ID.
svn path=/trunk/; revision=15909
2005-09-20 22:49:54 +00:00
Anders Broman df21536710 From Hannes Gredler:
patch to support 4 additional juniper DLTs.

all those are wrappers for exisiting media types augmented with meta-information which gets also displayed using this patch;

svn path=/trunk/; revision=15908
2005-09-20 20:25:55 +00:00
Anders Broman ff34f18d67 From Kaul:
Jabber traffic is XML, attached patch dissects it as such

svn path=/trunk/; revision=15907
2005-09-20 20:20:08 +00:00
Anders Broman 1bb6396a93 Fix bug #404 Decoding of MSISDN on GSM is incomplete.
svn path=/trunk/; revision=15906
2005-09-20 20:04:01 +00:00
Ronnie Sahlberg 5d98676745 from francesco
update to remove sprintf()



svn path=/trunk/; revision=15905
2005-09-20 19:42:40 +00:00
Ronnie Sahlberg 8088098ce6 make options field filterable
remove silly rotating buffers



svn path=/trunk/; revision=15904
2005-09-20 19:36:38 +00:00
Gerald Combs ba83bf145f Don't try to reassemble a zero-length fragment. Add a comment to
reassemble.c about the handling of zero-length fragments.

svn path=/trunk/; revision=15899
2005-09-20 17:23:19 +00:00
Jörg Mayer 27a1e92489 Francesco Fondelli: Add dcp support (forgot this file)
svn path=/trunk/; revision=15898
2005-09-20 15:19:11 +00:00
Jörg Mayer e6194537b3 Francesco Fondelli; Add dcp support
svn path=/trunk/; revision=15897
2005-09-20 15:18:28 +00:00
Tomas Kukosa 300f1231cd get rid of few warnings
svn path=/trunk/; revision=15895
2005-09-20 14:14:07 +00:00
Tomas Kukosa d3492e684a asn2eth
- #.FN_BODY accepts parameters too
 - single line variant of #.FN_PAR is possible
 - new parameter FN_VARIANT for OBJECT IDENTIFIER
packet-per.c
 - dissect_per_object_identifier() returns value as tvb
 - new dissect_per_object_identifier_str() function
PER dissectors adapted and regenerated

svn path=/trunk/; revision=15894
2005-09-20 10:56:08 +00:00
Ulf Lamping dce67e2bbe fix: packet-lldp.c(2071) : warning C4761: integral size mismatch in argument; conversion supplied
svn path=/trunk/; revision=15893
2005-09-20 09:02:38 +00:00
Ulf Lamping e8dd2e9279 fix: packet-dcerpc.c(4019) : warning C4018: '<' : signed/unsigned mismatch
svn path=/trunk/; revision=15892
2005-09-20 08:55:50 +00:00