Commit Graph

23251 Commits

Author SHA1 Message Date
Jeff Morriss a93eb10ee9 set SVN properties.
svn path=/trunk/; revision=52758
2013-10-22 13:27:31 +00:00
Pascal Quantin 3867c85ae9 From Roland Knall via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9244 :
Fix error: 'wsmlength' may be used uninitialized in this function

svn path=/trunk/; revision=52757
2013-10-22 11:12:41 +00:00
Michael Mann 75926345c6 Latest WSMP protocol support. Bug 9244 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9244)
Per bug, version 1 is no longer in use as its no longer specified in the standard.

svn path=/trunk/; revision=52755
2013-10-22 02:37:49 +00:00
Michael Mann c87641f286 dissection of group_mod messages. Bug 9283 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283)
From Zoltán Lajos Kis

svn path=/trunk/; revision=52754
2013-10-22 02:29:12 +00:00
Michael Mann 7a360326ab openSAFETY: Fixing rare crash as well as dissector errors. Bug 9314 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9314)
From Roland Knall

svn path=/trunk/; revision=52752
2013-10-22 02:08:42 +00:00
Michael Mann b6df06199c Pass struct rxinfo "private data" into AFS dissector instead of using pinfo->private_data.
svn path=/trunk/; revision=52751
2013-10-22 01:02:00 +00:00
Michael Mann 28b5926fe8 Pass usb_data_t "private data" into subdissectors instead of using pinfo->private_data.
svn path=/trunk/; revision=52750
2013-10-22 00:49:16 +00:00
Jörg Mayer 6eba75967c Properly implement subtree expansion (including automagically
expanding the mint subtrees during development).

svn path=/trunk/; revision=52748
2013-10-21 21:44:31 +00:00
Martin Mathieson 0aac675f84 Improve the way DRX before and after state is shown.
svn path=/trunk/; revision=52747
2013-10-21 21:20:39 +00:00
Michael Mann 87e55cb9e0 Sync with latest SAMBA PIDL source per http://www.wireshark.org/lists/wireshark-dev/201310/msg00217.html
Didn't integrate
0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch
0016-Regenerate-the-dnserver.patch

due to compilation errors on Windows.

svn path=/trunk/; revision=52744
2013-10-21 19:41:54 +00:00
Michael Mann 15294a1261 Add a new api to allow dissection of the array payload as a whole. Bug 9307 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9307)
From Matthieu Patou 

svn path=/trunk/; revision=52743
2013-10-21 18:46:52 +00:00
Michael Mann 772fb97f76 We can't really have conformant strings they are always conformant and
varying but pidl insists on having a different function.  Bug 9306 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9306)

From Matthieu Patou.

svn path=/trunk/; revision=52742
2013-10-21 18:33:14 +00:00
Michael Mann ac7caf7007 Add APIs for PIDL generated code to return the value of the integer that was dissected. Bug 9305 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9305).
From Matthieu Patou

svn path=/trunk/; revision=52741
2013-10-21 18:25:41 +00:00
Jeff Morriss 33dd47e5bc Add packet-spice.h
svn path=/trunk/; revision=52739
2013-10-21 17:59:51 +00:00
Chris Maynard 3616fa1549 Remove if (fh_tree) checks as add_ethernet_trailer() calls such functions as dissector_try_heuristic(), expert_add_info(), and col_append_str(), which all need to be called whether fh_tree is NULL or not.
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=52738
2013-10-21 17:31:22 +00:00
Michael Mann 2dafe09f0b Update spice protocol dissector. Bug 9143 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9143)
From Jonathon Jongsma

Note that the new packet-spice.h is auto-generated outside of Wireshark.

svn path=/trunk/; revision=52737
2013-10-21 16:48:07 +00:00
Michael Mann a8d18748ab dce-rpc: properly dissect multiple PDU in the same packet. Bug 9302 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9302).
From Matthieu Patou

svn path=/trunk/; revision=52736
2013-10-21 16:00:37 +00:00
Michael Mann 651b858892 Fix compile errors introduced in r52734.
svn path=/trunk/; revision=52735
2013-10-21 15:58:52 +00:00
Michael Mann 598726be02 Datablob size is NDR64/32 dependant. Bug 9301 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9301).
From Matthieu Patou

svn path=/trunk/; revision=52734
2013-10-21 15:50:23 +00:00
Michael Mann 8ee3d11818 Fix padding bytes overlapping due to NDR alignment. Bug 9300 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9300)
From Matthieu Patou

svn path=/trunk/; revision=52733
2013-10-21 15:46:13 +00:00
Michael Mann f69a489472 NULL check ref_nt_challenge_response and ref_lm_challenge_response. Bug 9299 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9299)
From Matthieu Patou

svn path=/trunk/; revision=52732
2013-10-21 15:39:07 +00:00
Pascal Quantin 14fd3d0157 ZeroMemory -> SecureZeroMemory
svn path=/trunk/; revision=52731
2013-10-21 15:16:41 +00:00
Evan Huus 23191ea6e6 Don't go into a loop if we find a zero-length line. Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9312

Anders, this may be related to your recent TVB optimizations, since I don't
think it happened before that? Did you change the behaviour of tvb_find_line_end
or its callees at all?

svn path=/trunk/; revision=52730
2013-10-21 13:07:19 +00:00
Michael Mann be62b39687 Pass fc_hdr "private data" into subdissectors instead of using pinfo->private_data.
svn path=/trunk/; revision=52729
2013-10-21 03:13:47 +00:00
Michael Mann 77837d2c9e Pass struct aspinfo "private data" into subdissectors instead of using pinfo->private_data.
svn path=/trunk/; revision=52728
2013-10-21 00:27:36 +00:00
Evan Huus 63eac3f6fd Fix -Wshadow error
svn path=/trunk/; revision=52726
2013-10-20 23:35:48 +00:00
Anders Broman 98dec2f09b Adds dissecting for actions, and proper display for OXM values.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283

svn path=/trunk/; revision=52725
2013-10-20 21:12:32 +00:00
Pascal Quantin b552143a5c Put PDU dissection in protocol tree
svn path=/trunk/; revision=52724
2013-10-20 21:05:37 +00:00
Michael Mann 24ba431d80 Pass ROHC "private data" from PDCP-LTE using dissector data parameter instead of using pinfo->private_data.
Passing data through the dissector parameter eliminates the need for ROHC dissector to save/restore private_data.

svn path=/trunk/; revision=52723
2013-10-20 20:35:24 +00:00
Jakub Zawadzki 1f110ac43f 2nd try to fix recent test failures.
After recent changes it's possible that epan_dissect_cleanup() can be called if there were
no dissection run on it (epan_dissect_run()) In such case ->tvb will have random value,
just initialize it to NULL in _init() and see if it's working.

Thanks goes to Evan for backtrace.

svn path=/trunk/; revision=52722
2013-10-20 19:05:00 +00:00
Pascal Quantin 7f3d07b9fd From e.yimjia via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9289 :
Add dissection of OMA-ILP

svn path=/trunk/; revision=52721
2013-10-20 18:43:00 +00:00
Pascal Quantin f06d7caaa5 Regenerate H.225 dissector
svn path=/trunk/; revision=52720
2013-10-20 18:26:08 +00:00
Pascal Quantin d269d19f99 Fix a typo
svn path=/trunk/; revision=52719
2013-10-20 18:06:23 +00:00
Michael Mann df6594bbd2 Pass MPLS "private data" into subdissectors instead of using pinfo->private_data.
svn path=/trunk/; revision=52718
2013-10-20 18:00:05 +00:00
Pascal Quantin cf9bbdecef From RobiOneKenobi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9297 :
Add support for MSVC2013

svn path=/trunk/; revision=52716
2013-10-20 17:35:30 +00:00
Pascal Quantin 33e376d180 From robionekenobi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9267 :
Fix compilation of packet-mq.c

svn path=/trunk/; revision=52715
2013-10-20 16:57:38 +00:00
Michael Mann 94c3d21550 Enhancement of the packet-mq dissector (WMQ 7.1-7.5). Bug 9267 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9267)
From robionekenobi

From me: Pass data through dissectors instead of using pinfo->private_data

svn path=/trunk/; revision=52707
2013-10-20 12:11:55 +00:00
Jakub Zawadzki bad81b517f Reintroduce back epan_dissect_reset(), proto_tree_reset()
This time it makes more sense, cause for each dissection we need two wmem allocators.
Reseting wmem allocator is much faster than destroy & create.

svn path=/trunk/; revision=52706
2013-10-20 10:21:25 +00:00
Jakub Zawadzki 107e4a6c80 Move resetting packet_info structure from dissect_packet() to epan_dissect_init()
It'd be actually good idea to seperate packet_info data (packet.c) from epan_dissect_t (epan.c),
but this rule is already violated.

Strict seperation could allow for example allow multiple dissection on the same epan_dissect_t
(I think it was idea behind it), but it's not working.

svn path=/trunk/; revision=52705
2013-10-20 10:11:16 +00:00
Jakub Zawadzki 336befd903 Remove allocation stem from PROTO_NODE_NEW() macro.
Tree root-node will be allocated using g_slice()

svn path=/trunk/; revision=52704
2013-10-20 10:03:32 +00:00
Evan Huus 7cc5d870ee Remove non-ASCII characters causing checkAPI failures
svn path=/trunk/; revision=52703
2013-10-20 02:38:51 +00:00
Evan Huus f5442e27a1 Fix format error.
svn path=/trunk/; revision=52702
2013-10-20 02:24:34 +00:00
Evan Huus b054d20a14 Don't use g_assert_cmpint, it isn't happy on Windows. g_assert is nearly as good
except it doesn't produce as nice error messages.

svn path=/trunk/; revision=52701
2013-10-20 02:18:19 +00:00
Michael Mann 796985587c Convert the proto_tree_add_text calls that should have been expert info.
svn path=/trunk/; revision=52700
2013-10-20 02:17:42 +00:00
Evan Huus badde83d4e Take a blind stab at adding oids_test to nmake
svn path=/trunk/; revision=52699
2013-10-20 02:10:39 +00:00
Michael Mann 522b4ce5c0 Pass SPX "private data" into subdissectors instead of using pinfo->private_data.
svn path=/trunk/; revision=52698
2013-10-19 23:06:13 +00:00
Anders Broman e958d8c081 From beroset@mindspring.com:
remove unnecessary and unused oid_resolv_cleanup()

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9295

svn path=/trunk/; revision=52697
2013-10-19 20:25:55 +00:00
Anders Broman 3c813bbcc1 From Zoltán Lajos Kis:
dissect flow_mod body in openflow_v4

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283

svn path=/trunk/; revision=52696
2013-10-19 20:19:35 +00:00
Anders Broman 09e32f5fb8 Minor optimizations.
svn path=/trunk/; revision=52695
2013-10-19 20:16:00 +00:00
Evan Huus 1f3549168d Don't link explicitly with libwmem, it's already in libwireshark and the symbol
doubling leads to all sorts of very subtle badness (including test failures due
to funny internal assertions because the two wmems have mismatching state).

Make wmem_init and wmem_cleanup PUBLIC instead of LOCAL so that they don't get
stripped and don't cause a link failure when trying to build oids_test (now that
it's not linking with libwmem explicitly). There is possibly a better way to fix
this, but I'm not sure what it is.

svn path=/trunk/; revision=52694
2013-10-19 19:40:02 +00:00